fluid-publish should revert package-lock.json on conclusion

Description

npm version 5, the current LTS version, maintains a package-lock.json file in addition to package.json . The last step of the fluid-publish dev workflow should revert this file to its content from git in addition to the package.json file

Environment

None

Activity

Show:

Justin Obara July 25, 2024 at 3:52 PM

Migrated to

Atisaya Jain March 16, 2018 at 10:48 AM
Edited

@Justin Obara @Tony Atkins I closed the previous PR while trying to rename commits. I am really sorry for this.

Please review PR #10 Github and let me know if any changes need to be made.

Atisaya Jain March 13, 2018 at 5:20 PM

Thank you so much for you help, Tony. It cleared a lot of doubts, really.

I have opened a PR #9 on Github, please review it. And please let me know if any other changes need to be made.

Tony Atkins [RtF] March 13, 2018 at 9:53 AM

Hi, . For "dev" releases, this package generates a version number (based in part on the date) that is saved to the package.json file. The updated package.json file is committed as part of a new tag. Once this is done, the goal is to leave the current working branch in the same state it was in before the release. We accomplish this by checking out the previous package.json from whatever branch we are working in.

This ticket covers also reverting the package-lock.json file, as though we had issued the command git checkout package-lock.json.

Atisaya Jain March 12, 2018 at 9:12 PM

This might be silly, but I think I am a bit lost here. What does it mean to revert back to content from git? Does it mean that after publishing, fluid-publish should be removed from the package-lock.json and package.json files of the module it has been used to publish? Or does it mean something else?

I would be grateful if you could help me how to approach this issue.

Migrated

Details

Assignee

Reporter

Components

Priority

Created February 22, 2018 at 2:09 PM
Updated July 25, 2024 at 3:52 PM
Resolved July 25, 2024 at 3:52 PM