Bad JavaScript in MultiFileUpload.js

Description

The createUploadCompleteHandler function contains the following line:

fileQueueComplete(uploaderContainer, options, progressBar, fragmentSelectors);

However, "options" is undefined in this context. Looks like a bad copy-and-paste, not caught because the no-server-side demo doesn't exercise that function.

I've worked around it by just adding "options" to the parameter list:

var createUploadCompleteHandler = function (uploaderContainer, progressBar, fragmentSelectors, status, options) {
...
upload_complete_handler: createUploadCompleteHandler (uploaderContainer, progressBar, fragmentSelectors, status, options),

Environment

None

Activity

Show:

Eli Cochran May 29, 2008 at 8:31 PM

options added all around

Fixed

Details

Assignee

Reporter

Components

Fix versions

Affects versions

Priority

Created May 17, 2008 at 12:35 AM
Updated July 11, 2008 at 8:06 PM
Resolved May 29, 2008 at 8:31 PM