Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

fluid-publish module should use a "+" to separate the build metadata

Description

Currently fluid-publish creates dev builds and appends the date and commit hash to the end. This is currently separated by a "." but should be separate by a "+" according to http://semver.org/#spec-item-10

Environment

None

Activity

Show:

Justin Obara April 6, 2018 at 1:52 PM

We actually want to use the data and commit has for sorting, so this seems like it would be counter productive. Also, if the build metadata is stripped it will just end up creating a mess of our npm repo.

Justin Obara April 6, 2018 at 1:51 PM

In doing some further investigation into build metadata while working on I found that npm strips out this information. It seems the logic is that because it can't be used to sort versions, as build metadata give equal precedence, it is to be ignored and thus stripped out.

See:

Justin Obara January 18, 2017 at 7:11 PM

Upon further review it seems that build metadata doesn't affect precedence of builds. I wonder if we'd prefer to keep things as is so that they are ordered. It's not clear if this will be the case with using buildmetada.

http://semver.org/#spec-item-11

Won't Fix

Details

Assignee

Reporter

Components

Priority

Created January 9, 2017 at 2:54 PM
Updated April 6, 2018 at 1:52 PM
Resolved April 6, 2018 at 1:52 PM