Move linting infrastructure over to ESHint and update grunt tasking to 1.0
Description
Environment
Activity
Tony Atkins [RtF] June 7, 2016 at 10:11 AM
Just to follow up, the migrated "strict" setting does cause problems in node projects. I am preparing a fix here:
Tony Atkins [RtF] June 7, 2016 at 9:44 AM
Anyway, just to close this out, the "new" errors related to "use strict" were a function of not having the right environment. On reflection, I do think that we have enough "non Crockford-isms" now that it would be worth adding a bit more to the wiki, including of course the fact that the default file is configured for browser code and needs to be edited to be used with node components.
Tony Atkins [RtF] June 6, 2016 at 12:54 PM
Only reopening because you can't edit comments on a closed issue...
Tony Atkins [RtF] June 6, 2016 at 12:51 PMEdited
So, let's start again. I tried to follow the instructions on the wiki and use the standard .eslintrc. It reports problems that were never reported by the previous settings in the old .jshintrc.
Tony Atkins [RtF] June 6, 2016 at 12:50 PM
It also seems very much like fair game to just use the .eslintrc from infusion without reading the PR, as that is exactly what we suggest that other people do:
https://wiki.fluidproject.org/pages/viewpage.action?pageId=3903458
Details
Assignee
Antranig BasmanAntranig BasmanReporter
Antranig BasmanAntranig BasmanComponents
Priority
Major
Details
Details
Assignee
Antranig BasmanReporter
Antranig BasmanComponents
Priority
Major
has brought to our attention an alternative linting tool to our JSHint (frozen at an ancient version to retain whitespace support), ESHint, that appears to have considerably superior engineering values and supports essentially all of the requirements motivating our JSHint fork at https://github.com/fluid-project/jshint
We should move over to ESHint, draw up an equivalent .eshintrc file to our existing rules, and also take the opportunity to move over to the grunt 1.x release which appeared recently.