Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

that.locate should return an empty element if the selector cannot be found...

Description

If you run that.locate(selector) from a view component that does not have a matching selector, currently the entire container is returned. This means that a single typo in a selector can result in mistakenly operating on the entire container. In talking with Antranig about working around this problem, he proposed simply fixing it in FluidView.js.

Environment

None

Activity

Show:

Antranig Basman February 12, 2016 at 4:18 PM

The failure sequence here is slightly subtle - the initial cacher to fluid.locate passes a raw DOM element to the "localContainer" argument, which is recognised correctly for the purposes of representing the cache key, but is then returned as the same raw element from "locate" and subsequent calls to "fastLocate" even if they supply a proper jQuery instead, as it ends up polluting the cache.

Justin Obara February 10, 2016 at 8:52 PM

Reopened as this is causing the reorder to throw errors on hover for dom.fastLocate and to be broken for mouse interactions.

Justin Obara February 5, 2016 at 12:58 PM

Merged pull request ( https://github.com/fluid-project/infusion-docs/pull/83 ) into the infusion-docs repo at 94207308ed8604cce0e9d40b56aa2d411457ba5d

Justin Obara February 4, 2016 at 8:06 PM

Merged pull request ( https://github.com/fluid-project/infusion/pull/657 ) into the project repo at 63ec072e54b75db0dbaae33fcac61264ebb8d63d

Fixed

Details

Assignee

Reporter

Components

Fix versions

Priority

Created November 25, 2015 at 4:08 PM
Updated July 8, 2016 at 1:05 PM
Resolved March 4, 2016 at 8:02 PM