Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Model Transformation system must not prune out execution of all transforms whose value input is undefined

Description

The model transformation system's "fluid.model.transform.doTransform" core implementation contains the following short-circuit:

// if the function has no input, the result is considered undefined, and this is returned
if (expanded === undefined) {
return undefined;
}

This is a faulty assumption in general, especially for IoC-driven transforms. However, it is valid for simple transform functions which have been "lifted" from plain functions. We need to distinguish between functions which have received a non-empty "transformSpec" (other than "type") and those which are plain functions and defeat the behaviour for the former.

Environment

None

Activity

Show:

Antranig Basman July 8, 2015 at 5:22 PM

Hi - the output works just fine, as shown in the following commit - https://github.com/amb26/infusion/commit/194850705c5dbebf56f423a4847868e2f5bdb1ea (part of https://github.com/fluid-project/infusion/pull/616 ) - perhaps you have some other problem.

Tony Atkins [RtF] July 8, 2015 at 12:57 PM
Edited

Antranig, the standardOutputTransformFunction grade also seems to return nothing unless you have a value. Can you recommend another grade?

Antranig Basman July 3, 2015 at 11:01 AM

This is not a bug - simply a result of our own forgetfulness about the meaning of our transform grade structure. Any transform can opt out of the standard input value workflow by simply avoiding including the "fluid.transforms.standardInputTransformFunction" grade. For example, the fluid.transforms.stringTemplate transform that we were originally trying to implement can just be registered with "fluid.transforms.standardOutputTransformFunction" gradeNames.

Fixed

Details

Assignee

Reporter

Components

Priority

Created July 2, 2015 at 11:02 PM
Updated July 8, 2016 at 12:47 PM
Resolved October 21, 2015 at 6:02 AM

Flag notifications