Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

ensure that listeners in the preference framework are properly namespaced

Description

Currently there are listeners like the onReset defined in the fullNoPreview preference editor that aren't properly namespaces.
https://github.com/fluid-project/infusion/blob/master/src/framework/preferences/js/FullNoPreviewPrefsEditor.js#L33-L37

This means that if you want to use the fullNoPreview prefs editor but want a reset that doesn't save, you won't be able to use this base grade. There is no way to override this event, as providing new configuration will just merge.

The entire preference framework should be examined to resolve similar issues.

Environment

None

Activity

Show:

Cindy Li August 30, 2016 at 5:03 PM

The pull request https://github.com/fluid-project/infusion/pull/742 has been merged into the project master branch at b11549a25f77fc83d5d989f77fbec1f396d474e2

Justin Obara August 30, 2016 at 4:56 PM

Did not namespace listeners that are bound to events of other components using IoC. These have not be namespace due to https://fluidproject.atlassian.net/browse/FLUID-5948#icft=FLUID-5948

Fixed

Details

Assignee

Reporter

Labels

Components

Fix versions

Affects versions

Priority

Created November 11, 2013 at 2:44 PM
Updated August 30, 2016 at 5:03 PM
Resolved August 30, 2016 at 5:03 PM