In Firefox 3.6, the HTML 5 strategy for Uploader sends an invalid multipart request, causing uploads to fail in PHP

Description

On line 202 of HTML5UploaderSupport.js, in the generateMultipartContent() method, we hand roll our own multipart request to send via XHR. However, we mistakenly start the the message with a single whitespace character (" "), which is not a valid. This causes an the request to be ignored as malformed by PHP.

The fix is super easy: just remove the space at line 202, and suddenly PHP likes us again.

Environment

None

Attachments

1

Activity

Show:

Colin Clark December 20, 2010 at 9:22 PM

I committed MIke's patch at r10443 after Michelle reviewed it.

Michelle D'Souza December 20, 2010 at 8:46 PM

Yep, the patch indeed removes the invalid leading space. Reviewed and ready to commit.

Mike Lam December 20, 2010 at 3:12 PM

Removed a space in the multi-part request so that the Uploader will upload files properly to PHP-based servers in FF 3.6

Colin Clark December 17, 2010 at 11:52 PM

I've committed a simple server debugging script written in PHP by Cindy, which is very helpful in debugging Upload issues with the server. It's located in the scratchpad: https://source.fluidproject.org/svn/scratchpad/uploader/simple-server-debug

Fixed

Details

Assignee

Reporter

Components

Fix versions

Priority

Created December 17, 2010 at 11:46 PM
Updated December 20, 2010 at 9:22 PM
Resolved December 20, 2010 at 9:22 PM