Simple Inline Edit Demo - Invitation text should be more informative and in a different colour and style.
Description
In the Simple Inline Edit Demo, the default invitation text (the text that appears when the editable text field is empty), should be in a different style and colour. As well, the text itself should be useful to the user giving them an indication of what to do.
Suggested style: italics with a grey colour. Suggested invitation text: "Edit me", "Edit this", "Edit this text"
Currently the invitation text is indistinguishable from editable text.
Environment
None
Attachments
3
Activity
Show:
Michelle D'Souza December 1, 2010 at 10:04 PM
I code reviewed this and am happy with it.
Mike Lam November 26, 2010 at 9:00 PM
Set the demo font-size to 2em and removed 'normal'
Mike Lam November 26, 2010 at 8:11 PM
Moved the defaultViewStyle from the demo to the component. Some CSS tweaks may be needed as the demo-inlineEdit-title style is overriding the italic styling of the defaultViewStyle.
Jonathan Hung November 26, 2010 at 7:03 PM
Some of the changes shown in the demo patch should become new defaults for the component: 1. component's defaultViewStyle style should be changed to match that of .demo-inlineEdit-invitation in the patch. 2. component's defaultViewText variable in the JS file should change to "Edit this".
Also: 3. the Demo's Javascript is overloading classnames in some places (class used for both selecting and styling) 4. some classes need better naming to follow convention. 5. some instances where custom selector or style is defined where the component's default should be enough.
In the Simple Inline Edit Demo, the default invitation text (the text that appears when the editable text field is empty), should be in a different style and colour. As well, the text itself should be useful to the user giving them an indication of what to do.
Suggested style: italics with a grey colour.
Suggested invitation text: "Edit me", "Edit this", "Edit this text"
Currently the invitation text is indistinguishable from editable text.