The InlineEdit demo in the new demo portal has crufty code at the top of it.

Description

The Inline Edit component demo has this code at the top of it:

/**

  • Customize the undo subcomponent appearance.

  • @param {Object} that

  • @param {Object} targetContainer
    */
    var myUndoRenderer = function (that, targetContainer) {
    var markup = "<span class='flc-undo'>" +
    "<span class='flc-undo-undoContainer'><a href='#' class='flc-undo-undoControl'><img src='../../../../integration-demos/sakai/images/undo.png' alt='Undo your edit' title='Undo your edit' style='border:none' /></a></span>" +
    "<span class='flc-undo-redoContainer'><a href='#' class='flc-undo-redoControl'><img src='../../../../integration-demos/sakai/images/redo.png' alt='Redo your edit' title='Redo your edit' style='border:none' /></a></span>" +
    "</span>";
    var markupNode = $(markup);
    targetContainer.append(markupNode);
    return markupNode;
    };

This is Eli's fancy undo/redo markup, but this renderer isn't hooked up anywhere. If we want to use it, we should hook it up, otherwise delete it.

Environment

None

Activity

Show:

Michelle D'Souza January 14, 2011 at 4:27 PM

Reopening these issues in order to add the inline edit component to them.

Colin Clark October 2, 2009 at 10:39 PM

I've review Jacob's change and it looks good. +1

Jacob Farber September 30, 2009 at 8:46 PM

I removed the function, awaiting review

Jacob Farber September 23, 2009 at 3:09 AM
Edited

Since we could implement a the function in the integration demo, I figured I could save you the trouble and just delete it from the simple demo.

Justin Obara September 22, 2009 at 2:55 PM

Bug Parade Infusion 1.1.2

Fixed

Details

Assignee

Reporter

Components

Fix versions

Priority

Created September 15, 2009 at 9:37 PM
Updated January 14, 2011 at 4:54 PM
Resolved January 14, 2011 at 4:54 PM