Typo in renderer resolveMessageSource() function

Description

The first line of resolveMessageSource() in fluidRenderer.js reads:

if (messageSource.type = "data") {

I suspect that "=" should be "===" instead.

Environment

None

Activity

Show:

Antranig Basman February 4, 2009 at 5:38 PM

Fixed at revision 6419 - In fact we do not support any other kinds of MessageSource than "data" right now, so it could be argued that the current implementation is just being "generous"
To be honest, I don't directly recall what other kinds of MessageSource were planned right now, but hopefully this will become obvious again once/if we start working more heavily with I18Ned templates. It will become possible to write a test for this issue once we do support a second type of MessageSource

Anastasia Cheetham February 4, 2009 at 5:04 PM

The renderer unit tests do have tests for UIMessage rendering. Tests should be added that catch this bug as part of the process of fixing it.

Fixed

Details

Assignee

Reporter

Original estimate

Time tracking

No time logged30m remaining

Components

Fix versions

Affects versions

Priority

Created February 4, 2009 at 3:37 PM
Updated June 3, 2009 at 5:46 PM
Resolved February 4, 2009 at 5:38 PM