UI Options should show current styling options as selected

Description

when you open the iFrame the selected settings are always the same, to start, no matter what the current style on the page is

Steps to reproduce:

1) Open the sakai mock-up:
http://build.fluidproject.org/fluid/sample-code/shared/sakai/sakai.html

2) Click on the "Edit Preferences" button

3) Change the colour scheme, click on "save and Apply your Preferences", and click close

4) Click on the "Edit Preferences" button

Notices that the original styling options are selected not the current style's options

Environment

FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5) FF2, FF3, IE6, IE7, Opera 9.5 (Win XP) FF3, IE7 (Win Vista) FF3, IE6 (Win 2000)

Attachments

2

Activity

Show:

Justin Obara December 15, 2008 at 7:12 PM

Verified fix using

FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
FF2, FF3, IE7, Opera 9.5 (Win XP)
FF3, IE7 (Win Vista)

Anastasia Cheetham December 15, 2008 at 5:58 PM

I have reviewed this patch, and it looks good to me.

Michelle D'Souza December 15, 2008 at 5:52 PM

Linted patch with license.

Michelle D'Souza December 15, 2008 at 5:41 PM

This regression was reintroduced in revision 6190. The problem is that the UI Options component was being initialized every time the 'Edit Appearance' button was pressed. I've created a patch that initializes the component only on the first time the button is pressed.

Michelle D'Souza December 15, 2008 at 5:36 PM

Patch file that initializes the UI Options component only once.

Fixed

Details

Assignee

Reporter

Components

Priority

Created December 11, 2008 at 8:13 PM
Updated December 15, 2008 at 7:12 PM
Resolved December 15, 2008 at 7:12 PM

Flag notifications