The fix looks ok to me in terms of code, but assigning to Colin to verify that the use of ARIA roles is indeed correct. I suggest that the variable "selector" in drawerAdjust be renamed since by line 91 its use is deceptive, it is clearly no longer a selector but represents DOM nodes. This clarity should cascade upwards to the methods "openDrawers" and "closeDrawers" whose APIs should be better documented to explain their expectations - an idiom used elsewhere is to refer to a "jQueryable". I also suggest the uses of "move" be replaced with "adjust" - "move" suggests that the drawer nodes are to be physically shifted around the DOM, rather than just have their visual state adjusted. This would make consistency with the internal method named "drawerAdjust".
Justin Obara March 24, 2010 at 2:11 PM
Assigned to Antranig for review
Justin Obara March 22, 2010 at 9:08 PM
Moved the tab role and aria states from the Drawer to the Handle. Also added the tabpanel role to the Contents.
Cabinet doesn't implement all of the necessary aria roles
Each of the contents sections should be tabpanels
http://dev.aol.com/dhtml_style_guide#tabpanel
http://www.w3.org/WAI/PF/aria/roles#tabpanel