Program steps and add nodes don't get focus when clicked in Safari.

Description

If you activate the action menu for a step using the keyboard, the next tab takes you to the delete step icon.  If you activate the action menu for a step using the mouse, the next tab takes you to the next add step icon (if those are expanded).  This does not happen in Firefox or Chrome.

Activity

Show:

Tony Atkins [RtF] December 8, 2021 at 1:18 PM

Apparently this is known behaviour for Safari:

https://developer.mozilla.org/en-US/docs/Web/HTML/Element/button#clicking_and_focus

 

Just to comment on why we don't see this with the command palette, in that case the focus styles are associated with the selected command variable, which we manage ourselves in response to clicks, et cetera.

Tony Atkins [RtF] December 8, 2021 at 1:01 PM

This issue claims the behaviour is intentional.

https://bugs.webkit.org/show_bug.cgi?id=13724

Tony Atkins [RtF] December 8, 2021 at 12:31 PM

As we discussed in meetings and on the chat, this seems to be one symptom of a potentially larger problem.  It seems like the focus logic in ProgramBlockEditor.js doesn't work on Safari for either add nodes or command blocks.

Done

Details

Assignee

Reporter

Components

Fix versions

Created December 6, 2021 at 2:42 PM
Updated July 12, 2022 at 7:36 PM
Resolved July 12, 2022 at 7:36 PM