Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 161 Current »

[09:27:10 CST(-0600)] <Justin_o> mlam, colinclark: wondering about this jira http://issues.fluidproject.org/browse/FLUID-3753
[09:27:22 CST(-0600)] <Justin_o> so there will no longer be a toggle from flash to plain single file upload?
[09:27:50 CST(-0600)] <colinclark> Justin_o: Based on jameswy's recommendation, that's right
[09:28:14 CST(-0600)] <colinclark> He said that with this approach we were probably in good shape just to omit it
[09:29:48 CST(-0600)] <colinclark> Justin_o: http://issues.fluidproject.org/browse/FLUID-3885
[09:29:58 CST(-0600)] <colinclark> I'd like to add this last one to the bug parade during general cleanup time
[09:30:17 CST(-0600)] <colinclark> In the spirit of keeping cindyli from getting mad at me for all the changes in Uploader (smile)
[09:31:47 CST(-0600)] <cindyli> colinclark: thx. (tongue)
[09:35:22 CST(-0600)] <heidi> sorry i'm late. my husband walked into a door and broke is only pair of glasses, blind as a bat without them... back from glasses centre. justin_o what can i work on/test !
[09:36:12 CST(-0600)] <mlam> heidi: can you help us out with the uploader?
[09:36:28 CST(-0600)] <heidi> mlam for sure. is it in trunk or is there a patch or ?
[09:36:41 CST(-0600)] <mlam> everything's in trunk now (smile)
[09:37:31 CST(-0600)] <heidi> mlam cool, ill check it out!
[09:38:01 CST(-0600)] <mlam> thanks!
[09:53:05 CST(-0600)] <heidi> mlam the browse files button isn't working .... am looking at src/webapp/demos/uploader/html/uploader.html - is that right?
[09:53:37 CST(-0600)] <mlam> no, for the uploader it's the uploader.html in the components directory
[09:53:44 CST(-0600)] <mlam> i'll talk to colinclark about changing that
[10:21:14 CST(-0600)] <Justin_o> anastasiac: do you have time, and would you like to coordinate updating the readme file?
[10:21:35 CST(-0600)] <anastasiac> Justin_o, sure - I can help with that
[10:22:13 CST(-0600)] <Justin_o> anastasiac: thanks
[10:26:13 CST(-0600)] <cindyli> mlam: read from the channel that colin just suggested to add 3885 into bug parade, "Implement backwards compatibility of Uploader's options from version 1.2 to 1.3". should i hold off modifying uploader in atutor till this is done?
[10:28:26 CST(-0600)] <mlam> I think you can still keep going with the uploader. I don't imagine the fix to take very long
[10:28:49 CST(-0600)] <cindyli> mlam: alrite. will start. thx
[10:29:09 CST(-0600)] <mlam> let me know if you run into any issues
[10:30:06 CST(-0600)] <cindyli> mlam: sure. another question is, can i use the uploader API on the wiki, is it updated?
[10:30:56 CST(-0600)] <mlam> No, the uploader API on the wiki will be out of date. We'll have to update the API before the release
[10:31:07 CST(-0600)] <mlam> Maybe I can get to that this afternoon or tomorrow morning
[10:55:30 CST(-0600)] <heidi> mlam the 'add more' button retains its focus style after adding files, and focus moving to upload button
[10:56:08 CST(-0600)] <mlam> what browser are you on?
[10:56:59 CST(-0600)] <mlam> or is this happening on all browsers?
[10:58:55 CST(-0600)] <jhung> everyone: In the rich text inline edit demo, you need to specifically click on the Edit link to begin edti mode. Clicking the paragraph doesn't do anything. Is this intentional?
[10:59:26 CST(-0600)] <mlam> jhung: yes it's intentional
[10:59:44 CST(-0600)] <jhung> mlam: okay...
[10:59:56 CST(-0600)] <mlam> we spoke to james about this and he thought that was the best interaction for it
[11:01:22 CST(-0600)] <heidi> mlam it was firefox on mac
[11:01:29 CST(-0600)] <heidi> using keyboard
[11:02:32 CST(-0600)] <heidi> mlam ff on win too
[11:03:11 CST(-0600)] <mlam> ok
[11:05:48 CST(-0600)] <heidi> mlam happens with mouse too
[11:06:08 CST(-0600)] <mlam> ok
[11:16:11 CST(-0600)] <colinclark> mlam: I was just catching up on channel logs
[11:16:21 CST(-0600)] <colinclark> heidi mentioned that the Uploader demo was broken?
[11:16:32 CST(-0600)] <colinclark> Isn't that a terrible thing?
[11:16:48 CST(-0600)] <heidi> colinclark yeah browse button didn't work ... this is the /demos version
[11:17:05 CST(-0600)] <colinclark> That is most certainly a bug
[11:17:13 CST(-0600)] <colinclark> Of course we want our demo to work, right? (smile)
[11:17:18 CST(-0600)] <mlam> I think we just need to move the component html file into the demos directory for consistency with the other componenents
[11:17:26 CST(-0600)] <colinclark> ?
[11:17:35 CST(-0600)] <colinclark> The component HTML file is a template
[11:17:44 CST(-0600)] <colinclark> loaded via AJAX into the demo page
[11:18:24 CST(-0600)] <colinclark> and as for cindyli and the issue of options backwards compatibility
[11:18:34 CST(-0600)] <mlam> Shouldn't the template be loaded from the demos directory if it's being used for the demo?
[11:19:01 CST(-0600)] <colinclark> cindyli: if you don't feel like changing your code to work with Uploader's changed API (with no documentation yet), I'd suggest waiting until I squash FLUID-3885 today
[11:19:33 CST(-0600)] <cindyli> colinclark: ok. mlam is working on updating wiki api anyway. also waiting on that. thx
[11:19:52 CST(-0600)] <colinclark> mlam: I'm not sure I understand
[11:20:54 CST(-0600)] <cindyli> oh, the now uploader has modified options or so, i thought you are going to update the api on the wiki page?!
[11:21:01 CST(-0600)] <mlam> colinclark: all of the other component demo templates are stored in the demos directory, whereas the template for the uploader demo is coming from the component/uploader/html directory.
[11:21:29 CST(-0600)] <colinclark> I think we might have a terminology issue? Or I'm just thorougly confused
[11:21:38 CST(-0600)] <colinclark> So, each demo has its own HTML page
[11:21:49 CST(-0600)] <colinclark> which is loaded automatically by the portal into an (ick) iFrame
[11:22:00 CST(-0600)] <colinclark> On the other hand, a template is something specific
[11:22:18 CST(-0600)] <colinclark> It represents the definitive markup for a component that the user should use in their application
[11:22:18 CST(-0600)] <cindyli> colinclark: i'm also confused. r u talking template stuff with me?
[11:22:27 CST(-0600)] <colinclark> cindyli: I'm talking to mlam
[11:22:48 CST(-0600)] <cindyli> ic :-D
[11:23:17 CST(-0600)] <colinclark> cindyli: For options and API, I've changed things a lot in the code. We have a JIRA open for me to provide an adaptor, which will give you backwards compatibility with your Infusion 1.2-era integration with Uploader
[11:23:22 CST(-0600)] <colinclark> Wait for that, and we'll be cool
[11:23:35 CST(-0600)] <colinclark> Most templates are rendered by the Renderer, mlam
[11:23:35 CST(-0600)] <mlam> colinclark: ok, terminology confusion on my part
[11:23:37 CST(-0600)] <cindyli> colinclark: understand
[11:23:41 CST(-0600)] <colinclark> Uploader is pretty antiquated
[11:23:53 CST(-0600)] <colinclark> so its template is generally AJAXed in by the user
[11:23:58 CST(-0600)] <colinclark> or cut and pasted (eek)
[11:24:02 CST(-0600)] <colinclark> So, for our demo
[11:24:24 CST(-0600)] <colinclark> we have an HTML page that is mostly empty, except for the < head > and a container where the template will get AJAXed in
[11:24:43 CST(-0600)] <colinclark> The demo code, you'll see, actually does the AJAX call to the file system and injects the Uploader's markup into the page
[11:25:10 CST(-0600)] <colinclark> If the demo is broken, it's usually a sign that you or I forgot to include some new JS files in the header of its HTML page
[11:25:34 CST(-0600)] <colinclark> So in terms of testing the Uploader, we need lots of browser coverage
[11:25:40 CST(-0600)] <colinclark> IE especially, in its various flavours
[11:25:52 CST(-0600)] <colinclark> Test the demo, the standalone template, and the integration with Image Gallery
[11:26:19 CST(-0600)] <colinclark> heidi, mlam: ^
[11:26:25 CST(-0600)] <colinclark> then we'll make a list of little things we need to fix
[11:26:28 CST(-0600)] <colinclark> and hopefully they'll be little
[11:26:30 CST(-0600)] <colinclark> (smile)
[11:27:08 CST(-0600)] <heidi> cool
[11:27:17 CST(-0600)] <heidi> i get the super basic version in IE8 - should it be flash?
[11:28:04 CST(-0600)] <heidi> actually let me dble check it's installed... might've removed it awhile ago to tst
[11:28:47 CST(-0600)] <heidi> yeah still super basic version mlam colinclark
[11:30:22 CST(-0600)] <colinclark> heidi: Definitely flash, yes heidi
[11:30:43 CST(-0600)] <heidi> mlam is it flash for you in IE?
[11:30:45 CST(-0600)] <mlam> heidi: you're right, i'm getting the single file uploader as well in IE8
[11:30:49 CST(-0600)] <heidi> ok
[11:32:40 CST(-0600)] <Bosmon2> So, I have failed to get "dynamic announcements" working for the Reorderer
[11:32:44 CST(-0600)] <mlam> heidi: the focus on the Add More button happens in windows, not in linux for me
[11:32:46 CST(-0600)] <Bosmon2> It was an intensely frustrating experience
[11:32:58 CST(-0600)] <Bosmon2> But it may be something that is just impossible with the current ATs
[11:32:59 CST(-0600)] <heidi> mlam k, win and mac then i guess
[11:56:09 CST(-0600)] <colinclark> Bosmon2: Okay, my crusty version of FluidView.js is out of trunk again
[11:56:13 CST(-0600)] <colinclark> you should be okay to commit your branch
[11:56:21 CST(-0600)] <colinclark> or, rather, your working copy
[11:58:24 CST(-0600)] <colinclark> so mlam any interesting new issues for Uploader?
[11:58:33 CST(-0600)] <colinclark> I guess the big one is no multi with IE 8?
[11:58:37 CST(-0600)] <colinclark> even when Flash 9+ is installed?
[11:58:51 CST(-0600)] <mlam> yes, the big one is the no multi with IE8
[11:58:52 CST(-0600)] <mlam> yes
[11:59:01 CST(-0600)] <colinclark> Has anyone tried it in IE 9?
[11:59:04 CST(-0600)] <mlam> well, i have flash 10 on my IE
[11:59:07 CST(-0600)] <mlam> not sure about 9
[11:59:15 CST(-0600)] <colinclark> Are there sane debugging tools in IE 8?
[11:59:18 CST(-0600)] <colinclark> I can't even remember
[11:59:32 CST(-0600)] <mlam> and then the focus on the Add More button after uploading files in both windows and Mac
[11:59:38 CST(-0600)] <colinclark> ok
[11:59:43 CST(-0600)] <mlam> the debugger in IE stinks so badly.
[11:59:44 CST(-0600)] <colinclark> Have we seen that one before?
[11:59:48 CST(-0600)] <colinclark> the focus issue?
[12:00:12 CST(-0600)] <mlam> I'm not sure . I didn't test in windows for a couple weeks now
[12:15:22 CST(-0600)] <michelled> heidi: I was just looking at your patch for 3828
[12:15:45 CST(-0600)] <heidi> what do you think?
[12:16:11 CST(-0600)] <michelled> I like patches that improve the experience while removing code (smile)
[12:16:18 CST(-0600)] <michelled> two things that need to be fixed up though
[12:17:18 CST(-0600)] <michelled> 1. instead of hard coding the "Current Page" string we should use the string in the options. I think it's terribly named but I'm not sure whether we are locked into that name or when it came into the code base
[12:17:33 CST(-0600)] <Justin_o> fluid-everyone: just to pick up on the getBeanValue discussion from yesterday... i just went to use it today and noticed that it is fluid.model.getBeanValue... i think i would now be fine with fluid.model.get. this seems to be clear enough...
[12:17:34 CST(-0600)] <michelled> it's called 'currentPageIndexMsg'
[12:17:58 CST(-0600)] <michelled> you can get at it like this: that.options.strings.currentPageIndexMsg
[12:18:05 CST(-0600)] <heidi> ah cool
[12:18:19 CST(-0600)] <colinclark> heidi: That will allow our users to translate the component into other languages
[12:18:23 CST(-0600)] <heidi> do you want me to change that or can you?
[12:18:34 CST(-0600)] <michelled> the other thing is that there were tests for the described by that are now failing
[12:18:40 CST(-0600)] <heidi> ah
[12:19:41 CST(-0600)] <michelled> could you look at it? I'm supposed to be writing some uploader tests (smile)
[12:20:11 CST(-0600)] <colinclark> Hey heidi and mlam, I'm having trouble reproducing problems with Uploader in IE 8
[12:20:22 CST(-0600)] <heidi> michelled will do! thanks for the help
[12:20:37 CST(-0600)] <heidi> colinclark - you're getting the flash version?
[12:20:41 CST(-0600)] <colinclark> I tried the demo, the standalone template, and the Image Gallery and it seems to be working--giving me the Flash version
[12:20:42 CST(-0600)] <colinclark> yeah
[12:20:43 CST(-0600)] <colinclark> weird
[12:20:57 CST(-0600)] <heidi> hm
[12:21:20 CST(-0600)] <heidi> colinclark this would be \components\uploader\html\Uploader.html right
[12:21:32 CST(-0600)] <colinclark> AHA!
[12:21:36 CST(-0600)] <colinclark> I'm trying it on the build site
[12:21:43 CST(-0600)] <heidi> ahh
[12:21:54 CST(-0600)] <colinclark> Running it locally, you do need to follow the instructions to set up your version of Flash with local permissions
[12:21:59 CST(-0600)] <colinclark> I'll dig those up
[12:22:08 CST(-0600)] <heidi> ah i see!
[12:22:13 CST(-0600)] <colinclark> mlam and heidi, can you try the build site version, just to make sure?
[12:22:18 CST(-0600)] <heidi> will do now
[12:24:07 CST(-0600)] <heidi> colinclark http://build.fluidproject.org/infusion/components/uploader/html/Uploader.html still simple upload
[12:24:53 CST(-0600)] <heidi> i think my flash is weird... sec
[12:26:30 CST(-0600)] <heidi> colinclark working! reinstalled flash
[12:26:37 CST(-0600)] <colinclark> sweet
[12:26:39 CST(-0600)] <heidi> there's a black bar along the bottom, but it's there
[12:26:39 CST(-0600)] <colinclark> so that's great
[12:26:54 CST(-0600)] <colinclark> I guess you proved that progressive enhancement works 100% in IE
[12:27:01 CST(-0600)] <heidi> yes (smile)
[12:27:02 CST(-0600)] <colinclark> since without a working Flash, you got the simple uploader
[12:27:05 CST(-0600)] <colinclark> and now you're getting the real deal
[12:27:09 CST(-0600)] <colinclark> What's the black bar along the bottom?
[12:27:34 CST(-0600)] <colinclark> ah, it seems to be keyboard focus on the document
[12:27:47 CST(-0600)] <colinclark> This must be related to the FSS heavy-handed :focus styles?
[12:27:48 CST(-0600)] <heidi> yah, good old fss-reset
[12:28:15 CST(-0600)] <colinclark> Gotta fix that in 1.4
[12:28:31 CST(-0600)] <colinclark> I think there are some lingering bugs related to keyboard navigation here
[12:28:34 CST(-0600)] <colinclark> I'll see what I can do about htat
[12:28:58 CST(-0600)] <heidi> colinclark looking really good - nice work
[12:29:01 CST(-0600)] <colinclark> Ok, so we can confirm to the King that Uploader seems like it's working fine in IE 8?
[12:29:20 CST(-0600)] <colinclark> Does anyone have time to try it with IE 6?
[12:29:21 CST(-0600)] <heidi> mlam give it a try?
[12:29:35 CST(-0600)] <colinclark> I think mlam might be lunching
[12:29:54 CST(-0600)] <heidi> don't have ie6 on my end
[12:30:02 CST(-0600)] <heidi> can i install it somehow?
[12:30:12 CST(-0600)] <colinclark> We have a VM you could use
[12:30:20 CST(-0600)] <colinclark> but it might take awhile to transfer
[12:44:12 CST(-0600)] <mlam> colinclark: Justin_o: heidi: uploader now working with IE8. my version of flash was wonky
[12:44:21 CST(-0600)] <colinclark> whew
[12:44:22 CST(-0600)] <colinclark> awesome
[12:44:25 CST(-0600)] <colinclark> I'm delighted
[12:44:31 CST(-0600)] <heidi> nicee
[12:44:31 CST(-0600)] <colinclark> Justin is giving me a copy of his IE 6 VM
[12:44:36 CST(-0600)] <colinclark> so I can test there
[12:44:40 CST(-0600)] <colinclark> unless you have IE 6 already, mlam
[12:44:47 CST(-0600)] <colinclark> I'm starting in on options backwards compatibility now
[12:44:50 CST(-0600)] <mlam> no IE 6 here
[12:46:07 CST(-0600)] <mlam> colinclark: i'm downloading IE6 now.
[12:47:44 CST(-0600)] <colinclark> great
[12:51:05 CST(-0600)] <harriswong> fluid-everyone: applying changes for http://issues.fluidproject.org/browse/FLUID-3775, taking out FSS dependencies from src/webapp/framework/fss/fssDependencies.json, changing them into cssFiles instead, and removing files from src/webapp/framework/fss/fss[Layout|Reset|Text|Themes]Dependencies.json. Is it safe to proceed?
[12:51:55 CST(-0600)] <Bosmon2> Hail, O KINGG
[12:52:11 CST(-0600)] <Bosmon2> Justin_o: Colin said I should ping you before trying to commit under FLUID-3730
[12:53:43 CST(-0600)] <Justin_o> Bosmon2: yep.. i had decreed that only some none-general bug parade issues could be committed against...
[12:53:55 CST(-0600)] <Bosmon2> Ah, I see
[12:53:56 CST(-0600)] <Justin_o> Bosmon2: which jiras did you need to commit against?
[12:54:06 CST(-0600)] <Justin_o> is it only FLUID-3730
[12:55:08 CST(-0600)] <Justin_o> Bosmon2: i'm letting exceptions trickle in if needed.. we have 3 on the go at the moment i think
[12:55:09 CST(-0600)] <Bosmon2> 3730 and 3711
[12:55:43 CST(-0600)] <Justin_o> Bosmon2: okay... that should be fine... i'll reply to my e-mail to the list earlier about the exceptions
[12:56:07 CST(-0600)] <Bosmon2> Also, we mentioned yesterday that I had a patch to commit from Harris for 3707
[12:56:11 CST(-0600)] <Bosmon2> But I can't see one attached to the issue
[12:56:21 CST(-0600)] <Justin_o> Bosmon2: yes.. i think that patch never materialized
[12:56:30 CST(-0600)] <Bosmon2> That's fine
[12:56:38 CST(-0600)] <Justin_o> harriswong: put a note about it on the jira i think
[12:56:41 CST(-0600)] <Bosmon2> The determination seems worrying in any case
[12:56:44 CST(-0600)] <Bosmon2> Yes, I read the note
[12:56:47 CST(-0600)] <Bosmon2> I think this kind
[12:56:58 CST(-0600)] <Bosmon2> of obscure issue is one the integrator should deal with by themselves
[12:57:08 CST(-0600)] <Bosmon2> We can't go around fabricating containers around ourselves in the DOM...
[12:57:09 CST(-0600)] <harriswong> Justin_o: ok
[12:57:36 CST(-0600)] <Justin_o> Bosmon2: yep agreed.. I think that's why harriswong didn't bother creating a patch
[12:59:09 CST(-0600)] <colinclark> cool
[13:02:58 CST(-0600)] <jhung> Hi everyone. I found that the tooltip text for rich inline edit was inaccurate. (http://issues.fluidproject.org/browse/FLUID-3887).
[13:02:58 CST(-0600)] <jhung> I created a patch and attached it to the bug. Please review to see if it's appropriate to commit for this release.
[13:03:29 CST(-0600)] <Justin_o> jhung: how are the other demos looking?
[13:05:44 CST(-0600)] <colinclark> Bosmon2: The King mentioned the getBeanValue question earlier in the channel
[13:05:54 CST(-0600)] <colinclark> He has some fairly reasonable arguments against get()
[13:05:58 CST(-0600)] <colinclark> but wanted clarity about one issue
[13:06:04 CST(-0600)] <colinclark> Are you thinking of fluid.get(), or fluid.model.get()
[13:06:09 CST(-0600)] <colinclark> ?
[13:06:36 CST(-0600)] <colinclark> I was sort of enamoured with the former
[13:06:42 CST(-0600)] <colinclark> enamoured might not be the right word
[13:08:01 CST(-0600)] <mlam> colinclark: flash 9 gives the single file upload
[13:08:10 CST(-0600)] <mlam> using IE8
[13:08:37 CST(-0600)] <colinclark> mlam: In IE 6?
[13:08:39 CST(-0600)] <colinclark> or 8?
[13:08:42 CST(-0600)] <colinclark> 8
[13:08:43 CST(-0600)] <colinclark> okay
[13:08:43 CST(-0600)] <mlam> 8
[13:08:46 CST(-0600)] <colinclark> any errors?
[13:08:53 CST(-0600)] <colinclark> i expect this is due to a programming error
[13:10:17 CST(-0600)] <mlam> no errors that i can see
[13:11:06 CST(-0600)] <colinclark> can you do some digging?
[13:11:12 CST(-0600)] <Bosmon2> Is this earlier, as in yesterday?
[13:11:13 CST(-0600)] <colinclark> it might be a horrible experience
[13:11:27 CST(-0600)] <colinclark> Bosmon2: Justin_o mentioned it earlier today in the channel
[13:11:28 CST(-0600)] <Bosmon2> But I am thinking of "fluid.get" yes
[13:11:34 CST(-0600)] <colinclark> But I think he raised his concerns yesterday
[13:11:40 CST(-0600)] <colinclark> partly in conversation with me, partly in the channel
[13:11:42 CST(-0600)] <mlam> yup
[13:11:45 CST(-0600)] <colinclark> Justin_o: Do you want to summarize real quick?
[13:11:46 CST(-0600)] <Bosmon2> I think over time that we have found this utility so fundamental that it belongs in the root
[13:11:53 CST(-0600)] <colinclark> I can imagine this might be one of those situations where we actually vote
[13:11:53 CST(-0600)] <Bosmon2> And it is a name which people type very frequently
[13:11:56 CST(-0600)] <Bosmon2> Almost every day (tongue)
[13:12:08 CST(-0600)] <colinclark> I don't love voting, but naming tends to be one of the things it works well for
[13:12:10 CST(-0600)] <jhung> justin_o: I'm still working my way through the first demo (rich text).
[13:12:55 CST(-0600)] <Justin_o> jhung: okay...
[13:13:35 CST(-0600)] <Justin_o> wondering if there will be more issues
[13:14:15 CST(-0600)] <Justin_o> that need addressing before the release
[13:14:26 CST(-0600)] <Justin_o> jhung: ^
[13:14:55 CST(-0600)] <harriswong> Justin_o: created a patch for http://issues.fluidproject.org/browse/FLUID-3775.
[13:15:35 CST(-0600)] <Bosmon2> yes, this votting can be very powerful
[13:15:47 CST(-0600)] <Bosmon2> It destroyed, I guess, amongst many worthy things, the "DARApplier"
[13:15:54 CST(-0600)] <colinclark> HURRAY!
[13:15:55 CST(-0600)] <colinclark> (tongue)
[13:15:56 CST(-0600)] <Bosmon2> And even that legendary utility known as "fluid.contund()"
[13:16:14 CST(-0600)] <Bosmon2> I guess that is why you are now willing to talk to me about it
[13:16:15 CST(-0600)] <colinclark> HURRAY!
[13:16:21 CST(-0600)] <Bosmon2> After the years that it featured only as a conversation-stopper (tongue)
[13:16:22 CST(-0600)] <anastasiac> contund is gone?
[13:19:38 CST(-0600)] <colinclark> (tongue)
[13:20:28 CST(-0600)] <Bosmon2> The great thing we will be able to do once colinclark makes his model transformation stuff is to make a "transformation-aware getBeanValue"
[13:20:40 CST(-0600)] <Bosmon2> For example to both READ FROM and WRITE TO transformed models!
[13:20:45 CST(-0600)] <colinclark> (smile)
[13:20:56 CST(-0600)] <Bosmon2> Then we can use this to complete our schema work on the Fluid Engage project
[13:20:59 CST(-0600)] <Bosmon2> Wait.......
[13:21:01 CST(-0600)] <Bosmon2> (tongue)
[13:24:32 CST(-0600)] <heidi> hey mlam do you have a sec? golam's unit test confuses me... am trying to tweak it
[13:24:36 CST(-0600)] <heidi> for pager
[13:25:28 CST(-0600)] <mlam> hmmm....i've never seen any of the pager tests before, but what's up?
[13:25:48 CST(-0600)] <heidi> mm, can i screen share for a sec?
[13:26:08 CST(-0600)] <mlam> sure
[13:32:49 CST(-0600)] <Justin_o> Bosmon2: i'd like to finish off engage at some point
[13:33:00 CST(-0600)] <Bosmon2> SO SAY WE ALL
[13:35:02 CST(-0600)] <Justin_o> harriswong: so in your patch for FLUID-3775 you also included removing the individual fss modules and just left the single all fss one.
[13:35:05 CST(-0600)] <jessm> michelled: ping?
[13:35:12 CST(-0600)] <Justin_o> This had been on my suggestion...
[13:35:31 CST(-0600)] <colinclark> jessm: michelled is pairing with me
[13:35:34 CST(-0600)] <colinclark> what's up?
[13:35:59 CST(-0600)] <harriswong> Justin_o: oh, ok! So they did get removed? Perfect, thanks!
[13:36:05 CST(-0600)] <jessm> colinclark: we have a mtg. with Erin
[13:36:09 CST(-0600)] <colinclark> eek
[13:36:11 CST(-0600)] <colinclark> i'll tell her
[13:36:21 CST(-0600)] <colinclark> Justin_o and Bosmon2: We'll get to Engage again one of these days
[13:36:24 CST(-0600)] <Justin_o> fluid-everyone: is that okay with everyone? my argument is that since with the build you will get all the files always, due to a bug.. we might as well not pretend like you can get them individually... also I think it was origianally setup for css concatenation which we still aren't doing
[13:36:24 CST(-0600)] <colinclark> in some form or another
[13:36:26 CST(-0600)] <colinclark> and it will be awesome
[13:36:27 CST(-0600)] <jessm> colinclark: thanks! i think it will be quick
[13:36:45 CST(-0600)] <colinclark> Justin_o: +1
[13:37:41 CST(-0600)] <harriswong> Justin_o: I also did a few tests on the demo with the files removed, seems to work.
[13:37:45 CST(-0600)] <anastasiac> Justin_o, makes sense to me: +1 (re FSS)
[13:38:29 CST(-0600)] <Justin_o> Okay.. thanks.. so i think FLUID-3775 can go in then
[13:38:45 CST(-0600)] <harriswong> Justin_o: the only reason to keep those files is when you need to break the FSS up again in the future.
[13:38:54 CST(-0600)] <Justin_o> harriswong: also jsonlinted the dependency files now.. so they are all formatted similarly and everything
[13:39:10 CST(-0600)] <Justin_o> harriswong: that's true...
[13:39:18 CST(-0600)] <Justin_o> we could always grab it from the history i suppose
[13:39:23 CST(-0600)] <harriswong> Justin_o: But then again you can always refer back to the jira
[13:39:29 CST(-0600)] <Justin_o> yep
[13:39:36 CST(-0600)] <Justin_o> and reverse your patch
[13:39:40 CST(-0600)] <Justin_o> for those parts
[13:39:48 CST(-0600)] <harriswong> Justin_o: yea.. yep.
[13:42:38 CST(-0600)] <Justin_o> fluid-everyone: so for the fluid.get issue... Bosmon2 you are saying that it is used such as fluid.get(obj, path);
[13:44:12 CST(-0600)] <colinclark> Justin_o: fluid.model.getBeanValue = function (root, EL, config) { ... ]
[13:44:32 CST(-0600)] <colinclark> Where "root" is the object from which you want to get the value
[13:44:39 CST(-0600)] <colinclark> and EL is the path to the value
[13:45:23 CST(-0600)] <jhung> anastasiac: for the keyboard a11y demo, the list of images have the class "selectable".
[13:45:34 CST(-0600)] <colinclark> so it would, as you say, be fluid.get(myCat, "state.isSleeping");
[13:45:34 CST(-0600)] <anastasiac> jhung, yes
[13:45:44 CST(-0600)] <colinclark> The value of which is, nearly always, "true"
[13:45:45 CST(-0600)] <Justin_o> i guess i'm still worried that it's not necessarily clear what you are actually getting
[13:46:07 CST(-0600)] <Justin_o> but i guess the actual argument names.. with root is more clear
[13:46:12 CST(-0600)] <jhung> anastasiac: but I'm wondering what would be a better classname if we were to use the prefix "demoSelector-". "demoSelector-selectable" sounds awkward.
[13:46:13 CST(-0600)] <mlam> colinclark: progressive enhancement working fine for Flash 9 on IE8. I just didn't revert Flash versions properly.
[13:46:15 CST(-0600)] <Justin_o> okay.. i think i can be persuaded
[13:46:22 CST(-0600)] <Justin_o> to go with fluid.get
[13:46:40 CST(-0600)] <colinclark> are you sure, Justin_o?
[13:46:54 CST(-0600)] <anastasiac> jhung, ".selectable" is actually the default selector specified by the plug-in, and that part of the demo was trying to show using the defaults, so I wouldn't want to change that one
[13:47:11 CST(-0600)] <jhung> ah. okay.
[13:47:20 CST(-0600)] <Justin_o> i'm not convinced that a new user coming in would understand what this function does
[13:47:37 CST(-0600)] <jhung> anastasiac: I think we should think of namespacing some of those then. (big grin) It wasn't clear. Post 1.3 of course.
[13:47:43 CST(-0600)] <anastasiac> jhung, we should probably put a comment in the HTML about the fact that "selectable" is the default, so we're going to use it here
[13:47:58 CST(-0600)] <jhung> anastasiac: good idea. I'll do that.
[13:48:01 CST(-0600)] <Justin_o> fluid.getValue may be clearer... not sure
[13:48:08 CST(-0600)] <anastasiac> thanks
[13:48:10 CST(-0600)] <Justin_o> but i understand the desire for brevaty
[13:48:56 CST(-0600)] <colinclark> I think we might be at voting time
[13:49:02 CST(-0600)] <colinclark> So, to summarize
[13:49:29 CST(-0600)] <colinclark> We have pretty well a consensus that we'd like to rename fluid.model.getBeanValue() and setBeanValue() to be shorter
[13:49:35 CST(-0600)] <colinclark> and to avoid the java connotation
[13:49:41 CST(-0600)] <colinclark> We have two proposals:
[13:49:46 CST(-0600)] <colinclark> 1. fluid.get()
[13:49:52 CST(-0600)] <colinclark> 2. fluid.getValue()
[13:50:10 CST(-0600)] <colinclark> Any +1s?
[13:53:54 CST(-0600)] <Bosmon2> I think "fluid.model.get()" was also proposed?
[13:54:02 CST(-0600)] <Bosmon2> I +1 for fluid.get()
[13:54:15 CST(-0600)] <colinclark> Bosmon2: Yes, right
[13:54:19 CST(-0600)] <colinclark> 3. fluid.model.get()
[13:55:05 CST(-0600)] <Bosmon2> I mean, we should be clear, that "fluid.get" is so fundamental that once we have ECMAScript v6, we plan to subsume its use into the "." operator built into the language (tongue)
[13:55:12 CST(-0600)] <colinclark> fluid-everyone: We're discussing the renaming of one of our core framework features ("the" core framework feature). If you feel like you have an opinion, please feel free to vote on the three options above.
[13:55:18 CST(-0600)] <mlam> coming from a heavy Java background, I always prefer functions or methods to be named getValue() over get(). seems more clear to me.
[13:56:37 CST(-0600)] <heidi> i like .get() getValue seems redundant.... what else would .get be getting?
[13:56:51 CST(-0600)] <heidi> i said get to many times and now it sounds weird
[13:56:54 CST(-0600)] <colinclark> ah, look, it's elicochran
[13:56:54 CST(-0600)] <heidi> *too
[13:57:00 CST(-0600)] <colinclark> he'll be delighted to hear about this vote
[13:57:10 CST(-0600)] <elicochran> vote?
[13:57:26 CST(-0600)] <colinclark> We're talking about renaming fluid.model.getBeanValue() (with backwards compatibility)
[13:57:26 CST(-0600)] <colinclark> (smile)
[13:57:39 CST(-0600)] <anastasiac> I'd say including "model" is not necessary, since it's not particular to models (unless you consider everything to be a model, in which case it is again not necessary)
[13:57:45 CST(-0600)] <colinclark> The three options on the table are 1. fluid.get(), 2. fluid.getValue(), and 3. fluid.model.get()
[13:58:18 CST(-0600)] <Justin_o> colinclark: i guess i'll +1 number option 2
[13:58:52 CST(-0600)] <anastasiac> get() seems awfully abrupt to me, but heidi's right - you couldn't really be getting anything other than the value, so you don't really need to be that specific
[13:58:53 CST(-0600)] <colinclark> So in case people are wondering, here's a document that describes our voting process http://wiki.fluidproject.org/display/fluid/Voting
[13:58:56 CST(-0600)] <elicochran> oh yeah, my least favorite name in Fluid. Funny (wink)
[13:59:00 CST(-0600)] <colinclark> lol
[13:59:12 CST(-0600)] <colinclark> I think you have global agreement about that, elicochran
[13:59:41 CST(-0600)] <elicochran> as usual, my timing is impeccable. carry on!
[13:59:44 CST(-0600)] <colinclark> lol
[13:59:52 CST(-0600)] <colinclark> So for those who want to vote, you should just +1 for your preferred option. If you just want to share an option, go for it.
[13:59:57 CST(-0600)] <colinclark> I'll only tally +1s or -1s
[14:00:31 CST(-0600)] <colinclark> So far we have one +1 for #1, and one for #2
[14:00:38 CST(-0600)] <mlam> +1 #2
[14:00:59 CST(-0600)] <heidi> +1 #1 (smile)
[14:01:21 CST(-0600)] <anastasiac> +1 for #2... this is getting close!
[14:02:16 CST(-0600)] <colinclark> I'm keen to hear what michelled and jessm will vote, but they're on a call
[14:03:05 CST(-0600)] <colinclark> Justin_o: I made a mistake when I merged the FLUID-3722 branch last night
[14:03:11 CST(-0600)] <colinclark> I shaved off one revision
[14:03:27 CST(-0600)] <colinclark> A key revision that involved adding extra ARIA labels for each row in the fileQueueView
[14:03:38 CST(-0600)] <colinclark> with Bosmon2's last commit, I've managed to restore that functionality
[14:03:42 CST(-0600)] <colinclark> it's not on your list of exceptions
[14:03:53 CST(-0600)] <colinclark> but in apology, I have written a whole set of shiny new, green tests
[14:03:57 CST(-0600)] <colinclark> for this functionality
[14:04:12 CST(-0600)] <Justin_o> (smile) i like it when the tests are green
[14:04:22 CST(-0600)] <Justin_o> colinclark: okay.. i'll add it to the exception list
[14:04:56 CST(-0600)] <colinclark> thanks
[14:04:59 CST(-0600)] <colinclark> committing now
[14:05:52 CST(-0600)] <yura_> i would +1 # 1
[14:06:17 CST(-0600)] <Justin_o> colinclark: can i vote for Golam since he is on vacation (wink)
[14:06:25 CST(-0600)] <colinclark> (tongue)
[14:06:45 CST(-0600)] <colinclark> Justin_o is showing his true Kingly colours
[14:07:06 CST(-0600)] <michelled> I vote +1 #1
[14:07:18 CST(-0600)] <colinclark> someone might start a revolución!
[14:07:31 CST(-0600)] <colinclark> So we've got four votes for #1
[14:07:32 CST(-0600)] <michelled> that's what happens when the KING turns violent (tongue)
[14:07:34 CST(-0600)] <colinclark> two for #2
[14:07:48 CST(-0600)] <colinclark> oh sorry
[14:07:51 CST(-0600)] <colinclark> three for #2
[14:07:57 CST(-0600)] <colinclark> the ballot counters are incompetent!
[14:08:01 CST(-0600)] <colinclark> (that would be me)
[14:08:05 CST(-0600)] <michelled> I want a recount!
[14:08:08 CST(-0600)] <anastasiac> hanging chads?
[14:08:09 CST(-0600)] <Justin_o> well that was 2 more votes than i thought we'd get for it... so i'm happy
[14:08:47 CST(-0600)] <mlam> i'm pretty sure Golam would be a +1 for #1, but since he's not here...we can't count him in on that (smile)
[14:09:31 CST(-0600)] <colinclark> welp, three votes are enough to call it
[14:09:40 CST(-0600)] <colinclark> but we can wait a little while longer in case any other votes trickle in
[14:11:36 CST(-0600)] <jessm> my only vote is keep it simple (Kiss principle)
[14:11:43 CST(-0600)] <jessm> and it looks like simple is winning (smile)
[14:12:40 CST(-0600)] <Bosmon2> hahaha
[14:12:54 CST(-0600)] <Bosmon2> Yes, the KINGG could build a palace on a neighbouring hill from which to shell the public
[14:13:02 CST(-0600)] <Bosmon2> They did this in Barcelona for a while (tongue)
[14:13:24 CST(-0600)] <colinclark> please don't shell us, king
[14:13:28 CST(-0600)] <Bosmon2> hahahahaha
[14:14:53 CST(-0600)] <heidi> michelled updated patch on fluid-3828
[14:15:04 CST(-0600)] <michelled> thanks heidi
[14:15:28 CST(-0600)] <colinclark> Justin_o: My Uploader commit is in
[14:15:32 CST(-0600)] <colinclark> so we're down to two:
[14:15:38 CST(-0600)] <Justin_o> colinclark: thanks...
[14:15:42 CST(-0600)] <colinclark> a. unit tests for progressive enhancement framework
[14:15:49 CST(-0600)] <colinclark> b. options backwards compatibility
[14:15:54 CST(-0600)] <colinclark> michelled and I are working on b
[14:15:58 CST(-0600)] <colinclark> starting with some unit tests
[14:18:32 CST(-0600)] <anastasiac> fluid-everyone: I'm going to redeploy build.fluidproject.org, so it will be our for few minutes
[14:18:37 CST(-0600)] <colinclark> anastasiac: thanks!
[14:19:49 CST(-0600)] <Bosmon2> Hail, O KINGGG
[14:20:11 CST(-0600)] <anastasiac> Justin_o, jhung: It looks to me like http://issues.fluidproject.org/browse/FLUID-3288 is no longer reproducable - probably a side effect of other changes. If you agree, should we close it?
[14:20:12 CST(-0600)] <Bosmon2> Justin_o: Can we also have an exception for FLUID-3487? This mainly requires me to write some test cases
[14:20:29 CST(-0600)] <colinclark> There is a general issue open for unit tests, right?
[14:21:48 CST(-0600)] <jhung> anastasiac: Not 100% sure since I have not tested in Ubuntu.
[14:21:57 CST(-0600)] <anastasiac> the unit test coverage jira is FLUID-3777, Bosmon2 and colinclark
[14:22:35 CST(-0600)] <anastasiac> ah, jhung, didn't catch the environment - thanks for pointing that out
[14:23:56 CST(-0600)] <Justin_o> colinclark: there is
[14:24:33 CST(-0600)] <jhung> anastasiac: is this issue testable using the current build site?
[14:24:46 CST(-0600)] <heidi> harriswong test #9 for pager is failing
[14:24:59 CST(-0600)] <Justin_o> Bosmon2: if you want you can file your tests against the general one.. if you would prefer to file against the FLUID-3487 i can make an exception for that, but i think filing against the general and making a comment about it on the jira should be fine
[14:25:00 CST(-0600)] <anastasiac> jhung, it should be - build site has latest trunk
[14:25:23 CST(-0600)] <michelled> heidi: your patch includes a new test for aria sort - is that intentional?
[14:25:38 CST(-0600)] <Justin_o> anastasiac: I committed a fix for that
[14:25:46 CST(-0600)] <Justin_o> thanks for testing it (smile)
[14:25:50 CST(-0600)] <heidi> oops no michelled
[14:25:52 CST(-0600)] <anastasiac> ah - cool (smile)
[14:25:58 CST(-0600)] <harriswong> heidi: let me check.
[14:26:03 CST(-0600)] <heidi> michelled that's a patch from harris from yesterday
[14:26:05 CST(-0600)] <heidi> my bad
[14:26:08 CST(-0600)] <anastasiac> Justin_o, I didn't test 3288 in the environments listed, though
[14:26:15 CST(-0600)] <michelled> is it just the test that got left in?
[14:26:20 CST(-0600)] <heidi> harriswong it might be an old patch i added
[14:26:26 CST(-0600)] <michelled> I can remove that but I'm wondering if there's other code in there as well
[14:26:33 CST(-0600)] <heidi> michelled i'll double check
[14:26:43 CST(-0600)] <Justin_o> anastasiac: oh
[14:26:48 CST(-0600)] <Justin_o> so you didn't try with safari?
[14:26:49 CST(-0600)] <anastasiac> sorry
[14:26:54 CST(-0600)] <anastasiac> no, but I can...
[14:27:00 CST(-0600)] <Justin_o> anastasiac: yes please.. thanks
[14:27:36 CST(-0600)] <Justin_o> anastasiac: also harriswong has a couple of patches for the general issues.. do you have time to review and commit those
[14:28:05 CST(-0600)] <Bosmon2> ok, thanks KINGG
[14:29:58 CST(-0600)] <anastasiac> Justin_o, something seems to be off on the build site - I just redeployed, but the new grid reorderer demo that's in trunk hasn't been deployed (unless my cache is wonky)
[14:31:12 CST(-0600)] <anastasiac> Justin_o, harriswong - happy to review patches, just let me know which JIRAs
[14:32:16 CST(-0600)] <jhung> justin_o, anastasiac: as a result of fluid-3288, I am going to close DECA-54 (http://issues.fluidproject.org/browse/DECA-54) and reopen FLUID-3568 (http://issues.fluidproject.org/browse/FLUID-3568). Deca54 is partially fixed because drag actions are fine now, but keyboard action is still broken (FLUID-3568).
[14:34:56 CST(-0600)] <heidi> michelled fixed
[14:36:01 CST(-0600)] <harriswong> heidi: so does that mean #9 passes again?
[14:36:21 CST(-0600)] <heidi> harriswong there is no #9! i guess it was from a patch of yours i applied yesterday
[14:37:06 CST(-0600)] <jhung> justin_o: can http://issues.fluidproject.org/browse/FLUID-3283 be added to bug parade. "Demos missing instructions."
[14:37:59 CST(-0600)] <harriswong> heidi: ok.
[14:38:32 CST(-0600)] <michelled> heidi: does that mean you updated the patch?
[14:38:40 CST(-0600)] <heidi> michelled yep
[14:38:47 CST(-0600)] <michelled> thx
[14:44:40 CST(-0600)] <anastasiac> ah, I think I rebuilt the wrong project...
[14:45:27 CST(-0600)] <anastasiac> Justin_o, ignore my comment about the build site - "user error"
[14:46:44 CST(-0600)] <anastasiac> Justin_o, FLUID-3288 seems fine in Safari 4 on OS 10.6
[14:49:27 CST(-0600)] <harriswong> Justin_o, anastasiac: created patch for http://issues.fluidproject.org/browse/FLUID-3888. Please review.
[14:54:19 CST(-0600)] <heidi> mlam is IE8 uploader (\src\webapp\components\uploader\html\Uploader.html) working for you after update ?
[14:54:41 CST(-0600)] <heidi> i can no longer click browse files
[14:55:08 CST(-0600)] <mlam> flash 9 or 10?
[14:55:24 CST(-0600)] <heidi> mlam 10
[14:56:11 CST(-0600)] <mlam> ok, i'll check it out in 2 mins.
[14:57:08 CST(-0600)] <heidi> tanks
[14:57:42 CST(-0600)] <mlam> colinclark: posted a patch to test the HTML5 uploader for focus and blur events .
[14:57:43 CST(-0600)] <mlam> http://issues.fluidproject.org/browse/FLUID-3777
[14:57:47 CST(-0600)] <colinclark> thanks, mlam
[14:57:51 CST(-0600)] <mlam> np
[14:57:58 CST(-0600)] <heidi> colinclakr if i upload a file, then add more and upload those, the status doesn't update to say they're uploaded
[14:58:02 CST(-0600)] <colinclark> Does it pass everywhere, or do we have to make a fix?
[14:58:03 CST(-0600)] <heidi> *colinclark
[14:58:13 CST(-0600)] <heidi> it still says To upload: 2 files (11.4 KB)
[14:58:17 CST(-0600)] <colinclark> heidi: Can you file a JIRA and include a screenshot?
[14:58:22 CST(-0600)] <heidi> yep
[14:58:25 CST(-0600)] <colinclark> and then bounce it to mlam to take a look?
[14:58:26 CST(-0600)] <colinclark> thanks so much
[14:58:28 CST(-0600)] <heidi> np
[14:58:29 CST(-0600)] <michelled> heidi: did you test your patch with a screen reader?
[14:58:36 CST(-0600)] <heidi> michelled yep
[14:58:45 CST(-0600)] <michelled> cool - I'm about to commit it
[14:58:48 CST(-0600)] <heidi> thanks!
[15:00:02 CST(-0600)] <michelled> heidi: I'm happy with the code change - if you were happy with the screen reader experience can you close the JIRA?
[15:00:41 CST(-0600)] <heidi> michelled you bet
[15:03:29 CST(-0600)] <mlam> heidi: is the uploader even working in FF for you?
[15:03:51 CST(-0600)] <heidi> mlam ya - you?
[15:03:55 CST(-0600)] <anastasiac> michelled, heidi: the latest commit to Pager.js includes a string ":true" added to the global def of fluid_1_2 in the header - what is that for??
[15:04:23 CST(-0600)] <heidi> i'm not sure - was that mine or something else?
[15:04:56 CST(-0600)] <heidi> i don't have it locally
[15:04:58 CST(-0600)] <anastasiac> it was in the most recent commit, which michelled committed, apparently from your patch for 3828
[15:05:32 CST(-0600)] <heidi> not in patch either
[15:06:50 CST(-0600)] <anastasiac> heidi, I checked with michelled: apparently it's a jslint thing. interesting
[15:09:42 CST(-0600)] <mlam> heidi: do you see an error with IE8?
[15:11:26 CST(-0600)] <anastasiac> Justin_o, harriswong: I've committed the patch to FLUID-3888 (version numbers) and resolved the JIRA
[15:11:43 CST(-0600)] <heidi> mlam i can't click the browse button - you?
[15:12:01 CST(-0600)] <mlam> no i can't
[15:12:01 CST(-0600)] <harriswong> anastasiac: great, thanks/
[15:12:15 CST(-0600)] <mlam> on the bottom left corner of the browser, do you see an error?
[15:12:36 CST(-0600)] <heidi> mlam no error. so browse button does or doesn't work for you?
[15:12:42 CST(-0600)] <mlam> it doesn't
[15:12:49 CST(-0600)] <heidi> k
[15:12:53 CST(-0600)] <Justin_o> anastasiac: thanks... harriswong also had one for the dependencies.. what was the issue number for that again harriswong
[15:13:04 CST(-0600)] <heidi> mlam maybe some flash file didn't get committed or ?
[15:14:11 CST(-0600)] <mlam> Not sure, i'm going to look into it
[15:14:12 CST(-0600)] <harriswong> Justin_o, anastasiac: i think you are referring to http://issues.fluidproject.org/browse/FLUID-3775?
[15:15:42 CST(-0600)] <heidi> mlam i also just made a jira for uploader: http://issues.fluidproject.org/browse/FLUID-3889
[15:15:49 CST(-0600)] <michelled> anastasiac, heidi: it gets rid of the jslint complaint about that line being read only. It's something that kasper showed me today. I need to still find the docs for it to know what it really means
[15:16:17 CST(-0600)] <heidi> strange!
[15:17:39 CST(-0600)] <heidi> mlam actually i need to update that jira - status doesn't update at all
[15:18:00 CST(-0600)] <anastasiac> Justin_o, harriswong: I'll review the patch on 3775
[15:18:32 CST(-0600)] <mlam> yah, i see it now.
[15:18:33 CST(-0600)] <mlam> thanks
[15:18:47 CST(-0600)] <heidi> mlam jira updated
[15:19:00 CST(-0600)] <heidi> mlam is the focus patch ready? i can test it
[15:19:14 CST(-0600)] <mlam> yah, it's ready
[15:19:21 CST(-0600)] <mlam> they're just additional tests for the html5 uploader
[15:20:27 CST(-0600)] <harriswong> Justin_o: I am updating inline edit qa test plan - simple text now
[15:23:19 CST(-0600)] <heidi> mlam is there a jira where the patch is or was it a direct commit
[15:23:58 CST(-0600)] <mlam> under the general unit test coverage JIRA. FLUID-3777
[15:25:52 CST(-0600)] <heidi> mlam i mean the fix for the focus staying on 'add more' do you?
[15:26:06 CST(-0600)] <mlam> oh that one...no, i haven't fixed that yet
[15:26:09 CST(-0600)] <heidi> okee
[15:26:13 CST(-0600)] <heidi> should i make a jira for it?
[15:26:50 CST(-0600)] <mlam> yes please
[15:28:56 CST(-0600)] <heidi> k
[15:33:14 CST(-0600)] <heidi> mlam http://issues.fluidproject.org/browse/FLUID-3890
[15:33:25 CST(-0600)] <heidi> i can make a jira for IE8 but i think yr on that now
[15:35:11 CST(-0600)] <Justin_o> Bosmon2: did you want to review my tooltip wrapper patch?
[15:35:46 CST(-0600)] <Justin_o> http://issues.fluidproject.org/browse/FLUID-3831
[15:36:37 CST(-0600)] <Bosmon2> Thanks, I will look at it now
[15:36:48 CST(-0600)] <Justin_o> Bosmon2: thanks
[15:36:57 CST(-0600)] <Justin_o> hope it is at least somewhat reasonable...
[15:51:20 CST(-0600)] <heidi> mlam here is the ie8 jira: http://issues.fluidproject.org/browse/FLUID-3891
[15:54:22 CST(-0600)] <mlam> ok, thanks
[16:13:04 CST(-0600)] <anastasiac> Justin_o, harriswong: I'm testing 3775, the updates of the dependencies. I tried building the infusionAll version of the package, and somethings definitely not right
[16:13:39 CST(-0600)] <anastasiac> InfusionAll is missing swf stuff, which might not be an issue since colinclark will likely fix that, but the demos don't seem to be finding the function they're demoing
[16:13:52 CST(-0600)] <colinclark> anastasiac: Really?
[16:14:07 CST(-0600)] <colinclark> I had updated the dependencies file for Uploader last night
[16:14:10 CST(-0600)] <colinclark> did I miss some things?
[16:14:19 CST(-0600)] <anastasiac> well, maybe not - it might be something in the patch
[16:15:13 CST(-0600)] <Justin_o> harriswong: do you remember changing any of the dependencies for uploader?
[16:15:27 CST(-0600)] <harriswong> anastasiac: the 3775 patch removed only the FSS dependencies.
[16:15:42 CST(-0600)] <harriswong> justin_o: yes, the only thing i changed is jsonLinted that file.
[16:15:57 CST(-0600)] <anastasiac> I'm testing the InfusionAll.js version (after the header-rewriting) and I'm getting errors like "fluid.inlineEdit is not a function" and "fluid.progress is not a function"
[16:16:14 CST(-0600)] <anastasiac> hm... so this might be a long-standing issue... I'll have to re-test without the patch
[16:16:42 CST(-0600)] <Justin_o> anastasiac: any chance that you had a conflict somewhere or something?
[16:16:45 CST(-0600)] <harriswong> justin_o, anastasiac: if the 3775 breaks it, i think it is most likely related to the removal of the fss in the build.properties?
[16:17:22 CST(-0600)] <anastasiac> Justin_o, no - no conflicts. I'll re-test without the patch, just in case this was something that was already there and we just didn't know
[16:18:02 CST(-0600)] <harriswong> anastasiac, justin_o: one thing to note is i did remove jQuerybgiframePlugin from Pager because i believe that plugin is no longer in use for pager.
[16:18:21 CST(-0600)] <anastasiac> that shouldn't be causing this problem...
[16:21:05 CST(-0600)] <Bosmon2> Sounds like something about the code is causing it to be built into a syntactically incorrect file
[16:23:14 CST(-0600)] <anastasiac> ok, Justin_o and harriswong: I just re-tested on a clean checkout, and the same problem is there, so it's not harriswong's patch
[16:23:33 CST(-0600)] <anastasiac> I don't know what it is...
[16:23:48 CST(-0600)] <Bosmon2> How badly minified is InfusionAll.js
[16:23:52 CST(-0600)] <Bosmon2> It's just concatted, right?
[16:24:03 CST(-0600)] <Bosmon2> What happens if you load it up in Eclipse... does it find syntax errors?
[16:24:23 CST(-0600)] <anastasiac> Bosmon2, I don't know - we generate both a "source" version that's only concatenated, and a version that's also minified
[16:24:34 CST(-0600)] <Bosmon2> Well, which one is broken
[16:25:24 CST(-0600)] <anastasiac> both
[16:26:27 CST(-0600)] <anastasiac> the InfusionAll.js file seems ok at first glance
[16:31:50 CST(-0600)] <anastasiac> more tomorrow...
[16:36:06 CST(-0600)] <harriswong> not sure if this will help, but these are the files missing in the trunk compared to 1.2
[16:36:07 CST(-0600)] <harriswong>     [82] => src\webapp\components\uploader\js\SWFUploadManager.js
[16:36:07 CST(-0600)] <harriswong>     [502] => src\webapp\lib\jquery\plugins\delegate\jQueryDelegatePluginDependencies.json
[16:36:07 CST(-0600)] <harriswong>     [503] => src\webapp\lib\jquery\plugins\delegate\js\jquery.delegate.js
[16:36:07 CST(-0600)] <harriswong>     [506] => src\webapp\lib\jquery\plugins\tooltip\js\jquery.tooltip.js
[16:36:07 CST(-0600)] <harriswong>     [688] => src\webapp\tests\framework-tests\core\html\keyboard-a11y-tests.html
[16:40:00 CST(-0600)] <Bosmon2> That's all fine
[16:40:38 CST(-0600)] <Bosmon2> Quick check, fluid-everyone - what's the correct copyright attribution for the head of a new file?
[16:42:49 CST(-0600)] <Justin_o> Bosmon2: for us here at ocad it is OCAD University
[16:43:59 CST(-0600)] <colinclark> Bosmon2: For you, it's whoever is paying you as specified in your contract
[16:44:24 CST(-0600)] <colinclark> But obviously we want to leave any previous attributions for our various former employers and partners
[16:51:03 CST(-0600)] <mlam> colinclark: patch posted for FLUID-3889
[16:51:41 CST(-0600)] <colinclark> awesome
[16:51:43 CST(-0600)] <colinclark> i'll commit it
[16:51:53 CST(-0600)] <mlam> ok, thanks
[16:52:21 CST(-0600)] <colinclark> mlam: Any idea how this regression could have happened?
[16:52:29 CST(-0600)] <colinclark> How could it have worked before and not now?
[16:52:41 CST(-0600)] <mlam> I think a couple lines of code went missing
[16:52:56 CST(-0600)] <colinclark> can you find out when?
[16:52:59 CST(-0600)] <mlam> sure
[16:53:01 CST(-0600)] <colinclark> thanks
[16:53:16 CST(-0600)] <colinclark> that scares the hell out of me
[16:54:01 CST(-0600)] <mlam> also, the JIRA that heidi posted today FLUID-3890 can't be reproduced any more....
[16:59:09 CST(-0600)] <colinclark> that's good news (smile)

  • No labels