Skip to end of metadata
Go to start of metadata

You are viewing an old version of this page. View the current version.

Compare with Current View Page History

« Previous Version 21 Next »

[03:05:48 EST(-0500)] * andreauoc (~carlos@120.Red-213-96-26.staticIP.rima-tde.net) has joined #fluid-work
[04:59:10 EST(-0500)] * sveto (~sveto@62.44.108.2) has joined #fluid-work
[08:25:07 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[08:29:43 EST(-0500)] * andreauoc (~carlos@120.Red-213-96-26.staticIP.rima-tde.net) has left #fluid-work
[09:12:15 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[09:44:32 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[09:45:07 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[09:49:29 EST(-0500)] * anastasiac (~team@142.150.154.189) has joined #fluid-work
[09:56:45 EST(-0500)] * clown (~clown@142.150.154.101) has joined #fluid-work
[10:01:48 EST(-0500)] <anastasiac> Bosmon, Bosmon2: are you there?
[10:19:17 EST(-0500)] * laurel (~Laurel@142.150.154.178) has joined #fluid-work
[10:19:34 EST(-0500)] * laurel (~Laurel@142.150.154.178) has left #fluid-work
[10:30:47 EST(-0500)] * sveto (~sveto@62.44.108.2) has left #fluid-work
[10:58:10 EST(-0500)] * EricDalquist (~dalquist@2607:f388:e:0:221:9bff:fe37:e768) has joined #fluid-work
[11:26:25 EST(-0500)] * elicochran (~elicochra@70.137.137.123) has joined #fluid-work
[12:57:55 EST(-0500)] * colinclark (~colin@142.150.154.101) has joined #fluid-work
[13:41:58 EST(-0500)] * colinclark (~colin@142.150.154.101) has joined #fluid-work
[14:11:57 EST(-0500)] <anastasiac> Bosmon, Bosmon2: are you there?
[14:13:03 EST(-0500)] <Bosmon> Yes, I am here
[14:13:21 EST(-0500)] <anastasiac> Bosmon, your recent changes to fluid.model.setBeanValue() have caused my code to fail, but I'm not sure if it's a bug in getPenultimate() or if I'm using setBeanValue() wrong
[14:13:32 EST(-0500)] <Bosmon> Ok, that is interesting
[14:13:33 EST(-0500)] <anastasiac> I'm essentially doing this:
[14:13:47 EST(-0500)] <Bosmon> There may be some edge cases that behave differently that have fallen between the cracks in the tests
[14:13:51 EST(-0500)] <anastasiac> fluid.model.setBeanValue ({}, "fields.title", "new title");
[14:13:58 EST(-0500)] <Bosmon> Ah ok
[14:14:08 EST(-0500)] <Bosmon> That case should work, let me make a test case and fix it
[14:14:12 EST(-0500)] <anastasiac> thanks!
[14:15:05 EST(-0500)] <Bosmon> If you made a JIRA, it would be even more tasty (tongue)
[14:15:26 EST(-0500)] <anastasiac> will do
[14:15:29 EST(-0500)] <Bosmon> tnx
[14:15:38 EST(-0500)] <anastasiac> I just wanted to confirm that it wasn't my bug first (smile)
[14:16:03 EST(-0500)] <Bosmon> Well, the behaviour on "blank paths" was never really specified
[14:16:22 EST(-0500)] <Bosmon> But there was actually a test case for the renderer that exposed exactly the same issue last night with getBeanValue() that I fixed up...
[14:17:34 EST(-0500)] <Bosmon> I mean, to be honest, it is not absolutely clear what kind of new object should be created... I guess if setBeanValue were really clever it would do things like looking if the upcoming path were a numeric index, and then try to guess that you were trying to make an array
[14:17:40 EST(-0500)] <Bosmon> But that would probably be going too far
[14:19:51 EST(-0500)] <anastasiac> well, it worked before... I guess the question is: should setBeanValue() be responsible for creating the necessary hierarchy?
[14:19:54 EST(-0500)] <anastasiac> fyi: http://issues.fluidproject.org/browse/FLUID-3489
[14:20:08 EST(-0500)] <Bosmon> Well, I guess it "should"
[14:20:22 EST(-0500)] <Bosmon> That had been the "semi-inadvertently" implemented behaviour so far
[14:20:32 EST(-0500)] <Bosmon> (smile)
[14:20:37 EST(-0500)] <anastasiac> (smile)
[14:21:21 EST(-0500)] <Bosmon> Thanks for the JIRA
[14:22:04 EST(-0500)] * colinclark (~colin@142.150.154.101) has joined #fluid-work
[17:21:37 EST(-0500)] * clown_afk (~clown@142.150.154.101) has left #fluid-work
[17:42:50 EST(-0500)] * anastasiac (~team@142.150.154.189) has left #fluid-work

  • No labels