/
fluid-work IRC Logs-2013-11-15

fluid-work IRC Logs-2013-11-15

Nov 15, 2013

[07:10:34 CST(-0600)] <Bosmon7> Hi there Justin_o

[07:10:37 CST(-0600)] <Bosmon7> Are you there?

[07:12:36 CST(-0600)] <Justin_o> Bosmon7: hello.. i'm here

[07:12:40 CST(-0600)] <Bosmon7> cool

[07:12:41 CST(-0600)] <Justin_o> i was just going to ping you (smile)

[07:12:58 CST(-0600)] <Bosmon7> I am just off travelling in a bit but I will be around later in the day again

[07:13:17 CST(-0600)] <Bosmon7> But I wanted to point towards a futher possibility for working around your model listener priority issue

[07:13:33 CST(-0600)] <Bosmon7> It appears that a combination of the techniques we tried yesterday might be effective

[07:13:49 CST(-0600)] <Justin_o> Bosmon7: i'm still trying to sort through that issue i was talking to you about yesterday.. unfortunately the plan we had discussed yesterday didn't work because they were still firing ahead of time. I've found that if i individually bind listeners to onCreate to addListeners for each model path, they fire at the correct time.. but i'm running into a very

[07:13:49 CST(-0600)] <Justin_o> strange issue that is preventing it from working still.

[07:13:57 CST(-0600)] <Justin_o> oh okay.... maybe that will be better then

[07:14:21 CST(-0600)] <Bosmon7> In particular, if you use the old-style, non-declarative scheme for attaching model listeners, there is a place in the record where you can enter a "priority" annotation and have it honoured

[07:14:23 CST(-0600)] <Bosmon7> https://github.com/fluid-project/infusion/blob/master/src/tests/framework-tests/core/js/DataBindingTests.js#L345-L346

[07:14:45 CST(-0600)] <Bosmon7> In these lines in the data binding test, you can see that the first argument to ChangeApplier's addListener can accept a record in addition to just a path

[07:14:50 CST(-0600)] <Bosmon7> I mean, in place of just a path

[07:15:05 CST(-0600)] <Bosmon7> And in this record there is a "priority" field that will be passed through to the underlying firer

[07:16:13 CST(-0600)] <Bosmon7> Although this example shows an addition to "guards", the same is also true of "modelChanged"

[07:16:35 CST(-0600)] <Justin_o> Bosmon7: oh great.. thanks for digging that out.. i'll give that a shot.

[07:16:56 CST(-0600)] <Justin_o> Bosmon7: from the look of it, it should solve the problem..

[07:23:47 CST(-0600)] <Justin_o> Bosmon7: thanks so much.. looks like that worked

[07:25:10 CST(-0600)] <Bosmon7> Justin_o - great - we survive that attempt on our life : P

[07:25:29 CST(-0600)] <Bosmon7> I'll try to hurry up the work on the new ChangeApplier now that it seems we are running into these problems urgently....

[07:27:12 CST(-0600)] <Justin_o> Bosmon7: (smile) thanks... i am looking forward to the new framework features and a new renderer (smile) but i guess that ones still a long ways off

[07:28:06 CST(-0600)] <Bosmon7> We should hopefully have something a bit like a new renderer in the spring...

[07:28:22 CST(-0600)] <Bosmon7> I imagine that, like the model relay system, the old and new implementations will coexist for a while

[07:28:49 CST(-0600)] <Bosmon7> When my work is merged in, we will have access to both the old ChangeApplier and the new one under different grade names, so that we can migrate our work over gradually

[07:28:54 CST(-0600)] <Justin_o> makes sense.. so we can migrate over time

[07:29:14 CST(-0600)] <Justin_o> that seems very practical

[07:30:09 CST(-0600)] <Justin_o> Bosmon7: i was talking to michelled a bit the other day about deprecation.. in particular in regards to things that we have marked for deprecation but don't yet have replacements for..

[07:32:15 CST(-0600)] <Justin_o> we were thinking of marking those things are to be replaced in 2.0 or something like that

[07:32:30 CST(-0600)] <Justin_o> anastasiac: i think you also brought this concern up a while back too

[08:00:11 CST(-0600)] <Justin_o> Bosmon7: looks like i was too hasty and misread the test.. it's still not working (sad)

[10:15:14 CST(-0600)] <Justin_o> Bosmon7: i tried this many different ways, but nothing seems to work. I even resorted to using a single onCreate event which would trigger the creation of a single listener to any model change event and had a handler function that would then determine which path was fired. This was attached directly to the composite panel without using dynamic grades and it

[10:15:14 CST(-0600)] <Justin_o> still fired too early. So it seems that my earlier hypothesis that these types of events would fire at the appropriate time was wrong. There also might be an issue with binding multiple change applier events with addListener from a dynamic grade, but it could also have been related to other things i was testing at the time. At any rate none of these worked,

[10:15:14 CST(-0600)] <Justin_o> even when setting the priority as you suggested today.

[10:17:23 CST(-0600)] <Justin_o> Bosmon7: I was able to fix the issue though.. it turned out to be relative easy in comparison. I changed the tree rebasing to source values for value fields, associated with valuebinding, from the composite panels model instead. I don't know if this would have an issue with valuebinding source from an IoC reference though.. so this may not be foolproof

[10:33:43 CST(-0600)] <anastasiac> yzen, cindyli, michelled: stand-up?

[10:33:58 CST(-0600)] <cindyli> yes

[11:32:16 CST(-0600)] <Justin_o> cindyli: did you happen to figure out anything new with the issue you have related to FLUID-5210

[11:35:47 CST(-0600)] <cindyli> Justin_o: do you mean the problem with rendering more than one adjusters in pmt? chris sent me a pull request this morning and it fixed that problem. seems it was 'cuz those adjuster containers are in a hidden div.

[11:36:18 CST(-0600)] <Justin_o> cindyli: hmm.. strange okay.. but we should be careful about it coming up again i guess

[11:36:38 CST(-0600)] <Justin_o> cindyli: what was the problem with them being in a hidden div?

[11:36:41 CST(-0600)] <cindyli> certainly

[11:37:54 CST(-0600)] <cindyli> Justin_o: when more than one adjusters were to be rendered in the hidden div, the whole markup would somehow be wiped out, which leads to an unfound adjuster container

[11:38:16 CST(-0600)] <cindyli> i'm still puzzled why one can be rendered fine but not more than one

[11:38:17 CST(-0600)] <Justin_o> cindyli: any idea why there being hidden is part of the issue?

[11:38:47 CST(-0600)] <cindyli> no idea yet (sad)

[11:40:46 CST(-0600)] <Justin_o> hmm.. okay.. thanks

[11:40:53 CST(-0600)] <Justin_o> cindyli: ^

[11:41:17 CST(-0600)] <cindyli> np

[11:42:48 CST(-0600)] <cindyli> Justin_o: chris found another issue that the additional options defined in the aux schema for subpanels are not passed down by the aux builder. i will send a pull request for this. when are you leaving for today? wonder if you have time to review that pull

[11:43:15 CST(-0600)] <Justin_o> cindyli: i'll probably be leaving around 2pm

[11:44:15 CST(-0600)] <cindyli> ah, ok. thanks, Justin_o (smile)

[12:09:48 CST(-0600)] <cindyli> Justin_o: i sent a pull request https://github.com/fluid-project/infusion/pull/435 for the issue with passing down the additional options for subpanels. can you take a look when you have time?

[12:10:10 CST(-0600)] <Justin_o> cindyli: sure, will take a look

[12:10:16 CST(-0600)] <cindyli> thanks, Justin_o

[12:32:44 CST(-0600)] <cindyli> Justin_o, michelled, shall we touch base again before Justin_o leaves to update our to do list and timeline?

[12:33:48 CST(-0600)] <Justin_o> cindyli: let me know if you would like to talk now

[12:34:12 CST(-0600)] <cindyli> let's do it, Justin_o. skype?

[12:46:31 CST(-0600)] <michelled> Justin_o, cindyli: I can join now

[12:46:33 CST(-0600)] <cindyli> Justin_o: this is the commit that fixes the issue with rendering multiple subpanels in a composite: https://github.com/cindyli/prefsEditors/commit/caaf170443fc4d0925cfb505a6334dd9119f8192

[12:46:56 CST(-0600)] <Justin_o> cindyli: thanks.. i'll take a look at it

[12:47:07 CST(-0600)] <cindyli> np, Justin_o

[12:47:25 CST(-0600)] <cindyli> michelled: we've finished and hang up

[12:47:42 CST(-0600)] <michelled> ok, can you cc me on the mail you send colin?

[12:47:51 CST(-0600)] <cindyli> sure, michelled

[12:54:45 CST(-0600)] <cindyli> Justin_o: what's the branch name that has the new adjusters and we need to eventually merged in our 153-187 branch?

[12:56:18 CST(-0600)] <Justin_o> cindyli: i'm not sure.. i'll take a look..

[12:56:33 CST(-0600)] <cindyli> thanks

[12:56:44 CST(-0600)] <Justin_o> cindyli: i'm getting errors in the auxbuilder tests and the builder tests when i try to merge in master into my FLUID-5205 branch..

[12:56:51 CST(-0600)] <Justin_o> cindyli: do you think you could help me take a look at that

[12:56:52 CST(-0600)] <Justin_o> ?

[12:57:03 CST(-0600)] <cindyli> sure, in 5205 branch?

[12:57:14 CST(-0600)] <cindyli> before or after merging in the master? Justin_o

[12:57:46 CST(-0600)] <Justin_o> after merging in master.. what's in my branch right now should be okay

[12:58:19 CST(-0600)] <Justin_o> cindyli: as for the branches we need to merge for chris and alex, i'm not sure.. we'll have to ask them i think.. there are no new pull requests that i can see

[12:58:39 CST(-0600)] <cindyli> ok, thanks, Justin_o

[13:05:03 CST(-0600)] <cindyli> Justin_o: those tests are passing now. pushed to my 5205 branch

[13:05:22 CST(-0600)] <Justin_o> cindyli: all preferences framework tests are passing?

[13:05:35 CST(-0600)] <cindyli> yes, all passing

[13:05:41 CST(-0600)] <Justin_o> cindyli: thanks.. what was the problem?

[13:06:28 CST(-0600)] <cindyli> Justin_o: might be caused by a variable name change which needs to pay attention at resolving conflicts

[13:06:47 CST(-0600)] <Justin_o> cindyli: ah okay.. that makes sense

[13:06:50 CST(-0600)] <Justin_o> thanks for fixing that up

[13:07:00 CST(-0600)] <cindyli> np

[13:08:05 CST(-0600)] <Justin_o> okay.. it's up in the pull request now

[13:08:38 CST(-0600)] <Justin_o> anastasiac, Bosmon7: can you please take a look at the FLUID-5205 pull request again.. it should be ready to go for another round of review

[13:09:10 CST(-0600)] <anastasiac> thanks, Justin_o, I'll have another go at it. I'm sure I can find a problem (wink)

[13:10:11 CST(-0600)] <Justin_o> anastasiac: hopefully they won't be blockers this time (smile)

[13:11:09 CST(-0600)] <Justin_o> i'm heading offline now.. have a good weekend everyone

[13:14:44 CST(-0600)] <anastasiac> looks good so far, Justin_o, nice work. Have a great weekend!

[16:02:15 CST(-0600)] <jwennmacher1> Sorry if this has been answered before. Is there a target for an Infusion 1.5 release? I couldn't find anything on the confluence site or from searches.