fluid-work IRC Logs-2013-10-18

[10:57:42 CDT(-0500)] <anastasiac> Justin_o, I think there's a bug with the UI Options component dependencies. The JS file is not being included in the bundle - I think it's because the build scripts assume the JS files are in a js subfolder

[10:58:32 CDT(-0500)] <Justin_o> anastasiac: thanks, could you file a jira for that?

[10:58:39 CDT(-0500)] <anastasiac> in process

[11:00:26 CDT(-0500)] <anastasiac> Justin_o: http://issues.fluidproject.org/browse/FLUID-5183 Adding to iteration page...

[11:20:27 CDT(-0500)] <Justin_o> anastasiac: thanks

[12:30:42 CDT(-0500)] <Justin_o> michelled: could you please take a look at my pull request for FLUID-5183 https://github.com/fluid-project/infusion/pull/420

[12:31:26 CDT(-0500)] <Justin_o> Bosmon: can you please take a look at my pull request for FLUID-5180 https://github.com/fluid-project/infusion/pull/419

[12:34:26 CDT(-0500)] <Bosmon> Hi Justin_o - your 5180 looks good

[12:35:35 CDT(-0500)] <Bosmon> Could you update it for my comments on your 5184? : P

[12:36:34 CDT(-0500)] <Bosmon> Your "stringLookup" grade is duplicated in two different files

[12:36:54 CDT(-0500)] <Bosmon> No, actually it is duplicated within the same file

[12:43:52 CDT(-0500)] <Justin_o> Bosmon: okay.. looking at your comment on FLUID-5184. Doesn't that force a user to know the details of the implementation

[12:43:55 CDT(-0500)] <Justin_o> ?

[12:44:09 CDT(-0500)] <Bosmon> Justin_o - you always have to know the details of the implementation if you are overriding...

[12:44:20 CDT(-0500)] <Bosmon> How would you know what to write otherwise? : P

[12:46:24 CDT(-0500)] <Justin_o> Bosmon: the method names are pretty easy to find

[12:46:38 CDT(-0500)] <Bosmon> Justin_o - so is the configuration attached to them

[12:46:55 CDT(-0500)] <Justin_o> i guess that's true.. it's still in the options

[12:47:21 CDT(-0500)] <Bosmon> It is the purpose of the configuration to be transparent ...

[12:56:17 CDT(-0500)] <Justin_o> Bosmon: okay, i've made those changes.. sorry about that duplicate object too.. guess i forgot to clean that up.

[14:27:48 CDT(-0500)] <Justin_o> Bosmon: when you get a chance could you please review my changes to the FLUID-5180 pull request.