fluid-work IRC Logs-2013-10-09

Owned by Fluid IRC Log Bot
Last updated: Oct 09, 2013
3 min read

[09:13:21 CDT(-0500)] <Justin_o> michelled: could you please review the latest changes for FLUID-5161 https://github.com/fluid-project/infusion/pull/415

[09:13:36 CDT(-0500)] <michelled> sure Justin_o

[09:13:52 CDT(-0500)] <Justin_o> michelled, yzen: if either of you have time, can you take a look at my pull request for the modulefiles grunt plugin too https://github.com/fluid-project/grunt-modulefiles/pull/2

[09:13:56 CDT(-0500)] <Justin_o> michelled: thanks

[09:15:35 CDT(-0500)] <Justin_o> colinclark, jessm: do you think we will have time before the next release for one of the designers to make new icon font based icons for the demo portal http://build.fluidproject.org/infusion/demos/

[09:16:02 CDT(-0500)] <colinclark> What's the benefit, Justin_o?

[09:17:51 CDT(-0500)] <Justin_o> 1) it will help us get rid of a few more images from our repo 2) we are missing an icon anyways so it might be a good time to change them all and not just make a new image based one 3) if we put a prefs editor on the page it will be able to adjust them..

[09:18:15 CDT(-0500)] <Justin_o> colinclark: ^ see above.. not immediately necessary for sure, but if we have time it would be nice

[09:19:03 CDT(-0500)] <colinclark> ok

[09:42:07 CDT(-0500)] <Justin_o> michelled: I have another pull request... this one is to update the build site after the changes for FLUID-5161 get into master. https://github.com/fluid-project/build.fluidproject.org/pull/5

[13:26:04 CDT(-0500)] <Justin_o> fluid-everyone: would anyone like to join the community meeting today remotely.. the topic will be "New Model Infrastructure" lead by Bosmon

[13:26:15 CDT(-0500)] <colinclark> I'll join, yes

[13:26:45 CDT(-0500)] <Justin_o> colinclark: okay.. thanks.. i'll skype you in

[13:27:09 CDT(-0500)] <Bosmon> Hi

[13:27:50 CDT(-0500)] <Bosmon> fluid-everyone: I have prepared some "useful notes" on the new infrastructure which would be useful reading before/during the meeting: http://wiki.fluidproject.org/display/fluid/New+Notes+on+the+ChangeApplier

[13:28:10 CDT(-0500)] <Bosmon> Please give me a few minutes because I will not be ready immediately

[13:28:18 CDT(-0500)] <colinclark> (smile)

[13:28:21 CDT(-0500)] <Justin_o> Bosmon: okay.. let me know when you'll be ready

[13:54:05 CDT(-0500)] <Bosmon> Justin_o - ok, finally ready now!

[13:54:07 CDT(-0500)] <Bosmon> Sorry for the delay

[13:55:04 CDT(-0500)] <Justin_o> Bosmon: no problem. ready to go?

[14:22:48 CDT(-0500)] <Justin_o> http://pastie.org/8390271

[14:41:46 CDT(-0500)] <Justin_o> https://github.com/fluid-project/infusion/blob/master/src/components/pager/js/Pager.js#L355-L394

[14:53:25 CDT(-0500)] <Justin_o> rough sketches http://pastie.org/8390338

[15:10:44 CDT(-0500)] <Justin_o> Bosmon: here's my current work for FLUID-5131 https://github.com/jobara/infusion/tree/FLUID-5131

[15:11:37 CDT(-0500)] <Bosmon> Thanks, Justin_o

[15:14:56 CDT(-0500)] <Bosmon> I think that your "fluid.prefs.compositePanel.rebaseTree" even still represents some overkill : P

[15:15:13 CDT(-0500)] <Bosmon> Do you actually expect anything to appear in the "modelRelayRules" field?

[15:15:40 CDT(-0500)] <Bosmon> I guess it does

[15:16:02 CDT(-0500)] <Justin_o> yes.. it corresponds to the model relay used between the subPanels and parent

[15:16:16 CDT(-0500)] <Justin_o> so that we know what to change the valuebinding to

[15:16:32 CDT(-0500)] <Bosmon> Yes

[15:16:41 CDT(-0500)] <Bosmon> I think there is not really a need to use the model transformation system here

[15:16:44 CDT(-0500)] <Bosmon> As we discussed

[15:16:48 CDT(-0500)] <Bosmon> "Some functions" will be just fine : P

[15:17:13 CDT(-0500)] <Justin_o> Bosmon: is it worth changing?

[15:17:29 CDT(-0500)] <Bosmon> Well, it would save you a dozen lines or so (smile)

[15:18:10 CDT(-0500)] <Justin_o> (smile) okay i'll look into that

[15:18:29 CDT(-0500)] <Justin_o> Bosmon: i'm heading out now.. if you have more feedback please send it along and I'll start in on it tomorrow

[15:18:38 CDT(-0500)] <Bosmon> I think your other code looks pretty good

[15:18:47 CDT(-0500)] <Bosmon> I'd like to see this regex surfaced as a dedicated function

[15:18:48 CDT(-0500)] <Bosmon> prefObj[mdlPrefix + prefName.replace(/[.]/g, "_")] = rule;

[15:19:14 CDT(-0500)] <Bosmon> Especially since it seems you do a similar operation earlier in the code

[15:20:09 CDT(-0500)] <Justin_o> Bosmon: right i should clean that up