fluid-work IRC Logs-2013-10-04

[07:59:33 CDT(-0500)] <Justin_o> cindyli: do you know why this was resolved? was there a fix that got merged in somewhere? http://issues.fluidproject.org/browse/FLUID-5116

[08:01:04 CDT(-0500)] <cindyli> Justin_o: yes, i fixed it and Bosmon merged the pull into the master. let me find out the commit#

[08:02:44 CDT(-0500)] <cindyli> Justin_o: https://github.com/fluid-project/infusion/commit/50b253a3e004c598ae7389e5d3b12fe53e679351

[08:07:06 CDT(-0500)] <Justin_o> cindyli: thanks do you know if this one is also done.. the comment at the end is a bit ambigous

[08:07:07 CDT(-0500)] <Justin_o> http://issues.fluidproject.org/browse/FLUID-5010

[08:07:57 CDT(-0500)] <cindyli> Justin_o: yes, it's fixed too

[08:08:19 CDT(-0500)] <Justin_o> cindyli: thanks

[08:08:25 CDT(-0500)] <cindyli> np

[08:14:55 CDT(-0500)] <cindyli> Justin_o: do you want me to start on uio renaming?

[08:17:54 CDT(-0500)] <Justin_o> cindyli: sure thanks.. let me know if there's a way we can split that up at all

[08:18:37 CDT(-0500)] <cindyli> sure

[08:35:41 CDT(-0500)] <Justin_o> anastasiac: can you test something for me..

[08:35:48 CDT(-0500)] <anastasiac> sure

[08:35:54 CDT(-0500)] <Justin_o> anastasiac: can you verify that text size doesn't work in the panel on the build site

[08:35:54 CDT(-0500)] <Justin_o> http://build.fluidproject.org/infusion/demos/uiOptions/gradesDemo/html/uiOptions.html

[08:36:24 CDT(-0500)] <anastasiac> works for me in FF, Justin_o

[08:36:52 CDT(-0500)] <anastasiac> works for me in Chrome, too

[08:37:25 CDT(-0500)] <Justin_o> anastasiac: i guess it's just me then, which i guess is a good thing.. thanks for testing

[09:09:16 CDT(-0500)] <Justin_o> anastasiac: do you know if this can be closed? do we still suggest the use of jQuery UI dialogs? http://issues.fluidproject.org/browse/FLUID-3744

[09:10:54 CDT(-0500)] <anastasiac> Justin_o, as far as I can tell, nothing in the current docs mentions jQuery dialogs, so I think that issue can be closed

[09:16:07 CDT(-0500)] <Justin_o> anastasiac: thanks

[09:17:24 CDT(-0500)] <cindyli> anastasiac, Justin_o, how do you think we should rename FatPanelUIOptions.html? to SeparatedPanelPrefsEditor.html?

[09:17:44 CDT(-0500)] * anastasiac ponders

[09:17:49 CDT(-0500)] <Justin_o> cindyli: long but i guess so

[09:18:00 CDT(-0500)] <Justin_o> or SeparatedPanel.htmkl

[09:18:02 CDT(-0500)] <Justin_o> html

[09:18:29 CDT(-0500)] <cindyli> sounds good. thanks

[09:18:33 CDT(-0500)] <anastasiac> I don't mind the long name, myself

[09:18:43 CDT(-0500)] <Justin_o> anastasiac: do you know what this means? http://issues.fluidproject.org/browse/FLUID-3740

[09:18:49 CDT(-0500)] <anastasiac> SeparatedPanel might be confused w Panels in general

[09:18:59 CDT(-0500)] <Justin_o> anastasiac: that's true

[09:19:36 CDT(-0500)] <anastasiac> Justni_o, that issue sounds like it was completed long ago

[09:19:55 CDT(-0500)] <Justin_o> anastasiac: thanks.. i'll close it

[09:19:58 CDT(-0500)] <anastasiac> I vote for the longer name, cindyli and Justin_o, to avoid confusion with prefs panels

[09:20:38 CDT(-0500)] <anastasiac> Justin_o, if you look at that issue's parent issue, you might find some other things we can close

[09:20:58 CDT(-0500)] <anastasiac> i.e. all of them!!

[09:21:45 CDT(-0500)] <cindyli> anastasiac, Justin_o, i'm fine with the longer name, my only concern is it could be even longer in the case at renaming FatPanelUIOptionsFrame.html -> SeparatedPanelPrefsEditorFrame.html

[09:22:51 CDT(-0500)] <anastasiac> well, if it looks like a duck and quacks like a duck...

[09:23:35 CDT(-0500)] <anastasiac> Justin_o, what do you think?

[09:26:54 CDT(-0500)] <Justin_o> anastasiac: i think that makes it a duck

[09:27:45 CDT(-0500)] <Justin_o> anastasiac, cindyli: i personally am fine with the longer names, i think we should start with the longer name and if there is concern we can rename it again

[09:27:59 CDT(-0500)] <anastasiac> my vote is: go with the longer names, cindyli. Maybe we can get another vote from michelled when she gets in

[09:28:11 CDT(-0500)] <cindyli> ok, thanks

[09:39:02 CDT(-0500)] <Justin_o> anastasiac: do you know if this one can be close http://issues.fluidproject.org/browse/FLUID-1653

[09:40:10 CDT(-0500)] <anastasiac> good question, Justin_o, I'm not sure

[09:42:33 CDT(-0500)] <Justin_o> anastasiac: okay.. i'll leave it for now then.. i added a comment anyways

[10:10:19 CDT(-0500)] <Justin_o> cindyli: do you still have an IE 9 vm?

[10:10:31 CDT(-0500)] <cindyli> yes, Justin_o

[10:10:44 CDT(-0500)] <Justin_o> cindyli: never mind.. i got mine working again.. thanks though

[10:10:56 CDT(-0500)] <cindyli> ok

[10:15:56 CDT(-0500)] <Justin_o> cindyli: do you know if this is already fixed? http://issues.fluidproject.org/browse/FLUID-5102

[10:19:25 CDT(-0500)] <cindyli> Justin_o: i think yes. resourceLoader has already been a top level option

[10:25:57 CDT(-0500)] <Justin_o> cindyli: thanks

[10:55:51 CDT(-0500)] <Justin_o> cindyli: did you want to break up the work for FLUID-5161 somehow.. i think i'm finished with the jira cleanup now

[10:56:23 CDT(-0500)] <cindyli> sure, Justin_o. let's talk about how to break up

[11:21:06 CDT(-0500)] <Justin_o> jhung: for GPII-193 did you just switch the focus highlighting to be dashed?

[11:21:27 CDT(-0500)] <jhung> yes Justin_o

[11:22:06 CDT(-0500)] <Justin_o> jhung: was vjoanna okay with that or do we need to run it by her again?

[11:22:54 CDT(-0500)] <jhung> Yes I talked to vjoanna about it. It should be fine.

[11:23:55 CDT(-0500)] <Justin_o> cool.. i do have one more comment.. leaving it on the pull request now

[11:24:28 CDT(-0500)] <jhung> ok thanks Justin_o

[11:25:32 CDT(-0500)] <Justin_o> jhung: comment is up

[11:25:44 CDT(-0500)] <Justin_o> let me know if you have questions about it

[11:39:48 CDT(-0500)] <Bosmon> Hi cindyli - how are you getting on with the "args" improvement to the testing framework?

[11:43:42 CDT(-0500)] <Justin_o> cindyli: we should probably opportunistically get to as many of these issues as possible while we do the renaming http://issues.fluidproject.org/issues/?jql=component%20%3D%20%22Prefs%20Framework%22%20AND%20project%20%3D%20FLUID%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC

[11:44:41 CDT(-0500)] <cindyli> ok, Justin_o, let's try

[11:44:57 CDT(-0500)] <Justin_o> cindyli: thanks.. i'm not sure how many there will be

[11:45:15 CDT(-0500)] <Justin_o> Bosmon: did you see the questions i left in the channel for you on wednesday?

[11:45:32 CDT(-0500)] <cindyli> Bosmon: i haven't started on that yet. but I noticed IoC testing framework probably already provides a way to accomplish that by using eventMaker and makeArgs

[11:45:55 CDT(-0500)] <cindyli> rather than directly attaching thru "listener"

[11:46:04 CDT(-0500)] <cindyli> sorry, not "eventMaker", should be "listenerMaker"

[11:46:59 CDT(-0500)] <cindyli> if that works, all we need to do is to add another test case into TestingTest.js

[13:08:47 CDT(-0500)] <Justin_o> cindyli: i made the changes for the build resources.. but can't test till after the file paths have all been updated... is there anything else you'd like me to take on

[13:09:30 CDT(-0500)] <cindyli> Justin_o: all paths have already been updated and pushed up into my github branch

[13:10:28 CDT(-0500)] <Justin_o> cindyli: really.. that was fast.. okay.. i'll update and test your changes out.. it's also occured to me that we might need to do some splitting out from within files.. like moving css and etc.

[13:10:54 CDT(-0500)] <Justin_o> cindyli: i'm not sure if any such case exists but we will probably need to reivew things

[13:11:08 CDT(-0500)] <cindyli> ok. good to know

[13:42:59 CDT(-0500)] <Bosmon> cindyli, Justin_o - I think you can eliminated the term "Panel" from the long name you quoted earlier

[13:43:04 CDT(-0500)] <Bosmon> eliminate

[13:44:44 CDT(-0500)] <cindyli> i'm ok with that. what do other ppl think? anastasiac, michelled: ^

[13:46:11 CDT(-0500)] <michelled> can you say the long name please cindyli?

[13:46:24 CDT(-0500)] <cindyli> now i have another long name: prefsEditorFullWithoutPreviewSchema.html

[13:46:27 CDT(-0500)] <cindyli>

[13:46:53 CDT(-0500)] <cindyli> the first long name we were talking about was "SeparatedPanelPrefsEditorFrame.html", michelled

[13:47:03 CDT(-0500)] <Bosmon> What is the meaning of "Full" in that new name, cindyli

[13:47:10 CDT(-0500)] <cindyli> full page demo

[13:47:12 CDT(-0500)] <Bosmon> And perhaps "Without" can be replaced with "No"

[13:47:21 CDT(-0500)] <cindyli> nice approach

[13:48:01 CDT(-0500)] <Bosmon> Also, why is there an html file whose name depends on whether there is a Schema or not?

[13:48:02 CDT(-0500)] <Justin_o> cindyli: i think the builds are working now.. it's really hard to test though, anyways you can merge in my changes.

[13:48:15 CDT(-0500)] <cindyli> ok, will do. thanks, Justin_o

[13:48:16 CDT(-0500)] <Bosmon> Couldn't we reuse the html file between the schema and non-schema versions?

[13:48:24 CDT(-0500)] <Bosmon> It seems as if all the actual markup would have to be the same

[13:48:31 CDT(-0500)] <Justin_o> Bosmon: it's a manual test

[13:48:37 CDT(-0500)] <Justin_o> so they have different script blocks

[13:49:13 CDT(-0500)] <Bosmon> Ok

[13:49:19 CDT(-0500)] <Bosmon> Well a cumbersome name is fine for test files

[13:52:01 CDT(-0500)] <anastasiac> sorry, I was distracted. catching up

[13:52:30 CDT(-0500)] <anastasiac> one thing: we should be consistent as to whether or not "prefsEditor" goes at the beginning of the name or the end (consistent across fat panel, full page, etc)

[13:53:36 CDT(-0500)] <anastasiac> so we're trying to decide between "SeparatedPanelPrefsEditor" and "SeparatedPrefsEditor", and we'll have "FullNoPreviewPrefsEditor", etc...

[13:53:50 CDT(-0500)] <anastasiac> "FullPrefsEditor"

[13:54:29 CDT(-0500)] <anastasiac> "FullPrefsEditor" looks odd without "page"… full what? It might be mistaken for the fullness of the editing capabilities

[14:05:52 CDT(-0500)] <Justin_o> cindyli, Bosmon, anastasiac: any idea what to rename the uiOptions directory in the build-scripts to

[14:06:08 CDT(-0500)] <Justin_o> it contains the resources needed to do the !important injection into the css files used by UIO

[14:07:00 CDT(-0500)] <anastasiac> Justin_o, if these files are related to what we're now calling the prefs framework, how about "prefsFramework" ?

[14:07:24 CDT(-0500)] <Justin_o> anastasiac: okay.. thanks

[14:13:07 CDT(-0500)] <Justin_o> cindyli: maybe we can leave the references in the release notes, those are all for 1.4 anyways.. so we will be re-writing them for 1.5

[14:13:19 CDT(-0500)] <Justin_o> and technically they are still correct for 1.4

[14:13:24 CDT(-0500)] <cindyli> sounds good, Justin_o

[14:16:08 CDT(-0500)] <Justin_o> cindyli, anastasiac, Bosmon: should the uiOptions component be created using the schema or grades.. or should we have instances for both?

[14:17:20 CDT(-0500)] <clown> jhernandez are you still around?

[14:17:29 CDT(-0500)] <anastasiac> good question, Justin_o. Given that our goal with the component is to provide an option that requires no modification, it shouldn't matter. But if modification i.e. customization is going to happen, does the choice affect how the customization would/could be done?

[14:17:45 CDT(-0500)] <anastasiac> e.g. if the grades are used, could I tweak it with a schema option? and vice-versa?

[14:17:55 CDT(-0500)] <Justin_o> anastasiac: unfortunately they are quite different as it stands

[14:18:20 CDT(-0500)] <Justin_o> since the schema version will create the enhancer and settings store as well

[14:18:31 CDT(-0500)] <anastasiac> so if we implement using schemas, customization must be done with schemas, and if we implement with grades, customization must be done with grades?

[14:18:39 CDT(-0500)] <anastasiac> wait, the grades version won't create enhancer and store??

[14:19:18 CDT(-0500)] <Justin_o> anastasiac: correct.. there are separate initializations for those when you use grades

[14:19:38 CDT(-0500)] <Justin_o> and no you couldn't adjust customizations of the grades with a schema

[14:19:54 CDT(-0500)] <Justin_o> you could go the other way though...

[14:20:11 CDT(-0500)] <Justin_o> anastasiac: this is because there is a separate tool, the builder, that creates the uio from the schema

[14:20:30 CDT(-0500)] <anastasiac> I wonder if a grades version of a uiOptions component should create the enhancer and store...

[14:21:12 CDT(-0500)] <Justin_o> anastasiac: it's a good question.. i guess it depends on what uiOptions is now..

[14:21:14 CDT(-0500)] <anastasiac> given that you can go the other way, plus the enhancer/store issue, perhaps the uiOptions component should just use the schemas

[14:21:17 CDT(-0500)] <Justin_o> is it the full stack

[14:21:24 CDT(-0500)] <Justin_o> and not just the editor interface like it was before

[14:21:28 CDT(-0500)] <anastasiac> that way, integrators can tweak the schemas, or use grades to customize

[14:22:42 CDT(-0500)] <Justin_o> right.. so i guess i could move the grades stuff to a new manual test and we'd be back down to a single uiOptions demo

[14:23:29 CDT(-0500)] <anastasiac> I guess so, yes. I wonder what cindyli, Bosmon think? maybe michelled?

[14:25:52 CDT(-0500)] <Justin_o> i guess the other issue with the schema version though is there is this component that creates the actual component so it would be strange to try to pass in options and etc. if you are expecting things to be initialized for your right away. meaning are you passing in options to the builder or to the running instance of UIO

[14:26:03 CDT(-0500)] <michelled> I'd like that better. I don't like the two UIO demos - I think it will be confusing for people looking at the demos

[14:27:26 CDT(-0500)] <Justin_o> michelled: i'm wondering if UIO is the stack of prefEditor, store, and enhancer

[14:27:35 CDT(-0500)] <Justin_o> michelled: and then the builder would create one of these stacks

[14:27:46 CDT(-0500)] <Justin_o> anastasiac, Bosmon, cindyli: ^ what do you think

[14:30:07 CDT(-0500)] <anastasiac> I like the idea of our "UIO component" being a bit of a demonstration of what the prefs framework can do, so including the full stack (editor + enhancer + store) makes sense to me

[14:30:50 CDT(-0500)] <anastasiac> but I'd describe it as "the builder creates a stack" and UIO is a packaged use of the builder to provide the stack with a simpler interface

[14:53:22 CDT(-0500)] <cindyli> Justin_o: how do you think to rename "build-scripts/uiOptions" to "build-scripts/preferences"?

[15:04:51 CDT(-0500)] <Justin_o> cindyli, Bosmon: i was talking in person with michelled and anastasiac. since it is so simple to create a basic UIO with the builder.. we are just going to drop the component entirely and just have the demo instead.

[15:05:13 CDT(-0500)] <cindyli> ok