fluid-work IRC Logs-2013-09-26

[07:43:46 CDT(-0500)] <jhung> justin_o: sent you a pull req for GPII-222.

[07:50:42 CDT(-0500)] <justin_o> jhung: thanks.. i'll take a look at it

[08:06:54 CDT(-0500)] <justin_o> jhung: left you a few comments on the pull request

[08:10:01 CDT(-0500)] <jhung> justin_o: thanks. I'll fix that dot/dash issue shortly after I resolve a merge conflict with another branch.

[08:19:33 CDT(-0500)] <justin_o> jhung: thanks, and i left a comment about the name of the class too

[08:22:53 CDT(-0500)] <jhung> I commented on that justin_o

[10:07:14 CDT(-0500)] <jessm> justin_o: and cindyli: thanks for being awesome and writing documentation that will help amilchev. it feels like we're diving into the exciting stuff now.

[10:19:42 CDT(-0500)] <jhung> justin_o: I've updated the pull request for GPII-222.

[10:33:02 CDT(-0500)] <justin_o> jessm: thanks..

[10:33:24 CDT(-0500)] <justin_o> jhung: thanks will take a look at it.. just have to write some docs first

[10:46:06 CDT(-0500)] <colinclark> Hey justin_o, are you around?

[11:01:31 CDT(-0500)] <justin_o> colinclark: hello

[11:11:40 CDT(-0500)] <colinclark> justin_o: Weirdly I don't have you on IM right now

[11:14:58 CDT(-0500)] <justin_o> colinclark: I don't have all of my IM accounts setup on this machine…

[11:15:04 CDT(-0500)] <colinclark> aha

[11:15:05 CDT(-0500)] <colinclark> ok

[11:15:17 CDT(-0500)] <colinclark> I was just looking at Chris' email about localizing his PMT work

[11:15:20 CDT(-0500)] <colinclark> it looks like there's a lot there

[11:15:34 CDT(-0500)] <colinclark> quite a bit of raw jQuery that could be factored better

[11:15:45 CDT(-0500)] <colinclark> and perhaps some misunderstandings about how it all fits together

[11:16:06 CDT(-0500)] <colinclark> do you think it makes sense to fork his repository and illustrate how to do it there?

[11:17:53 CDT(-0500)] <justin_o> colinclark: maybe.. it seems like alexander is trying to use the message bundles though. So using his code as an example might be enough.. not sure.. also cindyli and I are working on documentation about how to use the message bundles in the preferences framework. I told chris and alexander on the call this morning about it and that we'd send them a link to the docs when they were ready.

[11:18:13 CDT(-0500)] <colinclark> Cool

[11:31:16 CDT(-0500)] <colinclark> justin_o: I had mentioned that I was going to share the writing I did on the Preferences Framework for the PGA design document. I've posted it to the GPII wiki here, in case you're interested: http://wiki.gpii.net/index.php/Preferences_Framework_Overview

[11:31:38 CDT(-0500)] <justin_o> colinclark: thanks

[11:45:31 CDT(-0500)] <justin_o> cindyli, anastasiac: could you please review the documentation i've written for using message bundles in the preferences framework http://wiki.fluidproject.org/display/fluid/Localization+in+the+Preferences+Framework

[11:45:50 CDT(-0500)] <anastasiac> sure, justin_o

[11:46:01 CDT(-0500)] <anastasiac> which reminds me...

[11:46:11 CDT(-0500)] <anastasiac> justin_o, michelled, cindyli, Bosmon, colinclark, on the topic of docs: I've created JIRAs for docs tasks. I propose we use the "Needs Commit" status to indicate "needs review"

[11:46:16 CDT(-0500)] <anastasiac> so for example, after justin_o has drafted the i18n docs, he can set the status to "needs commit" and assign it to whoever he thinks should do a technical review.

[11:46:21 CDT(-0500)] <anastasiac> At the end, docs tasks could be assigned to me for a final editorial review. What you you all think of this idea?

[11:46:25 CDT(-0500)] <anastasiac> Does it make sense? or is that overloading the 'needs commit'? other concerns?

[11:49:00 CDT(-0500)] <justin_o> anastasiac: seems fine to me

[11:49:26 CDT(-0500)] <justin_o> anastasiac: by the way, is there a jira for i18n?

[11:49:46 CDT(-0500)] <colinclark> anastasiac: I think it makes sense to me, yes

[11:49:59 CDT(-0500)] <colinclark> seems like quite a reasonable use of "needs commit"

[11:50:33 CDT(-0500)] <anastasiac> justin_o: http://issues.fluidproject.org/browse/FLUID-5156

[11:51:32 CDT(-0500)] <justin_o> anastasiac: oh great.. okay.. i'll change that to needs commit then and assign to cindyli

[11:51:43 CDT(-0500)] <anastasiac>

[11:54:55 CDT(-0500)] <justin_o> cindyli, anastasiac: once those docs are in good enough shape we need to send the link off to the folks on the GPII list. They are in need of them to complete their work.

[11:55:28 CDT(-0500)] <anastasiac> k. cindyli, once you've double-checked the docs for technical stuff, assign the jira to me

[12:00:33 CDT(-0500)] <cindyli> sure

[13:30:40 CDT(-0500)] <justin_o> cindyli, anastasiac: i'll be heading offline now.. if you get through the localization in the preference framework docs today, could you please reply to chris and/or alexander on the GPII list about it.

[13:31:10 CDT(-0500)] <cindyli> sure, justin_o

[13:31:53 CDT(-0500)] <justin_o> thanks

[13:57:53 CDT(-0500)] <cindyli> anastasiac: I added another section onto the doc for the message bundle and done with it. have assigned the jira to you for the final guard: http://wiki.fluidproject.org/display/fluid/Localization+in+the+Preferences+Framework

[13:58:14 CDT(-0500)] <anastasiac> thanks, cindyli, I'll have a look

[13:58:19 CDT(-0500)] <cindyli> nice. thanks

[14:11:54 CDT(-0500)] <anastasiac> cindyli, did you get a chance to review the fluid.messageLoader page? http://wiki.fluidproject.org/display/docs/fluid.messageResolver It hasn't been edited since 2010, so there's a chance that it might be a wee bit out of date

[14:12:13 CDT(-0500)] <anastasiac> sorry, messageResolver

[14:13:15 CDT(-0500)] <cindyli> no, i didn't review it. I will try but not sure if I can get everything right. perhaps you or Bosmon8 can take a look after

[14:13:33 CDT(-0500)] <cindyli> anastasiac: ^

[14:13:43 CDT(-0500)] <anastasiac> yeah, cindyli, it might take a quick double-check of the code itself

[14:13:59 CDT(-0500)] <cindyli> ya

[14:28:26 CDT(-0500)] <anastasiac> cindyli, can I come sit with you for a minute to double-check some things about the localization documentation?

[14:28:35 CDT(-0500)] <cindyli> sure