fluid-work IRC Logs-2013-09-12

[07:26:38 CDT(-0500)] <michelled> kasparnet: are you there?

[07:41:45 CDT(-0500)] <kasparnet> sort of

[07:42:38 CDT(-0500)] <colinclark> I guess we'll skip our meeting and try again another day

[08:04:34 CDT(-0500)] <michelled> kasparnet: do we have a meeting now?

[08:05:36 CDT(-0500)] <colinclark> I was wondering that, too

[08:06:50 CDT(-0500)] <amilchev> yeah, me too

[10:01:19 CDT(-0500)] <Justin_o> michelled: could you please take a look at https://github.com/fluid-project/prefsEditors/pull/43 when you have a chance

[10:04:53 CDT(-0500)] <cindyli> michelled and Justin_o, i issued a pull request https://github.com/fluid-project/prefsEditors/pull/44 for GPII-194, to fix a couple of hovering styling issues in discovery tool. Can one of you take a look?

[10:06:02 CDT(-0500)] <Justin_o> cindyli: i saw that.. was just chatting with jhung about it actually.. he's looking at GPII-195 right now.. and the fix for that may affect your pull request.. so he's going to try to manage both of those for the time being

[10:07:13 CDT(-0500)] <cindyli> that's great. thanks, guys

[10:08:28 CDT(-0500)] <jhung> thanks cindyli.

[10:16:26 CDT(-0500)] <michelled> cindyli: are you there?

[10:16:50 CDT(-0500)] <cindyli> yes, michelled

[10:17:12 CDT(-0500)] <michelled> I was looking at Bosmon's pull for this JIRA: http://issues.fluidproject.org/browse/FLUID-5117

[10:17:20 CDT(-0500)] <michelled> it's not clear to me what we want here

[10:17:31 CDT(-0500)] <michelled> do we want the expander to be returned?

[10:20:17 CDT(-0500)] <michelled> cindyli: ^

[10:34:21 CDT(-0500)] <jessm> fluid-everyone: standup?

[10:34:32 CDT(-0500)] * clown_mtg in a meeting...

[11:00:39 CDT(-0500)] <system64> Hi michelled

[11:03:34 CDT(-0500)] <Justin_o> jhung: cindyli and I just noticed another styling issue with more text.. basically the "T" icon overlaps the text when the simplify or enlarge are enabled. do you think you can look at that with your styling jiras?

[11:13:23 CDT(-0500)] <jhung> Justin_o: sure. Can you put in a jira for that?

[11:14:16 CDT(-0500)] <Justin_o> jhung: sire

[11:14:17 CDT(-0500)] <Justin_o> sure

[11:18:27 CDT(-0500)] <jhung> Justin_o: "sire"? I'm not the king around here.

[11:18:52 CDT(-0500)] <Justin_o> jhung: lol

[11:19:04 CDT(-0500)] <Justin_o> just reciprocating respect

[11:20:35 CDT(-0500)] <jhung> In that case, I demand tithes from all my subjects Justin_o. Cookies or muffins is a good start.

[11:20:49 CDT(-0500)] <Justin_o> jhung: haha

[11:21:26 CDT(-0500)] <Justin_o> jhung: i'll try to bring some in when you are around next time

[11:24:08 CDT(-0500)] <jhung> Justin_o: done! If they're good, I maybe will let you clean the stables.

[11:25:13 CDT(-0500)] <Justin_o> jhung: oh what a reward

[11:25:27 CDT(-0500)] <Justin_o> jhung: by the way.. i created the jira and assigned it to you http://issues.gpii.net/browse/GPII-204

[11:25:39 CDT(-0500)] <jhung> thanks Justin_o

[11:30:49 CDT(-0500)] <Justin_o> cindyli: merged in your GPII-198 pull request

[11:31:13 CDT(-0500)] <cindyli> yay! thanks, Justin_o

[11:42:04 CDT(-0500)] <Justin_o> jhung, cindyli: I've finished up all my tasks for the Discovery Tool Interface jiras.. do you need any help. If not I'll move on to vp work until i see avtar or Bosmon online

[11:48:32 CDT(-0500)] <jhung> Justin_o: There is one thing you can look at.

[11:48:52 CDT(-0500)] <Justin_o> jhung: okay.. what's that?

[11:49:19 CDT(-0500)] <jhung> under GPII-200 there's an issue where the "More Text" hover isn't being applied when "Try something" is hovered.

[11:49:27 CDT(-0500)] <jhung> That should probably go into its own Jira.

[11:49:34 CDT(-0500)] <jhung> and I was wondering if you can look at it?

[11:50:13 CDT(-0500)] <Justin_o> jhung: sure i can take a look at that

[11:50:36 CDT(-0500)] <Justin_o> jhung: have you written the jira for it, if not i can write one up

[11:51:54 CDT(-0500)] <jhung> Can you do that Justin_o? I'm in a middle of a commit.

[11:52:05 CDT(-0500)] <Justin_o> jhung: no problem

[12:26:24 CDT(-0500)] <jhung> cindyli: I look a look at your pull request for GPII-194 and made a comment. Justin_o - once this change is made the pull request is good to go.

[12:26:51 CDT(-0500)] <cindyli> will take a look. thanks, jhung

[12:33:26 CDT(-0500)] <cindyli> jhung and Justin_o, jhung's suggestion has been applied.

[12:34:07 CDT(-0500)] <jhung> great. Justin_o let me know when that is in and I will send my pull request shortly after for GPII-196 and GPII-200.

[12:38:25 CDT(-0500)] <Justin_o> cindyli, jhung: i'll take a look at it

[12:42:37 CDT(-0500)] <michelled> system64: are you here?

[12:45:50 CDT(-0500)] <Justin_o> jhung, cindyli: Merged in GPII-194

[12:46:02 CDT(-0500)] <cindyli> thanks, Justin_o

[12:46:32 CDT(-0500)] <jhung> great Justin_o. I'll send a pull request for GPII-196 shortlu

[12:46:36 CDT(-0500)] <jhung> *shortly

[12:46:55 CDT(-0500)] <Justin_o> jhung: thanks.. i haven't had a chance to write up that jira yet .. i'll do that now

[12:56:56 CDT(-0500)] <michelled> colinclark: were you going to look at the 'three on a match" fix?

[12:57:18 CDT(-0500)] <colinclark> three on a match?

[12:57:28 CDT(-0500)] <michelled> http://issues.fluidproject.org/browse/FLUID-5126

[12:57:40 CDT(-0500)] <michelled> it showed itself when 3 integration tests were writting

[12:57:43 CDT(-0500)] <michelled> written

[12:57:56 CDT(-0500)] <colinclark> you should take this one if you are willin

[12:58:02 CDT(-0500)] <michelled> ok

[13:06:03 CDT(-0500)] <Justin_o> jhung: i think that issue you wanted me to look at is fixed, probably with cindy's changes

[13:06:12 CDT(-0500)] <Justin_o> jhung: can you confirm

[13:07:00 CDT(-0500)] <jhung> Justin_o: yep you're right.

[13:07:21 CDT(-0500)] <jhung> I sent a pull request for GPII-196/200

[13:10:14 CDT(-0500)] <Justin_o> jhung: cool, i'll take a look at that and resolve GPII-206

[13:47:00 CDT(-0500)] <system64> Hi michelled, I'm back

[13:48:47 CDT(-0500)] <michelled> hi system64. you were asking about the Infusion demos and the files included for them

[13:49:16 CDT(-0500)] <michelled> system64: the demos have the javascript files included individually to show the dependencies for each component

[13:49:30 CDT(-0500)] <michelled> you should make a build of Infusion and use the concatenated file

[13:50:05 CDT(-0500)] <system64> michelled: I did try building with ant but got some error. Couldn't find anything on Google.

[13:50:25 CDT(-0500)] <michelled> system64: what error did you get?

[13:50:36 CDT(-0500)] <Justin_o> jhung: commented on your pull request

[13:50:40 CDT(-0500)] <system64> michelled: http://pastie.org/pastes/8316520/text

[13:52:31 CDT(-0500)] <jhung> Justin_o: Thanks.

[13:52:36 CDT(-0500)] <michelled> system64: it looks like you're missing the optional script task

[13:52:36 CDT(-0500)] <michelled> http://wiki.fluidproject.org/display/fluid/Custom+Infusion+Builds+With+Ant#CustomInfusionBuildsWithAnt-Settinguptheenvironment

[13:52:37 CDT(-0500)] <system64> michelled: I tried to run this in build-scripts directory - `ant -lib lib/rhino`

[13:52:54 CDT(-0500)] <jhung> I think i lost some work when I had to do some branch pruning. I'll fix that now Justin_o

[13:53:01 CDT(-0500)] <michelled> 'optional' meaning it's not included with ant by default

[13:53:40 CDT(-0500)] <Justin_o> jhung: cool thanks

[13:54:25 CDT(-0500)] <system64> michelled: Should I run this `ant -f fetch.xml -Ddest=system` ?

[13:54:49 CDT(-0500)] <system64> to install the Script task

[13:55:20 CDT(-0500)] <michelled> yep, that should do it

[13:55:29 CDT(-0500)] <system64> I did run this in the same directory, but it asks for fetch.xml

[13:55:38 CDT(-0500)] <system64> How can I create one?

[13:56:28 CDT(-0500)] <michelled> system64: it's been a long time since I've set this up. can you look at the ant documentation and see if you can find it? http://ant.apache.org/manual/index.html

[14:05:53 CDT(-0500)] <jhung> Justin_o: updated and made a comment.

[14:07:12 CDT(-0500)] <Justin_o> jhung: cool.. i'll take a look again.. thanks

[14:10:45 CDT(-0500)] <Justin_o> jhung: okay.. i think i'll need to get vjoanna to take a look at this when she has time to see if all the changes are as they should be

[14:11:19 CDT(-0500)] <jhung> Sure Justin_o. I'll file Jiras for the things that didn't make it in.

[14:11:54 CDT(-0500)] <Justin_o> jhung: perfect thanks.. can you also remove those parts from the existing jiras

[14:12:03 CDT(-0500)] <colinclark> michelled: CAT SVGs

[14:12:32 CDT(-0500)] <jhung> will do Justin_o

[14:16:38 CDT(-0500)] <jhung> vjoanna: when you get a chance ask Justin_o to show you the fixes so far. I can join via skype too.

[15:15:19 CDT(-0500)] * system64 finally succeeded in building Infusion

[15:16:29 CDT(-0500)] <system64> michelled: If we add `ant-apache-bsf.jar` in libs, the process would have been so much easier