fluid-work IRC Logs-2013-09-05

[08:07:01 CDT(-0500)] <jhung> heidiv: I can't seem to activate the discovery tool panel using the keyboard. Was this always the case? (i.e. focus is on the panel, but space / enter doesn't open the panel).

[08:09:10 CDT(-0500)] <heidiv> jhung i tab to the button and hit enter and it opens

[08:10:48 CDT(-0500)] <jhung> heidiv: thanks. I think it may be something on my end then.

[08:11:02 CDT(-0500)] <heidiv> jhung clear your cache?

[08:11:05 CDT(-0500)] <jhung> also focus styling on demo content looks different in Webkit than it does in FF heidiv.

[08:13:19 CDT(-0500)] <heidiv> jhung looks the same to me - which theme? clear cache from all browsers?

[08:13:28 CDT(-0500)] <heidiv> win or mac?

[08:13:40 CDT(-0500)] <jhung> heidiv: clearing now. Using Mac.

[08:17:31 CDT(-0500)] <jhung> heidiv: that seems to do the trick. However focus gets put onto the panel bar before the button. Seems confusing.

[08:21:03 CDT(-0500)] <heidiv> jhung i'm not sure why it focuses the bar now - any thoughts?

[08:21:36 CDT(-0500)] <heidiv> jhung noticing a couple other things: the download/share font icon arrow is strange in all themes

[08:21:58 CDT(-0500)] <heidiv> and there's a horiz scroll bar even when browser is wide

[08:22:02 CDT(-0500)] <heidiv> should make jiras for these...

[09:36:25 CDT(-0500)] <cindyli> anastasiac, Justin_o, michelled, i rmb last week we were talking about updating myInfusion.js in the discovery tool to the latest. but seems it hasn't been updated yet. i wonder if there's anything stopping it from happening? The reason I'm asking is 'cuz the error that Chris is having with PMT on the "uiEnhancerRelay" is caused by a bug that has been fixed in the latest infusion.

[09:39:32 CDT(-0500)] <colinclark> hey yzen: Have you started to use any of when.js's "promise composition" features?

[09:39:36 CDT(-0500)] <colinclark> Like reduce()

[09:39:43 CDT(-0500)] <colinclark> If so, can I see some code?

[09:39:49 CDT(-0500)] <yzen> colinclark: not yet, but that's the goal for the lifecycle manager

[09:39:51 CDT(-0500)] <michelled> cindyli: I don't know, perhaps it's a good time to try to upgrade

[09:39:57 CDT(-0500)] <colinclark> awesome, yzen

[09:39:59 CDT(-0500)] <colinclark> how will you use it?

[09:40:21 CDT(-0500)] <yzen> so we have several settings handlers that we want to be truly async which would require the life cycle manager to support that

[09:40:32 CDT(-0500)] <cindyli> ok, michelled, i will send a pull request

[09:40:37 CDT(-0500)] <yzen> promises composition like reduce looks like a good fit

[09:41:24 CDT(-0500)] <colinclark> So the idea is that you'd have a promise that represents the completion of "the lifecycle process," which in turn consists of multiple promises, one each for the lifecycle actions involved?

[09:41:28 CDT(-0500)] <colinclark> Am I understanding that right?

[09:43:23 CDT(-0500)] <yzen> colinclark: correct yes

[09:44:01 CDT(-0500)] <yzen> colinclark: this should also aid significantly to the integration tests stability

[09:45:38 CDT(-0500)] <colinclark> how come, yzen?

[09:46:34 CDT(-0500)] <yzen> colinclark: well kasparnet suspects there might be issues with asynchrony when applying settings..

[09:46:52 CDT(-0500)] <colinclark> ah, interesting

[09:48:02 CDT(-0500)] <colinclark> yzen: What do you think is the best example of the use of Promises in the current system?

[09:48:25 CDT(-0500)] <yzen> colinclark: well we use them in the matchmaker

[09:49:37 CDT(-0500)] <cindyli> michelled: the infusion in the discovery tool has been brought to the latest with Justin_o's pull request being merged in yesterday. so, no more pull request on that from me.

[09:49:55 CDT(-0500)] <michelled> yay

[11:00:58 CDT(-0500)] <cindyli> Justin_o: our schema version of full with preview demo is broken: http://build.fluidproject.org/infusion/tests/manual-tests/html/uiOptionsFullWithPreviewSchema.html. seems just need to correct the url to the preview window. do you think the pull request to gpii/prefsEditors should wait till this is fixed?

[11:01:06 CDT(-0500)] <cindyli> creating a jira for it...

[11:06:12 CDT(-0500)] <cindyli> http://issues.fluidproject.org/browse/FLUID-5124

[11:07:48 CDT(-0500)] <Justin_o> cindyli: it probably doesn't matter, the demos aren't in the package we have in the Discovery Tool

[11:07:57 CDT(-0500)] <Justin_o> cindyli: but we should fix that asap, thanks for spotting it

[11:08:31 CDT(-0500)] <cindyli> ok, i will send a pull request for it, Justin_o

[11:08:33 CDT(-0500)] <Justin_o> yzen: can you take a look at this pull request https://github.com/GPII/prefsEditors/pull/5

[11:08:37 CDT(-0500)] <Justin_o> cindyli: thanks

[11:08:54 CDT(-0500)] <yzen> Justin_o: sure how soon do you need it ?

[11:09:13 CDT(-0500)] <Justin_o> yzen: whenever is fine, more so for the gpii folks than for us

[11:47:56 CDT(-0500)] <Justin_o> Bosmon2, colinclark, yzen: what do you think of http://mantrijs.com for dependency management. I'm not necessarily suggesting we use it, but what do you think of their approach?

[11:48:14 CDT(-0500)] <colinclark> I'll take a look

[12:09:45 CDT(-0500)] <Justin_o> kasparnet: was checking with avtar to see if we have a daily build of the gpii/prefsEditors repo yet. It seems that we were waiting for you to create a DNS record for build.gpii.net first. Has this been done already?

[12:12:01 CDT(-0500)] <kasparnet> argh, no ... I keep forgetting

[12:19:56 CDT(-0500)] <Justin_o> kasparnet: okay, when you get to it, could you please let avtar know

[12:39:31 CDT(-0500)] <cindyli> michelled: i sent a pull request for FLUID-5124 to fix the schema version of the full with preview demo. Can you take a look when you have a chance?

[12:39:43 CDT(-0500)] <cindyli> https://github.com/fluid-project/infusion/pull/397

[13:22:22 CDT(-0500)] <Justin_o> michelled: i have another pull request for you to look at https://github.com/fluid-project/prefsEditors/pull/41

[14:23:04 CDT(-0500)] <michelled> cindyli: can you please update this branch to master? https://github.com/fluid-project/prefsEditors/pull/38

[14:23:22 CDT(-0500)] <cindyli> sure, michelled

[14:23:33 CDT(-0500)] <michelled> thx!

[14:50:12 CDT(-0500)] <cindyli> michelled: the pull request #38 is updated.

[14:50:39 CDT(-0500)] <michelled> thx cindyli

[14:50:51 CDT(-0500)] <cindyli> np

[14:56:24 CDT(-0500)] <Justin_o> cindyli: left you a small comment on your pull request.. you have a trailing comma

[14:56:42 CDT(-0500)] <cindyli> ah. ok. thanks, Justin_o

[14:57:01 CDT(-0500)] <Justin_o> cindyli: other than that it looks good.. let me know when it's fixed and i'll merge it in

[14:57:17 CDT(-0500)] <cindyli> sure

[14:59:51 CDT(-0500)] <cindyli> Justin_o: fixed and pushed up

[15:02:31 CDT(-0500)] <Justin_o> cindyli: thanks merged into the repo

[15:02:50 CDT(-0500)] <cindyli> yay! thanks, Justin_o