fluid-work IRC Logs-2013-07-26

[06:32:29 CDT(-0500)] <diulf> hi, can someone help me with my extention? got a prob with relations and the attchment of the subobject

[06:32:33 CDT(-0500)] <diulf> right channel ?

[09:07:10 CDT(-0500)] <nanook_> Hey. can someone point me to a good example of a rendererComponent?

[10:13:05 CDT(-0500)] <michelled> fluid-everyone: I just pushed the pull request that removes the web app directory

[10:13:20 CDT(-0500)] <anastasiac> yay!

[10:13:25 CDT(-0500)] <michelled> I think it might cause some conflicts so you might want to update

[10:14:13 CDT(-0500)] <avtar> michelled: so maven isn't required anymore?

[10:14:52 CDT(-0500)] <anastasiac> Justin_o, I created that JIRA about an easier way to override the panel-holder template: http://issues.fluidproject.org/browse/FLUID-5102

[10:14:53 CDT(-0500)] <michelled> that's right avtar, but I think I still need to update the nightly build script

[10:15:09 CDT(-0500)] <michelled> avtar: I can't quite remember what it does, but I think it deploys the no longer built war

[10:16:50 CDT(-0500)] <avtar> michelled: which script?

[10:16:55 CDT(-0500)] <Justin_o> anastasiac: thanks

[10:17:17 CDT(-0500)] <michelled> avtar: what ever it is that continuum kicks off when it does the infusion nightly

[10:17:30 CDT(-0500)] <michelled> or have things changed?

[10:27:15 CDT(-0500)] <avtar> michelled: i'm taking a look

[10:40:31 CDT(-0500)] <avtar> michelled: i think the continuum infusion build job will need to be reconfigured

[10:48:02 CDT(-0500)] <Justin_o> jhung:

[10:48:21 CDT(-0500)] <Justin_o> jhung: i think i have the code level changes done for GPII-135 did you want to work on the styling for it now

[10:48:32 CDT(-0500)] <jhung> Justin_o: sounds good.

[10:48:54 CDT(-0500)] <Justin_o> jhung: thanks.. did you want me to submit a pull request for my changes, or will you just submit one with everything?

[10:48:55 CDT(-0500)] <jhung> I've filed a jira for that task, so I'll pull down your changes. Are they in master or should I use your branch Justin_o?

[10:49:06 CDT(-0500)] <jhung> submit yours first Justin_o

[10:49:13 CDT(-0500)] <Justin_o> jhung: they are in my branch now.. but i'll send the pull request

[10:49:24 CDT(-0500)] <jhung> sounds good.

[10:51:03 CDT(-0500)] <Justin_o> michelled, yzen: did you want to look at my GPII-135 pull request https://github.com/fluid-project/prefsEditors/pull/11

[10:52:09 CDT(-0500)] <Justin_o> yzen, michelled: i'll start looking at the other pull request for prefsEditors

[10:52:30 CDT(-0500)] <Justin_o> yzen: unless you want pari up on the schema work

[10:52:57 CDT(-0500)] <yzen> Justin_o: i have to take a look at GPII pull but i ll join you if I'm done shortly

[10:53:48 CDT(-0500)] <Justin_o> yzen: thanks.. i'll try to knock off some of these pull requests in the meantime

[11:06:36 CDT(-0500)] <Justin_o> jhung: do you know if we decided not to use the attached font to resolve this jira http://issues.gpii.net/browse/GPII-142

[11:06:57 CDT(-0500)] <Justin_o> I don't see it in heidi's pull request https://github.com/fluid-project/prefsEditors/pull/9/files

[11:08:32 CDT(-0500)] <jhung> Justin_o: yes, after using it Heidiv said it wasn't similar enough. So we'll file a new jira for it and just use default fonts for now.

[11:12:34 CDT(-0500)] <Justin_o> jhung: okay.. thanks.. can you comment on the jira about that?

[11:13:24 CDT(-0500)] <jhung> sure

[11:14:09 CDT(-0500)] <Justin_o> jhung: thanks

[11:19:52 CDT(-0500)] <anastasiac> Justin_o, in the new schema branch, would the following statements be generally sort of correct in terms of the technical relationship between components? "UIO 'is a' UIE" and "UIO 'has a' settingsStore'"

[11:20:00 CDT(-0500)] <anastasiac> I want to check if my understanding is correct

[11:21:10 CDT(-0500)] <Justin_o> anastasiac: not really.. UIO, UIE and the store are separate components.. i suppose the confusion could be from the naming in the builder

[11:21:37 CDT(-0500)] <anastasiac> Justin_o, it looks like UIO has a grade of UIE, and UIE has a store subcomponent. Is that much correct?

[11:21:56 CDT(-0500)] <Justin_o> what the builder creates is actually a new top level component that has the Store, UIE, and UIO

[11:22:11 CDT(-0500)] <Justin_o> as siblings

[11:22:24 CDT(-0500)] <anastasiac> but UIO doesn't actually have a line of code that instantiates as UIE, does it? The UIE is created because UIO has it as a grade?

[11:23:33 CDT(-0500)] <Justin_o> https://github.com/jobara/infusion/blob/FLUID-4907/src/webapp/components/uiOptions/js/Builder.js#L58-L102

[11:23:44 CDT(-0500)] <Justin_o> anastasiac: ^ you can see from there that there are two grades

[11:24:01 CDT(-0500)] <Justin_o> the subcomponents in these grades are store, uie and uio

[11:24:07 CDT(-0500)] <anastasiac> yes, I see that, Justin_o. But is there a line of code in the UIO that instantiates UIE?

[11:24:51 CDT(-0500)] <Justin_o> anastasiac: yes and no.. in some cases UIO does have it's own UIEnhancer.. internally as well.. so for fat panel and full with preview that's the case

[11:25:19 CDT(-0500)] <anastasiac> so how does the UIE get instantiated?

[11:25:29 CDT(-0500)] <anastasiac> in the current fat-panel demo, for example

[11:25:40 CDT(-0500)] <Justin_o> through the page enhancer

[11:25:50 CDT(-0500)] <Justin_o> and this is where the configuration for the internal one comes from

[11:25:51 CDT(-0500)] <anastasiac> how does the page enhancer get instantiated?

[11:26:32 CDT(-0500)] <Justin_o> anastasiac: this is how the existing demo works https://github.com/fluid-project/infusion/blob/master/src/demos/uiOptions/html/uiOptions.html#L75-L81

[11:26:51 CDT(-0500)] <Justin_o> you can see there are three separate calls to instantiate the store, enhancer, and uio

[11:26:52 CDT(-0500)] <anastasiac> not in the 4907 branch, it isn't

[11:27:18 CDT(-0500)] <Justin_o> anastasiac: nope, that's all handled by the new top level component that is created, which has the three as sibling subcomponents

[11:27:57 CDT(-0500)] <Justin_o> anastasiac: does that make sense.. it might be easier if i just show you

[11:30:59 CDT(-0500)] <jhung> Justin_o: have you had a chance to look at the pull req for GPII-134?

[11:33:38 CDT(-0500)] <Justin_o> jhung: actually i'm just looking at it now

[11:34:04 CDT(-0500)] <jhung> cool Justin_o. Let me know if there are any issues.

[11:35:20 CDT(-0500)] <Justin_o> jhung: i'll leave some comments on the pull request if i come into anything

[11:36:09 CDT(-0500)] <jhung> k

[11:36:50 CDT(-0500)] <Justin_o> jhung: left one comment so far

[11:39:46 CDT(-0500)] <Justin_o> jhung: what do i have to do to get the icons to show up.. i'm still seeing them missing in high contrast

[11:40:42 CDT(-0500)] <Justin_o> jhung: got it, had to clear my cache

[11:40:50 CDT(-0500)] <jhung> yeah. FF is funny that way

[11:41:46 CDT(-0500)] <Justin_o> jhung: would you be able to reply or address the comment i left in the pull request.. i think that's all that's holding it up from going in

[11:42:06 CDT(-0500)] <jhung> ok. I'll submit that fix now.

[11:43:13 CDT(-0500)] <jhung> done Justin_o

[11:51:19 CDT(-0500)] <anastasiac> Justin_o, we don't actually have a branch of the discoveryTool that uses the 4907 schema version of UIO, do we?

[11:51:25 CDT(-0500)] <anastasiac> no one's tried that?

[11:55:58 CDT(-0500)] <Justin_o> anastasiac: not that i'm aware of

[11:56:11 CDT(-0500)] <Justin_o> jhung: GPII-134 is in

[11:56:32 CDT(-0500)] <jhung> awesome Justin_o. I'll start on the low contrast theme now for DT.

[12:03:23 CDT(-0500)] <Justin_o> jhung: thanks

[13:50:38 CDT(-0500)] <Justin_o> anastasiac: was it just the Panels.js file that was confusing in terms of having new and old style in it?

[13:51:48 CDT(-0500)] <anastasiac> Justin_o, for me, yes. I didn't really look at the Enactors file, so I couldn't say. Though I'm just starting to look at if now. If it's got old and new in it, I'd say split it out. I think that applies to anything that someone might look at for guidance on how to do something

[13:53:57 CDT(-0500)] <Justin_o> anastasiac: okay, thanks

[14:00:06 CDT(-0500)] <michelled> Justin_o: do you expect these tests to run? http://build.fluidproject.org/infusionBuilder/tests/html/InfusionBuilder-tests.html

[14:02:28 CDT(-0500)] <Justin_o> michelled: yes those should work

[14:02:33 CDT(-0500)] <Justin_o> not sure when they would have broken though

[14:03:12 CDT(-0500)] <michelled> ah, just now

[14:03:15 CDT(-0500)] <michelled> web app in the url

[14:03:42 CDT(-0500)] <Justin_o> ah.. another spot

[14:04:15 CDT(-0500)] <michelled> Justin_o: actually, I'm not perfectly sure that's the issue

[14:04:29 CDT(-0500)] <michelled> I haven't looked to see if infusion is automatically updated for the builder or not

[14:06:37 CDT(-0500)] <Justin_o> michelled: unfortunately i don't remember

[14:07:05 CDT(-0500)] <michelled> Justin_o: I found an issue with the full UIO with preview

[14:07:06 CDT(-0500)] <Justin_o> anastasiac, michelled: if i move out the starter grades for UIO into separate files, would you rather have all of them in a single file.. enactors, panels, and etc.

[14:07:23 CDT(-0500)] <Justin_o> or would it be better to have them broken out into a few more files

[14:07:47 CDT(-0500)] <Justin_o> michelled: really… what's wrong with that?

[14:08:34 CDT(-0500)] <anastasiac> Justin_o, more files might make for easier mental parsing. Either a file for the panels, a file for the enactors, etc., or one file per 'settings', with everything needed for that setting (panel, enactor, etc)

[14:08:40 CDT(-0500)] <michelled> Justin_o: reset modifies the entire page but doesn't' store the new setting so refreshing shows the old settings

[14:08:49 CDT(-0500)] <michelled> the problem is in both the master and in your branch

[14:09:36 CDT(-0500)] <michelled> Justin_o: I imagine that for new settings, people will create a single file with the enactor + panel etc.

[14:09:37 CDT(-0500)] <Justin_o> anastasiac: i'm thinking of keeping the current groupings the same, so if they were currently in the same file, they still will be

[14:09:42 CDT(-0500)] <Justin_o> does that make sense?

[14:10:24 CDT(-0500)] <anastasiac> so that's all panels in a file, all enactors in a file? yes, that would be better than a single file with both

[14:15:26 CDT(-0500)] <Justin_o> anastasiac: there are a bunch of other starter grades too..like one for templateLoader, rootModel, Messages

[14:15:41 CDT(-0500)] <Justin_o> the templateLoader and messages one will be in the panels, while rootModel will be by itself, since it is used by both

[14:16:16 CDT(-0500)] <anastasiac> Justin_o, right… hm.. I wonder if the more 'administrative' stuff might go well in a file of its won

[14:16:18 CDT(-0500)] <anastasiac> own

[14:37:58 CDT(-0500)] <Justin_o> after having discussed this in person with michelled and anastasiac we have decided to have files for the panels, enactors, and the old api starter grades.. which will look like Panels.js, Enactors.js, StarterSet.js

[14:42:17 CDT(-0500)] <yzen> Bosmon: