fluid-work IRC Logs-2013-07-25

Owned by Fluid IRC Log Bot
Last updated: Jul 25, 2013Version comment
9 min read

[08:20:54 CDT(-0500)] <Justin_o> heidiv: i got your pull request in. jhung1 heidiv let me know if you have any more

[08:20:54 CDT(-0500)] <Justin_o> cindyli: how are things going.. do you think you'll be able to get the i18n work done today and didn't you need any help with it

[08:21:30 CDT(-0500)] <cindyli> Justin_o: should be done today

[08:21:33 CDT(-0500)] <heidiv> Justin_o thanks! am quickly doing a small demo css cleanup (gpii-142) but wondering about tackling http://issues.gpii.net/browse/GPII-131 afterwards - thoughts?

[08:22:18 CDT(-0500)] <heidiv> unless jhung1, i can help you w other stuff

[08:22:56 CDT(-0500)] <jhung1> heidiv: yes there are some stuff.

[08:23:32 CDT(-0500)] <jhung1> heidiv: I added high and low contrast images to GPII-136. Could you add them to the content?

[08:23:43 CDT(-0500)] <heidiv> jhung1 yes can do

[08:24:05 CDT(-0500)] <jhung> heidiv: thanks!

[08:24:06 CDT(-0500)] <Justin_o> heidiv: maybe also GPII-143 as well..

[08:24:32 CDT(-0500)] <heidiv> jhung Justin_o did you fix the panel bar ?

[08:25:48 CDT(-0500)] <Justin_o> cindyli: great.. is there anything you'd need me to help with, if not i can start work on somethings for the discovery tool

[08:26:23 CDT(-0500)] <cindyli> Justin_o: i'm fine for now. will let you know if i need help

[08:28:07 CDT(-0500)] <Justin_o> cindyli: okay.. sounds good..

[08:28:35 CDT(-0500)] <Justin_o> i'll start working on GPII-135

[08:30:26 CDT(-0500)] <jhung> heidiv: I'm working on that now. Fighting with UIO FSS's !important rules. (smile)

[08:31:58 CDT(-0500)] <jhung> heidiv: GPII-130 says "Needs commit" but I don't recall doing it. Did you work on that?

[08:34:15 CDT(-0500)] <Justin_o> anastasiac: i'm going to start looking at GPII-143. has anyone else started in on this yet?

[08:35:45 CDT(-0500)] <anastasiac> Justin_o, I know jhung has been working on the high-contrast versions of the panels, so he may have done something on that. You should probably check with him

[08:37:03 CDT(-0500)] <heidiv> jhung i didn't do 130

[08:37:19 CDT(-0500)] <heidiv> Justin_o is 130 do-able now?

[08:38:12 CDT(-0500)] <Justin_o> jhung: did you do anything for GPII-143?

[08:38:20 CDT(-0500)] <jhung> Justin_o: want to sync up on skype for GPII-135?

[08:38:32 CDT(-0500)] <Justin_o> jhung: sure just one minute

[08:39:16 CDT(-0500)] <Justin_o> heidiv, jhung: cindyli is still working on the i18n stuff for the schema work.. those things related to text could probably wait till after it is done

[08:49:36 CDT(-0500)] <heidiv> jhung is vjoanna creating the logo for http://issues.gpii.net/browse/GPII-140 or are you?

[08:50:42 CDT(-0500)] <anastasiac> Justin_o, to use the uio builder with my own aux schema, I should pass my aux schema name as a gradeName option to builder(), right? as commented out here (but with my name)? https://github.com/jobara/infusion/blob/FLUID-4907/src/webapp/demos/uiOptions/js/uiOptionsDemo.js#L24

[08:50:57 CDT(-0500)] <anastasiac> and the resulting constructed grade should have the namespace I specify in my schema?

[08:51:19 CDT(-0500)] <Justin_o> vjoanna: on this page it says the low contrast should be dark grey on light grey, is that still what we want http://wiki.fluidproject.org/display/fluid/Discovery+Tool+Prototype+Roadmap?

[08:53:13 CDT(-0500)] <Justin_o> anastasiac: you could do it with a grade, or you could just set the auxiliarySchema option

[08:53:13 CDT(-0500)] <Justin_o> http://wiki.fluidproject.org/display/fluid/Discovery+Tool+Prototype+Roadmap

[08:53:18 CDT(-0500)] <Justin_o> oops.. wrong url

[08:53:24 CDT(-0500)] <Justin_o> anastasiac: https://github.com/jobara/infusion/blob/FLUID-4907/src/webapp/components/uiOptions/js/AuxiliarySchema.js#L26-L29

[08:53:28 CDT(-0500)] <Justin_o> that's a base grade

[08:54:56 CDT(-0500)] <jhung> heidiv, vjoanna: I haven't gotten to that yet. So if someone has a free moment, go ahead and pick it up.

[08:55:38 CDT(-0500)] <vjoanna> Justin_o: i think heidiv and i last decided on light grey on dark grey for the low contrast theme

[08:55:54 CDT(-0500)] <heidiv> yep

[08:56:43 CDT(-0500)] <Justin_o> vjoanna, heidiv: thanks.. i'll update the wiki page

[08:57:02 CDT(-0500)] <jhung> heidiv, vjoanna: for low contrast, the colour values should have a contrast lower than 4.5:1. Use http://juicystudio.com/services/luminositycontrastratio.php#specify to confirm.

[08:57:50 CDT(-0500)] <heidiv> jhung i got the colours from jan's recommendation on the list

[08:58:34 CDT(-0500)] <heidiv> this says the ratio is 6.62:1 tho…hm

[08:58:41 CDT(-0500)] <heidiv> where did you get 4.5:1 ?

[08:59:02 CDT(-0500)] <jhung> From greggy.

[08:59:06 CDT(-0500)] <heidiv> this is the one i chose from jan's rec: 4 Light (#BDBDBB) on dark gray (#343434) = contrast: 6.6:1

[08:59:33 CDT(-0500)] <colinclark> hiya

[08:59:38 CDT(-0500)] <heidiv> ah, greg's off sick today i think

[08:59:42 CDT(-0500)] <jhung> here's what greggy said to me: "Over 7:1 will be higher contrast, 4.5:1 to 7:1 would be default, and less than 4.5:1 would be lower contrast."

[08:59:58 CDT(-0500)] <Justin_o> colinclark: hey.. i'm going to start work on GPII-135, which will add the low contrast setting in.. i'll need to update infusion though.. we started talking yesterday about moving it to a different location in the repo.. so thought now would be a good time..

[09:00:11 CDT(-0500)] <heidiv> jhung i'll run this by jan

[09:00:33 CDT(-0500)] <jhung> Cool heidiv. Let me know what you find out. This will affect the images I made yesterday.

[09:00:42 CDT(-0500)] <heidiv> and the new theme….

[09:03:03 CDT(-0500)] <yzen> Bosmon: hi

[09:04:19 CDT(-0500)] <jhung> nick jhung_away

[09:05:54 CDT(-0500)] <yzen> Justin_o: you might want to merge my FLUID-4986 branch into FLUID-4907

[09:06:24 CDT(-0500)] <colinclark> Justin_o: Can you send me a link real quick to the pull request

[09:06:30 CDT(-0500)] <Justin_o> yzen: is it necessary for FLUID-4907?

[09:06:36 CDT(-0500)] <colinclark> I'm sorry I'm slightly distracted, and thus slow to search for things

[09:07:01 CDT(-0500)] <yzen> Justin_o: well you already merged it once, you ll just have a weird pull to master once 4986 is merged into it

[09:07:13 CDT(-0500)] <yzen> Justin_o: not critical though, just more test cases

[09:07:19 CDT(-0500)] <Justin_o> colinclark: no pull request yet.. just thinking if we are going to move infusion in the prefsEditors repo.. i might as well do it with the work i'll do for GPII-135.

[09:07:30 CDT(-0500)] <Justin_o> colinclark: and the question i have now, is where should it go

[09:07:32 CDT(-0500)] <Justin_o> ?

[09:07:33 CDT(-0500)] <colinclark> didn't you make a pull request to the GPII repo?

[09:07:44 CDT(-0500)] <colinclark> or just send me a link to your prefsEditor fork

[09:07:59 CDT(-0500)] <Justin_o> colinclark: i see what you mean.. sure i'll dig one of those up

[09:08:21 CDT(-0500)] <Justin_o> colinclark: https://github.com/fluid-project/prefsEditors

[09:09:05 CDT(-0500)] <colinclark> Justin_o: Okay, so it sounds like we've got a "lib" directory that contains third-party dependencies at top level

[09:09:15 CDT(-0500)] <Justin_o> colinclark: so it's not really separated by tools at the moment… the src directory does have a common lib

[09:09:16 CDT(-0500)] <Justin_o> yes

[09:09:50 CDT(-0500)] <Justin_o> colinclark: does this seem adequate then for sharing between the various tools

[09:09:58 CDT(-0500)] <colinclark> yes, it does

[09:10:08 CDT(-0500)] <Justin_o> colinclark: cool.. thanks..

[09:10:08 CDT(-0500)] <colinclark> although I'm imagining that there will be shared things that aren't just third-party libraries

[09:10:17 CDT(-0500)] <colinclark> such as Adjustor views

[09:10:22 CDT(-0500)] <colinclark> where do you suggest they should go?

[09:11:23 CDT(-0500)] <Justin_o> colinclark: perhaps we could add a components, adjustors, views, or some other name, directory as a sibling to lib and discoverTool

[09:11:40 CDT(-0500)] <colinclark> Or should we nest those in a "shared" directory?

[09:12:29 CDT(-0500)] <Justin_o> colinclark: would lib then have to go in the "shared" directory?

[09:12:47 CDT(-0500)] <colinclark> Something like this? https://gist.github.com/colinbdclark/6080076

[09:13:07 CDT(-0500)] <colinclark> I don't know if this would be inconvenient at all

[09:14:26 CDT(-0500)] <Justin_o> colinclark: so in infusion we have lib as top level and then we put the shared pieces in either framework i guess

[09:14:27 CDT(-0500)] <Justin_o> https://github.com/fluid-project/infusion/tree/master/src/webapp

[09:14:43 CDT(-0500)] <colinclark> right

[09:14:44 CDT(-0500)] <Justin_o> colinclark: i don't mind either way though

[09:14:57 CDT(-0500)] <colinclark> in this case we don't have a "framework" so much as a collection of shared code

[09:15:27 CDT(-0500)] <Justin_o> colinclark: yes.. i definitely don't think we should call what we are planning to put in there framework

[09:15:43 CDT(-0500)] <Justin_o> colinclark: so i'm fine either with having everything in shared, or having lib stay at top and the rest in shared

[09:16:32 CDT(-0500)] <Justin_o> colinclark: in regards to DT i don't think we'll have any other shared piece other than infusion at the moment

[09:17:01 CDT(-0500)] <colinclark> I think it might make sense to convey to everyone that there should be a shared pool of stuff

[09:17:10 CDT(-0500)] <colinclark> on the same level as the tools themselves

[09:18:05 CDT(-0500)] <Justin_o> colinclark: okay.. i'll move it into a shared directory as implement GPII-135

[09:20:49 CDT(-0500)] <colinclark> thanks, that'll be great

[09:21:53 CDT(-0500)] <Justin_o> yzen: okay.. so it's just an update to what's already in there

[09:22:06 CDT(-0500)] <yzen> Justin_o: yes exactly, just more tests

[09:22:18 CDT(-0500)] <Justin_o> yzen: okay.. i'll do that

[09:22:57 CDT(-0500)] <Justin_o> yzen: done

[09:23:08 CDT(-0500)] <yzen> (smile)

[10:14:37 CDT(-0500)] <cindyli> Justin_o: can you try my FLUID-4907-i18n branch to see if "text Font" works with fat panel demo?

[10:14:59 CDT(-0500)] <cindyli> doesn't work on me. i suspected there's something wrong with my generated uio themes

[10:15:30 CDT(-0500)] <cindyli> but my ant build on generating uio themes keeps failing. sigh..

[10:20:00 CDT(-0500)] <Justin_o> cindyli: sure i'll give it a try

[10:20:17 CDT(-0500)] <cindyli> thanks, Justin_o

[10:24:44 CDT(-0500)] <Justin_o> cindyli: seems to be working

[10:24:56 CDT(-0500)] <cindyli> yay! thanks, Justin_o

[10:25:06 CDT(-0500)] <cindyli> problem with my uio css

[11:14:08 CDT(-0500)] <cindyli> Justin_o: one thing anastasiac noticed with builder initial grades @ https://github.com/jobara/infusion/blob/FLUID-4907/src/webapp/components/uiOptions/js/Builder.js#L25

[11:14:19 CDT(-0500)] <cindyli> should "fluid.uiOptions.auxSchema.starter" be taken out

[11:14:46 CDT(-0500)] <cindyli> otherwise, the users always get our starter panels

[11:15:37 CDT(-0500)] <Justin_o> cindyli: yes.. it should be the grade with the empty auxSchema

[11:17:55 CDT(-0500)] <cindyli> ok

[11:18:32 CDT(-0500)] <cindyli> do you want me to fix it in my i18n branch or u r doing it? Justin_o

[11:18:50 CDT(-0500)] <Justin_o> cindyli: would you mind changing that in your branch?

[11:19:03 CDT(-0500)] <cindyli> sure, will do it

[11:19:07 CDT(-0500)] <Justin_o> cindyli: thanks

[11:19:24 CDT(-0500)] <cindyli> np

[11:44:07 CDT(-0500)] <jhung> heidiv: I don't recall what our status was on GPII-134. It was ready, right? The only issue was the panel bar, but we have a different Jira for that.

[11:44:25 CDT(-0500)] <jhung> Or should I combine the panel bar fix with GPII-134?

[11:44:28 CDT(-0500)] <heidiv> jhung yep and the checkmarks were a bit off position wise

[11:44:33 CDT(-0500)] <heidiv> up to you jhung

[11:45:32 CDT(-0500)] <jhung> Ok. I'll look at the checkmarks. I'll also put in the fix for the panel bar as part of GPII-134, heidiv.

[11:45:52 CDT(-0500)] <heidiv> k just let Justin_o know in yr pull req

[11:47:07 CDT(-0500)] <Justin_o> jhung: i'm having issues with the font icons not showing up in low contrast mode.. not sure if there is a separate jira for this already.. it's the same issue with the high contrast

[11:48:32 CDT(-0500)] <jhung> Justin_o: yes - this is what I was telling you about this morning. Low contrast theme for the DT itself isn't ready - was waiting for the enactor to be implemeted first.

[11:48:53 CDT(-0500)] <Justin_o> jhung: cool.. that's what i thought, just wanted to double check

[11:49:08 CDT(-0500)] <jhung> High contrast is nearly done (GPII-134). Just a few last details to do as heidiv and I were just discussing.

[11:49:16 CDT(-0500)] <Justin_o> jhung: i have the panel in place now.. just need to get the toggling with the high contrast in

[11:49:25 CDT(-0500)] <Justin_o> jhung: great

[12:27:25 CDT(-0500)] <anastasiac> cindyli, the video player only wants to add a captions panel if the browser supports native video. With the new schema work, what do you think would be the best way to accomplish this? Should the schema be "adjusted" based on the browser check before being passed to the builder? Or would there be some other way?

[12:28:24 CDT(-0500)] <cindyli> anastasiac: your approach to adjust schema based on the browser check sounds good

[12:29:01 CDT(-0500)] <anastasiac> ok, thanks cindyli. I just wanted to check if there was some other technique that the schema version offered that I wasn't aware of

[12:30:18 CDT(-0500)] <cindyli> not as i know of

[12:44:08 CDT(-0500)] <jhung> colinclark: we intend to use the same fonts used in the CK12. CK12 is Creative Commons, however, it is unclear what the license is for the fonts themselves. Can it be assumed the typeface is also CC? Otherwise we'll find a substitute.

[12:50:34 CDT(-0500)] <jhung> colinclark: ignore my last comment. The font used is not open, but a commercial font.

[12:51:48 CDT(-0500)] <jhung> heidiv: the font used is Proxima Nova which is a commercial font. I think we should use standard web fonts (Helvetica Neue, Arial, Helvetica, Sans Serif).

[12:52:19 CDT(-0500)] <heidiv> jhung is there one that's similar we could use

[12:54:06 CDT(-0500)] <jhung> I'll trying finding something heidiv

[12:54:27 CDT(-0500)] <jhung> ^that's a lot of "ings".

[13:01:54 CDT(-0500)] <jhung> heidiv: I found something. Try: Josefin Sans. http://www.fontsquirrel.com/fonts/Josefin-Sans?filter%5Bopen%5D=Y&amp;filter%5Bdownload%5D=all

[13:02:37 CDT(-0500)] <heidiv> excellent jhung can you add it to 142?

[13:02:47 CDT(-0500)] <jhung> Sure

[13:03:44 CDT(-0500)] <kasparnet> michelled: did slackmaster yzen leave for the day?

[13:04:02 CDT(-0500)] <michelled> hehe

[13:04:10 CDT(-0500)] <michelled> he'll be online again soon

[13:04:14 CDT(-0500)] <michelled> walking puppy I think (smile)

[13:04:25 CDT(-0500)] <kasparnet> ah cool

[13:04:53 CDT(-0500)] <jhung> Done heidiv.

[13:04:58 CDT(-0500)] <heidiv> thanks!

[13:12:34 CDT(-0500)] <avtar> kasparnet: ping

[13:49:38 CDT(-0500)] <jhung> heidiv: I've pushed up changes to GPII-134. I'll submit a pull req - could you or jobara review it?

[13:49:52 CDT(-0500)] <heidiv> jhung flag justin, i can't merge

[13:50:00 CDT(-0500)] <jhung> k

[13:59:40 CDT(-0500)] <avtar> kasparnet: the gpii wiki has been upgraded to the LTS release of mediawiki

[14:00:07 CDT(-0500)] <avtar> please check your messages (wink)

[14:11:21 CDT(-0500)] <kasparnet> ooh, cool!

[14:11:23 CDT(-0500)] <kasparnet> thanks avtar