fluid-work IRC Logs-2013-07-18

[07:42:19 CDT(-0500)] <evgeni> any infusion/uioptions experts here?

[09:27:55 CDT(-0500)] <michelled> colinclark: we have a nightly build! http://build.fluidproject.org/discoveryTool

[09:28:02 CDT(-0500)] <colinclark> oooh!

[09:28:16 CDT(-0500)] <michelled> I still need to get back to avtar with the url we want for the GPII nightly build of the discovery tool

[09:28:21 CDT(-0500)] <colinclark> That's great

[09:39:10 CDT(-0500)] <yzen> Bosmon: AYT?

[10:00:05 CDT(-0500)] <jhung> anastasiac: I've pushed my changes to GPII-132. https://github.com/jhung/prefsEditors/tree/GPII-132

[10:00:33 CDT(-0500)] <anastasiac> thanks, jhung, I'll give merge them in and test it out

[10:00:56 CDT(-0500)] <jhung> ok let me know if you want to pair on the merge anastasiac

[10:01:09 CDT(-0500)] <anastasiac> sure. I'll probably commit what I've got first

[10:18:40 CDT(-0500)] <anastasiac> michelled, I've issued a pull request for GPII-125 (getting the new demo content working with the code): https://github.com/fluid-project/prefsEditors/pull/4

[10:24:03 CDT(-0500)] <jhung> anastasiac: I've updated GPII-132 in my repo. It fixes that issue with the hover icon not showing when preference is checked and focused.

[10:24:38 CDT(-0500)] <anastasiac> jhung, thanks, I'll merge and push to my pull request

[10:25:01 CDT(-0500)] <jhung> anastasiac: I really feel the panel is missing cursor key navigation.

[10:25:48 CDT(-0500)] <anastasiac> jhung, your latest branch doesn't seem to change much...

[10:27:41 CDT(-0500)] <yzen> colinclark: Bosmon hi

[10:27:53 CDT(-0500)] <colinclark> hi-ish

[10:28:28 CDT(-0500)] <yzen> colinclark: justin and I were wondering what should happen with the old way the uio were initialized after the schema work is completed

[10:28:35 CDT(-0500)] <yzen> Justin_o: ^

[10:28:53 CDT(-0500)] <colinclark> I might need to respond to this later, I'm deep in the midst of some writing

[10:28:57 CDT(-0500)] <yzen> colinclark: ok

[10:28:58 CDT(-0500)] <colinclark> sorry (sad)

[10:30:34 CDT(-0500)] <Justin_o> jessm: most of the toronto office will be missing standup today.. i think only danaayotte, and vjoanna will be around

[10:37:27 CDT(-0500)] <jessm> Justin_o: i'm talking to them now so we're all good

[13:02:42 CDT(-0500)] <anastasiac> ok, ramil_g, I'm looking at your full-page UIO. I see the controls, though they're not styled properly. The values seem to be saving properly, though the adjustments are not being applied to the page.

[13:03:13 CDT(-0500)] <anastasiac> ramil_g, I'd start by looking into the styling: Make sure you have all the required stylesheets loading on the page

[13:03:36 CDT(-0500)] <ramil_g> mine doesnt actually save

[13:04:52 CDT(-0500)] <anastasiac> ramil_g, how are you testing the saving?

[13:05:03 CDT(-0500)] <ramil_g> i tried changing the value of the text size and click on save and apply and the value just goes back to the previous value

[13:05:46 CDT(-0500)] <anastasiac> interesting. It works for me: it saves, and if I reload the page, the new values are still there. Are you seeing any errors in the console?

[13:06:12 CDT(-0500)] <ramil_g> no errors

[13:06:28 CDT(-0500)] <anastasiac> ramil_g, does the value always go back to 1?

[13:06:57 CDT(-0500)] <ramil_g> oh no it does save actually

[13:07:11 CDT(-0500)] <anastasiac> ok, good, so we're looking at the same thing

[13:07:30 CDT(-0500)] <ramil_g> yep i just realized you cant use 3 as the value of the text size

[13:07:40 CDT(-0500)] <ramil_g> cause i think 2 is the maximum

[13:09:18 CDT(-0500)] <anastasiac> right, the range is 1 to 2, in increments of .1, ramil_g

[13:09:24 CDT(-0500)] <ramil_g> so there's some css files that are missing ?

[13:17:24 CDT(-0500)] <anastasiac> ramil_g, it certainly looks like it; the styling should look more like this page http://build.fluidproject.org/infusion/tests/manual-tests/html/uiOptionsFullWithoutPreview.html

[13:17:45 CDT(-0500)] <anastasiac> ramil_g, have a look at that file to see which CSS files it uses, and then check that you're including those files

[13:20:54 CDT(-0500)] <ramil_g> anastasiac, the console isnt logging any missing css files

[13:21:24 CDT(-0500)] <anastasiac> ramil_g, it's possible you're not successfully including the files?

[13:23:36 CDT(-0500)] <ramil_g> <style media="all" type="text/css">@import url("http://localhost/drupal7/sites/all/libraries/infusion/framework/fss/css/fss-layout.css?mq58rn"(wink);

[13:23:37 CDT(-0500)] <ramil_g> @import url("http://localhost/drupal7/sites/all/libraries/infusion/framework/fss/css/fss-text.css?mq58rn"(wink);

[13:23:37 CDT(-0500)] <ramil_g> @import url("http://localhost/drupal7/sites/all/libraries/infusion/components/uiOptions/css/fss/fss-theme-bw-uio.css?mq58rn"(wink);

[13:23:37 CDT(-0500)] <ramil_g> @import url("http://localhost/drupal7/sites/all/libraries/infusion/components/uiOptions/css/fss/fss-theme-wb-uio.css?mq58rn"(wink);

[13:23:37 CDT(-0500)] <ramil_g> @import url("http://localhost/drupal7/sites/all/libraries/infusion/components/uiOptions/css/fss/fss-theme-by-uio.css?mq58rn"(wink);

[13:23:37 CDT(-0500)] <ramil_g> @import url("http://localhost/drupal7/sites/all/libraries/infusion/components/uiOptions/css/fss/fss-theme-yb-uio.css?mq58rn"(wink);

[13:23:37 CDT(-0500)] <ramil_g> @import url("http://localhost/drupal7/sites/all/libraries/infusion/components/uiOptions/css/fss/fss-text-uio.css?mq58rn"(wink);

[13:23:38 CDT(-0500)] <ramil_g> @import url("http://localhost/drupal7/modules/shortcut/shortcut.css?mq58rn"(wink);

[13:23:38 CDT(-0500)] <ramil_g> @import url("http://localhost/drupal7/modules/toolbar/toolbar.css?mq58rn");</style>

[13:23:59 CDT(-0500)] <ramil_g> those are the files that are being loaded

[13:26:21 CDT(-0500)] <anastasiac> right, ramil_g. If you look at the demo link I gave you, you'll see that the FullPage version of UIO requires a particular CSS file, UIOptionsFullPage.css, that you're not loading

[13:29:13 CDT(-0500)] <ramil_g> oh ok

[13:32:29 CDT(-0500)] <ramil_g> anastasiac, that file is not in the library?

[13:32:56 CDT(-0500)] <anastasiac> ramil_g, I think it should be… let me check

[13:33:10 CDT(-0500)] <anastasiac> yep, it should be there

[13:33:42 CDT(-0500)] <anastasiac> ah, ramil_g, it looks like it

[13:33:50 CDT(-0500)] <anastasiac> has been renamed to FullNoPreviewUIOptions.css

[13:33:55 CDT(-0500)] <anastasiac> do you see that file there, ramil_g?

[13:34:01 CDT(-0500)] <ramil_g> yes i see that file

[13:34:23 CDT(-0500)] <anastasiac> that and FullUIOptions.css - they're probably both required

[13:36:13 CDT(-0500)] <ramil_g> hmm, i have those files added in my code lines 348 and 347

[13:54:51 CDT(-0500)] <Justin_o> cindyli1: just noticed that a few of the unit tests are failing around the messages.. i'm guessing that will be fixed with your work now for i18n/l10n..

[13:55:40 CDT(-0500)] <cindyli1> yes, i noticed those too, Justin_o. they will be fixed with the new i18n

[13:55:56 CDT(-0500)] <Justin_o> cindyli1: great thanks

[13:56:03 CDT(-0500)] <cindyli1> np

[14:12:44 CDT(-0500)] <Justin_o> vjoanna: can you send me the link to the discovery tool mock ups.. i can't remember where they are on the wiki

[14:15:42 CDT(-0500)] <vjoanna> justin_o: http://wiki.fluidproject.org/display/fluid/Preference+Discovery+Tool+%28June+9%29

[14:16:10 CDT(-0500)] <Justin_o> vjoanna: thanks

[14:21:11 CDT(-0500)] <yzen> anastasiac: which branch should i use for the prefeditors

[14:21:12 CDT(-0500)] <yzen> ?

[14:22:20 CDT(-0500)] <anastasiac> yzen, my GPII-125 branch has the panels hooked up to the controls. I believe jhung's GPII-132 branch also works, though the simplification outcome would be better in mine. There's still a problem with persistence

[14:22:54 CDT(-0500)] <yzen> anastasiac: ok so if i were to add tts work to it i can just use yours right

[14:23:18 CDT(-0500)] <anastasiac> yes, that should be fine. Hopefully, michelled will review it and push it reasonably soon

[14:24:28 CDT(-0500)] <yzen> anastasiac: oh i see it's already there

[14:24:34 CDT(-0500)] <yzen> does it work in chrome ?

[14:24:40 CDT(-0500)] <yzen> avtar: ping

[14:24:48 CDT(-0500)] <avtar> hi

[14:26:25 CDT(-0500)] <avtar> yzen: hi

[14:26:40 CDT(-0500)] <yzen> avtar: remember the tts server we deployed?

[14:26:45 CDT(-0500)] <yzen> text to speech

[14:26:48 CDT(-0500)] <avtar> yup

[14:27:35 CDT(-0500)] <yzen> avtar: we moved it to fluid-project repo and renamed some things but it's essentially the same. do you think we can redeploy it from the new repo ?

[14:28:04 CDT(-0500)] <anastasiac> yzen, when we implemented it, it did work in Chrome.

[14:28:16 CDT(-0500)] <avtar> yzen: sure

[14:28:32 CDT(-0500)] <yzen> anastasiac: do you mean in the pref editors or earlier demo ?

[14:28:48 CDT(-0500)] <yzen> avtar: this is the new repo: https://github.com/fluid-project/FestivalTextToSpeechService

[14:28:49 CDT(-0500)] <avtar> yzen: this repo and master branch? https://github.com/fluid-project/FestivalTextToSpeechService

[14:29:03 CDT(-0500)] <anastasiac> the discovery tool, yzen, in the prefsEditor project

[14:29:03 CDT(-0500)] <yzen> avtar: (smile) yep

[14:31:48 CDT(-0500)] <Justin_o> yzen, cindyli1: push up changes to my branch.. the demo is now working (smile) and the unit tests other than those related to the messages are all passing

[14:31:59 CDT(-0500)] <yzen> Justin_o: nice (smile)

[14:32:18 CDT(-0500)] <cindyli1> ok, Justin_o

[14:32:45 CDT(-0500)] <Justin_o> yzen, cindyli1: so we just need to do the refactoring of the schema to use the objects instead of arrays and the message bundles stuff. Then we can have a pull request for Bosmon

[14:33:38 CDT(-0500)] <Bosmon> Thanks for your report, cindyli1

[14:33:42 CDT(-0500)] <Bosmon> I am investingating it now

[14:33:52 CDT(-0500)] <cindyli1> cool, thanks, Bosmon

[14:36:15 CDT(-0500)] <ramil_g> anastasiac, i've added all the css files that were in the uiOptions/css/ and the framework/fss/css , so now the Full Page looks a lot better, but the Fat Panel doesn't seem to work now

[14:37:17 CDT(-0500)] <yzen> anastasiac: what branch is MyInfusion.js from, would you know?

[14:37:34 CDT(-0500)] <anastasiac> ramil_g, the fat panel and the full-page versions require different CSS files. Are you loading different filed depending on which version is being used?

[14:38:12 CDT(-0500)] <anastasiac> yzen, it was taken from master. there's a read me in the lib/infusion folder with the commit hash

[14:39:01 CDT(-0500)] <yzen> anastasiac: thanks. there seems to be a bug in our model relay

[14:39:21 CDT(-0500)] <anastasiac> interesting - what bug are you seeing, yzen? because I'm having a problem with it, too, I think

[14:39:26 CDT(-0500)] <anastasiac> I was about to ping you about it

[14:39:32 CDT(-0500)] <yzen> https://github.com/jobara/infusion/blob/FLUID-4907/src/webapp/components/uiOptions/js/ModelRelay.js#L55 should say applier.modelChanged.removeListener

[14:39:56 CDT(-0500)] <yzen> this is one of the branches not master but same thing

[14:40:08 CDT(-0500)] <anastasiac> yzen, what symptoms does this cause?

[14:40:30 CDT(-0500)] <yzen> well a javascript error

[14:40:39 CDT(-0500)] <yzen> TypeError

[14:40:51 CDT(-0500)] <ramil> anastasiac, i've tried doing that but for some reason Drupal wasnt loading the css files properly so what I did was I just included all the css files with the infusion library so all the css files are being loaded whenever the Infusion library is loaded.

[14:41:31 CDT(-0500)] <anastasiac> oh, well ramil, that's likely to cause some problems (smile) they're not designed to be used together

[14:41:39 CDT(-0500)] <ramil> oh i see

[14:41:54 CDT(-0500)] <ramil> ok let me see what I can do

[14:42:18 CDT(-0500)] <anastasiac> ok, yzen, I see that. And unfortunately, fixing that doesn't help the problem I'm having :-.

[14:42:29 CDT(-0500)] <yzen> (sad)

[14:42:44 CDT(-0500)] <anastasiac> yzen, are you fixing that in the 4907 branch?

[14:42:59 CDT(-0500)] <anastasiac> or filing a new jura to fix it?

[14:44:27 CDT(-0500)] <yzen> yes

[14:50:14 CDT(-0500)] <Bosmon> Hi cindyli1 - pull ready for your issue

[14:50:23 CDT(-0500)] <Bosmon> You need to get yourself a nice avatar on GITTHUBB!

[14:50:28 CDT(-0500)] <Bosmon> perhaps some kind of CHRISTMASS CATT

[14:51:29 CDT(-0500)] <cindyli1> lol

[14:52:05 CDT(-0500)] <cindyli1> thanks for the fix, Bosmon, u r lightening fast!

[14:56:43 CDT(-0500)] <cindyli1> anastasiac: what persistence problem you have? is it same as the one we had last time when we worked together on the discovery tool?

[14:57:12 CDT(-0500)] <cindyli1> my pull request on model relay will fix that issue

[14:57:29 CDT(-0500)] <cindyli1> Bosmon will review that pull request btw

[14:57:33 CDT(-0500)] <anastasiac> I don't quire remember what the problem was then cindyli1. The page transformations save, but the panels don't reflect the fact that the setting (e.g. 'highContrast' is on). Is that what we had before

[14:57:35 CDT(-0500)] <anastasiac> ?

[14:57:59 CDT(-0500)] <cindyli1> yes, you are having the same issue, anastasiac

[14:58:13 CDT(-0500)] <anastasiac> so your fix will fix that? excellent!

[14:58:20 CDT(-0500)] <cindyli1> ya

[14:59:18 CDT(-0500)] <anastasiac> great. Which branch will that be in, cindyli1? which pull request is it?

[14:59:22 CDT(-0500)] <cindyli1> yzen: regarding ur pull request https://github.com/fluid-project/infusion/pull/367, it's already in my model relay pull request

[14:59:45 CDT(-0500)] <cindyli1> anastasiac: https://github.com/fluid-project/infusion/pull/360

[14:59:51 CDT(-0500)] <yzen> cindyli1: do you want be to close it ?

[14:59:53 CDT(-0500)] <yzen> (mine)

[15:00:12 CDT(-0500)] <anastasiac> thanks, cindyli1, I'll watch for the fix to be merged and update then

[15:00:13 CDT(-0500)] <cindyli1> yzen: your pull request for 5095

[15:00:18 CDT(-0500)] <cindyli1> FLUID-5095

[15:00:52 CDT(-0500)] <cindyli1> thanks, anastasiac, or you can try merge in that branch to see if it fixes your problem

[15:01:04 CDT(-0500)] <anastasiac> k

[15:05:00 CDT(-0500)] <cindyli1> yzen, perhaps you can take a look on my pull request, if it's confirmed including ur fix, u may wanna close yours. mine: https://github.com/fluid-project/infusion/pull/360

[15:06:29 CDT(-0500)] <yzen> cindyli1: sure but i think ill get to it tomorrow

[15:06:47 CDT(-0500)] <cindyli1> thanks, yzen

[15:12:11 CDT(-0500)] <anastasiac> cindyli1, your branch does fix the issue, thanks

[15:12:33 CDT(-0500)] <cindyli1> yay

[15:41:13 CDT(-0500)] <ramil_g> anastasiac, I've just excluded the css files for the Full Page and Full Page with Preview for now(by commenting them out) just to see what would happen with the Fat Panel UIO without those css files and I'm seeing a bunch of errors in the console

[15:41:37 CDT(-0500)] <ramil_g> "NetworkError: 404 Not Found - http://localhost/drupal7/sites/all/libraries/infusion/lib/jquery/ui/css/fl-theme-bw/bw.css"

[15:41:37 CDT(-0500)] <ramil_g> bw.css

[15:41:37 CDT(-0500)] <ramil_g> "NetworkError: 404 Not Found - http://localhost/drupal7/sites/all/libraries/infusion/lib/jquery/ui/js/jquery.ui.core.js"

[15:41:37 CDT(-0500)] <ramil_g> jquery.ui.core.js

[15:41:37 CDT(-0500)] <ramil_g> "NetworkError: 404 Not Found - http://localhost/drupal7/sites/all/libraries/infusion/lib/jquery/ui/css/fl-theme-yb/yb.css"

[15:42:23 CDT(-0500)] <anastasiac> those are required files, ramil_g, so perhaps you accidentally excluded them?

[15:43:09 CDT(-0500)] <ramil> no I've actually included the Drupal versions of them if you check inside the head element , theyre there

[15:43:26 CDT(-0500)] <ramil> so I need to tell Infusion somehow to not load those files

[15:43:53 CDT(-0500)] <anastasiac> ok

[15:44:37 CDT(-0500)] <ramil> or they should not be included actually since in my custom build i excluded the jquery libraries

[15:46:08 CDT(-0500)] <anastasiac> ramil, where are these requests coming from? Is it from the fat panel itself? the fat panel loads an html file into an iframe

[15:46:15 CDT(-0500)] <anastasiac> that html file has its own header

[15:47:13 CDT(-0500)] <ramil> i dont know how to check where its coming from but Im assuming the MyInfusion.js?

[15:49:54 CDT(-0500)] <ramil> anastasiac, i think its this: Referer http://localhost/drupal7/sites/all/libraries/infusion/components/uiOptions/html/FatPanelUIOptionsFrame.html

[15:50:13 CDT(-0500)] <anastasiac> yep, that's the frame contents, ramil

[15:51:28 CDT(-0500)] <ramil> ok so that file needs to be edited?

[15:51:59 CDT(-0500)] <anastasiac> well, that would work, ramil, but it won't work for anyone using your module if they're using their own infusion library

[15:52:25 CDT(-0500)] <anastasiac> this is a general issue we have with many of our templates, that we haven't yet addressed

[15:52:42 CDT(-0500)] <ramil> i could put it in the readme

[15:53:03 CDT(-0500)] <anastasiac> for now, your module will have to include its own copy of that file, with the header links re-written, and your code will have to tell UIO to use your version of the file instead of the default

[15:53:18 CDT(-0500)] <anastasiac> there's an option for that, though it's not elegant

[15:54:06 CDT(-0500)] <ramil> how do i tell infusion to use my own file for the /FatPanelUIOptionsFrame.html

[15:54:14 CDT(-0500)] <anastasiac> I'm just checking that, ramil

[15:54:20 CDT(-0500)] <anastasiac> give me a sec

[15:56:08 CDT(-0500)] <anastasiac> ramil, it's an option you'll need to add to your call to fluid.uiOptions.fatPanel. You'll need to create a 'fatPanelOpts' that extends commonOpts, the way basicFullPageOpts extends commonOpts

[15:56:34 CDT(-0500)] <ramil> is there a sample code somewhere?

[15:56:51 CDT(-0500)] <anastasiac> unfortunately, no

[15:57:26 CDT(-0500)] <anastasiac> let me mock something up an push it to my version of your repo, so that you can see it

[15:57:43 CDT(-0500)] <ramil> ok

[16:04:11 CDT(-0500)] <anastasiac> ramil: https://github.com/acheetham/infusion_uio/blob/FatPanelCustomPathToIFrameHtml/orig-infusion_uio.js

[16:04:27 CDT(-0500)] <anastasiac> ramil, check out the two new blocks at the very start of that file

[16:04:53 CDT(-0500)] <anastasiac> I don't know for sure if that will work. It's just a sketch, and you'll have to specify what the actual file path and name are (relative path)

[16:05:29 CDT(-0500)] <ramil_g> ok thanks anastasiac

[16:05:52 CDT(-0500)] <anastasiac> ramil_g, to understand a bit more about that call to fluid.demands(), have a look at http://wiki.fluidproject.org/display/docs/Demands+Specifications

[16:08:31 CDT(-0500)] <ramil_g> anastasiac, so basically in the FatPanelUIOptionsFrame.html i can just replace all of the .js files with MyInfusion.js?

[16:09:04 CDT(-0500)] <anastasiac> yes: replace the js links, and fix any css links as necessary

[16:09:22 CDT(-0500)] <anastasiac> ramil_g: don't edit the original file in the infusion library folder

[16:09:31 CDT(-0500)] <anastasiac> create a copy of that file into your module and edit that copy

[16:09:41 CDT(-0500)] <anastasiac> and then adjust that 'markupProps' path to point to your copy