fluid-work IRC Logs-2013-06-20

Owned by Fluid IRC Log Bot
Last updated: Jun 20, 2013Version comment
9 min read

[08:18:16 CDT(-0500)] <jhung> heidiv, Justin_o - I've submitted a pull request for FLUID-4997. https://github.com/fluid-project/infusion/pull/346

[08:18:36 CDT(-0500)] <heidiv> excellent

[08:19:08 CDT(-0500)] <jhung> Working on testing FLUID-4996 now and will submit a pull request for that too if it all checks out.

[08:19:15 CDT(-0500)] <Justin_o> jhung: great, you were able to get the rendering issues sorted out?

[08:19:55 CDT(-0500)] <jhung> Yeah. Seemed like firefox was caching fonts despite it being cleared. Quitting and restarting FF does the trick.

[08:20:37 CDT(-0500)] <Justin_o> jhung: that's good.. probably something that we won't have to worry about too often..

[08:21:34 CDT(-0500)] <jhung> yeah. Only seemed to occur when the font files were changed while there was an open FF session.

[08:37:04 CDT(-0500)] <heidiv> Justin_o do you have time this mornin for a quick skype about the carousel plugin?

[08:38:57 CDT(-0500)] <Justin_o> jhung: okay.. that should be fine for us, unless we start changing fonts dynamically too..

[08:39:18 CDT(-0500)] <Justin_o> heidiv: I should yes, writing up an e-mail at the moment, but after that I should have time.

[08:39:33 CDT(-0500)] <heidiv> Justin_o great - ping me when yr ready

[08:39:49 CDT(-0500)] <Justin_o> heidiv: will do.

[08:40:49 CDT(-0500)] <jhung> Justin_o: I think changing fonts dynamically should be fine since the file itself isn't being modified. I think that was the main problem w FF.

[08:43:29 CDT(-0500)] <Justin_o> jhung: ah i get it now.. yes.. that's highly unlikely outside of development

[09:18:10 CDT(-0500)] <Justin_o> anastasiac, yzen, jhung, Bosmon7, cindyli: I just sent an e-mail to the list with the details of our discussion from yesterday along with links to liras. please feel free to correct any errors and/or omissions there.. the wiki hasn't been fully updated yet though and I also didn't include the steps for actions.. which i suppose should go somewhere.. perhaps on the Iteration plan

[09:18:26 CDT(-0500)] <Justin_o> heidiv: when would you like to chat about the carrousel stuff?

[09:19:18 CDT(-0500)] <heidiv> Justin_o now? should be quick

[09:20:28 CDT(-0500)] <jhung> ok

[09:21:14 CDT(-0500)] <Justin_o> heidiv: sure

[10:01:39 CDT(-0500)] <cindyli> anastasiac, Justin_o, michelled, yzen, I just created a jira (http://issues.fluidproject.org/browse/FLUID-5062) for the issue that UIO uportal integration test throws javascript error - that.getSettings is not a function

[10:02:04 CDT(-0500)] <cindyli> it's added to the iteration page as well

[10:07:21 CDT(-0500)] <yzen> cindyli: thanks i lll take a look

[10:07:28 CDT(-0500)] <cindyli> thanks, yzen

[10:30:11 CDT(-0500)] <michelled> yzen: http://issues.fluidproject.org/browse/FLUID-4923

[10:33:09 CDT(-0500)] <yzen> michelled: fyi i have a pull for FLUID-5058?

[10:38:33 CDT(-0500)] <Bosmon7> Great use of event boiling, yzen (smile)

[10:38:53 CDT(-0500)] <yzen> Bosmon7: (smile) are you saying you are reviewing my pull request (smile) ?

[10:40:20 CDT(-0500)] <Bosmon7> yzen - just glancing over it, sadly : P

[10:40:37 CDT(-0500)] <Bosmon7> I don't have the time for full testing, getting ready to travel....

[10:52:18 CDT(-0500)] <anastasiac> Justin_o, do we have any hopes of the VideoPlayer working in IE10?

[10:52:56 CDT(-0500)] <Justin_o> anastasiac: i think we hope it will, but i doubt we tested it there at all

[10:53:04 CDT(-0500)] <Justin_o> anastasiac: how bad are things?

[10:53:16 CDT(-0500)] <anastasiac> ok, well, I just update my windows, and it updated IE. It's not pretty

[10:53:22 CDT(-0500)] <anastasiac> UIO seems ok, but the video is Green

[10:53:32 CDT(-0500)] <anastasiac> and the mammals demo only shows one video - green

[10:53:42 CDT(-0500)] <Justin_o> anastasiac: hmm.. that's strange

[10:53:49 CDT(-0500)] <anastasiac> time to turn off auto-update in my other VM!

[10:54:09 CDT(-0500)] <Justin_o> anastasiac: yes (smile)

[10:54:21 CDT(-0500)] <Justin_o> anastasiac: you can also try vm's from here if you need any http://www.modern.ie/en-us

[10:55:01 CDT(-0500)] <Justin_o> more direct link http://www.modern.ie/en-us/virtualization-tools#downloads

[10:56:06 CDT(-0500)] <anastasiac> thanks for reminding me, Justin_o

[10:56:43 CDT(-0500)] <Justin_o> anastasiac: can you file a jira about the video player not working in IE 10.. in case someone else hits it

[10:56:51 CDT(-0500)] <anastasiac> good idea, Justin_o

[10:57:14 CDT(-0500)] <anastasiac> you already did, Justin_o (smile) http://issues.fluidproject.org/browse/VP-308

[10:57:38 CDT(-0500)] <Justin_o> anastasiac: i don't know if i should be happy about having done that, or sad that i didn't remember

[10:57:49 CDT(-0500)] <anastasiac> LOL

[10:58:19 CDT(-0500)] <anastasiac> Justin_o, I added a comment to the issue about the single player in the mammals demo

[10:58:40 CDT(-0500)] <Justin_o> anastasiac: thanks

[11:05:25 CDT(-0500)] <yzen> michelled: so in regards to the uportal demo, should i work on removing it instead ?

[11:05:40 CDT(-0500)] <michelled> yzen: I think that would be great!

[11:05:47 CDT(-0500)] <yzen> ok ill take care of it

[11:05:54 CDT(-0500)] <michelled> thanks!

[11:26:02 CDT(-0500)] <yzen> michelled: fyi https://github.com/fluid-project/infusion/pull/348

[11:26:14 CDT(-0500)] <michelled> thx yzen

[11:36:33 CDT(-0500)] <michelled> yzen: did you determine whether there are things in the uportal demo that are not captured in tests or demos?

[11:37:42 CDT(-0500)] <yzen> michelled: as far as i can tell there was just a missing grade

[11:39:21 CDT(-0500)] <michelled> yzen: from the 4923 JIRA "We also used the demo to test some features that we wanted to ensure would continue to work such as nested Reorderers. When we remove the demo, we should create tests to cover these features. "

[11:39:41 CDT(-0500)] <michelled> I'm just wondering if you checked if all the things in the demo are covered by tests or examples or demos

[11:40:01 CDT(-0500)] <yzen> michelled: i have not but i will now

[11:40:17 CDT(-0500)] <michelled> thx yzen!

[11:40:23 CDT(-0500)] <yzen> np

[11:55:31 CDT(-0500)] <jhernandez> yzen: ping

[11:56:07 CDT(-0500)] <yzen> jhernandez: pong

[11:56:40 CDT(-0500)] <jhernandez> hi!

[11:56:57 CDT(-0500)] <jhernandez> just wanted to discuss about https://github.com/GPII/linux/pull/16#discussion_r4731118

[11:57:49 CDT(-0500)] <jhernandez> I am using this function because require(orcaFile) gives me an error

[11:58:44 CDT(-0500)] <jhernandez> the strange thing is that the json validator doesn't complains about the format

[11:58:49 CDT(-0500)] <jhernandez> (funny)

[11:58:51 CDT(-0500)] <jhernandez> :]

[11:59:30 CDT(-0500)] <yzen> jhernandez: are there any comments in that file ?

[11:59:54 CDT(-0500)] * jhernandez looks

[12:00:09 CDT(-0500)] <jhernandez> nope

[12:00:22 CDT(-0500)] <yzen> and the keys are in quotes ?

[12:00:59 CDT(-0500)] <jhernandez> yup

[12:01:05 CDT(-0500)] * jhernandez pasting into pastebin

[12:01:11 CDT(-0500)] <yzen> thanks

[12:02:31 CDT(-0500)] <jhernandez> http://pastebin.com/AiUnyaZP

[12:04:00 CDT(-0500)] <jhernandez> and yes, the keys are in quotes

[12:10:35 CDT(-0500)] <yzen> jhernandez: last thing i can think of make sure/add an empty line at the end of the file

[12:10:47 CDT(-0500)] <yzen> see if that does anything

[12:11:00 CDT(-0500)] <jhernandez> yzen: ACK

[12:12:19 CDT(-0500)] <jhernandez> yzen: same error

[12:12:25 CDT(-0500)] <yzen> weird

[12:12:37 CDT(-0500)] <jhernandez> require("/home/jhernandez/.local/share/orca/user-settings.conf");

[12:12:37 CDT(-0500)] <jhernandez> /home/jhernandez/.local/share/orca/user-settings.conf:2

[12:12:37 CDT(-0500)] <jhernandez> "pronunciations": {},

[12:12:40 CDT(-0500)] <jhernandez> ^

[12:13:05 CDT(-0500)] <jhernandez> yup

[12:13:28 CDT(-0500)] <yzen> hmm i wonder if it's because it's a conf extension

[12:14:16 CDT(-0500)] <jhernandez> nope

[12:14:28 CDT(-0500)] <jhernandez> I've already checked it

[12:15:04 CDT(-0500)] <jhernandez> wait

[12:15:10 CDT(-0500)] <jhernandez> funny

[12:15:11 CDT(-0500)] <jhernandez> xDDD

[12:15:15 CDT(-0500)] <yzen> looks consistent with http://nodejs.org/api/modules.html#modules_file_modules

[12:15:41 CDT(-0500)] <jhernandez> I added an extra line at the end of the .json file, and it worked

[12:16:04 CDT(-0500)] <yzen> haha

[12:16:09 CDT(-0500)] <jhernandez> hahaha

[12:16:11 CDT(-0500)] <yzen> really ?

[12:16:15 CDT(-0500)] <jhernandez> sure!

[12:16:16 CDT(-0500)] <yzen> so .json not .conf

[12:16:21 CDT(-0500)] <jhernandez> yup

[12:16:26 CDT(-0500)] <jhernandez> should I file a bug?

[12:16:45 CDT(-0500)] <yzen> this is really weird, i only saw this issue with git and applying patches

[12:17:24 CDT(-0500)] <yzen> so in order for it to work, you need to rename conf into json AND ensure the line is empty at the end?

[12:17:33 CDT(-0500)] <jhernandez> yup

[12:17:36 CDT(-0500)] <jhernandez> that's it

[12:18:18 CDT(-0500)] <yzen> jhernandez: ya don't bother then i think getJSONFromFile is fine to have , perhaps just double check if we do something similar elsewhere and put it in gpii.utils?

[12:20:27 CDT(-0500)] * jhernandez grep'ing universal repo

[12:21:04 CDT(-0500)] <yzen> jhernandez: you'd probably want it to be async since it's done on requets

[12:21:05 CDT(-0500)] <yzen> request

[12:23:15 CDT(-0500)] <jhernandez> yzen: ok

[12:23:29 CDT(-0500)] <yzen> jhernandez: thanks for being so responsive (smile)

[12:24:24 CDT(-0500)] <jhernandez> heh

[12:24:33 CDT(-0500)] <jhernandez> just trying to do my best

[12:24:35 CDT(-0500)] <jhernandez> :]

[12:38:36 CDT(-0500)] <jhernandez> yzen: I think this is the only place we're hitting this issue

[12:39:19 CDT(-0500)] <yzen> perhaps it makes sense to still put it in utils , since we might be needing something like that somewhere else

[12:39:23 CDT(-0500)] <yzen> jhernandez: ^

[12:39:34 CDT(-0500)] <jhernandez> ok

[12:40:23 CDT(-0500)] <yzen> i guess it will end up being a separate pull (since this one's linux) , hope it's ok with you

[12:40:28 CDT(-0500)] <jhernandez> yep

[12:40:36 CDT(-0500)] <jhernandez> the only question now is

[12:40:45 CDT(-0500)] <jhernandez> are you ok with the name of this method?

[12:40:51 CDT(-0500)] <jhernandez> :]

[13:27:32 CDT(-0500)] <yzen> jhernandez: sorry missed it, yes it's good imo

[13:39:45 CDT(-0500)] <yzen> michelled: ayt?

[13:41:31 CDT(-0500)] <michelled> yep

[13:44:14 CDT(-0500)] <yzen> michelled: about the 4923, if i were to write tests for nested reorderers, would 1 time be sufficient ?

[13:45:53 CDT(-0500)] <michelled> 1 test, you mean?

[13:46:52 CDT(-0500)] <yzen> michelled:sorry i meant 1 type

[13:47:24 CDT(-0500)] <michelled> yes, I think 1 type would be fine

[13:47:37 CDT(-0500)] <michelled> we just want some token coverage - we aren't going for full coverage here.

[13:48:14 CDT(-0500)] <Justin_o> heidiv: what did we say about using the speak style in css

[13:48:28 CDT(-0500)] <Justin_o> i think it didn't do anything.. have we decided not to use it with the icon fonts?

[13:48:42 CDT(-0500)] <heidiv> Justin_o it's not supported by browsers at the moment, and not sure it will be something that gets supported

[13:49:05 CDT(-0500)] <yzen> michelled: sounds good

[13:49:10 CDT(-0500)] <heidiv> i think the thought it should be controlled by the AT, not the site developer

[13:49:28 CDT(-0500)] <Justin_o> heidiv: okay. so we shouldn't use it in the css then?

[13:49:53 CDT(-0500)] <heidiv> Justin_o i'm not sure it matters either way, but yes i guess it's not something that's used so prob shouldn't be in yet?

[13:50:01 CDT(-0500)] <Justin_o> heidiv: thanks

[14:41:14 CDT(-0500)] <mancoolgunda> anastasiac: hi

[14:43:01 CDT(-0500)] <anastasiac> mancoolgunda, hi

[14:43:35 CDT(-0500)] <Justin_o> yzen: are you free at the moment

[14:43:36 CDT(-0500)] <Justin_o> ?

[14:43:44 CDT(-0500)] <yzen> yep

[14:44:20 CDT(-0500)] <mancoolgunda> anastaiac: I was working on the issue I was facing yesterday regarding the integration of Fluid Player into ATutor.

[14:44:28 CDT(-0500)] <anastasiac> right, how's it going?

[14:45:42 CDT(-0500)] <mancoolgunda> ya, so I was able to fix it somehow. Could you please check them once here. http://abhinavkops.comyr.com/mancoolgunda/ATutor/

[14:45:54 CDT(-0500)] * anastasiac checking

[14:45:57 CDT(-0500)] <mancoolgunda> Username: mancoolgunda, Password: abhinav

[14:46:06 CDT(-0500)] <mancoolgunda> This page : http://abhinavkops.comyr.com/mancoolgunda/ATutor/content.php?cid=5

[14:46:46 CDT(-0500)] <mancoolgunda> Actually I felt it is working fine, just wanted to know your comments as well.

[14:46:53 CDT(-0500)] <yzen> Justin_o: what's up ?

[14:46:55 CDT(-0500)] <Justin_o> yzen: can you chat with michelle and I?

[14:47:00 CDT(-0500)] <yzen> yes

[14:48:13 CDT(-0500)] <anastasiac> looking good, mancoolgunda. For me, the first two videos don't load, but the last four do.

[14:48:21 CDT(-0500)] <anastasiac> I also noticed some errors on the main page

[14:48:38 CDT(-0500)] <anastasiac> The version of Infusion that you upgraded ATutor to is missing some things that the rest of ATutor need

[14:48:48 CDT(-0500)] <anastasiac> The Reorderer is one, at least

[14:49:12 CDT(-0500)] <anastasiac> greggy should be able to tell you which parts of Infusion the rest of ATutor is using

[14:49:28 CDT(-0500)] <anastasiac> You'll need to build a version of infusion that has everyything

[14:51:29 CDT(-0500)] <mancoolgunda> anastasiac: oh.. ok.. got it. and how do I build it? using the builder? http://builder.fluidproject.org/

[14:52:09 CDT(-0500)] <anastasiac> mancoolgunda, the builder would be the place, yes

[14:54:05 CDT(-0500)] <mancoolgunda> also had a problem with ProgressiveEnhancement.js. It was giving me an error "Uncaught TypeError: Object #<Object> has no method 'registerNamespace' ". Any idea why?

[14:54:10 CDT(-0500)] <anastasiac> mancoolgunda, I also notice that your videos #3, 4 and 5 are having troubles with the time codes: When you hover over the videos to see the controls, the time codes are showing NaN instead of the 0:00/...

[14:54:30 CDT(-0500)] <anastasiac> where id you see this error?

[14:57:13 CDT(-0500)] <mancoolgunda> yes on chrome webm format works well, but on Firefox they show that NAN in the timeline.

[14:58:07 CDT(-0500)] <anastasiac> mancoolgunda, where did you see the "registerNamespace" error?

[14:59:25 CDT(-0500)] <mancoolgunda> just check this once again: http://abhinavkops.comyr.com/mancoolgunda/ATutor/content.php?cid=5

[14:59:57 CDT(-0500)] <mancoolgunda> I had commented the inclusion of ProgressiveEnhancement.js, have now uploaded on the server.

[15:02:15 CDT(-0500)] <anastasiac> hm

[15:04:07 CDT(-0500)] <anastasiac> ah, I see the problem, mancoolgunda: Something is including the file ProgressiveEnhancement.js, which shouldn't be necessary, since it's included in MyInfusion.js. The file is loading before MyInfusion.js, so it's trying to execute the function fluid.registerNamespace, which isn't defined until MyInfusion.js is loaded.

[15:05:37 CDT(-0500)] <mancoolgunda> so it should be commented out, I guess because it gets included later anyways.

[15:06:55 CDT(-0500)] <anastasiac> right

[15:07:38 CDT(-0500)] <mancoolgunda> one last thing, I wanted to add is Fluid Player uses Jquery-ui-1.8.14.css and ATutor was using Jquery-ui-1.8.16.css. So I had to downgrade ATutor's ui-css file to 1.8.14 (Fluid's version) because otherwise the controls were not getting rendered properly.

[15:08:08 CDT(-0500)] <anastasiac> ah, interesting

[15:09:44 CDT(-0500)] <anastasiac> well, I guess that's something to double-check with greggy, mancoolgunda

[15:10:24 CDT(-0500)] <mancoolgunda> anastasiac: Ya will do that now

[15:11:04 CDT(-0500)] <mancoolgunda> anastasiac: thanks a lot for your help (smile)

[15:11:23 CDT(-0500)] <anastasiac> mancoolgunda, no problem. Any time

[15:14:40 CDT(-0500)] <greggy> mancoolgunda: good to see this coming along

[15:18:01 CDT(-0500)] <mancoolgunda> greggy: hi

[15:18:13 CDT(-0500)] <mancoolgunda> was about to ping you (smile)

[15:19:29 CDT(-0500)] <mancoolgunda> greggy: I'm just pushing my changes to git so that you can get an idea of the changes that I made to integrate FluidPlayer.

[15:21:49 CDT(-0500)] <greggy> mancoolgunda: sounds good, keep things as modular as possible so we can easily switch out the old media player for the new one(s)

[15:23:08 CDT(-0500)] <mancoolgunda> greggy: Yes, I will keep that in mind.