fluid-work IRC Logs-2013-03-11

fluid-work IRC Logs-2013-03-11

[08:57:16 CDT(-0500)] <heidiv> Justin_o will UIO fat panel be our main focus? are the others going to be deprecated?

[09:19:25 CDT(-0500)] <Justin_o> heidiv: hmm not exactly sure, maybe arashs might know.. the fat panel is our current focus though

[09:20:16 CDT(-0500)] <heidiv> Justin_o the new design demo should likely be the new demo then, if the other two layouts won't be updated

[09:20:45 CDT(-0500)] <heidiv> Justin_o i wonder if we could pair for a second on skype?

[09:21:33 CDT(-0500)] <Justin_o> heidiv: sure

[13:15:39 CDT(-0500)] <colinclark> Hey Justin_o

[13:15:46 CDT(-0500)] <colinclark> I was thinking we should take our conversation here to the channel

[13:16:04 CDT(-0500)] <colinclark> You were telling me about the plan to use IcoMoon's free icons and their app to build icon fonts.

[13:16:21 CDT(-0500)] <Justin_o> colinclark: sure

[13:16:24 CDT(-0500)] <colinclark> I asked if you thought there were particular advantages to using icon fonts as opposed to individual images or CSS sprites

[13:16:47 CDT(-0500)] <Justin_o> the advantage is that they are scalable, and we can easily modify the colour.. so for UIO we wouldn't have to generate new icons for each contrast theme…

[13:16:49 CDT(-0500)] <colinclark> And I also asked about accessibility--if we thought there might be problems with using text + fonts instead of images

[13:17:05 CDT(-0500)] <colinclark> That first advantage is pretty compelling (smile)

[13:18:10 CDT(-0500)] <Justin_o> colinclark: (smile) yes.. even the colour theming is pretty compelling in terms of UIO.. in terms of flexibility and saving time and bandwidth

[13:18:16 CDT(-0500)] <Justin_o> in regards to a11y.. you can provide metadata that the screenreader is supposed to read in place of the actual font.. they have a brief video demo of this on there site..

[13:18:31 CDT(-0500)] <colinclark> Do we know, specifically, how that is achieved?

[13:18:35 CDT(-0500)] <Justin_o> http://www.youtube.com/watch?v=EWq7idrW2yU

[13:18:45 CDT(-0500)] <Justin_o> granted the demo isn't very good

[13:18:48 CDT(-0500)] <arashs> another benefit is that we can import an icon easily, if it does not exist

[13:19:42 CDT(-0500)] <Justin_o> colinclark: on the youtube page they explain it like this "The "Supplementary Private Use Area A" of Unicode is being used in the generated font to achieve this."

[13:20:30 CDT(-0500)] <colinclark> I imagine we should investigate what this means a bit more

[13:20:40 CDT(-0500)] <colinclark> and have a look at it with ATs other than VoiceOver

[13:20:42 CDT(-0500)] <colinclark> but it sounds very promising!

[13:27:25 CDT(-0500)] <arashs> colinclark: I was thinking if it would be ok to work on this

[13:27:57 CDT(-0500)] <colinclark> What do you mean, arashs?

[13:28:23 CDT(-0500)] <Justin_o> colinclark, arashs: perhaps we could generate some now and test them out with a couple of screen readers

[13:32:14 CDT(-0500)] <arashs> and if that worked, I could start working on it and create a font including our icons and tag all the icons

[13:32:55 CDT(-0500)] <colinclark> How does this fit with your priorities for UIO over the next week or so, Justin_o?

[13:33:11 CDT(-0500)] <colinclark> And how does it relate to jessm's priorities for the design team, arashs?

[13:33:38 CDT(-0500)] <Justin_o> colinclark: we need to implement the latest designs, so it seems like a good place to start

[13:34:29 CDT(-0500)] <arashs> colinclark: I have a meeting with her in a bit, I can ask her

[13:36:16 CDT(-0500)] <colinclark> Ok, cool.

[13:46:39 CDT(-0500)] <jessm> anastasiac: ping

[13:51:19 CDT(-0500)] <anastasiac> jessm: pong

[13:51:37 CDT(-0500)] <jessm> anastasiac: is it the case that we have equipment loan ready to go in /dev for IDI?

[13:52:03 CDT(-0500)] <anastasiac> jessm, we have the interface pretty much ready to go. I'm not sure the status of the actual downloadable PDF form

[13:52:25 CDT(-0500)] <jessm> anastasiac: who would know?

[13:52:29 CDT(-0500)] <jessm> or what is to know?

[13:52:35 CDT(-0500)] <anastasiac> I'm checking emails

[13:54:10 CDT(-0500)] <anastasiac> jessm, I recall that the form was sent to OCADU legal for approval, and I think I recall hearing that they finally looked at it

[13:54:27 CDT(-0500)] <anastasiac> but I can't find any official verdict/approval/updated form

[13:54:33 CDT(-0500)] <anastasiac> I wonder if joanna might know

[13:55:05 CDT(-0500)] <anastasiac> jessm, there's also the issue of updating the site with descriptions of the equipment. I believe Pat is prepared to do that, but it would take a bit of time after the site is ready for her

[14:02:22 CDT(-0500)] <anastasiac> jessm, other than that, final deployment would involve 1) re-deployment to the dev site from an existing branch (with any necessary final tweaks), 2) review and approval, and then 3) push to production site.

[14:04:21 CDT(-0500)] <anastasiac> michelled and cindyli: I've issued three pull requests for the video player wordpress plugin to be deployed to the IDI production site. I think it would be a good idea if the code had at least a bit of a review before being put into production. The three pull requests are: plugin https://github.com/acheetham/infusion-videoPlayer-wp-plugin/pull/1 base theme https://github.com/acheetham/wordpress-fss-theme/pull/1 idi-theme

[14:04:21 CDT(-0500)] <anastasiac> https://github.com/acheetham/idi-theme/pull/1

[14:05:26 CDT(-0500)] <anastasiac> wait, those pull requests are on the wrong repo - sorry :-/

[14:05:36 CDT(-0500)] <jessm> anastasiac: ok, i'll poke around to find out what the final word is from HR regarding the PDF

[14:05:58 CDT(-0500)] <anastasiac> ok, jessm, I'll get myself ready to post the site updates

[14:09:39 CDT(-0500)] <jessm> anastasiac: my bad, iris just sent me the edits and i just forwarded to you

[14:09:57 CDT(-0500)] <jessm> anastasiac: with those we should be ready to get this in motion if you please

[14:10:03 CDT(-0500)] <anastasiac> okley, jessm

[14:12:37 CDT(-0500)] <anastasiac> michelled and cindyli: the proper pull requests are: https://github.com/inclusive-design/infusion-videoPlayer-wp-plugin/pull/5 and https://github.com/inclusive-design/wordpress-fss-theme/pull/11 and https://github.com/inclusive-design/idi-theme/pull/65

[14:13:25 CDT(-0500)] <cindyli> thanks, anastasiac. I will take a look

[14:13:34 CDT(-0500)] <anastasiac> thanks, cindyli

[14:13:40 CDT(-0500)] <cindyli> np

[15:17:27 CDT(-0500)] <Justin_o> Bosmon: hello, I think we'll need to do the UIO meeting tomorrow instead of today.. hope that's okay..

[15:17:38 CDT(-0500)] <Justin_o> also had a question or two for you, if you have time

[15:17:39 CDT(-0500)] <Bosmon> Hi Justin_o, that's fine

[15:17:54 CDT(-0500)] <Bosmon> How has your branch been getting on?

[15:18:37 CDT(-0500)] <Justin_o> Bosmon: it's progressing.. https://github.com/jobara/infusion/tree/FLUID-4927

[15:20:03 CDT(-0500)] <Justin_o> Bosmon: so one of the question i had for you is if we have something like this in the framework already, or if there is a better approach

[15:20:04 CDT(-0500)] <Justin_o> https://github.com/jobara/infusion/blob/FLUID-4927/src/webapp/tests/component-tests/uiOptions/js/SettingPanelTests.js#L23-L26

[15:20:36 CDT(-0500)] <Justin_o> which is used here https://github.com/jobara/infusion/blob/FLUID-4927/src/webapp/tests/component-tests/uiOptions/js/SettingPanelTests.js#L61-L70

[15:20:49 CDT(-0500)] <Bosmon> Justin_o - We don't currently, the only equivalent is in the IoC testing framework

[15:21:25 CDT(-0500)] <Bosmon> Well, which I see you are using (smile)

[15:21:25 CDT(-0500)] <Justin_o> okay.. so that is in my test, although i think i could use it for the actual component too..

[15:21:46 CDT(-0500)] <Bosmon> So I'm surprised you missed the jquery fixture type : P

[15:22:23 CDT(-0500)] <Bosmon> Ah, interesting

[15:22:31 CDT(-0500)] <Bosmon> You are using it to acquire values for another fixture...

[15:23:24 CDT(-0500)] <Justin_o> Bosmon: yes.. trying to pull values out of the DOM

[15:23:33 CDT(-0500)] <Justin_o> to make sure things are being applied correctly

[15:24:16 CDT(-0500)] <Bosmon> You might be interested in using the "assertNode" capabilities of jqUnit

[15:24:26 CDT(-0500)] <Bosmon> Which allow these kinds of DOM-based tests to be expressed more compactly

[15:25:35 CDT(-0500)] <Bosmon> Justin_o ^

[15:26:03 CDT(-0500)] <Justin_o> Bosmon: thanks, sorry was looking for it.. found it just now in the jqUnit-browser.js file

[15:26:43 CDT(-0500)] <Bosmon> I guess this should be documented a bit better!

[15:26:48 CDT(-0500)] <Bosmon> I see the comment is somewhat inaccurate

[15:27:26 CDT(-0500)] <Justin_o> Bosmon: (smile) is there a list of keys that this object could hold?

[15:28:27 CDT(-0500)] <Bosmon> https://github.com/fluid-project/infusion/blob/master/src/webapp/tests/framework-tests/renderer/js/RendererTests.js#L348-L354

[15:28:36 CDT(-0500)] <Bosmon> You can see some examples here in the Renderer Tests

[15:28:48 CDT(-0500)] <Justin_o> Bosmon: thanks..

[15:29:14 CDT(-0500)] <Bosmon> It can hold arbitrary keys which will be interpreted as arbitrary DOM attributes

[15:29:21 CDT(-0500)] <Bosmon> As well as a few fixed keys you can see in the impl

[15:29:37 CDT(-0500)] <Bosmon> "nodeText" "nodeName" and "nodeHTML"

[15:29:57 CDT(-0500)] <Bosmon> And then the key "children" can hold an array which will continue to issue fixtures against the node's children

[15:31:54 CDT(-0500)] <Justin_o> Bosmon: great thanks.. i'll modify the tests to use that instead

[15:32:09 CDT(-0500)] <Justin_o> Bosmon: i have a couple other files you may be interested in look at

[15:32:11 CDT(-0500)] <Justin_o> https://github.com/jobara/infusion/blob/FLUID-4927/src/webapp/components/uiOptions/js/SettingView.js

[15:32:22 CDT(-0500)] <Justin_o> which is the grade to provide a common api with renderComponents

[15:32:46 CDT(-0500)] <Justin_o> Bosmon: and this one here is the panel portion of the setting

[15:32:47 CDT(-0500)] <Justin_o> https://github.com/jobara/infusion/blob/FLUID-4927/src/webapp/components/uiOptions/js/SettingPanel.js

[15:33:08 CDT(-0500)] <Justin_o> hopefully that will work with UIO's fetch resources

[15:48:52 CDT(-0500)] <Bosmon> Justin_o - which part of SettingView's implementation uses the "eventedModel" grade?

[15:50:01 CDT(-0500)] <Bosmon> Also - do you have an concrete implementation of a "settingPanel" showing it in use with a concrete one of our panels?

[15:50:36 CDT(-0500)] <Justin_o> Bosmon: it doesn't use it itself.. it's there for model management, but the component using that as a grade would need to wire it up itself..

[15:50:55 CDT(-0500)] <Justin_o> Bosmon: working on something that uses the setting panel.. starting in on the contrast setting now

[15:51:01 CDT(-0500)] <Justin_o> but won't have that done today likely

[15:51:03 CDT(-0500)] <Bosmon> Justin_o - cool, that will be interesting to see

[15:51:28 CDT(-0500)] <Bosmon> Can you summarise what features, in particular, this new architecture has that our old means of dealing with panels doesn't?

[15:51:35 CDT(-0500)] <Bosmon> This is a great colinclark-style question (smile)

[15:52:03 CDT(-0500)] <Justin_o> Bosmon: (smile) let me think up an appropriate answer

[16:00:43 CDT(-0500)] <Justin_o> Bosmon: i guess to be honest, i probably don't fully understand how they were originally implemented.. a quick look over it and i think the only thing that I really added was to abstract out the common bits.. so rendering out the title basically.. also it has a subcomponent to render out the widget.. so the options will not be top level.. probably all model based

[16:00:53 CDT(-0500)] <Justin_o> so in a nutshell, not much (wink)

[16:08:39 CDT(-0500)] <Justin_o> Bosmon: question about the assertNode

[16:08:59 CDT(-0500)] <Justin_o> Bosmon: is there a way to just know if a single class is on there, if I don't care about the rest

[16:09:51 CDT(-0500)] <Bosmon> Justin_o - it sounds like a useful extension (smile)

[16:22:59 CDT(-0500)] <Justin_o> Bosmon: (smile)

[17:04:45 CDT(-0500)] <Justin_o> Bosmon: how does this look for an extension to assertNode https://github.com/jobara/infusion/compare/FLUID-4931

[17:04:47 CDT(-0500)] <Justin_o> ?

[17:05:39 CDT(-0500)] <Bosmon> Justin_o - reasonable - you should be prepared for an array of values, I think

[17:07:01 CDT(-0500)] <Justin_o> Bosmon: okay, i think jQuery's hasClass takes a string.. so i can look at modifying an array to a string i guess

[17:07:48 CDT(-0500)] <Justin_o> i have to run now, but i'll take a look tomorrow.. if you have more comments feel free to comment on my branch or on the jira http://issues.fluidproject.org/browse/FLUID-4931

[17:07:49 CDT(-0500)] <Justin_o> thanks