fluid-work IRC Logs-2013-02-15

Owned by Fluid IRC Log Bot
Last updated: Feb 15, 2013Version comment
5 min read

[13:45:17 CST(-0600)] <michelled> Justin_o: I really feel it's time to ditch this: build.fluidproject.org/infusion/integration-demos/uportal/html/portal.html

[13:45:25 CST(-0600)] <michelled> we constantly break it without noticing

[13:45:36 CST(-0600)] <michelled> it doesn't seem like we are helping anyone with it

[13:46:55 CST(-0600)] <Justin_o> michelled: okay (smile)

[13:47:18 CST(-0600)] <Justin_o> i think we had it there just so we could have a place where we had integrated several of our components into a single demo

[13:47:24 CST(-0600)] <Justin_o> i'm not sure that's necessary anymore

[13:47:45 CST(-0600)] <michelled> Justin_o: I guess I'll make a JIRA for it

[13:48:34 CST(-0600)] <Justin_o> michelled: okay.. sounds good

[13:50:29 CST(-0600)] <colinclark> +1 for ditchage

[13:50:35 CST(-0600)] <colinclark> if that is a word (smile)

[14:24:49 CST(-0600)] <michelled> Justin_o: is it known that there are unit tests failing in IE9?

[14:25:02 CST(-0600)] <Justin_o> michelled: i'm not sure

[14:25:09 CST(-0600)] <Justin_o> are there a lot?

[14:25:36 CST(-0600)] <Justin_o> I think when i was making some changes recently i did notice that something for up loaders file queue view tests i think was failing in some IE's

[14:25:48 CST(-0600)] <Justin_o> i didn't get around to looking for / writing a jira

[14:26:04 CST(-0600)] <Justin_o> michelled: ^

[14:26:07 CST(-0600)] <michelled> Image Reorderer tests for example

[14:26:15 CST(-0600)] <Justin_o> michelled: not sure about those

[14:26:16 CST(-0600)] <michelled> but yes, it looks like a lot of tests

[14:26:46 CST(-0600)] <michelled> they are failing on the build site, but I don't' know when that started

[14:27:46 CST(-0600)] <Justin_o> michelled: (sad)

[14:27:50 CST(-0600)] <michelled> can you see if they fail for you too? just in case it's my VM?

[14:27:59 CST(-0600)] <Justin_o> michelled: i'll take a look

[14:29:30 CST(-0600)] <Justin_o> michelled: lots of red

[14:32:34 CST(-0600)] <michelled> Justin_o: I'm really close to pushing the GINGER WORLD pull request

[14:32:44 CST(-0600)] <michelled> Justin_o: I'm not sure what I should do about IE

[14:32:53 CST(-0600)] <michelled> this stuff is failing in current master

[14:33:03 CST(-0600)] <michelled> and also in the ginger world branch

[14:33:44 CST(-0600)] <Justin_o> michelled: i guess file a jira for it.. we'll have to get it fixed by the next release, but it doesn't seem like it should hold up the pull request if it's all working..

[14:38:23 CST(-0600)] <michelled> Bosmon: had you noticed the failing IE 9 tests?

[14:40:51 CST(-0600)] <Bosmon> michelled - I hadn't, I rarely succeed in running IE tests on my machien

[14:41:08 CST(-0600)] <Bosmon> Justin_o - have you had any more conversations recently with avtar about getting a testswarm running for us?

[14:41:51 CST(-0600)] <Justin_o> Bosmon: not for a week or so,

[14:41:55 CST(-0600)] <michelled> Bosmon: did you test the components in IE?

[14:42:02 CST(-0600)] <Justin_o> not sure when that will be done yet

[14:43:08 CST(-0600)] <Bosmon> I have been rewriting the ProgressiveEnhancement system to "new framework standards" last night

[14:43:34 CST(-0600)] <Bosmon> I did find a few issues with your version that I failed to be careful enough when doing the reviewing earlier in the week....

[14:43:50 CST(-0600)] <Bosmon> i) In one of your test cases, you had failed to clean up the tags "cat" and "dog" from the staticEnvironment before finishing

[14:44:33 CST(-0600)] <Bosmon> and ii) I think that many of the new definitions you added to ProgressiveEnhancement.js should have been marked with "non-API" comments - unless we want to commit ourselves to releasing Fluid 7.0 by 2014 (smile)

[14:45:03 CST(-0600)] <colinclark> tidying up after cats is a constant effort

[14:45:04 CST(-0600)] <Bosmon> For example things like fluid.enhance.typeToKey, the store fluid.enhance.checked, etc.

[14:46:44 CST(-0600)] <Bosmon> I'm just fixing these in my branch as I go along, since the merge work would become too awkward otherwise...

[14:46:53 CST(-0600)] <Bosmon> Yes, mine has just done quite a big PEEE (smile)

[14:47:25 CST(-0600)] <Justin_o> Bosmon: thanks for the clean up

[14:50:20 CST(-0600)] <michelled> Bosmon: the layout reordered doesn't work in IE9 in the GINGER WORLD branch

[14:51:57 CST(-0600)] <Bosmon> michelled - I see the test cases passing though

[14:51:59 CST(-0600)] <Bosmon> Do you too?

[14:52:54 CST(-0600)] <michelled> hmmm… no, I don't (sad)

[14:53:50 CST(-0600)] <michelled> gah - caching issue (sad)

[14:53:55 CST(-0600)] <michelled> let me try some more testing

[14:54:16 CST(-0600)] <Bosmon> Just looking into the image reorderer issues.... it seems that as usual they are caused by "focus" issues

[14:54:51 CST(-0600)] <Bosmon> Whatever we do in "focusLightbox" isn't good enough for IE9 to consider we have focused anything and so all the tests begin with "activeItem" set to undefined

[14:54:56 CST(-0600)] <Bosmon> So naturally they all fail

[14:55:02 CST(-0600)] <colinclark> wow, michelled just gah'ed

[14:55:08 CST(-0600)] <colinclark> sweet

[14:55:09 CST(-0600)] <Bosmon> These focus issues are a "dime a dozen".... : P

[14:57:25 CST(-0600)] <Bosmon> Ah, it's the usual hilarious rubbish

[14:57:32 CST(-0600)] <Bosmon> IE doesn't propagate the focus event synchronously

[14:57:40 CST(-0600)] <Bosmon> So it arrives after the key event that we simulate

[14:58:30 CST(-0600)] <michelled> yzen: how's your Chrome testing going?

[14:58:42 CST(-0600)] <yzen> michelled: im almost done with everything

[14:58:57 CST(-0600)] <yzen> i dont know why but my cookie store does not work, i think i might have something disabled

[14:59:01 CST(-0600)] <Bosmon> michelled, yzen - are you testing the current version of my branch which is merged with the current trunk?

[14:59:02 CST(-0600)] <yzen> so that unit tests fails

[14:59:18 CST(-0600)] <michelled> Bosmon: yes

[14:59:22 CST(-0600)] <Bosmon> cool

[14:59:28 CST(-0600)] <michelled> well, current as of this morning

[14:59:57 CST(-0600)] <Bosmon> Wow, it's so much nicer to debug the new framework.....

[15:00:05 CST(-0600)] <Bosmon> You can step right into invokers without all that trash : P

[15:00:30 CST(-0600)] <michelled> Bosmon: you've pushed more things since yzen and I last chatted with you

[15:00:38 CST(-0600)] <michelled> I suppose we should really review those

[15:00:46 CST(-0600)] <Bosmon> michelled - that was the merge I meant

[15:00:51 CST(-0600)] <Bosmon> But that was from Wednesday

[15:01:20 CST(-0600)] <michelled> yzen: https://github.com/amb26/infusion/commit/12c611e2b2be2c4a150af7ff4eae425db701d15b

[15:01:21 CST(-0600)] <Bosmon> I merged with KINGG's latest progressiveEnhancer, which would have made a mess for you otherwise

[15:01:27 CST(-0600)] <yzen> Bosmon: what about jqUnit update ? are you still going ahead with it ?

[15:01:39 CST(-0600)] <Bosmon> There were a couple of conflicts where I added a test for $.fn to make standalone tests work

[15:01:54 CST(-0600)] <Bosmon> yzen - which jqUnit update do you mean?

[15:02:05 CST(-0600)] <Bosmon> You mean the Qunit update that causes a failure in node?

[15:02:09 CST(-0600)] <yzen> i mean the one that breaks in node

[15:02:10 CST(-0600)] <yzen> yes

[15:02:14 CST(-0600)] <Bosmon> Have you investigated the cause of that yet?

[15:02:21 CST(-0600)] <Bosmon> I mean, I know you found which code is responsible

[15:02:33 CST(-0600)] <Bosmon> But have you discovered the MEANING behind the failure?

[15:02:57 CST(-0600)] <Bosmon> Does it seem as if we should prepare an issue ticket against QUnit?

[15:04:17 CST(-0600)] <yzen> well i think they now assume that IE has a attachEvent method now, I think what it means is that they stopped supporting something iike ie6

[15:05:28 CST(-0600)] <yzen> michelled: ok so all demos work, i only had a failure in cookie store for test for some reason, i tried stepping through and document.cookie is not being writable which seems like some setting i have in chrome ?

[15:06:11 CST(-0600)] <michelled> yzen: we need to review the parts we hadn't looked at

[15:06:25 CST(-0600)] <michelled> the commit I dropped in above

[15:06:28 CST(-0600)] <yzen> sure you want to do it right now ?

[15:06:35 CST(-0600)] <michelled> yeah

[15:06:37 CST(-0600)] <michelled> skype?

[15:06:49 CST(-0600)] <yzen> sure

[15:10:53 CST(-0600)] <Bosmon> michelled - it seems to me that fixing the ImageReorderer test cases would be an excellent job for the new IoC testing framework

[15:11:12 CST(-0600)] <Bosmon> It seems much the best approach for dealing with this unexpected asynchrony in the simulation.....