fluid-work IRC Logs-2013-02-05

Owned by Fluid IRC Log Bot
Last updated: Feb 05, 2013Version comment
6 min read

[11:35:39 CST(-0600)] <Justin_o> anastasiac: I found that there are some newly failing unit tests in cindy's branch.. unfortunately she is away.. do you have time to take a peak at it and see if you can fix those tests

[11:40:34 CST(-0600)] <anastasiac> Justin_o, sure - could you provide a link to the branch?

[11:43:26 CST(-0600)] <Justin_o> anastasiac: will do.

[11:43:45 CST(-0600)] <Justin_o> anastasiac: here's the pull request https://github.com/fluid-project/videoPlayer/pull/109

[11:44:00 CST(-0600)] <anastasiac> got it, Justin_o, I'll have a look

[11:44:07 CST(-0600)] <Justin_o> anastasiac: thanks

[11:46:02 CST(-0600)] <Justin_o> anastasiac: the problem i noticed was in Video Player Controls Integration Test Suite for Firefox and IE9

[11:46:16 CST(-0600)] <anastasiac> FF and IE9, got it

[11:47:13 CST(-0600)] <Justin_o> anastasiac: you may want to double check if there are more, but that was the one I saw

[12:05:14 CST(-0600)] <system64> I'm a passionate web developer, currently pursuing Mathematics and Computer Science. Is there anyway I can contribute to fluid project?

[12:06:06 CST(-0600)] <system64> I enjoy working with web technologies, and love semantic code (smile)

[12:08:13 CST(-0600)] <anastasiac> Justin_o, I'm not getting any failures with the video controls integration test suite in FF or in IE9

[12:08:29 CST(-0600)] <anastasiac> I've got cindy's 4853 branch

[12:12:10 CST(-0600)] <Justin_o> anastasiac: really

[12:12:23 CST(-0600)] <Justin_o> so no failing unit tests at all for those ones

[12:12:34 CST(-0600)] <anastasiac> I just ran all-tests in FF - no failures

[12:13:17 CST(-0600)] <Justin_o> anastasiac: now it's passing on mine too

[12:13:18 CST(-0600)] <Justin_o> (sad)

[12:13:24 CST(-0600)] <Justin_o> i guess it was your magic touch again

[12:13:30 CST(-0600)] <anastasiac> (smile)

[12:13:49 CST(-0600)] <Justin_o> anastasiac: can you turn things to gold too?

[12:14:13 CST(-0600)] <colinclark> Hi system64, it's nice to meet you!

[12:15:04 CST(-0600)] <colinclark> How did you hear about Fluid?

[12:16:27 CST(-0600)] <anastasiac> Justin_o, there are still some failures in IE9, but not in the controls integration tests

[12:16:46 CST(-0600)] <Justin_o> anastasiac: are they new failures or also on the build site?

[12:18:41 CST(-0600)] <anastasiac> Justin_o, the videoPlayerIntegration tests fail differently, others the same

[12:18:49 CST(-0600)] <system64> colinclark: thanks for your reply, I wanted to take part in GSOC 2012 last year. But couldn't complete my application. The projects of IDI go well with my stack.

[12:18:59 CST(-0600)] <colinclark> Ah, cool

[12:19:35 CST(-0600)] <colinclark> Is there anything you're particularly interested in getting involved with, system64?

[12:20:13 CST(-0600)] <Justin_o> anastasiac: that's strange i'm getting those behaving the same in IE9

[12:20:43 CST(-0600)] <system64> It will be nice to do anything, even a bug fix to start with. I'm relatively new to contributing to open source projects.

[12:21:41 CST(-0600)] <anastasiac> Justin_o, for me, the build site fails test #2 and hangs on test #5. Cindy's branch passes all and gets an 'unspecified error' global failure as #6

[12:23:04 CST(-0600)] <colinclark> Cool. I think Justin_o or michelled can probably point you at some interesting bugs or little tasks to get started with, system64.

[12:23:34 CST(-0600)] <Justin_o> anastasiac: i'm getting the global failure on both

[12:25:38 CST(-0600)] <system64> colinclark: thanks, where can I see the bugs or issues?

[12:25:54 CST(-0600)] <colinclark> http://issues.fluidproject.org

[12:37:24 CST(-0600)] <Justin_o> michelled: here is a pull request for our progressive enhancement stuff in infusion https://github.com/fluid-project/infusion/pull/261

[12:41:09 CST(-0600)] <michelled> thx Justin_o

[12:41:22 CST(-0600)] <michelled> Justin_o, colinclark: yzen and I are reviewing the GINGER WORLD pull request

[12:41:45 CST(-0600)] <michelled> we noticed that an API that was deprecated in 1.3 was removed

[12:41:59 CST(-0600)] <michelled> is that ok? in the code base it says it will be removed in 1.6

[12:44:05 CST(-0600)] <Justin_o> michelled: (sad) i guess we had expected to release 1.5 much earlier

[12:44:55 CST(-0600)] <michelled> the API that is removed is the first parameter to fluid.defaults http://wiki.fluidproject.org/display/docs/fluid.defaults

[12:45:03 CST(-0600)] <michelled> honestly, I didn't even remember that API existed

[12:45:07 CST(-0600)] <michelled> I wonder if anyone uses it at all

[12:45:18 CST(-0600)] <michelled> I think it's ok to remove, but I figured I should surface the change

[12:45:21 CST(-0600)] <michelled> what do you think?

[12:46:22 CST(-0600)] <Justin_o> michelled: i didn't know about that option

[12:47:54 CST(-0600)] <Justin_o> michelled: i guess we need to make sure we stick to these guidelines http://wiki.fluidproject.org/display/fluid/Fluid+Versioning+Scheme

[12:56:47 CST(-0600)] <Justin_o> heidiv: cindy's FLUID-4853 pull request has been merged into the project repo now

[12:57:16 CST(-0600)] <heidiv> Justin_o k!

[12:59:35 CST(-0600)] <Justin_o> jhung: this one is still marked as a blocker for VP, but it wasn't on our short list. http://issues.fluidproject.org/browse/VP-123

[12:59:41 CST(-0600)] <Justin_o> should it be moved down to critical?

[13:00:37 CST(-0600)] <heidiv> Justin_o be nice to fix that one. it felt quite brokeny when i was doing fullscreen work.

[13:00:55 CST(-0600)] <heidiv> but it's not a show stopper

[13:01:16 CST(-0600)] <jhung> Yeah. I agree heidiv.

[13:01:29 CST(-0600)] <jhung> It be nice to fix, but it still "works".

[13:01:36 CST(-0600)] <jhung> Just requires 2 clicks.

[13:02:28 CST(-0600)] <jhung> So put it as a critical Justin_o. That okay heidiv?

[13:02:36 CST(-0600)] <heidiv> yep

[13:02:44 CST(-0600)] <Justin_o> jhung: thanks

[13:05:21 CST(-0600)] <jhung> justin_o: there's a pull request for VP-123?

[13:06:01 CST(-0600)] <Justin_o> jhung: nope

[13:07:19 CST(-0600)] <jhung> anastasiac: on http://wiki.fluidproject.org/display/fluid/FLOE+Video+Player+Development+Planning under VP-123, are those notes still applicable?

[13:08:55 CST(-0600)] <anastasiac> jhung, I think that's out of date. I think the work michelled and Justin_o are doing on progressive enhancement might somehow supplant that work

[13:09:56 CST(-0600)] <jhung> ok thanks

[13:56:10 CST(-0600)] <Bosmon> yzen, michelled - are you there?

[13:56:18 CST(-0600)] <michelled> yep, we are here

[13:59:49 CST(-0600)] <Bosmon> Hi Justin_o - thanks again for those reports from last year

[13:59:59 CST(-0600)] <Bosmon> Don't think because it took so long to get to them that they weren't appreciated (smile)

[14:00:26 CST(-0600)] <Bosmon> So far I have dealt with FLUID-4631 amd FLUID-4634

[14:00:43 CST(-0600)] <Bosmon> Looking at FLUID-4637 now, looks pretty bizarre (smile)

[14:03:06 CST(-0600)] <Justin_o> Bosmon: (smile) no problem, glad to help.. and thanks for looking into these.

[14:07:03 CST(-0600)] <Justin_o> Bosmon: i'm trying to upgrade the version of jqUnit used by the Video Player, while we won't have time to start using the new IoC based tests, we wanted it in place for when we do. I'm assuming i just need to change the module part to be jqUnit.module("… "); and the tests to be jqUnit.test and jqUnit.asyncTest. However, i'm getting failures around jqUnit.exists not being a function

[14:07:08 CST(-0600)] <Justin_o> did i miss some other change?

[14:11:56 CST(-0600)] <Bosmon> Justin_o - you need to also include the file jqUnit-browser.js

[14:12:09 CST(-0600)] <Justin_o> Bosmon: ah okay.. thanks

[14:12:28 CST(-0600)] <Bosmon> It has been factored into two files so we can centralise those definitions which are common to both the browser and the node.js environments

[14:12:40 CST(-0600)] <Justin_o> Bosmon: that makes sense..

[14:12:44 CST(-0600)] <Bosmon> In our npm module there is a corresponding file jqUnit-node.js which includes definitions specific to node.js

[14:13:15 CST(-0600)] <Bosmon> That module currently only lives in the GPII source tree but we should think about putting it somewhere else when we have our "big kettle refactoring" that yzen is planning

[14:14:43 CST(-0600)] <Justin_o> Bosmon: (smile) i was just going to ask you where that was

[14:44:07 CST(-0600)] <Justin_o> Bosmon: do you have a minute to look at my pull request for FLUID-4794

[14:44:07 CST(-0600)] <Justin_o> https://github.com/fluid-project/infusion/pull/261

[14:44:41 CST(-0600)] <Bosmon> Justin_o - it's a good start

[14:44:52 CST(-0600)] <Bosmon> And now leaves the issue of how the client is expected to determine what "stuff to forget" (smile)

[14:44:54 CST(-0600)] <colinclark> What's a "stuff," Justin_o?

[14:46:42 CST(-0600)] <Bosmon> Also I think you may not have read the behaviour of "progressiveCheckerForComponent" correctly

[14:46:57 CST(-0600)] <Bosmon> Can you explain how the user could have the same effect using the functions you've described as a replacement?

[14:47:28 CST(-0600)] <Justin_o> colinclark: anything you'd like really.. but specifically something that would be in the static environment..

[14:47:49 CST(-0600)] <colinclark> Justin_o: But presumably the "stuff" is actually some kind of formal data structure?

[14:47:55 CST(-0600)] <Justin_o> Bosmon: i figured we'd drop most of what was there and really more on the IoC system for context resolution instead

[14:48:18 CST(-0600)] <Bosmon> Justin_o - but this checker is precisely what enables the IoC system to be used

[14:48:23 CST(-0600)] <Justin_o> colinclark: it would be a typeTag in the static environment

[14:48:35 CST(-0600)] <Bosmon> You should go and review its use in the Uploader in order to remind yourself of what this function does

[14:49:01 CST(-0600)] <colinclark> Bosmon: To be fair, it's pretty complex logic

[14:49:26 CST(-0600)] <colinclark> perhaps it will be more helpful to talk/type it through if something is unclear?

[14:50:10 CST(-0600)] <Bosmon> colinclark - sure

[14:51:43 CST(-0600)] <Bosmon> We should really have some better diagrams for this kind of thing...

[14:51:57 CST(-0600)] <Bosmon> It might just about be possible to work it out by means of squinting at the one in our paper : P

[14:56:08 CST(-0600)] <Justin_o> Bosmon: do you have something i can look at.. i guess my assumption is that if it is in the staticEnvironement it should be resolvable through the demands system

[14:57:42 CST(-0600)] <Justin_o> Bosmon: is it because these would need to act on the top level component itself and demands won't affect that one

[14:57:43 CST(-0600)] <Justin_o> ?