fluid-work IRC Logs-2013-02-04

[08:26:43 CST(-0600)] <kasper__> ping yzen

[08:27:08 CST(-0600)] <yzen> kasper_:

[08:28:10 CST(-0600)] <kasper_> yzen: I cant get the windows registry resolver working for some reason

[08:28:29 CST(-0600)] <yzen> kasper_: are you trying the pull request ?

[08:28:44 CST(-0600)] <yzen> that thing was never in master if your remember

[08:28:47 CST(-0600)] <kasper_> is there a pull request for the resolver?

[08:28:49 CST(-0600)] <kasper_> oh, wow

[08:28:55 CST(-0600)] <kasper_> we're so damn slow

[08:29:01 CST(-0600)] <yzen> yes it's about 10months old

[08:29:06 CST(-0600)] <kasper_> jesus

[08:29:11 CST(-0600)] <yzen> probably needs updating too

[08:34:59 CST(-0600)] <kasper_> yzen.. thanks for pointing that pull request out .. I completely forgot about it

[08:35:17 CST(-0600)] <kasper_> yzen, so I still have a question

[08:35:21 CST(-0600)] <kasper_> we have:

[08:35:28 CST(-0600)] <kasper_> https://github.com/GPII/windows/blob/master/gpii/node_modules/registryResolver/src/RegistryResolver.js

[08:35:45 CST(-0600)] <kasper_> which isn't used by the universal pull request

[08:35:58 CST(-0600)] <kasper_> it allows one to do: http://wiki.gpii.net/index.php/Lifecycle_Handler#Refering_to_Windows_Registry_values

[08:36:43 CST(-0600)] <kasper_> which would mean that we dont require to do this: https://github.com/yzen/universal/commit/711a197e2de2ba486d4ce34c985214af87501321#L2R53 for all new applications

[08:38:13 CST(-0600)] <kasper_> but currently it's not usable by the lifecyclemanager, as it requires that it's defined as a resolver (https://github.com/GPII/universal/blob/master/gpii/node_modules/lifecycleManager/src/LifecycleManager.js#L78-L96)

[08:38:15 CST(-0600)] <yzen> kasper_: well it probably is not that well factored

[08:38:25 CST(-0600)] <yzen> what we'd want is a generic registry accessor function

[08:38:37 CST(-0600)] <yzen> that would take arguments that we would be able to encode in json

[08:39:22 CST(-0600)] <yzen> for example

[08:39:26 CST(-0600)] <yzen> look at the final pull request

[08:39:32 CST(-0600)] <yzen> there's no need to write any function there

[08:39:36 CST(-0600)] <yzen> as far as i can tell

[08:39:57 CST(-0600)] <kasper_> what pull request are we talking about?

[08:40:00 CST(-0600)] <kasper_> this one? https://github.com/yzen/universal/commit/711a197e2de2ba486d4ce34c985214af87501321#L2R53

[08:40:50 CST(-0600)] <yzen> ya, isnt the final just have an exec

[08:41:17 CST(-0600)] <yzen> https://github.com/GPII/universal/pull/46/files#L4R50

[08:43:56 CST(-0600)] <kasper_> yzen: ok, so far so good

[08:44:23 CST(-0600)] <yzen> kasper_:

[08:44:31 CST(-0600)] <kasper_> but then, isn't it an issue that the universal repo points to something defined in the windows repo – if one launches GPII in windows

[08:45:13 CST(-0600)] <yzen> kasper_: yes, that's a legitimate concern, we need to figure out whether it actually make sense to be there or not

[08:46:01 CST(-0600)] <kasper_> I dont think it does – but is there a way to add the registry resolver to the lifecycleManager component from within windows' RegistryResolver.js

[08:46:04 CST(-0600)] <kasper_> ?

[08:46:26 CST(-0600)] <yzen> kasper_: well yes. as long as the module is imported properly it should just work

[08:46:34 CST(-0600)] <kasper_> yzen: btw, just tagged v0.1 on github .. hit 500 commit's exactly

[08:46:44 CST(-0600)] <yzen> kasper_: AWESOME

[13:03:06 CST(-0600)] <michelled> Bosmon: the KING and I have been looking at cindyli's pull request for show hide

[13:03:58 CST(-0600)] <Bosmon> Have you also been dancing and making plans for the governance of SIAM?

[13:04:16 CST(-0600)] <michelled> we were wondering why we need a totalTimeToScrubber component, instead of just adding a modelChanged listener on totalTime

[13:04:17 CST(-0600)] <michelled> https://github.com/fluid-project/videoPlayer/pull/109/files

[13:04:33 CST(-0600)] <michelled> of course I've been dancing!

[13:04:39 CST(-0600)] <michelled> and actually trying to convince the KING that he should too

[13:06:01 CST(-0600)] <Justin_o>

[13:06:59 CST(-0600)] <Bosmon> I agree that there is no need for this component

[13:08:02 CST(-0600)] <Justin_o> cindyli: ^

[13:27:43 CST(-0600)] <Justin_o> cindyli: i think you missed this discussion http://wiki.fluidproject.org/display/fluid/fluid-work+IRC+Logs-2013-02-04 when you went offline

[13:27:52 CST(-0600)] <Justin_o> what are your thoughts?

[13:29:26 CST(-0600)] <cindyli> Justin_o: thanks for letting me know. I'm fine with adding a listener for total time

[13:42:06 CST(-0600)] <Justin_o> jhung_away: are you able to try out heidi's FLUID-4889 branch and see if it looks okay

[13:53:26 CST(-0600)] <jhung_away> Justin_o: I've had no luck recently trying to clone thing from github. Maybe you can show me tomorrow morning?

[13:53:59 CST(-0600)] <Justin_o> okay

[13:54:05 CST(-0600)] <Justin_o> or if you want i can screen share.. up to yo

[13:54:06 CST(-0600)] <Justin_o> you

[13:54:16 CST(-0600)] <jhung> sure screen share is good.

[13:55:10 CST(-0600)] <Justin_o> jhung: okay.. i'm just running through some tests of another pull request.. i'll ping you when i'm ready. is that okay?

[13:55:17 CST(-0600)] <jhung> sure

[14:22:09 CST(-0600)] <Justin_o> cindyli: we merged in your fluid-4826 branch as is

[14:22:58 CST(-0600)] <cindyli> oh, ok. thanks, Justin_o. so the decision is to ignore the IE8 failure?

[14:24:10 CST(-0600)] <Justin_o> cindyli: sadly for now yes

[14:24:48 CST(-0600)] <cindyli> alrite

[14:24:59 CST(-0600)] <Justin_o> cindyli: would you be able to file a jira for it though

[14:25:14 CST(-0600)] <cindyli> sure, Justin_o

[14:25:43 CST(-0600)] <Justin_o> thanks

[16:14:28 CST(-0600)] <yzen> thanks Bosmon

[16:14:48 CST(-0600)] <Bosmon> np

[16:14:57 CST(-0600)] <Bosmon> yzen - continuing discussion about npm install in fluid-tech