fluid-work IRC Logs-2012-01-11

Owned by Fluid IRC Log Bot
Last updated: Jan 11, 2012Version comment
5 min read

[08:10:50 CST(-0600)] <yura1> kasper: ayt?

[08:12:17 CST(-0600)] <kasper> yeah

[08:13:19 CST(-0600)] <kasper> yura1: ^

[08:18:04 CST(-0600)] <yura1> kasper: do you still have that link somewhere with instructions about git svn mirror ? that we used for cspace

[08:18:59 CST(-0600)] <kasper> yura1: yeah, I'd think so… give me a sec

[08:19:23 CST(-0600)] <yura1> thanks, kasper

[08:19:33 CST(-0600)] <kasper> this one? http://wiki.collectionspace.org/display/collectionspace/Experimenting+with+GitHub+for+CollectionSpace

[08:20:40 CST(-0600)] <kasper> oh, I guess this one is about setting up github for individual usage.. not the whole mirror deal

[08:20:51 CST(-0600)] <kasper> so.. are we talking about the link you originally gave me?

[08:21:02 CST(-0600)] <kasper> yura1: ^

[08:21:57 CST(-0600)] <yura1> ya the link (smile)

[08:22:49 CST(-0600)] <kasper> yura1: Looks like I wrote some stuff down a while ago

[08:22:54 CST(-0600)] <kasper> which has the link at the top

[08:22:55 CST(-0600)] <kasper> http://wiki.collectionspace.org/display/~kaspermarkus/Setting+up+svn+sync+to+github

[08:23:38 CST(-0600)] * kasper is wildly impressed with himself

[08:23:42 CST(-0600)] <kasper> (smile)

[08:26:10 CST(-0600)] <yura1> kasper: wow, i could not find that (smile)

[10:51:49 CST(-0600)] <abledaccess> Michelle what happened to the admin styles?

[10:52:43 CST(-0600)] <michelled> abledaccess: do you mean the changes we made?

[10:52:59 CST(-0600)] <michelled> we put them into the style-admin.css file https://github.com/fluid-project/studios.fluidproject.org/blob/development/wp-content/themes/fluid-studios/style-admin.css

[10:58:12 CST(-0600)] <abledaccess> That's it. Thanks. How is it called?

[10:59:41 CST(-0600)] <michelled> abledaccess: it gets included in the admin head using a wordpress hook: https://github.com/fluid-project/studios.fluidproject.org/blob/development/wp-content/themes/fluid-studios/functions.php#L56

[11:09:55 CST(-0600)] <abledaccess> Oh, great. Just tryingg to keep things tidy. Wonderful. I need to pay closer attention. Regarding the post thumbnails, it out puts invalid code. Is there a problem with setting explicit width of 240 and height of 160? There is a way of setting image dimensions on import. I'd have to hunt for the solution. Would that be preferred?

[11:19:26 CST(-0600)] <michelled> abledaccess: cindyli may have more insight into that. Our thumbnail size handling is certainly a bit smelly since it requires two different things - the code that we've added to function.php and setting the size in the admin interface when we install studios

[11:20:12 CST(-0600)] <michelled> abledaccess: take a look at the read me to see what we do with a new instance of studios: https://github.com/fluid-project/studios.fluidproject.org/blob/development/README.txt

[11:23:46 CST(-0600)] <cindyli> abledaccess: can you elaborate your question? where's the invalid code get outputted?

[11:28:04 CST(-0600)] <abledaccess> My mistake. I didn't set the image dimensions correctly in the settings>media pane. I figured it out. No worries. Thanks.

[11:38:02 CST(-0600)] <michelled> np - it's great to have someone taking a fresh look at what we did with studios

[14:26:39 CST(-0600)] <cindyli> michelled, anastasiac, as u've known the use of our invokers is as -

[14:26:40 CST(-0600)] <cindyli> invokers: {

[14:26:40 CST(-0600)] <cindyli> invokerName1: {

[14:26:40 CST(-0600)] <cindyli> funcName: "name.of.implementation.function1",

[14:26:40 CST(-0600)] <cindyli> args: [...]

[14:26:40 CST(-0600)] <cindyli> },

[14:26:40 CST(-0600)] <cindyli> invokerName2: {

[14:26:41 CST(-0600)] <cindyli> funcName: "name.of.implementation.function2",

[14:26:42 CST(-0600)] <cindyli> args: [...]

[14:26:42 CST(-0600)] <cindyli> }

[14:26:42 CST(-0600)] <cindyli> ...

[14:26:43 CST(-0600)] <cindyli> }

[14:26:56 CST(-0600)] <cindyli> in this case funcName must be a known string

[14:27:05 CST(-0600)] <cindyli> i wonder if it could be a variable

[14:27:47 CST(-0600)] <anastasiac> cindyli, could you give a more specific example of what you want to do?

[14:27:48 CST(-0600)] <cindyli> a variable that's generated from script

[14:27:56 CST(-0600)] <anastasiac> ah

[14:28:31 CST(-0600)] <cindyli> sure, anastasiac, our 4551 jira suggests to use invoker to replace these lines: https://github.com/fluid-project/videoPlayer/blob/master/js/VideoPlayer_media.js#L31-35

[14:29:39 CST(-0600)] <cindyli> to do it, what I can think of is to define variable "renderer" as the funcName of the invoker

[14:30:52 CST(-0600)] <cindyli> as you can see that this variable is dynamically created on the fly and could be one of the many functions that's defined in that.options.mediaRenderers

[14:31:06 CST(-0600)] <cindyli> i wonder if our invoker has a way to support this complexity

[14:32:01 CST(-0600)] <anastasiac> I haven't worked much with invokers, cindyli. I wonder if yura1 might have any suggestions

[14:33:26 CST(-0600)] <anastasiac> though cindyli (and michelled), looking at this renderSources function makes me wonder: why to we, by default, render all of the sources? we don't need to do that, do we?

[14:33:48 CST(-0600)] <anastasiac> Is there something I'm not understanding there?

[14:38:23 CST(-0600)] <cindyli> well, anastasiac, the sources are the video sources or urls that need to be tug into html tag, which by looking at the code is <source> inside <video>. it looks reasonable to me

[14:39:12 CST(-0600)] <anastasiac> yes, but doesn't the html include several <source> tags, to be used in different cases, i.e. when different formats are supported? shouldn't we ultimately be loading only one of them?

[14:39:13 CST(-0600)] <cindyli> it might need a better function name tho

[14:39:20 CST(-0600)] <anastasiac> or maybe I'm completely misunderstanding the <source> tag

[14:39:54 CST(-0600)] <anastasiac> ah, ok, no

[14:39:56 CST(-0600)] <anastasiac> right

[14:40:08 CST(-0600)] <anastasiac> we have one source tag, with an array of sources

[14:40:14 CST(-0600)] <anastasiac> got it

[14:40:18 CST(-0600)] <cindyli> cool

[14:40:55 CST(-0600)] <anastasiac> no, sorry cindyli, I'm still confused (smile)

[14:41:05 CST(-0600)] <anastasiac> for example, look at our demo html file

[14:41:07 CST(-0600)] <cindyli> lol

[14:41:23 CST(-0600)] <anastasiac> our sources has four different versions of the stallman video

[14:41:34 CST(-0600)] <anastasiac> won't this code render all four of them - unnecessarily?

[14:42:22 CST(-0600)] <cindyli> that's right, i agree, unnecessary

[14:42:22 CST(-0600)] <anastasiac> it does

[14:42:38 CST(-0600)] <anastasiac> so maybe we need to completely rethink that function

[14:43:27 CST(-0600)] <anastasiac> ok, no, I think I'm wrong, cindyli

[14:43:35 CST(-0600)] <anastasiac> the word "render" is what's confusing me

[14:43:44 CST(-0600)] <anastasiac> in this case, it just means "output the necessary html"

[14:43:46 CST(-0600)] <anastasiac> I think

[14:43:52 CST(-0600)] <cindyli> exactly

[14:43:54 CST(-0600)] <anastasiac> which we do want to do for each source

[14:44:10 CST(-0600)] <anastasiac> ok, sorry - thanks for putting up with me working this out

[14:44:37 CST(-0600)] <cindyli> haha, you made me re-think of the process

[14:44:44 CST(-0600)] <cindyli> good for us

[14:45:05 CST(-0600)] <anastasiac> yes, you can always count on me for silly questions that make you stop and think for a second (wink)

[14:45:27 CST(-0600)] <cindyli> (smile)