fluid-work IRC Logs-2011-09-30

[08:43:38 CDT(-0500)] <jhung1> justin_o, what is the max filesize for demo version of Uploader?
[08:44:02 CDT(-0500)] <Justin_o> jhung1: i think it's 20 mb
[08:44:17 CDT(-0500)] <jhung1> interesting.
[08:44:38 CDT(-0500)] <jhung1> thanks may have found a bug, but may be something with VMware. will confirm
[08:48:28 CDT(-0500)] <anastasiac> Justin_o, are we still holding off on UIO testing?
[08:48:51 CDT(-0500)] <Justin_o> jhung1: thanks
[08:49:29 CDT(-0500)] <Justin_o> anastasiac: we have to keep waiting till this pull request is merged in https://github.com/fluid-project/infusion/pull/174
[08:49:54 CDT(-0500)] <anastasiac> ok, Justin_o. I'm in the office today, so at least I can help finish the uploader testing
[08:51:03 CDT(-0500)] <Justin_o> anastasiac: thanks
[08:51:46 CDT(-0500)] <jhung1> anastasiac: cool. I;m trying to do the same.
[08:52:31 CDT(-0500)] <colinclark> What's the delay on merging that pull request, Justin_o?
[08:52:36 CDT(-0500)] <jhung1> anastasiac: I seem to be able to upload very large files in Uploader without errors. It would be good to have someone else confirm this...
[08:53:07 CDT(-0500)] <anastasiac> jhung1, how large, and are you expecting errors? is there a threshold at which errors should occur?
[08:53:22 CDT(-0500)] <Justin_o> colinclark: i think cindyli just pushed in here latest set of changes last night, so those probably just need to be reviewed
[08:53:30 CDT(-0500)] <colinclark> ok, great
[08:53:59 CDT(-0500)] <anastasiac> ah, catching up on the channel, I see the 20M limit, jhung1
[08:54:02 CDT(-0500)] <anastasiac> I'll give it a try
[08:54:34 CDT(-0500)] <Justin_o> colinclark: do you remember off hand what the file size cap is in demo version of the uploader?
[08:54:43 CDT(-0500)] <colinclark> 20 MB
[08:54:45 CDT(-0500)] <jhung1> anstasiac: as far as I know, there should be an upper limit of 20MB on Flash uploader, and 100MB with HTML 5.
[08:55:08 CDT(-0500)] <jhung1> It's actually a bug: http://issues.fluidproject.org/browse/FLUID-3990
[08:55:10 CDT(-0500)] <Justin_o> colinclark: okay thanks.. that's what I had though too
[08:55:47 CDT(-0500)] <anastasiac> so jhung1, you're saying you can upload the large file? the bug might be fixed?
[08:56:03 CDT(-0500)] <jhung1> yes, anastasiac.
[08:56:19 CDT(-0500)] <anastasiac> ok. I'll let you know what I find
[08:56:22 CDT(-0500)] <jhung1> Or I'm unable to reproduce it using the current test VM.
[08:56:34 CDT(-0500)] <jhung1> I'm going to try a genuine Win7 machine now anastasiac.
[08:56:41 CDT(-0500)] <anastasiac> k
[08:56:56 CDT(-0500)] <Justin_o> jameswy: see i told you there was a good reason to keep that machine there
[08:59:12 CDT(-0500)] <jameswy> Justin_o: Haha. I still think we should just Boot Camp it on one of the Macs.
[09:00:37 CDT(-0500)] <Justin_o> jameswy: it wouldn't be a bad idea to set up some of the machines with boot camp, and we can use vmware to access the partition most of the time and switch when we want to try them outside of the vm
[09:00:58 CDT(-0500)] <jameswy> Justin_o: Let's do that.
[09:02:15 CDT(-0500)] <Justin_o> jameswy: sounds good.. some time after this release we can set it up
[09:08:35 CDT(-0500)] <jhung1> anastasiac, justin_o: so i'm finding something interesting. I'm able to upload 93MB files in Uploader in IE8 and IE9 on Win 7. On the same session using Firefox, the same file produces a "file is too big" error.
[09:09:07 CDT(-0500)] <Justin_o> jhung1: so a problem with the flash version then i guess
[09:09:28 CDT(-0500)] <jhung1> justin_o: it would appear that way.
[09:09:55 CDT(-0500)] <heidi_> cindyli http://build.fluidproject.org/image-gallery/image-gallery.php down - what's the link to the hourly one again?
[09:10:25 CDT(-0500)] <cindyli> heidi_: http://build.fluidproject.org/uploader/hourly/image-gallery.php
[09:13:03 CDT(-0500)] <anastasiac> jhung, I don't suppose you'd care to drop some large image files onto my computer, would you? it's Fliodhais
[09:24:17 CDT(-0500)] <heidi_> cindyli not sure if my last msg got through but what is the url to the hourly image gallery again? http://build.fluidproject.org/image-gallery/image-gallery.php is down
[09:24:57 CDT(-0500)] <cindyli> yours went thru, but not my reply
[09:24:58 CDT(-0500)] <cindyli> http://build.fluidproject.org/uploader/hourly/image-gallery.php
[09:26:57 CDT(-0500)] <Justin_o> colinclark: i have some license and copyright questions for you if a some time
[09:27:02 CDT(-0500)] <colinclark> yes, for sure
[09:27:33 CDT(-0500)] <Justin_o> 1) do we need to include a license for the rhino and related files we have in the builds scripts directory
[09:28:46 CDT(-0500)] <jhung1> anastasiac, justin_o: I created FLUID-4478 (re: Flash version not rejecting large files)
[09:29:14 CDT(-0500)] <heidi_> thanks cindyli
[09:29:25 CDT(-0500)] <cindyli> np, heidi_
[09:31:28 CDT(-0500)] <colinclark> Justin_o: It certainly wouldn't hurt
[09:32:28 CDT(-0500)] <colinclark> Justin_o: Our use of Rhino is covered under this license: http://www.mozilla.org/MPL/
[09:33:08 CDT(-0500)] <colinclark> The BSF and commons-logging jars are covered under Apache 2.0: http://commons.apache.org/bsf/license.html
[09:33:37 CDT(-0500)] <Justin_o> colinclark: thanks, okay.. a couple more… was jscssp file modified still or was that reverted
[09:33:55 CDT(-0500)] <Justin_o> i saw a commit that said it was upgraded, but wasn't sure if it kept the modifications or not
[09:34:08 CDT(-0500)] <colinclark> michelled: could clarify what modifications we have made
[09:34:20 CDT(-0500)] <colinclark> but certainly we are using a fork of JSCSSP, rather than the original version
[09:35:12 CDT(-0500)] <michelled> Justin_o: we've made several modifications to jscssp
[09:36:01 CDT(-0500)] <Justin_o> michelled, colinclark: thanks.. i guess we should indicate that somewhere.. either in a readme with it, a comment to in it, or in the main readme if we are going to include the build-scripts lib files in there
[09:36:50 CDT(-0500)] <huslage> uploader build is fixed
[09:38:08 CDT(-0500)] <Justin_o> colinclark: i'm trying to go through to update the copyrights too.. for our files.. some have been almost completely rewritten.. how much old code left is enough to retain a copyright?
[09:38:23 CDT(-0500)] <Justin_o> also any idea what Bosmon2's current copyright assignment is?
[09:38:45 CDT(-0500)] <colinclark> Lucendo
[09:38:53 CDT(-0500)] <Justin_o> colinclark: okay, thanks
[09:39:18 CDT(-0500)] <colinclark> Here's his copyright from Fluid.js as a template:
[09:39:19 CDT(-0500)] <colinclark> Copyright 2010 Lucendo Development Ltd.
[09:39:34 CDT(-0500)] <colinclark> So, Justin_o, we should go through the particular cases where substantial changes have happened
[09:40:04 CDT(-0500)] <Justin_o> colinclark: sure.. did you want me to bring them up in the channel or something?
[09:40:20 CDT(-0500)] <colinclark> fire away
[09:40:21 CDT(-0500)] <Justin_o> off the top of my head the biggest ones will be UIEnhancer, ToC, and UIO
[09:40:31 CDT(-0500)] <Justin_o> i have the details for UIEnhancer
[09:40:40 CDT(-0500)] <Justin_o> lines 233 - 235
[09:40:40 CDT(-0500)] <Justin_o> lines 240 - 242
[09:40:40 CDT(-0500)] <Justin_o> lines 279 - 281
[09:40:55 CDT(-0500)] <Justin_o> those are the only things that are identical from before we moved to OCAD
[09:41:20 CDT(-0500)] <Justin_o> and all come from commits in 2009 from michelled
[09:41:37 CDT(-0500)] <Justin_o> i'll look through UIO and ToC now
[09:43:36 CDT(-0500)] <colinclark> Justin_o: amazing!
[09:43:38 CDT(-0500)] <colinclark> You are so detailed!
[09:44:14 CDT(-0500)] <Justin_o> colinclark: thanks, hopefully I caught them all
[09:45:08 CDT(-0500)] <colinclark> I don't even like the code at those lines in UIEnhancer
[09:45:11 CDT(-0500)] <colinclark>
[09:45:28 CDT(-0500)] <colinclark> I think we're such boring boilerplate
[09:46:18 CDT(-0500)] <colinclark> wait, i can't type
[09:46:25 CDT(-0500)] <colinclark> we're not boring boilerplate
[09:46:26 CDT(-0500)] <colinclark> we're awesome
[09:46:30 CDT(-0500)] <Justin_o>
[09:46:33 CDT(-0500)] <colinclark> those lines of code are boring boilerplate
[09:46:35 CDT(-0500)] <colinclark> oh well
[09:46:42 CDT(-0500)] <colinclark> i'm drinking coffee now, it'll get better
[09:47:32 CDT(-0500)] <Justin_o> lol
[10:01:53 CDT(-0500)] <colinclark> So, Justin_o, I think I'd go with a simple and conservative approach to these kinds of licensing questions...
[10:02:07 CDT(-0500)] <colinclark> if there's a reasonable body of code, ensure that the attribution is retained
[10:02:08 CDT(-0500)] <Justin_o> okay
[10:02:20 CDT(-0500)] <colinclark> so, in the case of UIE, it sounds like attribution should be given to UT, OCAD, and Lucendo
[10:02:25 CDT(-0500)] <Justin_o> you wouldn't happen to have a definition for reasonable body of code?
[10:02:31 CDT(-0500)] <colinclark> no, I don't
[10:02:43 CDT(-0500)] <Justin_o>
[10:02:48 CDT(-0500)] <Justin_o> i'll make some judgement calls then
[10:02:54 CDT(-0500)] <colinclark> It's awfully hard to consider a couple of if statements followed by method invocations to be meaningful contributions
[10:03:07 CDT(-0500)] <Justin_o> yep.. make sense
[10:03:13 CDT(-0500)] <colinclark> but I suspect UT's code will soon drift away completely and the we can remove them from the file
[10:03:16 CDT(-0500)] <Justin_o> what do you think about configuration in the defautls
[10:03:17 CDT(-0500)] <colinclark> all in good time
[10:03:19 CDT(-0500)] <Justin_o> defaults
[10:03:22 CDT(-0500)] <colinclark> we're better to be safe and conservative
[10:03:31 CDT(-0500)] <anastasiac> jhung1, I was able to successfully add that large file to the uploader queue and upload it (IE9, Win7, demo version)
[10:03:38 CDT(-0500)] <anastasiac> (VM)
[10:03:42 CDT(-0500)] <colinclark> I think I'd consider it, for this purpose, as equivalent to code, Justin_o
[10:03:58 CDT(-0500)] <Justin_o> colinclark: ah so you are saying we should keep the UT copyright for those
[10:03:59 CDT(-0500)] <jhung1> anastasiac: okay. Thanks!
[10:04:13 CDT(-0500)] <Justin_o> colinclark: that last comment was about the if statements
[10:04:24 CDT(-0500)] <colinclark> Justin_o: I think I would, yes
[10:04:32 CDT(-0500)] <Justin_o> okay
[10:04:43 CDT(-0500)] <cindyli> heidi_: are you testing image gallery hourly build?
[10:04:55 CDT(-0500)] <heidi_> cindyli soon, what's up?
[10:05:23 CDT(-0500)] <cindyli> i'm going to trace down the issue that some of the uploaded files are not displayed
[10:05:39 CDT(-0500)] <cindyli> heidi_: which cannot be reproduced at my local
[10:05:50 CDT(-0500)] <cindyli> so i need to experiment with hourly scripts a bit
[10:06:00 CDT(-0500)] <cindyli> will revert them back to original eventually
[10:06:27 CDT(-0500)] <cindyli> but my changes may affect what you will be seeing
[10:06:56 CDT(-0500)] <cindyli> can you hold off testing it if you have other things to do, heidi_
[10:07:07 CDT(-0500)] <heidi_> cindyli yep i'll check other stuff
[10:07:14 CDT(-0500)] <cindyli> cool. thanks, heidi_
[10:07:16 CDT(-0500)] <heidi_> do we know why the normal build site isn't working?
[10:07:34 CDT(-0500)] <cindyli> it's not loading jquery.js
[10:08:02 CDT(-0500)] <cindyli> seems like wrong folder structure or permission issue, heidi_
[10:08:57 CDT(-0500)] <heidi_> cindyli ok are you fixing that as well?
[10:09:15 CDT(-0500)] <cindyli> huslage: r u trying to bring back http://build.fluidproject.org/image-gallery/image-gallery.php
[10:10:18 CDT(-0500)] <cindyli> no, heidi_, it doesn't seem like the scripting problem. huslage might be working on it
[10:11:09 CDT(-0500)] <cindyli> looking into the hourly build first
[10:11:34 CDT(-0500)] <heidi_> k
[10:12:23 CDT(-0500)] <heidi_> Justin_o UIO testing is on right? we're not waiting for anything?
[10:12:54 CDT(-0500)] <Justin_o> heidi_: we're still waiting on this pull request https://github.com/fluid-project/infusion/pull/174
[10:13:20 CDT(-0500)] <colinclark> Justin_o: is michelled working on that review? ^
[10:14:15 CDT(-0500)] <Justin_o> colinclark: I'm not sure, michelled is it you are Bosmon2 who is going to look at that?
[10:14:51 CDT(-0500)] <michelled> I thought Bosmon2 was going to but if we are at the point where we want to start in on UIO testing then I can
[10:16:31 CDT(-0500)] <michelled> Justin_o: my FF updated itself to 7 - does that mean I can't do FF testing? or do we mean 6+
[10:16:56 CDT(-0500)] <Justin_o> michelled: it's pretty annoying
[10:17:16 CDT(-0500)] <Justin_o> that we get stuck with these changes in the middle of the release
[10:17:35 CDT(-0500)] <Justin_o> if possible i'd rather do FF 6 testing and then switch to FF Current in the next release
[10:17:46 CDT(-0500)] <Justin_o> but if everyone has been updated then we might as well test with the latest
[10:18:05 CDT(-0500)] <michelled> is uploader testing on hold Justin_o? I haven't been following the channel very closely
[10:18:14 CDT(-0500)] <michelled> do we need to get uio testing started?
[10:19:04 CDT(-0500)] <Justin_o> I don't think uploader testing is on hold, unless I missed something too
[10:19:08 CDT(-0500)] <Justin_o> michelled: ^^
[10:19:55 CDT(-0500)] <Justin_o> michelled: and looks like there are some more uploader tasks still left to do
[10:23:37 CDT(-0500)] <Justin_o> michelled: could you please send me a list of the changes that we made in the jscssp file
[10:23:58 CDT(-0500)] <michelled> sure Justin_o
[10:24:05 CDT(-0500)] <Justin_o> thanks
[10:39:21 CDT(-0500)] <Justin_o> fluid-everyone: My standup update. Working on FLUID-4247 to update the copyrights and licenses. Will probably wrap up around 2:30 today.
[10:58:07 CDT(-0500)] <cindyli> huls
[11:00:09 CDT(-0500)] <cindyli> ignore pls :-P
[11:05:11 CDT(-0500)] <colinclark> michelled and Justin_o: I'm just about to head off for the afternoon, until I have to teach in Charles' class this evening...
[11:05:25 CDT(-0500)] <colinclark> but I'm wondering if perhaps it would be useful to summarize where we're at with the release?
[11:06:33 CDT(-0500)] <Justin_o> colinclark: i think so.. I could start, if you want to fill in the missing pieces michelled
[11:06:40 CDT(-0500)] <michelled> sure
[11:07:10 CDT(-0500)] <Justin_o> basically we're done testing except for UIO and Uploader. UIO is still waiting for this pull request to make it's way into the repo https://github.com/fluid-project/infusion/pull/174
[11:07:55 CDT(-0500)] <Justin_o> there are some other release related issues that I'm working on as well. All of these have pull requests except for FLUID-4247, which i'm working on still to update the licenses and copyrights
[11:08:24 CDT(-0500)] <Justin_o> once the testing is all done, we can move on to tagging, testing, announcing and etc for the release
[11:08:26 CDT(-0500)] <colinclark> Justin_o: You'll hand whatever's left of that task to someone when you retire for your nap this afternoon?
[11:08:37 CDT(-0500)] <Justin_o> colinclark: yes, will do
[11:08:37 CDT(-0500)] <colinclark> Uploader testing is progressing okay?
[11:08:48 CDT(-0500)] <michelled> slow and steady
[11:08:49 CDT(-0500)] <colinclark> There was something going on earlier related to builds
[11:08:50 CDT(-0500)] <Justin_o> I think so, there are a few issues left
[11:09:13 CDT(-0500)] <michelled> jhung1: found an IE uploader bug where max file size is being ignored
[11:09:22 CDT(-0500)] <Justin_o> colinclark: i missed that, i think jhung1 was saying something about the file upload cap not working in the flash version for the uploader
[11:09:48 CDT(-0500)] <michelled> do we think that's blocker material?
[11:10:08 CDT(-0500)] <colinclark> nope
[11:10:24 CDT(-0500)] <colinclark> But you guys are the "kings"
[11:10:38 CDT(-0500)] <michelled> my feeling as well but I wasn't sure if I was just rushing to get this out
[11:10:43 CDT(-0500)] <colinclark> lol
[11:11:45 CDT(-0500)] <Justin_o> i'll agree with you both
[11:14:57 CDT(-0500)] <colinclark> okay, so all the Uploader testers are still okay, despite any build breakage on the nightly image gallery instance?
[11:15:01 CDT(-0500)] <colinclark> Justin_o, michelled ^
[11:15:38 CDT(-0500)] <colinclark> Also, what is the status of reviewing the last UIO pull request? Who is doing that and when do we expect it will be done?
[11:15:42 CDT(-0500)] <michelled> as far as I know, that is correct colinclark, although I haven't pinged people individually
[11:16:09 CDT(-0500)] <Justin_o> colinclark: Bosmon2 should be looking at that if he pops up this afternoon
[11:16:15 CDT(-0500)] <michelled> colinclark: since there are still several uploader tests that need to happen, I was holding off on reviewing the UIO patch
[11:16:26 CDT(-0500)] <colinclark> Okay, I'm going to send ol' Bosmon2 a text
[11:16:34 CDT(-0500)] <michelled> if we get done with uploader testing then I'll review it instead of waiting for Bosmon2
[11:16:36 CDT(-0500)] <colinclark> just in case
[11:17:00 CDT(-0500)] <colinclark> okay, so, i'll summarize to make sure I understand everything correctly:
[11:17:09 CDT(-0500)] <colinclark> 1. Uploader testing is progressing
[11:17:21 CDT(-0500)] <colinclark> 2. We have one pull request left to review for UIO, then testing for it can commence
[11:17:40 CDT(-0500)] <colinclark> 3. We have the usual release tidy up: licensing, version numbers, etc. still to do. Justin_o is taking the lead on that, and michelled will help
[11:17:45 CDT(-0500)] <colinclark> Is there anything else I'm missing?
[11:18:52 CDT(-0500)] <Justin_o> colinclark: i think that was it
[11:19:38 CDT(-0500)] <colinclark> Is there anything I can help with before I head off for the afternoon?
[11:22:27 CDT(-0500)] <Justin_o> colinclark: i think i'm okay, you've helped me a bunch already
[11:22:33 CDT(-0500)] <colinclark> great
[11:22:36 CDT(-0500)] <colinclark> michelled: You're cool?
[11:22:46 CDT(-0500)] <colinclark> cindyli: you're always cool, so I won't even ask
[11:22:53 CDT(-0500)] <colinclark> anastasiac: Docs are looking okay?
[11:23:16 CDT(-0500)] <colinclark> huslage: Can't wait to read your latest RFP draft
[11:23:21 CDT(-0500)] <anastasiac> docs are in good shape. It's be nice to get some group review after the release, but I think holes are minimal
[11:23:23 CDT(-0500)] <huslage> pushy
[11:23:26 CDT(-0500)] <colinclark> lol
[11:23:41 CDT(-0500)] <huslage> i can't wait for the people to give me what i asked for so i can write my latest RFP draft
[11:24:00 CDT(-0500)] <michelled> colinclark: yep - I'm fine - getting Justin_o's pull requests in right now
[11:24:18 CDT(-0500)] <Justin_o> michelled: thanks.. i'll try to get the other one wrapped up before i have to head out
[11:24:26 CDT(-0500)] <michelled> sounds good
[11:24:57 CDT(-0500)] <colinclark> heidi_ posted our new job posting to the IDRC web site: http://idrc.ocad.ca/index.php/about-the-idrc/idrc-news/456-were-hiring-a-systems-developer
[11:25:12 CDT(-0500)] <colinclark> If you know any great sysadmin/developer types, pass it on
[11:25:29 CDT(-0500)] <colinclark> I know huslage is eager to have a buddy
[11:25:36 CDT(-0500)] <huslage> i love buddies
[11:25:46 CDT(-0500)] <huslage> it's lonely
[11:25:47 CDT(-0500)] <huslage> so
[11:25:49 CDT(-0500)] <huslage> lonely
[11:27:40 CDT(-0500)] <colinclark> Okay, see you all next week
[11:27:46 CDT(-0500)] <colinclark> huslage will be here in person, which is wicked!
[11:27:54 CDT(-0500)] <michelled> bye colinclark
[11:27:57 CDT(-0500)] <cindyli> colinclark: do u have a min before u head off
[11:27:59 CDT(-0500)] <colinclark> jhung has coffee saved for you, huslage
[11:28:01 CDT(-0500)] <colinclark> cindyli: sure
[11:28:09 CDT(-0500)] <cindyli> one image gallery issue
[11:28:12 CDT(-0500)] <colinclark> ok
[11:28:13 CDT(-0500)] <michelled> Justin_o: did you see my comment on the version number pull request?
[11:28:45 CDT(-0500)] <cindyli> colinclark: heidi_ and i noticed some uploaded images are not displayed properly in the div underneath
[11:28:55 CDT(-0500)] <colinclark> oh, interesting
[11:28:58 CDT(-0500)] <colinclark> any idea why?
[11:29:00 CDT(-0500)] <cindyli> i just found out it's because
[11:29:08 CDT(-0500)] <Justin_o> michelled: nope, i'll go take a look now
[11:29:21 CDT(-0500)] <cindyli> 1. our php setting allows the max uploaded file size to 2M
[11:29:24 CDT(-0500)] <cindyli> which is too low
[11:29:40 CDT(-0500)] <cindyli> we should increase this setting
[11:29:52 CDT(-0500)] <colinclark> ok
[11:29:53 CDT(-0500)] <cindyli> probably a few other max size settings
[11:30:00 CDT(-0500)] <colinclark> I bet huslage can help with that part
[11:30:13 CDT(-0500)] <huslage> cindyli: which site?
[11:30:17 CDT(-0500)] <huslage> the continuum one?
[11:30:24 CDT(-0500)] <cindyli> yes, huslage
[11:30:27 CDT(-0500)] <huslage> sec
[11:30:32 CDT(-0500)] <cindyli> 2, enhance the image gallery code to detect this type of error. colinclark
[11:30:45 CDT(-0500)] <cindyli> colinclark: should i file a jira and fix t
[11:30:49 CDT(-0500)] <cindyli> it**
[11:31:07 CDT(-0500)] <cindyli> i don't think this jira would be a blocker
[11:31:08 CDT(-0500)] <colinclark> cindyli: I'll leave the Kings to decide...
[11:31:16 CDT(-0500)] <colinclark> but I'd say it's worth fixing for 1.5
[11:31:19 CDT(-0500)] <colinclark> but not for 1.4
[11:31:25 CDT(-0500)] <huslage> ok cindyli the limit is 10M now
[11:31:31 CDT(-0500)] <cindyli> cool. thanks, huslage
[11:31:37 CDT(-0500)] <huslage> off to lunch. bbiab
[11:31:44 CDT(-0500)] <colinclark> So you can probably get away with filing the JIRA and then leaving it for after the release
[11:31:50 CDT(-0500)] <colinclark> Justin_o and michelled, what do you think?
[11:31:58 CDT(-0500)] <colinclark> Is it actively blocking our ability to test the Uploader?
[11:32:00 CDT(-0500)] <michelled> that sounds fine to me
[11:33:43 CDT(-0500)] <cindyli> no, it's nothing to do with uploader, colinclark
[11:34:02 CDT(-0500)] <cindyli> and, once the limit is increased, it won't block the uploader testing
[11:34:05 CDT(-0500)] <Justin_o> cindyli: was it just the php settings?
[11:34:19 CDT(-0500)] <cindyli> yes, a part, Justin_o
[11:34:37 CDT(-0500)] <Justin_o> cindyli: so it wasn't just whatever huslage changed?
[11:34:40 CDT(-0500)] <cindyli> our image gallery php server script should also be improved to detect this type of error
[11:34:50 CDT(-0500)] <Justin_o> ah
[11:34:57 CDT(-0500)] <Justin_o> cindyli: i think that part can wait till after the release
[11:35:08 CDT(-0500)] <cindyli> huslage increases to 10M, what if a user uploads an image exceeding 10M limit
[11:35:09 CDT(-0500)] <Justin_o> but yes, please file a jira
[11:35:35 CDT(-0500)] <cindyli> sure, i will file the jira and set the version to fix @ 1.5, Justin_o, is that ok
[11:36:21 CDT(-0500)] <colinclark> see you all next week!
[11:36:23 CDT(-0500)] <Justin_o> cindyli: yep that's good… thanks
[11:36:26 CDT(-0500)] <Justin_o> colinclark: see you
[11:36:52 CDT(-0500)] <cindyli> np, Justin_o
[11:41:49 CDT(-0500)] <Justin_o> michelled: i've updated the pull request for FLUID-4249 https://github.com/fluid-project/infusion/pull/177
[11:46:16 CDT(-0500)] <cindyli> heidi_: i'm done with image gallery hourly build site. pass to your hand
[11:46:55 CDT(-0500)] <cindyli> just a little notes that don't upload images that are over 10M
[11:47:10 CDT(-0500)] <cindyli> otherwise the same display issue would happen
[11:51:09 CDT(-0500)] <heidi_> cindyli okay cool - thanks!
[11:51:22 CDT(-0500)] <cindyli> np, heidi_
[11:59:14 CDT(-0500)] <anastasiac> Justin_o and jhung1, I have a question about uploader in IE. I'm seeing something odd in IE9/Win7 and IE8/WinXP (haven't tried other IEs yet).
[11:59:33 CDT(-0500)] <anastasiac> When I remove a file from the queue, I get an error message displayed
[11:59:36 CDT(-0500)] <anastasiac> is that normal?
[11:59:44 CDT(-0500)] <anastasiac> it doesn't happen in FF on Mac
[12:00:08 CDT(-0500)] <Justin_o> anastasiac: i don't think that is normal
[12:00:24 CDT(-0500)] <anastasiac> jhung, you've been testing in IE - have you seen that?
[12:00:39 CDT(-0500)] <anastasiac> oh, I think he's eating...
[12:01:33 CDT(-0500)] <anastasiac> Justin_o, it's one of the Uploader error messages, and it's "HTTP Status code: File cancelled.<file> failed to upload" where <file> is the file I removed from the queue. The file removes from the queue just fine
[12:02:44 CDT(-0500)] <Justin_o> anastasiac: is it during upload when you remove it?
[12:03:13 CDT(-0500)] <anastasiac> only when removing i.e. in response to clicking on the red x
[12:08:18 CDT(-0500)] <anastasiac> Justin_o, it happens in IE7 as well.
[12:08:43 CDT(-0500)] <anastasiac> I've just installed the very latest flash player in all these browsers: 10.3 (since they didn't have flash)
[12:08:50 CDT(-0500)] <anastasiac> I wonder if that has anything to do with it?
[12:09:29 CDT(-0500)] <Justin_o> anastasiac: i suppose it could, there's a chance there is an issue with swfupload and the new flahs
[12:09:30 CDT(-0500)] <Justin_o> flash
[12:09:51 CDT(-0500)] <anastasiac> maybe jhung can check the flash version he's testing with
[12:11:05 CDT(-0500)] <jhung> anastasiac: catching up on the convo now..
[12:12:39 CDT(-0500)] <jhung> anastasiac: I did not see errors when removing files from the queue
[12:12:56 CDT(-0500)] <anastasiac> jhung, what version of flash do you have, exactly?
[12:15:18 CDT(-0500)] <jhung> 10.3
[12:15:24 CDT(-0500)] <anastasiac> that's what I've got...
[12:15:28 CDT(-0500)] <anastasiac> this is very weird
[12:15:40 CDT(-0500)] <anastasiac> oh, jhung: are you testing with the image gallery, or the demo?
[12:15:52 CDT(-0500)] <jhung> anastasiac: the demo
[12:16:03 CDT(-0500)] <anastasiac> ah. could you try it with the gallery? http://build.fluidproject.org/uploader/hourly/image-gallery.php
[12:17:00 CDT(-0500)] <jhung> anstasiac: yes i get errors on IE9 on Win7
[12:17:19 CDT(-0500)] <anastasiac> interesting. So Justin_o, jhung confirms
[12:18:00 CDT(-0500)] <jhung> anastasiac: do you want me to try other versions?
[12:18:11 CDT(-0500)] <anastasiac> sure, go ahead
[12:18:20 CDT(-0500)] <jhung> k'
[12:18:55 CDT(-0500)] <anastasiac> I'm getting the error in IE6 as well
[12:21:05 CDT(-0500)] <anastasiac> So Justin_o, I guess the question now is: how bad is this? Is it a blocker?
[12:22:07 CDT(-0500)] <Justin_o> anastasiac: i'll try to see if i can reproduce it here.. and see how it looks
[12:26:09 CDT(-0500)] <jhung> justin_o: it isn't terrible. Not a blocker, but definitely needs fixing.
[12:26:29 CDT(-0500)] <jhung> At least the error message is related to the user's action, so it isn't completely inappropriate.
[12:27:45 CDT(-0500)] <anastasiac> also, everything actually works just fine. the message is just a bit surprising
[12:29:28 CDT(-0500)] <Justin_o> okay.. sounds like it isn't a blocker then.. thanks anastasiac and jhung
[12:37:40 CDT(-0500)] <jhung> justin_o: so does Uploader testing include the Image Uploader, or is image uploader testing part of the "check shipped demos" task?
[12:38:55 CDT(-0500)] <Justin_o> jhung: it's part of uploader testing
[12:39:03 CDT(-0500)] <jhung> okay.
[12:40:26 CDT(-0500)] <anastasiac> Justin_o, I'll file that uploader bug with the error message, if you haven't
[12:41:05 CDT(-0500)] <michelled> jameswy: I haven't noticed Lucien in the channel and his two testing tasks are still not checked off
[12:41:12 CDT(-0500)] <michelled> any idea what's going on?
[12:41:23 CDT(-0500)] <michelled> I just want to reassign them if it doesn't look like he'll get to them
[12:41:28 CDT(-0500)] <Justin_o> anastasiac: thanks, i haven't done that
[12:42:18 CDT(-0500)] <jameswy> michelled: I haven't touched base with him. Let me see what's what.
[12:43:06 CDT(-0500)] <jhung> anastasiac: when you change the Allowed Image Types options, unchecking the 2nd file type causes an obscured error to appear.
[12:44:30 CDT(-0500)] <jhung> appears in IE8. Not in FF3.6
[12:44:32 CDT(-0500)] <michelled> thanks jameswy
[12:44:56 CDT(-0500)] <anastasiac> wow! jhung, you're right about obscure, if you'r seeing what I'm seeing...
[12:45:22 CDT(-0500)] <jhung> yeah. fun fun.
[12:45:34 CDT(-0500)] <jhung> Oddly, it's fine in IE9 anastasiac.
[12:45:49 CDT(-0500)] <anastasiac> "x files were too y and were not added to the queue. "
[12:46:05 CDT(-0500)] <anastasiac> poor files, too y. How can we help them with their y-ness?
[12:46:17 CDT(-0500)] <anastasiac> is that the message you see? [12:46:44 CDT(-0500)] <jhung> Yep same error. [12:47:06 CDT(-0500)] <jhung> I just wish we lived in a society where it doesn't matter if a file has too much Y. [12:47:32 CDT(-0500)] <michelled> we can dream of an inclusive society in the future ... [12:47:34 CDT(-0500)] <anastasiac> jhung, I'm seeing it on the second click, regardless of what you were doing, so turn something off, it will happen if you try to turn it back on. or second off, no matter which ones you're clicking. is that what you see? [12:48:48 CDT(-0500)] <jhung> yep. Once the error is present it doesn't go away. [12:48:56 CDT(-0500)] <anastasiac> jhung, the first two times I click a checkbox, the entire page goes blank and seems to reload, but subsequent checkbox clicks don't do that, is that what you're seeing? [12:50:04 CDT(-0500)] <jhung> anastasiac: the demo always looks like it refreshes for me (uploader collapses and reappears) [12:50:20 CDT(-0500)] <anastasiac> oh, so it's not refreshing for me once that error has occurred [12:50:39 CDT(-0500)] <jhung> It refreshes for me, but the error still persists. [12:50:41 CDT(-0500)] <anastasiac> Justin_o, are you following this discussion? errors with the demo settings checkboxes? [12:50:55 CDT(-0500)] <jhung> Perhaps it's a difference in VMs / OS / speed? [12:51:45 CDT(-0500)] <anastasiac> jhung, can you confirm that once this weird message occurs, the uploader is completely non-functional? [12:52:10 CDT(-0500)] <jhung> anastasiac: I just noticed that on the 2nd uncheck, an error appears in the IE error log. [12:52:54 CDT(-0500)] <jhung> "null is null or not an object" in image-gallery.php [12:53:12 CDT(-0500)] <anastasiac> IE 9 seems fine in Win 7: not happening there [12:53:31 CDT(-0500)] <Justin_o> jhung, anastasiac: which checkboxes are you referring to? [12:53:51 CDT(-0500)] <anastasiac> Justin_o, the image gallery demo settings: file types [12:53:55 CDT(-0500)] <Justin_o> michelled: do you know what copyright we give lahabana for a bug fix he contributed [12:53:57 CDT(-0500)] <jhung> anastasiac: yep. Confirm the same (IE9 Win7) [12:54:17 CDT(-0500)] <anastasiac> the second time you click one of them (i.e. either turn off a second one or turn the first one back on) the file size error message template displays, very oddly [12:54:20 CDT(-0500)] <michelled> Justin_o: I think it would be up to him [12:54:24 CDT(-0500)] <anastasiac> and the uploader stops working [12:54:29 CDT(-0500)] <michelled> I think he'd retain copyright [12:54:38 CDT(-0500)] <michelled> colinclark would know for sure [12:54:56 CDT(-0500)] <Justin_o> michelled: [12:55:09 CDT(-0500)] <michelled> Justin_o: how about a note to colinclark and lahabana asking? we aren't in a place to make bundles today anyway [12:55:20 CDT(-0500)] <Justin_o> michelled: sure [12:56:12 CDT(-0500)] <anastasiac> jhung, which version of IE are you testing? [12:56:16 CDT(-0500)] <anastasiac> I'm seeing this in IE6 [12:56:41 CDT(-0500)] <jhung> anastasiac: IE8 and confirming bugs in IE9 [12:56:53 CDT(-0500)] <anastasiac> I'll test IE7 now [12:57:54 CDT(-0500)] <anastasiac> yep, happening in IE7 [12:58:07 CDT(-0500)] <anastasiac> jhung, do you mean you're seeing the error in IE9, or you're going to test IE9? [12:58:39 CDT(-0500)] <jhung> anastasiac: I mean I'm also testing IE9. I do not see this bug in IE9 [12:58:52 CDT(-0500)] <anastasiac> ok, good confirmation of what I saw [13:03:33 CDT(-0500)] <anastasiac> Justin_o, I filed http://issues.fluidproject.org/browse/FLUID-4480 about that non-blocker error message [13:04:55 CDT(-0500)] <anastasiac> I'm wondering about this checkbox one: it does stop the entire uploader from working, Justin_o. But it might be an image gallery bug and not an uploader bug. Does that make it a blocker, or not? [13:05:53 CDT(-0500)] <Justin_o> anastasiac: it sounds like an image gallery bug, and if so I'd say not a blocker for this release. Could you or maybe cindyli do a bit of digging to confirm whether it is an issue with the image gallery itself or something do with the uploader? [13:06:25 CDT(-0500)] <anastasiac> maybe cindyli can help - I know less than nothing about the workings of the image gallery code [13:16:28 CDT(-0500)] <michelled> anastasiac: did you figure out why you were getting the single file uploader when you were using the server version of the uploader? [13:17:22 CDT(-0500)] <anastasiac> yes, it's a flash installation problem in my multi-IE VM. After I've quit IE, it forgets that I install flash, and I have to reinstall it [13:17:34 CDT(-0500)] <anastasiac> very annoying [13:19:18 CDT(-0500)] <cindyli> anastasiac: u said "I'm wondering about this checkbox one: it does stop the entire uploader from working..." [13:19:25 CDT(-0500)] <cindyli> what's this checkbox one? [13:19:28 CDT(-0500)] <cindyli> 4880? [13:20:00 CDT(-0500)] <anastasiac> cindyli, there's no JIRA for it: it's a problem we've just discovered [13:20:30 CDT(-0500)] <cindyli> is it the one you want me to look into? what's about? [13:20:37 CDT(-0500)] <cindyli> anastasiac: ^ [13:20:48 CDT(-0500)] <anastasiac> in IE6 7 and 8, if you check/uncheck any checkboxes, the second time you do, a weird error appears, cindyli [13:21:02 CDT(-0500)] <cindyli> ah, i see, anastasiac, it's a known issue [13:25:23 CDT(-0500)] <anastasiac> cindyli, I can't find any existing uploader JIRAs that include the word "check" - what should I be looking for? [13:25:44 CDT(-0500)] <cindyli> image gallery maybe [13:25:53 CDT(-0500)] <cindyli> anastasiac: also digging.. [13:27:44 CDT(-0500)] <cindyli> anastasiac: http://issues.fluidproject.org/browse/FLUID-4238 [13:28:06 CDT(-0500)] <anastasiac> thanks [13:28:09 CDT(-0500)] <cindyli> np [13:29:05 CDT(-0500)] <michelled> anastasiac, jhung1: have either of you looked at the uploader server on ie8 xp? [13:29:30 CDT(-0500)] <anastasiac> michelled, yes, some. what's up? [13:30:26 CDT(-0500)] <michelled> I'm only getting the single file uploader [13:30:32 CDT(-0500)] <michelled> it was all fine with the demo [13:30:36 CDT(-0500)] <michelled> but not with the server [13:31:08 CDT(-0500)] <anastasiac> michelled, have you ensure that flash is installed? [13:31:28 CDT(-0500)] <anastasiac> you may be seeing the same thing I saw, where you have to reinstall [13:31:31 CDT(-0500)] <michelled> yep, I get the flash uploader in the demo [13:31:40 CDT(-0500)] <anastasiac> hm [13:33:49 CDT(-0500)] <michelled> fluid-everyone: in case you also missed it cindyli just brought it to my attention that the uploader server build is broken so we should be using the hourly build [13:34:02 CDT(-0500)] <michelled> http://build.fluidproject.org/uploader/hourly/image-gallery.php [13:34:37 CDT(-0500)] <cindyli> anastasiac: i see your update in 4238. thanks. actually, adjusting any setting triggers this bug, not only by clicking on a file type checkbox [13:35:11 CDT(-0500)] <anastasiac> ok, cindy, thanks, I'll adjust the description to be more accurate [13:35:36 CDT(-0500)] <anastasiac> michelled, my IE8 is messed up. the security settings won't let me install flash, even though I've already installed it [13:35:39 CDT(-0500)] <cindyli> thanks, anastasiac [13:35:41 CDT(-0500)] <anastasiac> <sigh> [13:36:11 CDT(-0500)] <michelled> anastasiac: you might want to grab clean VMs [13:36:42 CDT(-0500)] <anastasiac> yeah; they were clean. are there new ones? [13:36:59 CDT(-0500)] <Justin_o> michelled: i'm going to be heading out now.. can you i hand off FLUID-4247 to you [13:37:17 CDT(-0500)] <michelled> sure Justin_o. where did you get to? [13:37:34 CDT(-0500)] <anastasiac> michelled, Justin_o, is there a central repository for VMs available, where I can get a clean one? [13:38:19 CDT(-0500)] <jhung1> anastasiac: yes there is [13:38:23 CDT(-0500)] <jhung1> I can show you where it is [13:38:26 CDT(-0500)] <anastasiac> thanks [13:38:38 CDT(-0500)] <Justin_o> anastasiac: yes, your hold be able to connect to the "Swarm" machine, there's a directory in the documents folder called "Clean VMs" [13:39:16 CDT(-0500)] <Justin_o> michelled: i have a branch going in my github space https://github.com/jobara/infusion/tree/FLUID-4247 [13:39:24 CDT(-0500)] <anastasiac> thanks, Justin_o [13:40:36 CDT(-0500)] <michelled> ok Justin_o - what's left to be check? [13:40:53 CDT(-0500)] <Justin_o> basically here's what's left 1) look through all the js and lib files in the src/webapp/tests directory and subdirectories 2) wait to hear back from lahabana about his code contribution copyright 3) we need to write up the changes that we made jscssp (you can look at the fast-xml pull as an example of how to document this) 4) make sure the readme/release notes are up-to-date with the licences [13:41:29 CDT(-0500)] <michelled> I think anastasiac already did 4 [13:41:40 CDT(-0500)] <michelled> thanks for the detailed list - I'll take this on [13:41:55 CDT(-0500)] <Justin_o> michelled: i found that using the blame and history features in github were quite helpful, and when i needed more i would do a diff betweenn the head and a specific commit [13:42:04 CDT(-0500)] <Justin_o> no problem, and thanks for taking it over [13:42:11 CDT(-0500)] <michelled> np [13:42:14 CDT(-0500)] <Justin_o> okay.. have a good weekend everyone.. nap time [13:42:20 CDT(-0500)] <michelled> get better! [13:42:43 CDT(-0500)] <michelled> anastasiac: am I right in saying that you checked that the readme/release notes were up to date with respect to licenses? [13:43:13 CDT(-0500)] <anastasiac> michelled, my most recent check of the release notes focussed on known issues. I think the licenses were checked a while back [13:43:27 CDT(-0500)] <michelled> ok, txh [13:43:30 CDT(-0500)] <michelled> thx [13:57:57 CDT(-0500)] <jhung1> anastasiac: I found that I can't stop an upload in IE until the current file has finished uploading. [13:58:23 CDT(-0500)] <anastasiac> odd; when I tested IE6 yesterday, it would stop right away [13:58:47 CDT(-0500)] <anastasiac> I'll test again as soon as I'm set up with clean VMs [14:05:26 CDT(-0500)] <heidi_> michelled hey are we still holding off on UIO testing? [14:07:42 CDT(-0500)] <Bosmon2> Hi cindyli - I'm looking at your pull request now [14:07:59 CDT(-0500)] <cindyli> cool [14:08:10 CDT(-0500)] <Bosmon2> I guess it can only be improved in a few small ways - currently the operation of the function is inconsistent in that it accepts the lineHeight as well as the container [14:08:30 CDT(-0500)] <Bosmon2> Given it goes making further measurements on the container itself, you should just move the direct jQuery css call into the function itself and remove the last argument [14:08:40 CDT(-0500)] <Bosmon2> Also there is a minor inconsistency in the test case name which is "numberize" : P [14:09:32 CDT(-0500)] <Bosmon2> But I wonder why the test case works - that is, why should a line height of 8px convert to 1em? [14:10:03 CDT(-0500)] <cindyli> 1em == 8px / contain.css("font-size") [14:10:12 CDT(-0500)] <cindyli> the font-size of that container is 8px as well [14:10:38 CDT(-0500)] <cindyli> in terms of ur first comment, let me dig out the code [14:12:04 CDT(-0500)] <cindyli> Bosmon2: are you suggesting to move this line - https://github.com/cindyli/infusion/blob/FLUID-4473/src/webapp/components/uiOptions/js/UIEnhancer.js#L491 [14:12:18 CDT(-0500)] <cindyli> into fluid.uiEnhancer.numerizeLineHeight() [14:12:25 CDT(-0500)] <cindyli> so the last argument can be removed [14:12:32 CDT(-0500)] <cindyli> i actually did it intentionally [14:12:50 CDT(-0500)] <Bosmon2> Yes, moving that line [14:13:01 CDT(-0500)] <cindyli> in order to provide mock-ups on "line-height" value [14:13:24 CDT(-0500)] <cindyli> you may have noticed that the unit test are all testing fluid.uiEnhancer.numerizeLineHeight() [14:14:14 CDT(-0500)] <Bosmon2> Yes... but then the contract of the function is unclear in that it goes to the container for some things and not others [14:14:26 CDT(-0500)] <Bosmon2> Perhaps the best way is to improve it further, and have the caller supply both values rather than neither [14:14:54 CDT(-0500)] <Bosmon2> So the other route is to remove the container argument completely, and have the caller also compute container[0].currentStyle.lineHeight [14:16:11 CDT(-0500)] <cindyli> I see. good point, Bosmon2 [14:16:13 CDT(-0500)] <Bosmon2> There is still the issue that the test case is browser-dependent... would it be possible to just make the regexp test unconditionally? Does every other browser report the measurement in px plus a unit measurement? Or do the browsers other than IE report a measurement in px minus a unit? [14:16:44 CDT(-0500)] <Bosmon2> I notice that the test case doesn't test the IE calculation branch as a result [14:16:58 CDT(-0500)] <cindyli> yes, i should test that too [14:17:43 CDT(-0500)] <cindyli> yes, we should be able to make the regexp test unconditionally [14:17:47 CDT(-0500)] <Bosmon2> cool [14:18:20 CDT(-0500)] <cindyli> as far as i know, only IE 6 − 8 returns in em without a unit [14:18:37 CDT(-0500)] <Bosmon2> ok, that's great [14:18:37 CDT(-0500)] <cindyli> all others return certain number with "px" unit [14:18:47 CDT(-0500)] <Bosmon2> We can just leave the IE-ness in this area as a comment then [14:18:56 CDT(-0500)] <cindyli> ok [14:19:09 CDT(-0500)] <cindyli> thanks, making change now [14:20:30 CDT(-0500)] <jhung1> anastasiac: did you create a jira for the "y-ness" error messages? If not, I will make one now... [14:21:06 CDT(-0500)] <anastasiac> jhung1, cindy says it's a known issue. I added a comment and screen shot to the JIRA [14:21:27 CDT(-0500)] <anastasiac> jhung, it's http://issues.fluidproject.org/browse/FLUID-4238 if you want to add any comments [14:21:28 CDT(-0500)] <jhung1> okay. [14:26:35 CDT(-0500)] <anastasiac> michelled, I'm set up now with a new clean VM for IE8 on XP. The server image gallery is working with the flash-based multi-file uploader [14:27:10 CDT(-0500)] <michelled> thx anastasiac: I was using the wrong version of the server for testing [14:27:17 CDT(-0500)] <anastasiac> ah [14:27:21 CDT(-0500)] <michelled> heidi_: yes, we are still holding on UIO testing [14:27:37 CDT(-0500)] <michelled> cindyli: is currently working on the code improvements that Bosmon2 has suggested [14:27:46 CDT(-0500)] <cindyli> yes, michelled [14:28:14 CDT(-0500)] <heidi_> k [14:28:32 CDT(-0500)] <michelled> heidi_: are you unable to pick up the uploader tests remaining? [14:28:47 CDT(-0500)] <heidi_> michelled yeah i don't have IE 6 or 7 VMs here [14:29:07 CDT(-0500)] <heidi_> i can do a bit of work on the IDI site tho so i'll do that until UIO is ready [14:30:27 CDT(-0500)] <michelled> ok, that sounds good [14:30:50 CDT(-0500)] <jhung1> anastasiac: I added FLUID-4483 (uploading an image does not stop right away) [14:31:08 CDT(-0500)] <anastasiac> ok [14:39:22 CDT(-0500)] <michelled> anastasiac, jhung1: did you come across a scrolling bug when testing uploader in IE using the keyboard? [14:39:36 CDT(-0500)] <anastasiac> not yet [14:39:45 CDT(-0500)] <michelled> basically, I can move focus to files in the file queue but they don't scroll into view [14:40:21 CDT(-0500)] <michelled> I'll open a JIRA [14:53:03 CDT(-0500)] <jhung1> thanks michelled [14:53:35 CDT(-0500)] <michelled> here's the JIRA in case you want to add something jhung1: http://issues.fluidproject.org/browse/FLUID-4484 [14:53:47 CDT(-0500)] <jhung1> I also fiiled 2 new Jiras related to uploading large files in Image Uploader: 1. Error message is displayed too late. 2. Error message presented is incorrect in this case. [14:54:11 CDT(-0500)] <jhung1> ^ for IE on Win7 [15:04:07 CDT(-0500)] <jhung1> The image uploader demo needs some love. [15:10:37 CDT(-0500)] <cindyli> Bosmon2: 4473 is ready again [15:11:12 CDT(-0500)] <Bosmon2> cindyli - thanks, I'll look at it now [15:11:20 CDT(-0500)] <cindyli> great. thanks [15:12:58 CDT(-0500)] <Bosmon2> cindyli - OK, I like this implementation [15:13:01 CDT(-0500)] <Bosmon2> I will test and commit [15:13:31 CDT(-0500)] <cindyli> glad you like it [15:13:34 CDT(-0500)] <cindyli> finally. thanks [15:13:55 CDT(-0500)] <Bosmon2> michelled - I've reviewed the API for public FLUID-4250, there's a pull request [15:14:11 CDT(-0500)] <michelled> thx Bosmon2 [15:14:34 CDT(-0500)] <michelled> Bosmon2: let me know when cindyli's patch goes in [15:14:42 CDT(-0500)] <michelled> I'll kick the build at that point [15:19:02 CDT(-0500)] <Bosmon2> michelled - it is in [15:19:08 CDT(-0500)] <Bosmon2> We are now CLOSED! [15:22:02 CDT(-0500)] <Bosmon2> The mountains will now CLOSE [15:25:24 CDT(-0500)] <michelled> [15:25:33 CDT(-0500)] <michelled> fluid-everyone: is it ok if I rebuild now? [15:25:58 CDT(-0500)] <cindyli> fine with me [15:26:11 CDT(-0500)] <anastasiac> I'm testing off the hourly image gallery server - will that be affected? [15:27:11 CDT(-0500)] <michelled> I don't think so anastasiac - it's the nightly builds that I'm restarting [15:27:15 CDT(-0500)] <anastasiac> k [15:27:24 CDT(-0500)] <anastasiac> I'll keep going, then [15:34:22 CDT(-0500)] <michelled> fluid-everyone: we are rebuilt and UIO testing is now open! [15:34:30 CDT(-0500)] <anastasiac> yay!! [15:34:33 CDT(-0500)] <heidi_> woohoooo [15:34:38 CDT(-0500)] <jameswy> [15:37:53 CDT(-0500)] <anastasiac> michelled, I just filed another uploader bug: http://issues.fluidproject.org/browse/FLUID-4488 The image gallery is ignoring the file queue limit. Doesn't seem like a blocker to me, but you, being King, should decide [15:39:12 CDT(-0500)] <michelled> thanks anastasiac - I don't think it's a blocker. I thought jhung had already mentioned it - can you see if it's already been filed? [15:39:31 CDT(-0500)] <anastasiac> I did search for it and didn't see it; I'll check again [15:41:32 CDT(-0500)] <anastasiac> michelled, I still don't see it. We can check with him on monday [15:41:40 CDT(-0500)] <michelled> thanks [15:44:48 CDT(-0500)] <anastasiac> michelled, jhung found a similar issue where file sizes are being ignored. I've linked the two liras in case they're related [15:45:01 CDT(-0500)] <michelled> thx