fluid-work IRC Logs-2011-09-21

[08:44:09 CDT(-0500)] <cindyli> Justin_o: do we have a test plan for inline edit? no luck from my wiki search
[08:45:40 CDT(-0500)] <Justin_o> yes we do.. which inline edit task are you doing
[08:48:50 CDT(-0500)] <cindyli> Justin_o:
[08:49:16 CDT(-0500)] <cindyli> simple text on Mac ff6 and safari 5, then going to move on to rich text
[08:49:44 CDT(-0500)] <cindyli> is it ok?
[08:51:09 CDT(-0500)] <Justin_o> cindyli: okay.. i'll send you those ones
[08:51:19 CDT(-0500)] <cindyli> thanks, Justin_o
[08:56:17 CDT(-0500)] <Justin_o> cindyli: this is where all the tests plans are housed
[08:56:19 CDT(-0500)] <Justin_o> http://wiki.fluidproject.org/display/fluid/Testing+Fluid+Components
[08:57:03 CDT(-0500)] <Justin_o> cindyli: here are the two specific test plans you need
[08:57:04 CDT(-0500)] <Justin_o> http://wiki.fluidproject.org/display/fluid/Inline+Edit+QA+Test+Plan+-+Simple+Text
[08:57:18 CDT(-0500)] <cindyli> cool. thanks, Justin_o
[08:57:40 CDT(-0500)] <Justin_o> http://wiki.fluidproject.org/display/fluid/Inline+Edit+QA+Test+Plan+-+Rich+Text
[09:04:58 CDT(-0500)] <heidi_> Justin_o i can do a 1/2 day of testing today ... uploader or UIO ready? otherwise i'll do some med priority stuff
[09:05:19 CDT(-0500)] <Justin_o> heidi_: those aren't ready yet
[09:05:22 CDT(-0500)] <Justin_o> unfortunately
[09:05:25 CDT(-0500)] <heidi_> ok
[09:35:03 CDT(-0500)] <colinclark_> Justin_o: Hi, morning
[09:35:15 CDT(-0500)] <Justin_o> colinclark_: hello
[09:35:17 CDT(-0500)] <colinclark_> So, I haven't yet managed to get to the code reviews you asked me about yesterday
[09:35:23 CDT(-0500)] <colinclark_> I'm sorry for that--I have time today, though
[09:35:32 CDT(-0500)] <colinclark_> Let me tell you my schedule, and we can work out the best ways for me to contribute
[09:35:44 CDT(-0500)] <colinclark_> We should also help Hasan with learning Mercurial at some point
[09:35:55 CDT(-0500)] <colinclark_> Deep in the recesses of our memory
[09:36:05 CDT(-0500)] <Justin_o> colinclark_: okay
[09:36:12 CDT(-0500)] <colinclark_> So I have a meeting now with huslage and Yong from OCAD IT about networking gear for our fancy new servers
[09:36:39 CDT(-0500)] <colinclark_> And a meeting at 12:15-1:15 pm with Scalar to talk about said fancy new servers
[09:36:46 CDT(-0500)] <colinclark_> After that, I'm all clear
[09:38:01 CDT(-0500)] <Justin_o> colinclark_: okay… cool.. i guess the order of priority would be to look at bosoms first FLUID-4453
[09:38:11 CDT(-0500)] <Justin_o> Then Cindy's FLUID-4445
[09:38:16 CDT(-0500)] <Justin_o> and my last FLUID-4460
[09:38:35 CDT(-0500)] <colinclark_> Okay, I'm writing that list down
[09:39:08 CDT(-0500)] <colinclark_> Okay, anything else we are blocking on for the release?
[09:42:39 CDT(-0500)] <cindyli> Justin_o: inline edit simple text fails test 7, do u wanna double confirm before i file the jira?
[09:42:42 CDT(-0500)] <cindyli> demo site: http://build.fluidproject.org/infusion/demos/inlineEdit/simple/html/inlineEdit.html
[09:42:52 CDT(-0500)] <cindyli> test plan: http://wiki.fluidproject.org/display/fluid/Inline+Edit+QA+Test+Plan+-+Simple+Text
[09:43:14 CDT(-0500)] <cindyli> platform is mac, ff 6
[09:43:51 CDT(-0500)] <Justin_o> cindyli: is that for the state tests?
[09:44:03 CDT(-0500)] <cindyli> yes, Justin_o
[09:48:14 CDT(-0500)] <Justin_o> cindyli: okay i think you have to fix up your keyboard settings. apple for some reason ships their OS with a setting to not tab to all controls by default
[09:48:31 CDT(-0500)] <Justin_o> it's under the keyboard settings in the OS i can drop by and help you with this if you like
[09:48:33 CDT(-0500)] <cindyli> aha, i see. fixing
[09:48:49 CDT(-0500)] <Justin_o> cindyli: you might have to restart your browser too
[09:49:02 CDT(-0500)] <cindyli> ok, Justin_o, thanks
[09:49:14 CDT(-0500)] <Justin_o> n;
[09:49:16 CDT(-0500)] <Justin_o> np
[10:27:53 CDT(-0500)] <heidi_> huslage https://connect.ocad.ca/fluid-work down?
[10:28:10 CDT(-0500)] <huslage> i don't run that, heidi
[10:28:12 CDT(-0500)] <huslage> but i'll check
[10:28:15 CDT(-0500)] <heidi_> ah ok
[10:28:21 CDT(-0500)] <mlam> Justin_o: can you check my pull request for FLUID-4443?
[10:28:44 CDT(-0500)] <Justin_o> mlam: sure.. thanks
[10:28:44 CDT(-0500)] <heidi_> jameswy i think we'll have to use yorku connect today
[10:29:08 CDT(-0500)] <Justin_o> heidi_: it seems to be down here too
[10:29:13 CDT(-0500)] <Justin_o> we're going to try the york one
[10:29:18 CDT(-0500)] <heidi_> k
[10:29:25 CDT(-0500)] <Justin_o> http://breeze.yorku.ca/fluidwork'
[10:29:25 CDT(-0500)] <heidi_> york working for me
[10:29:33 CDT(-0500)] <Justin_o> http://breeze.yorku.ca/fluidwork
[10:29:37 CDT(-0500)] <Justin_o> great, see you there
[12:13:40 CDT(-0500)] <Justin_o> cindyli: just noticed that one of the UIEnhancer tests if failing in IE 9
[12:14:13 CDT(-0500)] <Justin_o> it looks like it has to do with browsers calculation of text size
[12:15:08 CDT(-0500)] <Justin_o> or line size
[12:21:47 CDT(-0500)] <Justin_o> cindyli: here's the jira http://issues.fluidproject.org/browse/FLUID-4461
[13:39:58 CDT(-0500)] <Justin_o> fluid-everyone: dev meeting.. any topic suggestions?
[13:40:22 CDT(-0500)] <anastasiac> Justin_o, status updates on the blocker bugs and testing would be good
[13:43:35 CDT(-0500)] <Justin_o> anastasiac: sure.. lets start with that.. if there are any more topic suggestions please bring them up
[13:43:51 CDT(-0500)] <Justin_o> fluid-everyone: blocker update
[13:44:01 CDT(-0500)] <Justin_o> all the blockers have pull requests that colin is looking at
[13:44:19 CDT(-0500)] <Justin_o> i think there is one UIO and 3 uploader ones
[13:45:28 CDT(-0500)] <Justin_o> Testing is going along.. we still have a bunch of Medium Priority Issues, left. Outside of uploader and UIO almost all of the High Priority tests are done
[13:45:44 CDT(-0500)] <Justin_o> I did notice in my testing that the UI Enhancer tests were failing in IE 9
[13:45:48 CDT(-0500)] <Justin_o> i sent a link to that earlier
[13:45:56 CDT(-0500)] <Justin_o> http://issues.fluidproject.org/browse/FLUID-4461
[13:46:02 CDT(-0500)] <Justin_o> this may end up being a blocker
[13:46:27 CDT(-0500)] <Justin_o> So any testing help would be nice to get these all done, particularly after we reopen Uploader and UIO
[13:46:29 CDT(-0500)] <Justin_o> for testing
[13:46:42 CDT(-0500)] <Justin_o> Bosmon: you might be able to give colin a hand with some code review if you have time
[13:47:14 CDT(-0500)] <anastasiac> is there an ETA for when those fixes will be pushed
[13:47:15 CDT(-0500)] <anastasiac> ?
[13:47:42 CDT(-0500)] <Justin_o> anastasiac: over the next couple of days
[13:49:16 CDT(-0500)] <Justin_o> anastasiac: i think colin's going to try to get the UIO one pushed asap, but I'm thinking we should probably fix that issue i mentioned in the channel earlier too.
[13:51:01 CDT(-0500)] <heidi_> Justin_o i can help out with testing now / tomorrow
[13:51:18 CDT(-0500)] <heidi_> hoping to be in the office tomorrow too btw
[13:51:30 CDT(-0500)] <Justin_o> heidi_: that's excellent, thanks
[13:51:42 CDT(-0500)] <Justin_o> Bosmon: do you mind taking a peak at FLUID-4461
[13:51:45 CDT(-0500)] <Bosmon> Justin_o - Just an IE9 issue?
[13:51:48 CDT(-0500)] <Bosmon> It's ok in IE8?
[13:51:59 CDT(-0500)] <Justin_o> I think just in IE9, but i haven't tested IE 8 yet
[13:52:03 CDT(-0500)] <Justin_o> do you have IE 9?
[13:52:11 CDT(-0500)] <Bosmon> Annoyingly IE9 is the one browser I can't test in
[13:52:18 CDT(-0500)] <Justin_o>
[13:52:24 CDT(-0500)] <Bosmon> I guess I could make up yet another VM...
[13:52:43 CDT(-0500)] <Justin_o> it's a fairly minor error, basically we are expecint 1.5 back as the line size, but getting 1.51
[13:52:46 CDT(-0500)] <Bosmon> Somehow there is a "fault" with the IE9 in my real physical Win7 machine that it fails to deal with things from the filesystem
[13:53:00 CDT(-0500)] <Bosmon> I guess I can try and see if it will be happier running the test over HTTP to localhost
[13:53:13 CDT(-0500)] <Bosmon> 1.51!
[13:53:14 CDT(-0500)] <Justin_o> Bosmon: did you change your security settings in IE?
[13:53:18 CDT(-0500)] <Justin_o> or the advanced settings
[13:53:19 CDT(-0500)] <colinclark> oh hi, there's Bosmon
[13:53:23 CDT(-0500)] <colinclark> I haven't seen him in ages
[13:53:33 CDT(-0500)] <Bosmon> Justin_o - yes, I tried any number of security changes
[13:53:36 CDT(-0500)] <Bosmon> Hi colinclark
[13:53:41 CDT(-0500)] <Bosmon> But it remains stubborn
[13:53:48 CDT(-0500)] <Bosmon> Perhaps it is just a rounding error....
[13:53:52 CDT(-0500)] <Justin_o> colinclark: did you want to hand over any of your code reviews to Bosmon ?
[13:53:57 CDT(-0500)] <colinclark> erm
[13:54:01 CDT(-0500)] <Justin_o> Bosmon: could be..
[13:54:05 CDT(-0500)] <colinclark> Bosmon probably can't review his own code
[13:54:08 CDT(-0500)] <colinclark> but I guess there are others
[13:54:12 CDT(-0500)] <colinclark> Can you suggest any, Justin_o
[13:54:15 CDT(-0500)] <colinclark> ?
[13:54:20 CDT(-0500)] <Justin_o> colinclark: funny Bosmon just said the same thing to me :0
[13:54:21 CDT(-0500)] <Justin_o>
[13:54:26 CDT(-0500)] <colinclark> My list includes 4453, 4445, and 4460
[13:54:39 CDT(-0500)] <Justin_o> colinclark: i think you're missing one
[13:55:08 CDT(-0500)] <Justin_o> FLUID-4443
[13:55:16 CDT(-0500)] <Justin_o> that's the one mlam just finishe
[13:55:20 CDT(-0500)] <Justin_o> finished
[13:56:05 CDT(-0500)] <Bosmon> Ok - I can certainly take on FLUID-4443 and FLUID-4460
[13:56:26 CDT(-0500)] <Justin_o> Bosmon: thanks
[13:57:01 CDT(-0500)] <colinclark> So I'm just due for 4453, then?
[13:57:12 CDT(-0500)] <Bosmon> There is still FLUID-4445
[13:57:14 CDT(-0500)] <Justin_o> colinclark: and 4445
[13:57:15 CDT(-0500)] <Justin_o> yes
[13:57:20 CDT(-0500)] <colinclark> Okay, yes
[13:57:21 CDT(-0500)] <colinclark> sorry
[13:57:38 CDT(-0500)] <colinclark> My list is now updated
[13:57:42 CDT(-0500)] <Justin_o> Bosmon: i'll see if someone around here can look at http://issues.fluidproject.org/browse/FLUID-4461 while you do those code reviews
[13:57:56 CDT(-0500)] <Justin_o> fluid-everyone: any volunteers to work on an IE 9 bug?
[13:58:06 CDT(-0500)] <huslage> haha
[13:58:08 CDT(-0500)] <huslage> that's funy
[13:58:45 CDT(-0500)] <Justin_o> huslage: yes.. it's almost like volunteering to go in front of a firing squad..
[13:58:55 CDT(-0500)] <Bosmon> If noone has taken it after my review, I will see if the HTTP route works for me
[13:59:07 CDT(-0500)] <Justin_o> Bosmon: great, thanks
[13:59:07 CDT(-0500)] <Bosmon> It's nowhere near as bad as taking on IE6 issues
[13:59:24 CDT(-0500)] <Bosmon> I have spent a weekend with 3 dozen "alert" statements....
[13:59:27 CDT(-0500)] <Justin_o> so true.. at least there is some semblance of a debugger
[13:59:35 CDT(-0500)] <Justin_o> ouch
[14:00:08 CDT(-0500)] <colinclark> What's the IE9 issue?
[14:00:17 CDT(-0500)] <Bosmon> Font size miscalculation
[14:00:25 CDT(-0500)] <Bosmon> 1.51 plays 1.5 ...
[14:00:39 CDT(-0500)] <Bosmon> It might just be an issue with how big "ems" are
[14:00:45 CDT(-0500)] <Bosmon> Given I think we switched over to those recently
[14:01:23 CDT(-0500)] <Justin_o> Bosmon: i believe so
[14:16:50 CDT(-0500)] <Justin_o> Bosmon, colinclark: so it looks like it has to do with line 333 of UIEnhancer.js
[14:16:51 CDT(-0500)] <Justin_o> var fontSize = container.css("font-size");
[14:17:05 CDT(-0500)] <Justin_o> in IE 9 it returns 9.93, in FF 6 it returns 10
[14:18:52 CDT(-0500)] <Justin_o> i suppose we could round size before returning it on line 340
[14:19:48 CDT(-0500)] <cindyli> Justin_o: i just caught up the irc conversation. i would be happy to work on ie9 bug
[14:19:57 CDT(-0500)] <Justin_o> cindyli: thanks
[14:20:17 CDT(-0500)] <Bosmon> Justin_o - well, somewhat - I guess it bears investigation what the cause for the discrepancy is
[14:20:18 CDT(-0500)] <Justin_o> cindyli: so above is all that I've found out so far
[14:20:22 CDT(-0500)] <cindyli> np, Justin_o, first to set up ie9 on my vm
[14:20:23 CDT(-0500)] <Bosmon> Why SHOULD the value be 10?
[14:20:39 CDT(-0500)] <Justin_o> Bosmon: because Firefox says so
[14:21:12 CDT(-0500)] <Justin_o> i guess they are doing some internal rounding.. unless jQuery is doing something different between the two.. a bit annoying that they aren't normalizing this for us
[14:28:53 CDT(-0500)] <cindyli> Justin_o: interesting, ui enhancer tests fail on mac ff6. Have you tried that?
[14:29:03 CDT(-0500)] <cindyli> not only the font size, also a few others
[14:31:32 CDT(-0500)] <Justin_o> really.. didn't get that
[14:32:52 CDT(-0500)] <Justin_o> also interesting is that in IE 9 the first call to fluid.uiEnhancer.getTextSizeInPx returns 10, but the second time it returns 9.93
[14:34:00 CDT(-0500)] <Bosmon> Justin_o - ok, that is a useful clue
[14:34:17 CDT(-0500)] <Bosmon> In that it is most likely something we are doing ourselves, in rounding some OTHER measurement to a whole number of pixels
[14:37:56 CDT(-0500)] <Justin_o> Bosmon: maybe, and changing something in the DOM?
[14:38:23 CDT(-0500)] <Bosmon> Well, one thing I have worried about a bit is the way that text sizing and UIO is sort of "self-feeding"
[14:38:32 CDT(-0500)] <Bosmon> In that we change some measurements which we then rely on reading again later
[14:38:37 CDT(-0500)] <Bosmon> But I don't think I understand it completely
[14:39:41 CDT(-0500)] <Bosmon> I had a worrying sensation that in my FLUID-4453 branch, everything now appears slightly SMALLER
[14:39:45 CDT(-0500)] <Bosmon> But I can't swear to it
[14:49:14 CDT(-0500)] <heidi_> Justin_o testing manual progress and a negative value is accepted when it should be 0% - known issue?
[14:50:04 CDT(-0500)] <heidi_> also 0% still shows 14% shading
[14:50:13 CDT(-0500)] <heidi_> this is for http://build.fluidproject.org/infusion/tests/manual-tests/html/simple-progress.html
[14:50:16 CDT(-0500)] <Justin_o> heidi_: yes for the first one
[14:50:19 CDT(-0500)] <Justin_o> not sure for the second one
[14:50:29 CDT(-0500)] <Justin_o> can you describe it a bit more
[14:50:37 CDT(-0500)] <heidi_> Justin_o enter 0%
[14:51:20 CDT(-0500)] <Justin_o> okay
[14:51:28 CDT(-0500)] <heidi_> Justin_o nevermind, i guess that's what 0% looks like ha
[14:51:32 CDT(-0500)] <heidi_> i thought it would be empty
[14:52:31 CDT(-0500)] <heidi_> Justin_o it's weird that the default 14% looks like 0% but when i change it and enter 14% it's a different size
[14:52:41 CDT(-0500)] <Justin_o> heidi_: yah.. this has a minimum size.. set to 5px or something.. pretty strange, but this manual example is due for a refresh or replacement
[14:53:26 CDT(-0500)] <heidi_> Justin_o know what i mean about the two 14%s looking different? not sure what's happening there
[15:00:30 CDT(-0500)] <Justin_o> heidi_: i'm heading out.. talk to you tomorrow
[15:00:35 CDT(-0500)] <heidi_> night!