fluid-work IRC Logs-2010-12-21

Owned by Fluid IRC Log Bot
Last updated: Dec 21, 2010Version comment
23 min read

[08:38:10 CST(-0600)] <colinclark> Morning, fluid-everyone
[08:38:14 CST(-0600)] <colinclark> How's testing going?
[08:38:45 CST(-0600)] <colinclark> jessm: Do you still have the two Inline Edit tasks on your list?
[08:38:50 CST(-0600)] <heidi> still running through 'check shipped examples' for win xp browsers this morning
[08:39:18 CST(-0600)] <jessm> colinclark: nope, i did my inline edits
[08:39:37 CST(-0600)] <jessm> colinclark: i'm going to ping Erin when she comes online to see if we can split the uploader tests
[08:39:46 CST(-0600)] <colinclark> I think that makes sense
[08:39:51 CST(-0600)] <colinclark> heidi: Sounds good, thanks
[08:41:09 CST(-0600)] <colinclark> mlam has been testing Uploader with Chrome, so I think he'll be able to finish that this morning
[08:41:35 CST(-0600)] <jessm> colinclark: after testing, then what?
[08:41:39 CST(-0600)] <colinclark> anastasiac: What happened with the bug you found in UI Options yesterday?
[08:41:53 CST(-0600)] <colinclark> jessm: Then we'll do the usual release process
[08:42:00 CST(-0600)] <colinclark> I'll dig up a link to the wiki page
[08:42:09 CST(-0600)] <colinclark> We also need to finish the README
[08:42:26 CST(-0600)] <anastasiac> colinclark, it was filed - I don't think justin considered it a blocker, but it would be an easy fix
[08:42:36 CST(-0600)] <colinclark> anastasiac: Can you send a URL?
[08:42:52 CST(-0600)] <anastasiac> http://issues.fluidproject.org/browse/FLUID-3965
[08:43:05 CST(-0600)] <colinclark> So releasing generally involves cutting a tag, building a release package, doing some testing of that, and posting the release.
[08:43:12 CST(-0600)] <colinclark> This one is slightly more complicated in that we have the Builder now
[08:43:22 CST(-0600)] <colinclark> So it will need to get redeployed with the release
[08:44:43 CST(-0600)] <colinclark> anastasiac: Can you do me a huge favour?
[08:44:43 CST(-0600)] <colinclark> C
[08:44:56 CST(-0600)] <colinclark> Can you elaborate on the JIRA why it's happening?
[08:45:01 CST(-0600)] <anastasiac> indeed
[08:45:11 CST(-0600)] <colinclark> Also look into whether the dependency files are correct for UIO?
[08:45:26 CST(-0600)] <anastasiac> sorry - I had thought that heidi or justin had put that on there already...
[08:47:12 CST(-0600)] <colinclark> no worries
[08:48:15 CST(-0600)] <colinclark> jessm: Are you running Snow Leopard?
[08:48:25 CST(-0600)] <jessm> 10.6? yes
[08:49:03 CST(-0600)] <colinclark> I wonder if it makes sense, if you have time, to move onto one of the Mac-friendly medium tasks?
[08:49:04 CST(-0600)] <colinclark> Buil
[08:49:07 CST(-0600)] <colinclark> ack
[08:49:08 CST(-0600)] <colinclark> typing sucks
[08:49:23 CST(-0600)] <colinclark> Builder in Firefox 4, maybe?
[08:49:29 CST(-0600)] <jessm> colinclark: roger that
[08:49:37 CST(-0600)] <colinclark> Firefox 4 is great, but you might need to set up multiple profiles
[08:49:37 CST(-0600)] <colinclark> H
[08:49:40 CST(-0600)] <colinclark> ave you done that?
[08:50:06 CST(-0600)] <jessm> colinclark: eek, no
[08:50:23 CST(-0600)] <colinclark> You can probably get away with just swapping between them, then
[08:50:30 CST(-0600)] <colinclark> You're not a big user of, say, Firebug, right?
[08:50:42 CST(-0600)] <jessm> colinclark: i have it, but don't use it regularly
[08:50:48 CST(-0600)] <colinclark> ok
[08:50:49 CST(-0600)] <jessm> i can just download ff4 and run it?
[08:51:37 CST(-0600)] <colinclark> Yep, it should be just fine. http://www.mozilla.com/en-US/firefox/beta/
[09:04:23 CST(-0600)] <anastasiac> colinclark, regarding FLUID-3965: I've double-checked the dependencies, verified the proposed fix, and commented on the JIRA
[09:04:32 CST(-0600)] <colinclark> thanks
[09:04:42 CST(-0600)] <colinclark> I would really like to resolve this
[09:04:58 CST(-0600)] <colinclark> though I worry that we can't realistically do so without a retest of UIO, which is not really feasible
[09:05:31 CST(-0600)] <colinclark> Can we imagine any testing scenarios enabling us not to have to fully retest?
[09:06:19 CST(-0600)] <jessm> jameswy: you're a mad man! your testing list is SOOOOO long. Santa is definitely going to notice it
[09:06:32 CST(-0600)] <jameswy> (smile)
[09:06:50 CST(-0600)] <anastasiac> well, testing on any one platform where resource fetching works in general will verify that the file is correctly linked - I can't imagine a scenario in which it's properly linked in one browser, and not another... if we also test in a browser where ajax fetching of resources is troublesome, might that be sufficient?
[09:06:50 CST(-0600)] <jameswy> And they're all in Windows. WINDOWS! :S
[09:09:02 CST(-0600)] <colinclark> michelled: I think we could use your advice here
[09:09:44 CST(-0600)] <jessm> woah, our wiki doesn't really work in FF4
[09:09:53 CST(-0600)] <colinclark> jessm: How so?
[09:10:01 CST(-0600)] <colinclark> Works for me, as well as it ever works, I think
[09:10:05 CST(-0600)] <jessm> i edited the task list and saved and it didn't work
[09:10:19 CST(-0600)] <jessm> lemme try again
[09:10:36 CST(-0600)] <colinclark> strange
[09:10:46 CST(-0600)] <colinclark> weirdly, i found I could actually drag and drop between task lists in FF4
[09:10:54 CST(-0600)] <colinclark> which I gather has been a chronic problem in the past
[09:11:21 CST(-0600)] <jessm> yeah, i can't save
[09:11:24 CST(-0600)] <jessm> it just doesn't happen
[09:11:42 CST(-0600)] <michelled> colinclark, anastasiac: I think we should do a quick UIO test in the supported IEs and FF. That should be enough for us to find any issues with the change
[09:11:46 CST(-0600)] <colinclark> oh no
[09:11:52 CST(-0600)] <colinclark> michelled: Okay
[09:12:09 CST(-0600)] <colinclark> anastasiac: Can you put a patch together for this fix?
[09:12:13 CST(-0600)] <colinclark> michelled: You'll review it?
[09:12:17 CST(-0600)] <anastasiac> I was just about to offer
[09:12:22 CST(-0600)] <colinclark> And then we'll make the call
[09:12:22 CST(-0600)] <colinclark> t
[09:12:26 CST(-0600)] <colinclark> thanks, anastasiac
[09:12:32 CST(-0600)] <michelled> ya, I can review it
[09:15:52 CST(-0600)] <colinclark> jessm: Can you give me some steps to reproduce the wiki problems you're seeing?
[09:15:53 CST(-0600)] <colinclark> I
[09:15:57 CST(-0600)] <colinclark> just have to edit the task list page?
[09:16:08 CST(-0600)] <jessm> colinclark: i can't edit the task page in Chrome now
[09:16:14 CST(-0600)] <colinclark> ok, lemme try
[09:16:18 CST(-0600)] <jessm> can't even get Page Operations to drop down and show me edit
[09:16:28 CST(-0600)] <jessm> and in FF4 i made the edits in edit mode and then tried to save
[09:16:34 CST(-0600)] <colinclark> Do you get an error?
[09:16:45 CST(-0600)] <jessm> i got a msg. that there were unsaved changes and do i want to edit, disregard them or something
[09:16:50 CST(-0600)] <jessm> let me get the exact wording
[09:17:32 CST(-0600)] <colinclark> hmm
[09:17:38 CST(-0600)] <jessm> A version of this page you were editing at Dec 21, 2010 10:08 was not saved. Do you want to view the change, resume editing or discard it?
[09:17:44 CST(-0600)] <colinclark> it's certainly very slow
[09:18:17 CST(-0600)] <jessm> jameswy: did you successfully use it this a.m.?
[09:27:35 CST(-0600)] <colinclark> jessm: Editing this wiki page is definitely fried
[09:27:45 CST(-0600)] <colinclark> Try drag and drop with FF4, it does strangely seem to work
[09:28:33 CST(-0600)] <anastasiac> michelled: I've attached a patch to FLUID-3965 and assigned it to you for review.
[09:28:45 CST(-0600)] <michelled> thanks anastasiac
[09:31:45 CST(-0600)] <jessm> colinclark: woah! drag-n-drop does work, but you have to grab it just right and there are no drop targets
[09:31:52 CST(-0600)] <jessm> our reorderer is better (smile)
[09:34:05 CST(-0600)] <colinclark> jessm: No kidding (smile)
[09:34:11 CST(-0600)] <colinclark> and it supports ARIA now!
[09:49:46 CST(-0600)] <michelled> anastasiac: the patch looks good - I've commented on the JIRA
[09:49:49 CST(-0600)] <michelled> feel free to commit
[09:51:06 CST(-0600)] <michelled> fluid-everyone: I'm going back to some cspace work - please ping me if you need my help with the Infusion release
[09:52:42 CST(-0600)] <anastasiac> fluid-everyone: I'd like to restart the build site, to deploy a fix to UIOptions - is now an ok time?
[09:52:56 CST(-0600)] <heidi> fin w m
[09:53:01 CST(-0600)] <heidi> ahh, my 'e' key sucks
[09:54:02 CST(-0600)] <michelled> that reminds me of the days when colinclark used to carry around a bag with the keys that had fallen off his laptop
[09:56:16 CST(-0600)] <heidi> ha
[09:59:11 CST(-0600)] <anastasiac> fluid-everyone: I've redeployed the fix to FLUID-3965, so we'll need a round of testing on UIOptions on a few browsers/platforms. I can do FF3.6 on Mac OS; jameswy, could you try some IE/windows testing?
[10:23:36 CST(-0600)] <colinclark> anastasiac: Were you able to get some testing help for UIO yet?
[10:24:05 CST(-0600)] <anastasiac> no, not yet - I see that jameswy is not at his desk, so I'll have to talk to him the old fashioned way ;_0
[10:24:17 CST(-0600)] <colinclark> ok
[10:24:59 CST(-0600)] <colinclark> Morning, erin
[10:25:06 CST(-0600)] <erin> morning!
[10:25:08 CST(-0600)] <colinclark> I notice you've got two Uploader tasks on your testing to-do list
[10:25:13 CST(-0600)] <erin> yep
[10:25:17 CST(-0600)] <colinclark> How are those going? Do you want to share them with anyone?
[10:25:37 CST(-0600)] <erin> they are going. just on two browsers. i can do them
[10:25:41 CST(-0600)] <erin> james is doing the windows ones
[10:25:42 CST(-0600)] <heidi> anastasiac i'm noticing that UIO takes two clicks to open now (win xp, ff3.6)
[10:25:59 CST(-0600)] <anastasiac> heidi: known inssue FLUID-3618
[10:26:04 CST(-0600)] <heidi> ah cool
[10:26:06 CST(-0600)] <jessm> erin: what's your vector Victor on the uploader testing on Mac?
[10:26:32 CST(-0600)] <erin> what's a vector victor?
[10:26:39 CST(-0600)] <jessm> erin: status (smile)
[10:26:59 CST(-0600)] <jessm> erin: it's from a movie
[10:27:06 CST(-0600)] <erin> just about done on ff
[10:28:33 CST(-0600)] <jessm> erin: and you're done with the other?
[10:28:43 CST(-0600)] <erin> nope
[10:37:18 CST(-0600)] <jessm> erin: you ok to get both of those uploader tests done today?
[10:37:55 CST(-0600)] <colinclark> mlam and jameswy: You guys mentioned Uploader issues cropping up?
[10:38:13 CST(-0600)] <erin> jessm: yes, i should be good
[10:38:27 CST(-0600)] <jessm> erin: let me know early as you can if not – i can help
[10:38:42 CST(-0600)] <colinclark> anastasiac: Can you close http://issues.fluidproject.org/browse/FLUID-3965 and make note of the revision you committed at?
[10:38:49 CST(-0600)] <erin> jessm: ok!
[10:39:07 CST(-0600)] <anastasiac> colinclark, will do (wanted to finish testing first)
[10:39:16 CST(-0600)] <colinclark> thanks
[10:40:11 CST(-0600)] <mlam> colinclark: I made a mistake with reading the SWF UPloader documentation with regards to the file size limit
[10:40:33 CST(-0600)] <mlam> i guess after a few late nights, Ks start to look like Ms (sad)
[10:40:46 CST(-0600)] <mlam> the default file unit for SWF is KB, not MB
[10:41:10 CST(-0600)] <jameswy> colinclark: Yep. 3990 (20 MB file limit in Flash, 100 MB in FF), 3989 (inconsistent behavior between HTML5 and Flash for uploading existing files), 3988 (nuttiness when you upload non-image files to the image gallery uploader demo)
[10:41:24 CST(-0600)] <mlam> as it stands in our code now, the default file limit is not 2G, it's 20MB
[10:42:33 CST(-0600)] <colinclark> lol
[10:42:35 CST(-0600)] <colinclark> quite a difference
[10:42:44 CST(-0600)] <colinclark> Okay, let me catch up with these issues and we can make a decision from there
[10:50:14 CST(-0600)] <colinclark> mlam: FLUID-3988 and 3989 will require us to take some time to assess the problem against a local Image Gallery instance. It tends to report reasonable errors.
[10:50:35 CST(-0600)] <colinclark> But it looks like 3989 is caused by a clear and obvious failure on the Uploader's part...
[10:50:35 CST(-0600)] <colinclark> t
[10:50:42 CST(-0600)] <colinclark> there's no code path for error handling, whatsoever
[10:53:12 CST(-0600)] <mlam> what do you suggest we do with 3988? It does fit well with what we planned to do for 1.4....listen for appropriate errors and provide some feedback to the user from these errors
[10:55:14 CST(-0600)] <colinclark> 3988 doesn't make sense to me
[10:55:17 CST(-0600)] <colinclark> why is it happening?
[10:56:40 CST(-0600)] <mlam> in terms of 3989, for html5 to upload unique files only, we'd have to perform some server-side checks, or cache information into the browser to keep track of what's been uploaded during the session
[10:56:59 CST(-0600)] <mlam> i'm not sure, i'm still testing out 3988
[10:57:55 CST(-0600)] <mlam> 3989 seems more like server-side work than client side. i'm not sure why swf itself would restrict uploading duplicate files.
[10:58:32 CST(-0600)] <colinclark> I'm fairly certain the server rejects duplicate files
[10:58:46 CST(-0600)] <colinclark> the problem is that the HTML 5 strategy is not doing any error handling at all
[10:58:53 CST(-0600)] <colinclark> which seems pretty unacceptable
[11:08:26 CST(-0600)] <jessm> the builder is wicked cool
[11:09:24 CST(-0600)] <colinclark> (smile)
[11:11:01 CST(-0600)] <jessm> colinclark: 'enter' on download doesn't work – space does on FF4. bug?
[11:11:23 CST(-0600)] <colinclark> jessm: Interesting, and yes, bug-worthy
[11:11:30 CST(-0600)] <jessm> wait
[11:11:32 CST(-0600)] <jessm> just worked
[11:11:35 CST(-0600)] <colinclark> odd
[11:11:38 CST(-0600)] <jessm> might be (l)user error
[11:11:43 CST(-0600)] <colinclark> L
[11:12:07 CST(-0600)] <jessm> colinclark: yeah, (l)user
[11:12:57 CST(-0600)] <colinclark> no problem
[11:12:59 CST(-0600)] <colinclark> thanks for testing
[11:14:19 CST(-0600)] <mlam> colinclark: what do you suggest we do about the html5 error handling?
[11:14:42 CST(-0600)] <colinclark> Handle some errors
[11:14:44 CST(-0600)] <colinclark> I have a patch
[11:14:46 CST(-0600)] <colinclark> I'm just trying it out
[11:15:02 CST(-0600)] <mlam> ok
[11:15:17 CST(-0600)] <colinclark> Let me post it on the JIRA so you can give it a try and tweak it
[11:15:22 CST(-0600)] <colinclark> I just wrote it, haven't tested it
[11:15:33 CST(-0600)] <colinclark> rebuilding gallery from scratch, which takes forever
[11:18:40 CST(-0600)] <colinclark> mlam: http://issues.fluidproject.org/browse/FLUID-3989
[11:18:51 CST(-0600)] <colinclark> It's just a sketch--no idea if it actually works
[11:18:56 CST(-0600)] <mlam> ok
[11:25:27 CST(-0600)] <colinclark> mlam: This doesn't quite work, but should be easy to make work
[11:25:39 CST(-0600)] <colinclark> I just haven't used a raw XHR in a looong time.
[11:32:16 CST(-0600)] <colinclark> mlam: Okay new patch, basic functionality is working
[11:33:09 CST(-0600)] <mlam> ok, cool
[11:33:47 CST(-0600)] <colinclark> mlam: Here's the -b patch http://issues.fluidproject.org/secure/ManageAttachments.jspa?id=14922
[11:33:54 CST(-0600)] <colinclark> I'd hugely appreciate some serious testing with it
[11:33:57 CST(-0600)] <colinclark> and comparison with Flash
[11:36:17 CST(-0600)] <mlam> i'm applying the patch now
[11:36:41 CST(-0600)] <colinclark> mlam: Okay, so my patch doesn't display nice friendly user error messages
[11:36:46 CST(-0600)] <colinclark> I'll have to dig a bit deeper into why
[11:38:12 CST(-0600)] <colinclark> mlam: I just attached a screenshot of how the error appears in Flash
[11:38:44 CST(-0600)] <heidi> hey mlam, when you tested rich text with chrome, did you find tiny mce = keyboard trap?
[11:39:06 CST(-0600)] <heidi> ill check if there's an existing jira..
[11:40:49 CST(-0600)] <mlam> hey heidi, no i didn't have any keyboard traps at all, i was able to tab out and hit save/cancel
[11:40:58 CST(-0600)] <mlam> colinclark: ok, thanks
[11:41:17 CST(-0600)] <heidi> strange... on my win xp, tab = tab in the editor, and i'm not sure how to get out
[11:44:04 CST(-0600)] <colinclark> heidi: First thing, check the TinyMCE documentation to see how they handle navigating out of the editor
[11:44:14 CST(-0600)] <colinclark> I expect that they have some keyboard shortcut
[11:44:45 CST(-0600)] <heidi> i'll check colin. it behaves fine on other browsers - can tab out
[11:44:51 CST(-0600)] <colinclark> interesting!
[11:44:58 CST(-0600)] <colinclark> maybe they have some kind of chrome bug
[11:45:07 CST(-0600)] <heidi> yeah ill check it out
[11:45:11 CST(-0600)] <colinclark> or maybe we do (smile)
[11:45:19 CST(-0600)] <colinclark> thanks, heidi
[11:50:00 CST(-0600)] <jessm> colinclark: as king: http://issues.fluidproject.org/browse/FLUID-1600
[11:50:15 CST(-0600)] <jessm> colinclark: is that a simple fix and is it important to do now?
[11:50:57 CST(-0600)] <colinclark> jessm: No, and thus no
[11:51:04 CST(-0600)] <colinclark> It's an unpleasant bug
[11:51:12 CST(-0600)] <colinclark> Pretty brain-bending to fix
[11:51:29 CST(-0600)] <jessm> colinclark: ah, ok
[11:51:32 CST(-0600)] <colinclark> Which is why it's so old yet still unresolved
[11:51:42 CST(-0600)] <jessm> i noticed its ancientness
[11:51:48 CST(-0600)] <jessm> and ubiquity
[11:53:12 CST(-0600)] <jessm> colinclark: another quick question
[11:53:39 CST(-0600)] <colinclark> fire away, jessm
[11:53:44 CST(-0600)] <jessm> colinclark: in inline edit simple entering in text separated by spaces – what do we really expect there?
[11:53:54 CST(-0600)] <jessm> colinclark: i haven't seen a browser do a 1to1 mapping
[11:55:05 CST(-0600)] <colinclark> jessm: Can you elaborate?
[11:55:08 CST(-0600)] <colinclark> I think I know what you mean
[11:55:11 CST(-0600)] <colinclark> but more detail helps
[11:55:25 CST(-0600)] <jessm> colinclark: if i type in "type this here and then this here" with many spaces in between
[11:55:40 CST(-0600)] <jessm> it does not render that way in simple text inline edit
[11:55:46 CST(-0600)] <colinclark> yes, that's correct
[11:55:58 CST(-0600)] <colinclark> What does the test plan expect?
[11:56:06 CST(-0600)] <jessm> when i was testing yesterday safari seemed to put in some spaces, but not nearly the number i had typed and FF4 doesn't seem to put any in
[11:56:12 CST(-0600)] <colinclark> If I remember, this is another long-standing issue in Inline Edit
[11:56:17 CST(-0600)] <colinclark> and a fuzzy one in some ways
[11:56:24 CST(-0600)] <colinclark> but I'm curious what the test plan suggests should happen
[11:56:35 CST(-0600)] <jessm> "The content of the inline edit field should be changed to the new value"
[11:56:50 CST(-0600)] <colinclark> Okay, a bit ambiguous
[11:57:25 CST(-0600)] <jessm> colinclark: http://issues.fluidproject.org/browse/FLUID-2499 it was closed but it seems to me to be very much alive
[11:57:31 CST(-0600)] <colinclark> interesting!
[11:57:49 CST(-0600)] <colinclark> Closed because it's a duplicate
[11:57:49 CST(-0600)] <jessm> ah http://issues.fluidproject.org/browse/FLUID-887
[11:57:49 CST(-0600)] <colinclark> Try
[11:57:52 CST(-0600)] <colinclark> yep
[11:58:07 CST(-0600)] <colinclark> So, this was a funny one
[11:58:12 CST(-0600)] <colinclark> I think it's legitimate issue
[11:58:22 CST(-0600)] <colinclark> a bit of cats and dogs
[11:58:51 CST(-0600)] <colinclark> "this is how XML whitespace normalization works" vs. "this can be very disconcerting for users"
[11:58:56 CST(-0600)] <colinclark> I lean on the latter, rather than the former
[11:59:12 CST(-0600)] <colinclark> but I think it's a can of worms we won't open up this late in the release cycle
[11:59:17 CST(-0600)] <jessm> interesting that my IRC client got it right
[11:59:22 CST(-0600)] <colinclark> lol
[11:59:27 CST(-0600)] <colinclark> Is your IRC client running in a browser?
[11:59:34 CST(-0600)] <jessm> of course my irc client doesn't have keyboard a11y
[11:59:39 CST(-0600)] <jessm> no, colloquy
[12:00:06 CST(-0600)] <colinclark> jessm: If you think it's noteworthy, I'd suggest setting a to fix version of 1.4 and see if someone will pick it up
[12:00:32 CST(-0600)] <jessm> how very kingly
[12:00:39 CST(-0600)] <colinclark> lol
[12:02:37 CST(-0600)] <colinclark> fluid-everyone: I've bitten off a bit more than I can chew
[12:02:45 CST(-0600)] <colinclark> With this pending Uploader blocker
[12:03:02 CST(-0600)] <colinclark> I signed up for testing Uploader in IE 6 Win XP
[12:03:10 CST(-0600)] <colinclark> Can someone else pick this one up for me while I fix bugs?
[12:03:32 CST(-0600)] <anastasiac> colinclark, I have Justin's vm with IE 6 - I can have a go at testing Uploader
[12:03:39 CST(-0600)] <colinclark> anastasiac: You're a life saver
[12:03:40 CST(-0600)] <colinclark> thanks
[12:03:43 CST(-0600)] <anastasiac> I'll take it off your list on the testing page
[12:03:47 CST(-0600)] <heidi> i'll pick up some of the uploader ones in win xp
[12:03:56 CST(-0600)] <heidi> other than ie 6
[12:03:58 CST(-0600)] <colinclark> Might want to hold off on actually starting the testing, since I think we'll have to freeze and restart testing
[12:04:06 CST(-0600)] <colinclark> Has anyone else found any major Uploader issues they want to share?
[12:04:22 CST(-0600)] <colinclark> jameswy or mlam or anyone else?
[12:04:42 CST(-0600)] <jessm> erin: how's your testing going?
[12:05:48 CST(-0600)] <colinclark> jessm: I'd like your advice on a potential blocker. jameswy, too.
[12:06:28 CST(-0600)] <colinclark> http://issues.fluidproject.org/browse/FLUID-3989
[12:06:55 CST(-0600)] <colinclark> The Uploader is currently telling users that their uploads are successful, even when they fail due to errors
[12:07:06 CST(-0600)] <jessm> eek-ness
[12:07:10 CST(-0600)] <colinclark> So, if the network was somehow down or the server wasn't responding correctly, they'd see green
[12:07:33 CST(-0600)] <colinclark> Similarly, the Image Gallery (as an example of this category of behaviour) rejects any files that have previously been uploaded
[12:07:37 CST(-0600)] <colinclark> the user sees green success
[12:07:50 CST(-0600)] <colinclark> This, in my mind, constitutes a blocker
[12:07:55 CST(-0600)] <colinclark> but I'd like your opinions
[12:08:31 CST(-0600)] <jessm> colinclark: i agree, green is nice, but especially because it shouldn't be misleading
[12:08:49 CST(-0600)] <colinclark> yes
[12:09:11 CST(-0600)] <colinclark> I don't know if it affects the decision much, but I do have a "working" patch up on the JIRA
[12:09:19 CST(-0600)] <jameswy> colinclark, jessm: agreed. We can't be telling users the upload was successful when it failed.
[12:09:22 CST(-0600)] <colinclark> michelled and mlam will need to review and extensively test
[12:09:29 CST(-0600)] <colinclark> okay, blocker it is
[12:09:47 CST(-0600)] <colinclark> jameswy and erin: Have you found any other Uploader issues?
[12:09:51 CST(-0600)] <jameswy> colinclark, jessm: I was about to file another uploader issue, but it might be related
[12:09:56 CST(-0600)] <colinclark> ok
[12:09:58 CST(-0600)] <colinclark> fire away
[12:10:26 CST(-0600)] <jameswy> When I upload images now, it reads as successful, redirects me to the add information screen, but none of my files are there--instead, I see other files (a .xml , .doc, etc.)
[12:11:15 CST(-0600)] <colinclark> jameswy: That, I believe, is a bug in the Image Gallery
[12:11:27 CST(-0600)] <colinclark> I can't wait until we retire it for a simple little PHP script (wink)
[12:11:52 CST(-0600)] <colinclark> jameswy: I think the key question is "do your files get uploaded correctly?"
[12:12:30 CST(-0600)] <colinclark> I have noticed behaviour in the Gallery that makes it seem like you only ever see the first things that were uploaded in the confirmation/metadata page
[12:12:32 CST(-0600)] <colinclark> if you know what I mean
[12:13:18 CST(-0600)] <jameswy> colinclark: I think they uploaded successfully, because when I went to IE (re: flash uploader) to upload those same files, I got a bunch of errors
[12:13:37 CST(-0600)] <colinclark> ok
[12:13:59 CST(-0600)] <colinclark> you can always check in the Browse Images & Collections page
[12:14:36 CST(-0600)] <jameswy> colinclark: Ah, right! Good idea. Will check now.
[12:15:45 CST(-0600)] <jameswy> colinclark: They were uploaded successfully.
[12:16:31 CST(-0600)] <jameswy> colinclark: Is the Image Gallery's metadata page bug a known/filed issue?
[12:16:50 CST(-0600)] <jameswy> (or one that we care about at all since it's not technically a component?)
[12:17:25 CST(-0600)] <colinclark> jameswy: It's probably worth filing anyway, since others will find this issue
[12:17:38 CST(-0600)] <jameswy> colinclark: Alright.
[12:17:54 CST(-0600)] <colinclark> jessm: Can you wear the crown for about half an hour or so?
[12:18:10 CST(-0600)] <jessm> colinclark: eek, ok, what does that entail?
[12:18:22 CST(-0600)] <colinclark> We need michelled or Bosmon and mlam to review my patch and do some testing
[12:18:29 CST(-0600)] <colinclark> they can go ahead and commit it if it works
[12:18:39 CST(-0600)] <colinclark> Then we need to restart all of Uploader's testing
[12:18:40 CST(-0600)] <jessm> k
[12:18:42 CST(-0600)] <colinclark> (sorry)
[12:18:49 CST(-0600)] <colinclark> and we need a report back from erin on any bugs she's found
[12:18:50 CST(-0600)] <jessm> is the patch in?
[12:19:00 CST(-0600)] <colinclark> jessm: The patch is on the JIRA
[12:19:07 CST(-0600)] <jessm> roger that
[12:19:08 CST(-0600)] <colinclark> code is frozen, so no commits without a patch, then review
[12:19:23 CST(-0600)] <jessm> so, i'm guessing mlam eriny and michelled are busy right now
[12:19:45 CST(-0600)] <colinclark> jameswy: I wasn't able to fully reproduce FLUID-3988. It's pretty wacko...
[12:19:51 CST(-0600)] <colinclark> but are you willing to punt it for this release?
[12:22:14 CST(-0600)] <anastasiac> jessm, eriny and michelled are out having lunch right now - they'll be back after
[12:22:24 CST(-0600)] <jessm> anastasiac: thanks
[12:24:00 CST(-0600)] <jameswy> colinclark: I think it's okay to let 3988 go if it's specific to the image gallery, but if it's uploader-specific, I'd be more hesitant.
[12:24:10 CST(-0600)] <colinclark> it's really hard to know
[12:24:14 CST(-0600)] <colinclark> I saw it on the daily build
[12:24:23 CST(-0600)] <colinclark> but I can't reproduce it on my local instance of the Image Gallery
[12:24:23 CST(-0600)] <jameswy> colinclark: What happens when you try to reproduce it? It acts as expected for you?
[12:24:27 CST(-0600)] <jameswy> Aha.
[12:24:40 CST(-0600)] <jameswy> Weird.
[12:25:09 CST(-0600)] <jameswy> Also, Erin was about to file an uploader issue but I don't know if she got to it before lunch--
[12:25:16 CST(-0600)] <colinclark> ok
[12:25:22 CST(-0600)] <colinclark> I'll be back once I'm settled in at Cisco
[12:25:28 CST(-0600)] <colinclark> In the meantime, jessm has the crown
[12:25:34 CST(-0600)] <colinclark> thanks everyone for your awesome testing
[12:25:40 CST(-0600)] <colinclark> and jameswy your list really is impressive
[12:25:43 CST(-0600)] <colinclark> (smile)
[12:26:09 CST(-0600)] <jameswy> --when Javascript is disabled, both the single and multifile uploader show up, one on top of each other. I imagine Erin will file the issue in greater detail when she gets back
[12:26:12 CST(-0600)] <jameswy> ^ jessm
[12:26:16 CST(-0600)] <anastasiac> colinclark, fyi the image-gallery version of the uploader demo doesn't work in IE6 because of a wayward comma in image-gallery.js - I can file it, but it's probably not a blocker for 1.3, right?
[12:26:42 CST(-0600)] <jessm> jameswy: roger that
[12:26:49 CST(-0600)] <anastasiac> jessm, since you have the crown: ^
[12:27:44 CST(-0600)] <jessm> anastasiac: hrm, inneresting – since we're going to have to tweak the uploader with another fix – i dunno
[12:27:50 CST(-0600)] <jessm> let's ask colin when he's back
[12:28:07 CST(-0600)] <jessm> anastasiac: doesn't smell like a blocker
[12:28:40 CST(-0600)] <anastasiac> just to clarify, jessm, this wouldn't be a change to the uploader itself, but rather to the image gallery app that's using the uploader - and it's only on IE6 (jameswy says later IEs are ok) so I'm going to predict it's not a blocker
[12:28:59 CST(-0600)] <jessm> anastasiac: smells like not a blocker
[12:29:05 CST(-0600)] <jessm> i need to work on my kingliness
[13:19:44 CST(-0600)] <jessm> jameswy: anastasiac: folks still gone?
[13:20:19 CST(-0600)] <anastasiac> jessm, michelled just got back, but she wasn't with the others - they're still out
[13:21:16 CST(-0600)] <jessm> michelled: perhaps you can check on colinclark's patch?
[13:21:34 CST(-0600)] <jessm> michelled: the idea is to open freeze back up to patch it
[13:21:37 CST(-0600)] <jessm> michelled: http://issues.fluidproject.org/browse/FLUID-3989
[13:24:10 CST(-0600)] <anastasiac> jessm, erin's just back now, too
[13:24:15 CST(-0600)] <michelled> jessm: I'm back now - sorry I didn't let you know when I disappeared
[13:24:32 CST(-0600)] <michelled> anyway, I can certainly review colin's patch
[13:24:42 CST(-0600)] <jessm> michelled: thanks muchly
[13:25:06 CST(-0600)] <jessm> erin: we're hoping to hear from you re: uploader testing – have you found any big issues? we're about to patch another bug and so need to know where things are
[13:25:40 CST(-0600)] <erin> haven't found anything other than http://issues.fluidproject.org/browse/FLUID-3992
[13:26:33 CST(-0600)] <jameswy> jessm: I've added a few more issues, but nothing definitively blocker-like.
[13:26:34 CST(-0600)] <jameswy> Biggest one uploader-related is that if you delete a file in your system that's in the upload queue, it'll halt the upload at that file, or somehow upload the deleted file anyway.
[13:27:55 CST(-0600)] <jessm> jameswy: i'm not sure i follow
[13:29:18 CST(-0600)] <jameswy> jessm: FLUID-3996 and FLUID-3998: add files to queue, delete file from your system (not the queue), upload anyways, and it'll either halt the upload at the deleted file, or it'll somehow upload a system-deleted file.
[13:29:37 CST(-0600)] <mlam> I'm just catching up in the logs
[13:29:42 CST(-0600)] <mlam> applied colin's second patch
[13:31:57 CST(-0600)] <jessm> mlam: can you coordinate with michelled on that?
[13:32:03 CST(-0600)] <mlam> yes, definitely
[13:32:38 CST(-0600)] <jessm> mlam: thanks so much
[13:32:44 CST(-0600)] <michelled> mlam: do you mean 'patch d'
[13:32:49 CST(-0600)] <michelled> ?
[13:32:55 CST(-0600)] <mlam> np
[13:33:29 CST(-0600)] <michelled> mlam: did you apply patch b or patch d?
[13:33:37 CST(-0600)] <mlam> michelled: i applied b, lemme revert and apply d
[13:33:45 CST(-0600)] <michelled> thx
[13:33:55 CST(-0600)] <michelled> I reviewed the code and it makes sense but I haven't tested anything
[13:34:11 CST(-0600)] <michelled> mlam: if you have good results with your testing then we can commit it and restart testing
[13:34:27 CST(-0600)] <mlam> ok, i'll let you know shortly
[13:34:28 CST(-0600)] <jessm> jameswy: did you already tell colin about those two bugs? 3996 and 3998?
[13:36:08 CST(-0600)] <mlam> michelled: patch works really well.
[13:36:21 CST(-0600)] <michelled> cool - which browsers did you test with?
[13:36:30 CST(-0600)] <jameswy> jessm: I filed them after he left. Just spoke to anastasiac about it though--3998 occurs because it's not actually being uploaded, it's just being simulated. Still, there should probably be a check on the client-side to make sure the files still exist before uploading, so we'll keep the issue there.
[13:36:42 CST(-0600)] <mlam> i've just tested with FF 3.6 for now.
[13:37:00 CST(-0600)] <michelled> wanna do a quick IE test? then we can commit and open it up
[13:37:21 CST(-0600)] <michelled> also, mlam can you please run the unit tests?
[13:37:27 CST(-0600)] <mlam> We properly listen for an error, but I suppose for a future release, we can modify the error messages to be more detailed
[13:37:32 CST(-0600)] <mlam> michelled: on it
[13:37:53 CST(-0600)] <michelled> (smile)
[13:39:54 CST(-0600)] <mlam> michelled: I'm not able to test in IE, since the image gallery isn't set up in my virtual box
[13:40:06 CST(-0600)] <mlam> i'll try on a couple other browsers
[13:42:10 CST(-0600)] <mlam> michelled: all unit tests across chrome, IE, and FF
[13:42:24 CST(-0600)] <mlam> *pass
[13:49:34 CST(-0600)] <erin> on FF on mac (regular demo), if you click upload after deleting a file in the queue, the uploader won't do anything at all.
[13:50:13 CST(-0600)] <erin> mlam:^ do you want this filed as a separate jira or part of jameswy's 3998
[13:51:19 CST(-0600)] <mlam> erin: can you file as part of 3998?
[13:51:24 CST(-0600)] <mlam> michelled: almost done testing.
[13:51:31 CST(-0600)] <erin> mlam: ok
[13:51:52 CST(-0600)] <michelled> mlam: were you able to test IE?
[13:53:12 CST(-0600)] <mlam> yes i am
[13:54:29 CST(-0600)] <mlam> michelled: everything seems to work fine in all browsers in XP
[13:54:41 CST(-0600)] <michelled> thanks mlam
[13:54:46 CST(-0600)] <mlam> yw
[13:59:39 CST(-0600)] <mlam> michelled has just committed colin's patch for FLUID-3989
[13:59:53 CST(-0600)] <michelled> fluid-everyone: we can restart uploader testing now
[14:00:11 CST(-0600)] <jessm> mlam: michelled: awesome
[14:00:19 CST(-0600)] <jessm> erin: you clear on this?
[14:00:25 CST(-0600)] <jessm> anastasiac: were you also doing testing?
[14:00:54 CST(-0600)] <anastasiac> jessm, I was testing the uploader demo (not the image gallery) in IE6
[14:00:56 CST(-0600)] <michelled> fluid-everyone: I haven't restarted the building yet
[14:01:20 CST(-0600)] <michelled> is now a good time? (and of course I mean the build not the building)
[14:01:26 CST(-0600)] <erin> sure
[14:01:27 CST(-0600)] <anastasiac> fine with me
[14:04:05 CST(-0600)] * michelled wants a faster JIRA from Santa
[14:04:50 CST(-0600)] <anastasiac> fluid-everyone: the build server has been restarted now
[14:05:00 CST(-0600)] <michelled> thx anastasiac
[14:05:05 CST(-0600)] * anastasiac wants a faster wiki from Santa
[14:07:23 CST(-0600)] <michelled> fluid-everyone: I'm seeing 4 open blockers for the release: 3774 - sneak peek documentation, 3879 - Readme, 3944 - uploader readme and 3989 - the JIRA that was just fixed and I will now close
[14:07:42 CST(-0600)] <michelled> fluid-everyone: are there any other bugs that you feel are blockers that haven't been marked as such?
[14:08:12 CST(-0600)] <jameswy> michelled: 3999 might be one
[14:08:25 CST(-0600)] <jameswy> You can add files WHILE upload is active.
[14:08:41 CST(-0600)] <michelled> in all browsers?
[14:08:57 CST(-0600)] <jameswy> michelled: Safari, and all FFs.
[14:09:10 CST(-0600)] <jameswy> michelled: IE doesn't have the issue, Chrome is yet to be tested.
[14:11:32 CST(-0600)] <michelled> jameswy: do you feel that it is a blocker? I know it's not great but I'm wondering if it's something that could be marked as critical for 1.4 and a known issue for 1.3
[14:13:26 CST(-0600)] <jameswy> michelled: yeah, not awesome, but I think we can leave it out for this release.
[14:14:07 CST(-0600)] <michelled> ok
[14:14:31 CST(-0600)] <michelled> anastasiac: are the readmes and sneak peek documentation done?
[14:14:49 CST(-0600)] <michelled> actually, I'm thinking we should add 3999 to the known issues in the readme
[14:14:54 CST(-0600)] <michelled> anastasiac: can you do that?
[14:15:19 CST(-0600)] <michelled> fluid-everyone: anything else we should talk about to determine if it's a blocker?
[14:15:24 CST(-0600)] <mlam> FLUID-3999 - There was a similar JIRA regarding the Add More button which I had resolved and closed. I must have re-introduced this one.
[14:15:55 CST(-0600)] <anastasiac> michelled: The sneak peek is, I think, done, but needs review; The readme is mostly done, but I wanted to wait till most testing done before finally updating the "known issues" - just doing that now, and will add 3999; the readme will also need review
[14:16:20 CST(-0600)] <michelled> thanks anastasiac. and the uploader readme, was that on your plate?
[14:16:44 CST(-0600)] <anastasiac> no, that's colin's
[14:17:00 CST(-0600)] <anastasiac> or at least, he has to give me info (smile)
[14:17:11 CST(-0600)] <michelled> ok, cool
[14:27:01 CST(-0600)] <jameswy> fluid-everyone: I'm heading out soonish, and put Uploader tasks back into the high priority pool for re-testing
[14:27:16 CST(-0600)] <jameswy> Please feel free to dig in and take some, (smile)
[14:27:20 CST(-0600)] <michelled> thanks jameswy
[14:28:27 CST(-0600)] <heidi> anastasiac - so the changes to TOC in UIO add UIO links to the page when UIO isn't open - is that intentional? the links don't do anything
[14:28:45 CST(-0600)] <heidi> i think you worked on that, maybe it was someone else
[14:29:03 CST(-0600)] <anastasiac> heidi, I don't think that was me - doesn't sound familiar at all
[14:29:13 CST(-0600)] <heidi> ah sorry
[14:29:20 CST(-0600)] <heidi> did someone do some TOC UIO thing today ?
[14:29:59 CST(-0600)] <anastasiac> heidi, I only fixed the bug where the table of contents template couldn't load at all
[14:30:54 CST(-0600)] <heidi> hmm. right now when you turn it on, 3 links appear on the top: "easier to see" "easier to find" and "preview window" and they don't do anything. so i guess TOC isn't filtering out the UIO headers ? anastasiac
[14:32:01 CST(-0600)] <anastasiac> hm... michelled thinks this might be a known issue. I'll check jira
[14:32:11 CST(-0600)] <heidi> ah
[14:32:30 CST(-0600)] <heidi> ill check too, thanks anastasiac
[14:33:45 CST(-0600)] <michelled> fluid-everyone: these are the tasks left before we can start the actual release for 1.3:
[14:33:45 CST(-0600)] <michelled> 1. UI Options testing: heidi is working through this
[14:33:45 CST(-0600)] <michelled> 2. Uploader testing: mlam, jameswy, jessm and erin are working on this - if anyone else has free cycles they should pitch in here
[14:33:45 CST(-0600)] <michelled> 3. Uploader Readme: colinclark will get some text to anastasiac
[14:33:46 CST(-0600)] <michelled> 4. Sneak Peek Documentation: someone needs to review this
[14:33:46 CST(-0600)] <michelled> 5. Readme: anastasiac is waiting for testing to complete to add the last known issues. someone needs to review this - jessm?
[14:36:47 CST(-0600)] <anastasiac> heidi, I've filed http://issues.fluidproject.org/browse/FLUID-4001 against the ToC for our issue. If we find or file something against UIOptions for it, we should relate the two issues
[14:37:16 CST(-0600)] <heidi> okay
[14:37:19 CST(-0600)] <heidi> thanks anastasiac
[15:04:05 CST(-0600)] <mlam> fluid-everyone: colinclark has asked if everyone can post their updates/outstanding issues into the channel before they leave for the day?
[15:04:20 CST(-0600)] <anastasiac> will do
[15:54:12 CST(-0600)] <jessm> michelled: roger that on readme review
[16:03:20 CST(-0600)] <michelled> thx
[16:07:14 CST(-0600)] <anastasiac> fluid-everyone, my update for the day:
[16:07:14 CST(-0600)] <anastasiac> - helped test uploader
[16:07:14 CST(-0600)] <anastasiac> - working on ensuring tutorials are correct
[16:07:15 CST(-0600)] <anastasiac> - documentation tasks still-to-do:
[16:07:15 CST(-0600)] <anastasiac> – updates to IoC
[16:07:15 CST(-0600)] <anastasiac> – reviews of IoC, Renderer, expanders
[16:07:16 CST(-0600)] <anastasiac> - remaining documentation holes:
[16:07:16 CST(-0600)] <anastasiac> – uploader
[16:07:16 CST(-0600)] <anastasiac> – model transformation
[16:07:17 CST(-0600)] <anastasiac> – progressive enhancement
[16:20:43 CST(-0600)] <erin> uploader was tested on FF and Safari on OSX10.6. logged 4002 and 3992, but otherwise all goood
[16:23:43 CST(-0600)] <mlam> fluid-everyone: I'll be testing the remainder of the uploader tasks, and I'll try to go through as many Win 7 tasks as I can tonight and tomorrow morning before coming in since I have Win 7 at home.
[16:24:03 CST(-0600)] <heidi> ui options looks goof on win xp
[16:24:07 CST(-0600)] <heidi> *good !
[16:27:14 CST(-0600)] <mlam> fluid-everyone: please don't forget to chime into the channel with your end-of-day update (smile)
[16:58:13 CST(-0600)] <jessm> i have two tests to do before noon tomorrow: uploader and rich text inline edit in FF4 on Mac OS
[16:58:34 CST(-0600)] <jessm> and I'm going to do some work on the readme with anastasiac I think in the a.m. – I'll be here