fluid-work IRC Logs-2010-02-09

Owned by Fluid IRC Log Bot
Last updated: Feb 09, 2010Version comment
21 min read

[02:55:32 EST(-0500)] * sveto (~sveto@62.44.108.2) has joined #fluid-work
[05:19:50 EST(-0500)] * athena7 (~athena@adsl-76-250-193-123.dsl.wlfrct.sbcglobal.net) has joined #fluid-work
[07:09:47 EST(-0500)] * justin_o (~jmo@2002:63e3:179a:0:21f:5bff:feca:f969) has joined #fluid-work
[07:50:45 EST(-0500)] * boyan (~boyan@62.44.108.2) has joined #fluid-work
[08:02:29 EST(-0500)] * justin_o (~jmo@CPE001b63f2cc0e-CM0011aec4b062.cpe.net.cable.rogers.com) has joined #fluid-work
[08:10:48 EST(-0500)] * justin_o (~jmo@CPE001b63f2cc0e-CM0011aec4b062.cpe.net.cable.rogers.com) has joined #fluid-work
[08:19:29 EST(-0500)] * anastasiac (~team@142.150.154.193) has joined #fluid-work
[08:55:13 EST(-0500)] * jessm (~Jess@c-71-232-3-151.hsd1.ma.comcast.net) has joined #fluid-work
[08:59:09 EST(-0500)] <jessm> jamon: ping
[08:59:35 EST(-0500)] <jessm> jamon: i haven't gotten a daily email from wiki.fluidproject.org for a few days
[09:08:42 EST(-0500)] * colinclark (~colin@bas2-toronto09-1176130909.dsl.bell.ca) has joined #fluid-work
[09:15:30 EST(-0500)] <colinclark> Hey sveto, thanks for your new patch
[09:15:38 EST(-0500)] <colinclark> We're getting somewhere here. (smile)
[09:15:45 EST(-0500)] <colinclark> So here's the question I was puzzling over last night
[09:15:50 EST(-0500)] <sveto> I hope it helps
[09:16:01 EST(-0500)] <colinclark> Why do we even render the collect/uncollect button?
[09:16:21 EST(-0500)] <colinclark> If I look at your code, it looks like all the work to change its label, etc. is done dynamically with jQuery.
[09:16:54 EST(-0500)] <sveto> as far as I understand we don't have a choice not to render it, because it is in the render scope?
[09:17:04 EST(-0500)] <colinclark> Ah, I don't think that's the case.
[09:17:16 EST(-0500)] <colinclark> The renderer will leave any markup alone that it doesn't have a component in the tree for.
[09:17:24 EST(-0500)] <colinclark> So the rules work roughly like this:
[09:17:43 EST(-0500)] <colinclark> 1. If an element has no component in the tree, and no entry in the cutpoints, it'll be left alone
[09:18:03 EST(-0500)] <colinclark> 2. If an element is listed in the cutpoints, but does not have an associated component in the tree, it gets removed from the markup
[09:18:34 EST(-0500)] <colinclark> 3. If an element has both a cutpoints entry and a component in the tree, it will be rendered based on the bindings in the component.
[09:19:02 EST(-0500)] <colinclark> But, I guess, the issue is that anything inside render scope does get destroyed and recreated
[09:19:11 EST(-0500)] <colinclark> So I see your point (smile)
[09:19:36 EST(-0500)] <sveto> I see, so the problem is that it isn't rendered but recreated
[09:19:51 EST(-0500)] <sveto> then can't we go for a render decorator?
[09:20:49 EST(-0500)] <colinclark> We can go for a render decorator--you mean for the click handler, I assume?
[09:20:56 EST(-0500)] <sveto> yes
[09:21:19 EST(-0500)] <colinclark> Locating an element via selector even after it's been removed and re-added to the DOM by the Renderer should work just fine.
[09:21:44 EST(-0500)] <colinclark> And yes, we can put back the code I took out to bind the click handler via a decorator...
[09:21:48 EST(-0500)] <colinclark> but with one catch
[09:22:06 EST(-0500)] <colinclark> I was finding that the click handler wasn't preventing the default action on the link, which it should.
[09:22:22 EST(-0500)] <colinclark> The other option is to bind a live event to the element with jQuery.
[09:22:37 EST(-0500)] <colinclark> Live events are automatically bound as elements are injected into the DOM which match the selector
[09:22:53 EST(-0500)] <colinclark> Lemme think about it for a minute after I get a chance to look through your patch more closely
[09:23:10 EST(-0500)] <colinclark> sveto: I certainly did some damage in my attempt to fix things, but we're getting there one step at a time (smile)
[09:23:41 EST(-0500)] <sveto> ok, it was aplpied on top of the previous patch, so it is somewhat long
[09:24:13 EST(-0500)] <colinclark> sveto: Cool. So your patch effectively replaces mine, then?
[09:24:27 EST(-0500)] <sveto> yes, it should at least
[09:24:34 EST(-0500)] <colinclark> k, thanks
[09:24:51 EST(-0500)] <colinclark> I'm gonna be in and out this morning, but I'll keep you up to date on the list about my progress
[09:25:13 EST(-0500)] <colinclark> And in the meantime, feel free to put up more patches if you make progress
[09:25:28 EST(-0500)] <colinclark> Otherwise, there are no lack of other blockers to work on (smile)
[09:26:02 EST(-0500)] <sveto> yes, indeed, but how do we proceed with patches that are still not applied?
[09:27:12 EST(-0500)] <colinclark> Ah, like the object code entry patch, you mean?
[09:27:57 EST(-0500)] <sveto> well, yes about that one, but on the My Collection page too
[09:28:02 EST(-0500)] <sveto> branch, sorry, not page
[09:30:33 EST(-0500)] * yura (~yura@142.150.154.101) has joined #fluid-work
[09:37:14 EST(-0500)] <colinclark> I'll try to the object code patch in before I have to run to an appointment. As for My Collection, our goal is to get the branch working ASAP so we can easily merge it into trunk
[09:37:27 EST(-0500)] <colinclark> You have commit access, so you can always commit the patches if they're working (smile)
[09:37:51 EST(-0500)] <colinclark> The reason I made a patch last night was just because it was so late and I wasn't necessarily thinking clearly, but wanted you to see where I was at
[09:39:47 EST(-0500)] <sveto> ok, I'll now look quickly at object code entry and continue with my collection
[09:42:04 EST(-0500)] <colinclark> thanks
[09:51:15 EST(-0500)] <jamon> jessm: tell me when i can restart the wiki then, bunch of exceptions in its log
[09:53:40 EST(-0500)] <jessm> how about at 11:30? during standup?
[09:53:48 EST(-0500)] <jamon> sure that works for me jessm
[09:54:20 EST(-0500)] * sveto (~sveto@62.44.108.2) has left #fluid-work
[09:56:02 EST(-0500)] * yura (~yura@142.150.154.101) has joined #fluid-work
[09:59:54 EST(-0500)] <colinclark> yura: How's it going?
[10:00:07 EST(-0500)] <colinclark> It's gonna be a quiet morning in the office for you, I'm afraid. Justin and I are both on passport duty
[10:00:31 EST(-0500)] <colinclark> yura: I will be in this afternoon for sure, though. So we can do some coding then. I may need your help finishing up My Collection integration
[10:00:42 EST(-0500)] <colinclark> And I imagine there's still lots of Artifact View work to do
[10:00:49 EST(-0500)] <yura> colinclark: yes totally
[10:01:08 EST(-0500)] <yura> i m trying get as much done for artifact view right now , yes
[10:01:39 EST(-0500)] * justin_o (~jmo@2002:63e3:179a:0:21f:5bff:feca:f969) has joined #fluid-work
[10:11:49 EST(-0500)] <colinclark> hey jameswy
[10:11:58 EST(-0500)] <colinclark> I see there's maybe a new media badge icon floating around
[10:12:16 EST(-0500)] <colinclark> There is a JIRA for the fact that the media badges appear wacky in a few cases. You can attach the icon to that JIRA if you want
[10:12:26 EST(-0500)] <jameswy> colinclark: Great--will attach to that one.
[10:20:46 EST(-0500)] * clown (~clown@142.150.154.101) has joined #fluid-work
[10:25:49 EST(-0500)] <jessm> hey everyone, the wiki will be restarted at 11:30a today
[10:26:05 EST(-0500)] <jessm> jameswy: justin_o yura: ^
[10:26:24 EST(-0500)] <justin_o> jessm: thanks for the warning
[10:26:26 EST(-0500)] <yura> jessm: thanks
[10:26:27 EST(-0500)] <jameswy> jessm: thanks for the headsup!
[10:26:45 EST(-0500)] <jessm> sending to list too
[10:29:10 EST(-0500)] * sveto_ (~sveto@85.187.19.183) has joined #fluid-work
[10:30:14 EST(-0500)] * EricDalquist (~dalquist@2607:f388:e:0:221:9bff:fe37:e768) has joined #fluid-work
[10:42:23 EST(-0500)] <jameswy> colinclark: Yura showed me his screen, and it looks like the media badge icon is already up-to-date; someone must have pulled it off the graffle file, because it's not the old one I gave to Yura weeks ago.
[10:43:22 EST(-0500)] <justin_o> yura: i just made a samll update to the description html page, adding a meta tag to the head...
[10:43:46 EST(-0500)] <justin_o> this means that you will have to make sure you update before submitting your patch
[10:44:01 EST(-0500)] <yura> right, is that just the html page?
[10:44:52 EST(-0500)] * colinclark (~colin@bas2-toronto09-1176130909.dsl.bell.ca) has joined #fluid-work
[10:50:40 EST(-0500)] <justin_o> yura: yep just the html page
[10:52:43 EST(-0500)] <yura> thanks justin_o
[11:38:01 EST(-0500)] * EverettZ (~chatzilla@bas4-toronto06-1279277691.dsl.bell.ca) has joined #fluid-work
[11:39:08 EST(-0500)] <EverettZ> jessm: Is the Breeze currently used by Fluid the same as it was a year or so ago?
[11:39:22 EST(-0500)] <jessm> EverettZ: unfortunately, yes
[11:40:26 EST(-0500)] <EverettZ> jessm: Not to beat an old horse, but it is very discouraging to try to contribute to a project when there are accessibility barriers in so many places. Recognizing the help that I have received to find ways to reduce them.
[11:40:55 EST(-0500)] <EverettZ> jessm: Jira, Breeze, Wiki content, just to name a few.
[11:41:10 EST(-0500)] <jessm> EverettZ: thanks for your email re: wiki content
[11:41:33 EST(-0500)] <jessm> EverettZ: i just sent out an email with the tasks that we're working on – basically a text export of JIRA
[11:42:23 EST(-0500)] <jessm> EverettZ: if you'd like to join our standup we can certainly use Skype – the trouble we find is that we can't have people just pop into Skype, so we're a bit at a loss for what to do. We seem to try out a new system every few months hoping for something that works better
[11:43:15 EST(-0500)] <EverettZ> jessm: Yes, got your e-mail, and Justin was able to make me a filter a while back for Jira.
[11:43:20 EST(-0500)] * boyan (~boyan@62.44.108.2) has left #fluid-work
[11:44:55 EST(-0500)] <EverettZ> jessm: I'll let you know should a time come when I want to participate in the standup. I assume that is different from the design meeting at 3:30pm EDT.
[11:45:22 EST(-0500)] <jessm> EverettZ: yes, standup is everyone just updating on what they're working on for the day – it's about a 15 min. mtg.
[11:45:46 EST(-0500)] <jessm> EverettZ: we actually ahve been using skye for our design meetings because Breeze is so awful, so just let me know if you'd like to come today
[11:45:55 EST(-0500)] <jessm> that's the only drawback, you can't just pop in
[11:46:38 EST(-0500)] <EverettZ> jessm: I would like to participate in today's design meeting. I'd like to get a sense of what is happening with kiosk and maybe to ask a couple of questions so that I can give some thought to accessibility.
[11:46:53 EST(-0500)] <jessm> EverettZ: that would be excellent
[11:46:56 EST(-0500)] <EverettZ> jessm: Skype id is ezufelt
[11:47:43 EST(-0500)] <jessm> EverettZ: just added you
[11:47:45 EST(-0500)] <jessm> i'm jesshmitchell
[11:48:11 EST(-0500)] <EverettZ> jessm: Thanks, I'll see you this afternoon
[11:48:21 EST(-0500)] <jessm> looking forward to it
[11:52:57 EST(-0500)] <justin_o> jessm: just to update you ... i've resolved ENGAGE-280... I'll probably move onto one of the critical jiras (probably the toggle on the browse page). If anyone needs my help with a blocker issue though I'm available to help out
[11:53:11 EST(-0500)] <jessm> justin_o: great, thanks
[11:54:15 EST(-0500)] <jessm> justin_o: you've closed 280?
[11:54:28 EST(-0500)] <justin_o> well... i closed > opened > resolved it...
[11:54:45 EST(-0500)] <justin_o> it needs to get reviewed before it can be closed
[11:54:54 EST(-0500)] <jessm> that's what i was getting at
[11:54:58 EST(-0500)] <jessm> ok, so it's up for review
[11:55:01 EST(-0500)] <justin_o> yes
[12:01:07 EST(-0500)] <jessm> yura: you're on a blocker for artifact, right?
[12:02:07 EST(-0500)] <yura> jessm: yep
[12:02:19 EST(-0500)] <yura> several of them
[12:02:32 EST(-0500)] <jessm> yura: oh, good, carry on!
[12:39:06 EST(-0500)] * sveto_ (~sveto@85.187.19.183) has joined #fluid-work
[12:51:39 EST(-0500)] <sveto_> hi yura, I'm trying to get My Collection running, but I realized that the "view" Couch DB view doesn't emit a document id
[12:52:21 EST(-0500)] <sveto_> and I store the artifacts by id
[12:52:41 EST(-0500)] <sveto_> is it possible to add this to the view?
[13:03:22 EST(-0500)] * colinclark (~colin@142.150.154.101) has joined #fluid-work
[13:05:48 EST(-0500)] <colinclark> sveto_: I hear you were looking for yura. What's up?
[13:05:53 EST(-0500)] <colinclark> He's gone for lunch
[13:06:44 EST(-0500)] <sveto_> I think that he implemented the couch views, so I was asking him if we could add the document _id in the "view" view
[13:12:52 EST(-0500)] <colinclark> sveto_: I guess we can. Tell me more about what you're trying to accomplish.
[13:13:07 EST(-0500)] <colinclark> I'm guess it relates to the fact that Lucene views pass back the ID of a document as _id
[13:13:12 EST(-0500)] <colinclark> Whereas the standard views aren't doing that?
[13:13:29 EST(-0500)] <colinclark> Anyway, sveto, I sat down with ArtifactView a bit more while I was waiting at the passport office
[13:13:33 EST(-0500)] <sveto_> ok, as we are storing the artifacts by _id I need that to query them
[13:13:45 EST(-0500)] <colinclark> And I see the source of this whole confusion about the button getting smashed during rendering...
[13:14:19 EST(-0500)] <colinclark> Your setup procedure for ArtifactView and its subcomponent (the thing formerly called "collectionOperations") was in the wrong order, I think.
[13:14:28 EST(-0500)] <colinclark> You were initializing subcomponents before actually rendering the page
[13:14:38 EST(-0500)] <colinclark> So of course anything you do to the pre-rendered DOM will be gone after rendering
[13:14:58 EST(-0500)] <sveto_> so it is an option to do rendering first?
[13:15:01 EST(-0500)] <colinclark> So the real fix is to render first, then instantiate your subcomponents and let them attach themselves to the DOM
[13:15:10 EST(-0500)] <colinclark> Sure. You control the order of operations in your component
[13:15:25 EST(-0500)] <colinclark> One of the things you'll see that I did was to move out setup code from your creator function
[13:15:55 EST(-0500)] <colinclark> In the "that-ist" style of defining objects, there's a fuzziness between operations that define a "type" of component and setup operations.
[13:15:58 EST(-0500)] <colinclark> If that makes sense
[13:16:24 EST(-0500)] <colinclark> So I've found in both Artifact View and the ArtifactCollectView that setup code was sort of mixed into the creator function
[13:16:47 EST(-0500)] <sveto_> yes, that makes sense
[13:16:53 EST(-0500)] <colinclark> This is not something you did--others don't follow this pattern, but it does make code easier to read, and the lifecycle of construction clearer
[13:17:19 EST(-0500)] <colinclark> So anyway, I'm getting there. I'll now harmonize these changes with what's in your patch. What have you been up to in the past couple of hours?
[13:17:26 EST(-0500)] <colinclark> And tell me more about the ID issue
[13:17:27 EST(-0500)] <colinclark> (smile)
[13:17:46 EST(-0500)] <sveto_> I'm working on the i18n for my collection
[13:18:09 EST(-0500)] <sveto_> we need again to change the views to take an additional lang parameter to complete this
[13:18:33 EST(-0500)] <sveto_> about the id issue - the artifacts are stored in the users database as ids
[13:19:25 EST(-0500)] <sveto_> so when we add an artifact or remove it the service that takes care of that is doing so based on the artifact id
[13:19:39 EST(-0500)] <colinclark> Right
[13:20:07 EST(-0500)] <colinclark> And is it the case that lucene passes back artifact IDs as "_id" whereas our regular views pass them back as "id"?
[13:21:15 EST(-0500)] <sveto_> well, not exactly... ah! I think that I'm talking nonsenses, we should have the id, just outside the actual payload couchdb is returning
[13:21:34 EST(-0500)] <sveto_> I'm going to check that, but I'm almost sure it will work
[13:21:38 EST(-0500)] * anastasiac (~team@142.150.154.193) has joined #fluid-work
[13:25:06 EST(-0500)] <sveto_> of course the id is there, sorry for the noise
[13:26:28 EST(-0500)] <colinclark> sveto_: No worries
[13:26:39 EST(-0500)] <colinclark> It's good to chat through these things anyway
[13:26:55 EST(-0500)] <colinclark> So I have no idea if we're going to have a headache when we merge all of our MyCollection work together
[13:26:55 EST(-0500)] <justin_o> colinclark: so i've got the toggle showing on browse pages
[13:27:02 EST(-0500)] <colinclark> But I guess I'll take the pain on that (wink)
[13:27:04 EST(-0500)] <colinclark> justin_o: Ah, wicked
[13:27:09 EST(-0500)] <colinclark> Does it work ok?
[13:27:20 EST(-0500)] <justin_o> colinclark: yep... it works
[13:27:29 EST(-0500)] <colinclark> Nice
[13:27:51 EST(-0500)] <justin_o> however it is showing up on that one page extra, i could try to add yet another option in browse to hide this or something
[13:28:04 EST(-0500)] <justin_o> the extra page is exhibition browse
[13:28:52 EST(-0500)] <justin_o> colinclark: i think the problem that i'm having is that it doesn't really fit on the browse page
[13:29:09 EST(-0500)] <justin_o> although the browse page is already a monster... not sure if should give it another tentacle or not
[13:29:16 EST(-0500)] <colinclark> yack
[13:29:23 EST(-0500)] <colinclark> This is exactly what I was expecting
[13:29:25 EST(-0500)] <colinclark> So, just to confrim
[13:31:34 EST(-0500)] * elicochran (~elicochra@dhcp-169-229-212-8.LIPS.Berkeley.EDU) has joined #fluid-work
[13:32:28 EST(-0500)] <colinclark> sorry, one sec justin_o
[13:33:15 EST(-0500)] <justin_o> colinclark: sure
[13:42:50 EST(-0500)] <colinclark> To add the toggle to the catalogue browse page, you had to add it Browse, right?
[13:43:01 EST(-0500)] <colinclark> And that of course means that other Browse-based pages have it now, too?
[13:43:14 EST(-0500)] <colinclark> And the only solution would be to have some kind of option to Browse to enable toggle?
[13:43:18 EST(-0500)] <colinclark> justin_o: ^
[13:44:25 EST(-0500)] <justin_o> colinclark: yep
[13:44:30 EST(-0500)] <justin_o> that's basically it
[13:44:36 EST(-0500)] <colinclark> justin_o: I think there are only two options:
[13:44:39 EST(-0500)] <colinclark> 1. Leave it in for all pages
[13:44:43 EST(-0500)] <colinclark> 2. Add a tentacle
[13:44:48 EST(-0500)] <colinclark> What's your recommendation?
[13:45:40 EST(-0500)] <justin_o> i would rather go with option 1, but the interaction may be confusing on the exhibition browse page...
[13:46:23 EST(-0500)] <justin_o> colinclark: ^
[13:46:43 EST(-0500)] <colinclark> Ok, justin_o. I'd say add a tentacle
[13:46:45 EST(-0500)] <colinclark> (sad)
[13:47:18 EST(-0500)] <justin_o> colinclark: (sad) my thoughts exactly... since now both the browse and the navBar have to know about the toggle button
[13:47:41 EST(-0500)] <colinclark> Hmmm
[13:47:43 EST(-0500)] <colinclark> Let me see
[13:47:45 EST(-0500)] <colinclark> So it's a markup issue
[13:47:52 EST(-0500)] <justin_o> yes...
[13:48:09 EST(-0500)] <colinclark> The only real contract around that toggle button is "put the markup in the DOM"
[13:48:29 EST(-0500)] <colinclark> So, all you need to do is renderize the toggle button
[13:48:51 EST(-0500)] <colinclark> meaning, if the option is false, don't output the components in the tree
[13:48:59 EST(-0500)] <justin_o> okay
[13:49:10 EST(-0500)] <colinclark> So there's very little concern in the browse component for the toggle
[13:49:11 EST(-0500)] <justin_o> that makes sense
[13:49:20 EST(-0500)] <colinclark> It still sucks, but it's not so bad, justin_o
[14:03:57 EST(-0500)] <colinclark> sveto_: You around?
[14:04:07 EST(-0500)] <sveto_> yes, I'm here
[14:04:11 EST(-0500)] <colinclark> Cool
[14:04:18 EST(-0500)] <colinclark> So a question about something you mentioned earlier in the day
[14:04:22 EST(-0500)] <colinclark> Views for the user DB
[14:04:28 EST(-0500)] <colinclark> I'm thinking I didn't quite get things right last night...
[14:04:34 EST(-0500)] <colinclark> Let me post you the views I created
[14:05:11 EST(-0500)] <sveto_> ok
[14:05:22 EST(-0500)] <colinclark> sveto_: So these are the views I put into the mccord/_design/lucene document http://142.150.154.59:5984/_utils/document.html?mccord/_design/lucene
[14:05:38 EST(-0500)] <colinclark> Does one of these actually belong in the users database? I'll re-read your email, too (smile)
[14:05:51 EST(-0500)] <justin_o> jessm: ENGAGE-360 has been resolved and is ready for review
[14:05:57 EST(-0500)] <jessm> justin_o: roger that
[14:06:00 EST(-0500)] <colinclark> I thought that was a really hilarious title, "Handing in My Collection" (smile)
[14:06:09 EST(-0500)] <colinclark> justin_o: Is ENGAGE-360 the toggle fix you made?
[14:06:16 EST(-0500)] <justin_o> colinclark: yes
[14:06:22 EST(-0500)] <colinclark> justin_o: I guess I'm on deck to review it
[14:06:38 EST(-0500)] <justin_o> colinclark: thanks
[14:06:58 EST(-0500)] <colinclark> sveto_: so by_user_collection and by_user_artifacts should actually be in the users database, right?
[14:07:02 EST(-0500)] <jessm> justin_o: colinclark: it isn't a blocker
[14:07:12 EST(-0500)] <sveto_> colinclark: yes, both are in the users database
[14:07:17 EST(-0500)] <colinclark> I totally suck, I should have read things more closely, sveto_
[14:07:21 EST(-0500)] <justin_o> not too much code change and only 3 files touched
[14:07:29 EST(-0500)] <colinclark> Did you create non-lucene versions of these views, or should I just use them as-is?
[14:07:47 EST(-0500)] <colinclark> jessm: All the blockers were taken, so Justin squashed the next thing down on the list
[14:07:54 EST(-0500)] <colinclark> We're at a funny bottleneck point
[14:07:58 EST(-0500)] <jessm> colinclark: roger that
[14:08:13 EST(-0500)] <colinclark> justin_o: I think you should spend some time with yura over skype
[14:08:20 EST(-0500)] <colinclark> He's probably feeling the pressure, as I am
[14:08:29 EST(-0500)] <colinclark> Otherwise, justin_o, you can pair with me
[14:08:34 EST(-0500)] <sveto_> colinclark: no, not really, I'll try to do it tomorrow I guess
[14:08:45 EST(-0500)] <colinclark> sveto_: Okay. The lucene views will be fine for the time being
[14:09:29 EST(-0500)] <justin_o> colinclark: sure....
[14:09:44 EST(-0500)] <sveto_> colinclark: I've done some changes that should allow i18n, should I commit them, or supply them as a patch?
[14:09:50 EST(-0500)] <colinclark> sure to me or sure to yura? (smile) You don't have to pick your favourites
[14:09:57 EST(-0500)] <justin_o> yura: would you like me to pair up with you or should i team up with colin
[14:10:05 EST(-0500)] <colinclark> sveto_: good question.
[14:10:09 EST(-0500)] <colinclark> I fear conflicts galore
[14:10:14 EST(-0500)] <colinclark> Let me ask you a few questions first...
[14:10:14 EST(-0500)] <justin_o> colinclark: sorry wasn't finished
[14:10:28 EST(-0500)] <colinclark> justin_o: I was just kidding anyway
[14:10:39 EST(-0500)] <justin_o> (smile)
[14:11:02 EST(-0500)] <colinclark> sveto_: Can your i18n changes go in without the two patches we created?
[14:11:08 EST(-0500)] <colinclark> Or does it depend on changes in those patches?
[14:12:06 EST(-0500)] <sveto_> colinclark: I've applied the patches, so they are dependant, yes
[14:12:14 EST(-0500)] <colinclark> sveto_: Ok, make a patch then
[14:12:19 EST(-0500)] <colinclark> I will deal with sorting them all out
[14:12:24 EST(-0500)] <colinclark> sveto_: Luck me, eh? (smile)
[14:12:44 EST(-0500)] <yura> justin_o: I m really close to finish some chunk of artifactView, so we can pair up some time soon if I m stuck ? how does that sound?
[14:12:53 EST(-0500)] <colinclark> sveto_: One other thing...
[14:12:58 EST(-0500)] <sveto_> colinclark: (smile) I'll make a patch after you commit to trunk, the changes are not too much to reproduce
[14:13:05 EST(-0500)] <colinclark> ok, cool
[14:13:11 EST(-0500)] <colinclark> that'd be super awesome, sveto_
[14:13:12 EST(-0500)] <colinclark> Thanks
[14:13:24 EST(-0500)] <colinclark> sveto_: So, yes.... I had trouble applying your object code view patch to trunk
[14:13:35 EST(-0500)] <colinclark> I'm slightly distracted today, so it could have been my own stupidity
[14:13:43 EST(-0500)] <colinclark> But did you make that patch against your old codeEntry branch or against trunk?
[14:13:54 EST(-0500)] <justin_o> yura: sure sounds good
[14:13:56 EST(-0500)] <colinclark> And, either way, did you have any success applying it against trunk?
[14:14:08 EST(-0500)] <colinclark> justin_o: I guess that means you're free to pair with me?
[14:14:15 EST(-0500)] <justin_o> colinclark: yep
[14:14:24 EST(-0500)] <colinclark> justin_o: iChat or Skype?
[14:14:30 EST(-0500)] <colinclark> I guess iChat would allow you to actually drive
[14:14:37 EST(-0500)] <sveto_> colinclark: good question, I think it was trunk, but I'll check again
[14:14:37 EST(-0500)] <colinclark> Do you do iChat, justin_o?
[14:14:42 EST(-0500)] <colinclark> sveto_: Thanks
[14:14:45 EST(-0500)] <justin_o> yep... i'll just fire it up
[14:15:02 EST(-0500)] <colinclark> The reason I thought it might be the branch was that you had the fluid-engage-kettle project named as "fluid-engage"
[14:15:16 EST(-0500)] <colinclark> Which was the case in your branch, but I didn't merge that change to the project file into trunk
[14:15:36 EST(-0500)] <colinclark> justin_o: We'll start by reviewing your 360 changes
[14:15:51 EST(-0500)] <colinclark> Then we'll move on to untangling a few patches and wrapping up the My Collectn work.
[14:15:59 EST(-0500)] <colinclark> The view is working awesome now
[14:16:06 EST(-0500)] <colinclark> And sveto_'s made lots of progress, too
[14:16:13 EST(-0500)] <justin_o> great
[14:17:40 EST(-0500)] <jessm> colinclark: um, i might have found something re: Jr. Jr. FJ
[14:18:22 EST(-0500)] <colinclark> jessm: ok, what's up?
[14:18:39 EST(-0500)] <jessm> i can make the scroll bar disappear
[14:18:48 EST(-0500)] <colinclark> jessm: overflow: none?
[14:18:54 EST(-0500)] <jessm> no
[14:19:20 EST(-0500)] <jessm> the .fl-list-thumbnails is set at 0 25px -12px 42px;
[14:19:27 EST(-0500)] <jessm> that negative bottom is causing it
[14:19:44 EST(-0500)] <jessm> if i change it to 0 or 10 or 12 the scroll disappears
[14:20:00 EST(-0500)] <jessm> the negative 12 seems to be the culprit
[14:24:49 EST(-0500)] <colinclark> jessm: sorry, one sec
[14:26:48 EST(-0500)] <colinclark> jessm: That sounds pretty great.
[14:26:59 EST(-0500)] <colinclark> Were you able to bring the description up into the correct alignment/
[14:27:00 EST(-0500)] <colinclark> ?
[14:27:06 EST(-0500)] <colinclark> Or does this fix just get rid of the scroll bards?
[14:27:09 EST(-0500)] <colinclark> bars
[14:27:11 EST(-0500)] <colinclark> can't type (tongue)
[14:27:41 EST(-0500)] <jessm> oh, i didn't know there was an issue with description, but this fix does align the artist name with the piece name
[14:27:49 EST(-0500)] <jessm> what is this other issue? descriptions?
[14:35:29 EST(-0500)] <colinclark> jessm: yeah, you've got it
[14:35:32 EST(-0500)] <colinclark> I think you've fixed it
[14:35:47 EST(-0500)] <jessm> flc-navigationList
[14:36:34 EST(-0500)] <jessm> here it is: http://build.fluidproject.org:8095/engage/fluid-infusion/src/webapp/framework/fss/css/fss-mobile-layout.css
[14:36:52 EST(-0500)] <jessm> line 255
[14:37:24 EST(-0500)] <sveto_> colinclark: I think that the patch was created against the trunk, but I too have problems applying it, I'll make another one
[14:37:34 EST(-0500)] <colinclark> sveto_: thanks so much
[14:37:54 EST(-0500)] <jessm> i don't have a JIRA #, just this: http://build.fluidproject.org:8095/engage/catalogue/view.html?db=mccord_exhibitions&amp;title=Simply+Montr%C3%A9al%3A+Glimpses+of+a+Unique+City&amp;lang=en
[14:38:32 EST(-0500)] <colinclark> jessm: Okay, let me look at where the best place to put thi sis
[14:42:14 EST(-0500)] <colinclark> jessm: You're totally right...
[14:43:02 EST(-0500)] <colinclark> The right place to implement this fix is in fluid-engage-core/trunk/components/catalogue/css/Catalogue.css
[14:43:20 EST(-0500)] <colinclark> You'll want to write a new declaration for .fl-list-thumbnail, overriding the default in the mobile theme
[14:44:40 EST(-0500)] <jameswy> yura and I just tested the video items under an artifact on the iPod, and it works fabulously! It's awesome.
[14:44:58 EST(-0500)] <yura> jameswy: yey
[14:54:22 EST(-0500)] <colinclark> so amazing
[14:54:27 EST(-0500)] <colinclark> I needed that news, jameswy! (smile)
[15:01:19 EST(-0500)] <jessm> colinclark: is there anyway i can test my patch before submitting?
[15:03:32 EST(-0500)] <yura> hey justin_o, do you have some time do you have some time now to pair up with me to look at some issues i m dealing with (smile)?
[15:04:14 EST(-0500)] <justin_o> yura: i think so... I'm still waiting for colin to get back
[15:04:22 EST(-0500)] <yura> ya he said i can steal you (smile)
[15:04:43 EST(-0500)] <justin_o> yura: okay... then definitely i'm free
[15:05:02 EST(-0500)] <yura> i m in skype
[15:05:04 EST(-0500)] <yura> signing in
[15:06:04 EST(-0500)] <justin_o> okay...
[15:08:09 EST(-0500)] <colinclark> jessm: sorry, was filling up the tea kettle
[15:08:26 EST(-0500)] <colinclark> So the answer to your question is yes. But it's a bit theoretical
[15:08:41 EST(-0500)] <colinclark> One of the things we try to always do is make sure that our components work nicely even without the server in place.
[15:08:56 EST(-0500)] <colinclark> You should be able to open up the catalogue page and work with it straight off the file system
[15:09:13 EST(-0500)] <colinclark> However, we cut some corners when implementing some of the 0.3 pages
[15:09:22 EST(-0500)] <colinclark> So a few aren't correctly previewing from the file system. There's a JIRA about it.
[15:09:27 EST(-0500)] <jessm> yes, am doing that, but the html renders badly in the browser by itself
[15:09:28 EST(-0500)] <colinclark> jessm: Lemme check the catalogue page
[15:09:32 EST(-0500)] <colinclark> jessm: yack
[15:09:33 EST(-0500)] <colinclark> sorry
[15:09:38 EST(-0500)] <jessm> not your fault
[15:09:49 EST(-0500)] <jessm> ok, i'll submit the patch and then take a look at it again, sound ok?
[15:10:05 EST(-0500)] <colinclark> yep, sounds good
[15:10:09 EST(-0500)] <colinclark> jessm: So in terms of your patch
[15:10:16 EST(-0500)] <colinclark> Here's a few rules of thumb to make it Awesome
[15:10:24 EST(-0500)] * jessm listening
[15:10:28 EST(-0500)] <colinclark> 1. Start with a clean and shiny working copy
[15:10:47 EST(-0500)] <colinclark> 2. If your working copy has been sitting around for a bit, make sure you update to get any of the latest changes in the repo
[15:10:55 EST(-0500)] <jessm> rt
[15:10:56 EST(-0500)] <colinclark> That's pretty much it
[15:11:04 EST(-0500)] <jessm> so, those two are the same (wink)
[15:11:08 EST(-0500)] <colinclark> yeah
[15:11:13 EST(-0500)] <colinclark> It's really important (tongue)
[15:11:17 EST(-0500)] <jessm> lol
[15:17:40 EST(-0500)] * elicochran_ (~elicochra@2607:f140:400:166:21b:63ff:fec8:1179) has joined #fluid-work
[15:19:25 EST(-0500)] <jessm> colinclark: so, just a detail, but the value gets fixed when i change it on the span level – am i going to screw up the whole page by fixing it on the catalogue level?
[15:19:48 EST(-0500)] <colinclark> I doubt it, no
[15:19:53 EST(-0500)] <colinclark> The only way to know is to try it
[15:19:59 EST(-0500)] <jessm> (smile)
[15:20:03 EST(-0500)] <colinclark> You should be able to use Firebug to apply it correctly and test it
[15:20:03 EST(-0500)] <jessm> ok, i'm diving in
[15:20:08 EST(-0500)] <jessm> we can always revert
[15:20:10 EST(-0500)] <colinclark> sure
[15:26:19 EST(-0500)] <jessm> colinclark: so, there are actually three changes that need to happen
[15:26:26 EST(-0500)] <colinclark> jessm: ok
[15:26:26 EST(-0500)] <jessm> and i might need a bit of talkign through this
[15:26:32 EST(-0500)] <colinclark> ok, i can do that
[15:26:43 EST(-0500)] <jessm> colinclark: cool
[15:26:58 EST(-0500)] <colinclark> here or on skype?
[15:27:05 EST(-0500)] <jessm> so, there are three items that make up one row
[15:27:09 EST(-0500)] <jessm> here is fine with me
[15:27:13 EST(-0500)] <colinclark> ok
[15:27:43 EST(-0500)] <jessm> <img class> thumbnail, <div class> title, and <span class> artist and/or date
[15:28:05 EST(-0500)] <jessm> to fix the scrolling i made a change to the fl-list-thumbnails for <span class>
[15:28:49 EST(-0500)] <jessm> to fix the bottom space i made a fix to the fl-list-thumbnails:not
[15:29:19 EST(-0500)] <jessm> to fix the left justify with the title i change the fl-list-thumbnails for <img class>
[15:29:38 EST(-0500)] <jessm> so, changing the one catalogue.css isn't going to do it, eh?
[15:30:33 EST(-0500)] <colinclark> jessm: I think you can just change the one CSS file
[15:30:43 EST(-0500)] <colinclark> But it seems to me that you should scope your selectors a little more generically
[15:30:56 EST(-0500)] <jessm> but i require two different values for the same fl-list-thumbnails
[15:31:21 EST(-0500)] <jessm> crap, design mtg.
[15:31:30 EST(-0500)] <colinclark> We can pick it up when you're done
[15:31:39 EST(-0500)] <colinclark> I think I'm confused by your fix, but I bet it's easy
[15:44:15 EST(-0500)] * Bosmon (~a@174-29-5-229.hlrn.qwest.net) has joined #fluid-work
[15:44:27 EST(-0500)] <Bosmon> Interesting article on "CSS 'not' hacks"
[15:44:28 EST(-0500)] <Bosmon> http://www.digital-web.com/articles/CSS_not_hacks/
[15:44:40 EST(-0500)] <Bosmon> It appears that "last-child" is not generally supported
[15:44:44 EST(-0500)] <Bosmon> And neither is the "not()" selector
[15:45:38 EST(-0500)] <Bosmon> I guess the browsers in the iPod touches will be a kind of Webkit 3?
[15:50:03 EST(-0500)] <colinclark> Bosmon: yeah, that's the really great thing about these new themes
[15:50:10 EST(-0500)] <colinclark> They can safely be defined for a specific browser platform
[15:50:11 EST(-0500)] <colinclark> We
[15:50:11 EST(-0500)] <colinclark> have
[15:50:23 EST(-0500)] <colinclark> We have no strong future plans to support non-WebKit platforms
[15:50:23 EST(-0500)] <colinclark> A
[15:50:27 EST(-0500)] <colinclark> Weird
[15:50:33 EST(-0500)] <colinclark> Something's wrong with my keyboard
[15:50:51 EST(-0500)] <colinclark> Anyway, if we were to implement support for a non-WebKit platform, it'd be a very different thing
[15:50:57 EST(-0500)] <colinclark> With very different style declarations
[15:51:11 EST(-0500)] <colinclark> So this is one case where we can feel pretty decent about using CSS 3 selectors that aren't supported by IE (smile)
[15:55:43 EST(-0500)] <jessm> colinclark: do you know what JIRA i was working on?
[15:56:16 EST(-0500)] <colinclark> Lemme look it up
[16:03:33 EST(-0500)] <colinclark> jessm: I don't think we have a JIRA for your issue
[16:05:07 EST(-0500)] <jessm> colinclark: i'll create one
[16:05:12 EST(-0500)] <colinclark> thanks, jessm
[16:14:35 EST(-0500)] <jessm> colinclark: let's give it a whirl: http://issues.fluidproject.org/browse/ENGAGE-363
[16:14:41 EST(-0500)] <jessm> patched and such
[16:18:36 EST(-0500)] <colinclark> jessm: Your selector for the fl-link-summary seems a bit extreme. Does it need to be?
[16:19:13 EST(-0500)] <jessm> colinclark: you mean padding 0?
[16:19:26 EST(-0500)] <colinclark> Yeah, the selector you use to add that padding
[16:20:08 EST(-0500)] <jessm> colinclark: the padding there is taken care of w/ the bottom of the thumbnail
[16:20:18 EST(-0500)] <jessm> so, i made 3 changes here:
[16:20:50 EST(-0500)] <jessm> .fl-list-thumbnails > li a .fl-icon and the next two
[16:21:34 EST(-0500)] <colinclark> So it's this selector I'm wondering about:
[16:21:35 EST(-0500)] <colinclark> .fl-list-thumbnails:not(.fl-thumbnails-expanded):not(.fl-list-brief) > li a > .fl-icon ~ .fl-link-summary
[16:21:45 EST(-0500)] <colinclark> It shows a remarkable prowess for sophisticated selector usage
[16:21:51 EST(-0500)] <colinclark> But I'm wondering if it's a bit... baroque?
[16:22:02 EST(-0500)] <colinclark> Would this selector work instead, or is there a big specificity issue?
[16:22:12 EST(-0500)] <jessm> colinclark: um, am i going to get in trouble for saying it's a copy/paste?
[16:22:20 EST(-0500)] <colinclark> jessm: From where?
[16:22:27 EST(-0500)] <colinclark> jessm: And yes, you will get in trouble (tongue)
[16:23:42 EST(-0500)] <jessm> from <span class> for the artist and date
[16:24:08 EST(-0500)] <jessm> fss-mobile-layout.css
[16:26:29 EST(-0500)] <colinclark> jessm: I'm gonna have to punt on this one for a bit
[16:26:30 EST(-0500)] <colinclark> I
[16:26:40 EST(-0500)] <colinclark> I need to get My Collection sorted out, then you're on deck
[16:26:54 EST(-0500)] <jessm> colinclark: k
[16:27:06 EST(-0500)] <colinclark> But I think you can probably apply that style in a more simple way if you avoid cut and paste
[16:27:20 EST(-0500)] <colinclark> FSS has to do it the hard way, but you don't need to when you're overriding it
[16:27:39 EST(-0500)] <jessm> colinclark: i can take another crack at it then
[16:50:13 EST(-0500)] <colinclark> Bosmon / Bosmon2: Are one of you alive?
[16:51:07 EST(-0500)] <Bosmon> yes
[16:51:09 EST(-0500)] <Bosmon> This one is living (tongue)
[16:51:16 EST(-0500)] <Bosmon> THE ORIGINAL AND BEST"!
[16:53:04 EST(-0500)] <colinclark> ah Bosmon you are there
[16:53:05 EST(-0500)] <colinclark> sorry
[16:53:10 EST(-0500)] <colinclark> So super-quick question
[16:53:13 EST(-0500)] <colinclark> Query parameter parsing
[16:53:20 EST(-0500)] <colinclark> It's something we have to do a bit of on the client
[16:53:21 EST(-0500)] <colinclark> Not ideal
[16:53:32 EST(-0500)] <colinclark> And there's really nothing there for us. It's nasty and error prone
[16:53:35 EST(-0500)] <Bosmon> I see
[16:53:44 EST(-0500)] <Bosmon> I guess we need to down-port a bit of kettleUtils.js
[16:53:50 EST(-0500)] <Bosmon> None of that stuff actually depends on Kettle....
[16:53:52 EST(-0500)] <colinclark> that'd be awesome
[16:54:01 EST(-0500)] <colinclark> yura is the one who most needs it at the moment
[16:54:09 EST(-0500)] <colinclark> Shall I ask him to take a stab at it, and then you can review a patch?
[16:54:25 EST(-0500)] <Bosmon> Well.... there is not too much "patch" about it
[16:54:31 EST(-0500)] <Bosmon> We'd just need to change the path
[16:54:50 EST(-0500)] <Bosmon> It's a shame that we never managed to get round to factoring Kettle
[16:54:56 EST(-0500)] <colinclark> In other words, we'd need to move a function from kettleUtils "up" a bit?
[16:55:09 EST(-0500)] <Bosmon> I can't see why we shouldn't move the whole of kettleUtils...
[16:55:37 EST(-0500)] <Bosmon> Some of that stuff belongs in the core framework anyway
[16:56:04 EST(-0500)] <Bosmon> I guess the contentTypes stuff would be a bit too heavyweight on the client
[16:56:48 EST(-0500)] <Bosmon> But noone need include that
[16:57:13 EST(-0500)] <Bosmon> I'm afraid to put it in the same directory as Engage.js though (smile)
[16:57:17 EST(-0500)] <Bosmon> Can we make a new one? (tongue)
[17:04:08 EST(-0500)] <colinclark> Bosmon: a new directory? (tongue)
[17:04:19 EST(-0500)] <colinclark> I can't see any reason not to put it in the same directory
[17:04:32 EST(-0500)] <colinclark> But, to be clear, I'm already pretty worried about the weight of code we ship to the client
[17:04:44 EST(-0500)] <colinclark> These phones are not as speedy at chewing through source as the desktop browsers are
[17:05:06 EST(-0500)] <colinclark> So I think we should adopt a "move when in dire need" strategy
[17:05:16 EST(-0500)] * justin_o (~jmo@CPE001b63f2cc0e-CM0011aec4b062.cpe.net.cable.rogers.com) has joined #fluid-work
[17:22:01 EST(-0500)] * clown (~clown@142.150.154.101) has left #fluid-work
[17:48:42 EST(-0500)] * anastasiac (~team@142.150.154.193) has left #fluid-work
[19:17:58 EST(-0500)] * yura (~yura@bas3-toronto06-2925097429.dsl.bell.ca) has joined #fluid-work
[21:59:04 EST(-0500)] * colinclark (~colin@bas2-toronto09-1176130909.dsl.bell.ca) has joined #fluid-work