fluid-work IRC Logs-2013-11-20

Owned by Fluid IRC Log Bot
Last updated: Nov 20, 2013
7 min read

[08:04:23 CST(-0600)] <Justin_o> Bosmon: do you have a chance to look over FLUID-5205 again? https://github.com/fluid-project/infusion/pull/433

[08:40:01 CST(-0600)] <Bosmon> Hi Justin_o - apart from one very small comment, it seems ok

[08:40:13 CST(-0600)] <Bosmon> But perhaps you could talk more about your "renderOnPreference" issue

[08:40:28 CST(-0600)] <Justin_o> which issue was that again?

[08:41:38 CST(-0600)] <Bosmon> You commented in the test, "@amb26 I am using the renderOnPreference option to indicate which preference to base the creation and destruction of the sub panel on. I would have preferred to have put this up one level so that it was the configuration to the composite panel for when to create it. "

[08:41:54 CST(-0600)] <Justin_o> Bosmon: ah yes.. that one..

[08:41:59 CST(-0600)] <Bosmon> The issue is a bit unclear

[08:42:02 CST(-0600)] <Bosmon> Could you explain it more fully?

[08:42:16 CST(-0600)] <Justin_o> Bosmon: i had wanted renderOnPreference to be at the same level as createOnEvent

[08:42:33 CST(-0600)] <Justin_o> but the options you can specify there are restricted

[08:42:48 CST(-0600)] <Justin_o> so i had to move it down into the components own options

[08:42:54 CST(-0600)] <Bosmon> ok

[08:42:57 CST(-0600)] <Justin_o> the sub panels own options that is

[08:43:09 CST(-0600)] <Bosmon> Why would you want it further up?

[08:43:31 CST(-0600)] <Justin_o> it just seemed like a more suitable space since it does something similar to createOnEvent

[08:43:40 CST(-0600)] <Justin_o> brb.. going for coffee walk

[08:43:42 CST(-0600)] <Bosmon> ok

[08:43:54 CST(-0600)] <Bosmon> Well, you don't get to put your own options at the higher level : P

[08:44:01 CST(-0600)] <Bosmon> But I was wondering about the comment about the dynamic grade

[09:07:15 CST(-0600)] <Justin_o> Bosmon: you mean in regards to the same issue?

[09:07:31 CST(-0600)] <Bosmon> yes

[09:10:15 CST(-0600)] <Justin_o> Bosmon: well i was going to change the argument map so that i could add the option at the higher level.. the only place that seemed appropriate for this was in the subpanel base grade, but this is supplied dynamically so would happen to late.

[09:12:50 CST(-0600)] <Bosmon> Oh, I see

[09:12:57 CST(-0600)] <Bosmon> Ok, I wouldn't worry about that

[09:13:10 CST(-0600)] <Bosmon> I think the pull looks ok

[09:13:15 CST(-0600)] <Bosmon> What is necessary in order to test it?

[09:15:09 CST(-0600)] <Justin_o> Bosmon: Unfortunately we don't have any demos of this functionality. We do have unit tests which you can run through.. i'd suggest at least the panels, auxbuilder, and builder tests.. if not all of the preference framework ones.. also you might want to run through one of the demos just to make sure nothing else broke in the process.. the UIO one and/or the

[09:15:09 CST(-0600)] <Justin_o> manual tests.

[09:15:39 CST(-0600)] <Justin_o> Bosmon: anastasiac also has some test code she's been working with for instructional demos, you might be able to grab those from her as well

[09:15:58 CST(-0600)] <Bosmon> Justin_o - could this test code be worked up into some manual tests?

[09:17:23 CST(-0600)] <Bosmon> The report that "anastasiac was unable to break it" that I heard from michelled is promising, but it is proper to have something clearer

[09:17:38 CST(-0600)] <anastasiac> Bosmon and Justin_o, I was actually hoping to discuss the idea of instructional demos at the community meeting this afternoon; we came up with the idea a long time ago, but never followed through

[09:17:51 CST(-0600)] <Justin_o> Bosmon: i've tried to capture them into the unit tests

[09:17:52 CST(-0600)] <anastasiac> they could serve as both instruction and test case

[09:18:21 CST(-0600)] <Bosmon> anastasiac - that sounds promising

[09:18:33 CST(-0600)] <Bosmon> Especially if they are committed into the main repository (smile)

[09:18:36 CST(-0600)] <anastasiac> Bosmon, will you be joining the community meeting today?

[09:18:41 CST(-0600)] <Bosmon> yes

[09:18:54 CST(-0600)] <anastasiac> excellent; why don't we discuss it then?

[09:19:31 CST(-0600)] <Bosmon> cool

[09:22:05 CST(-0600)] <anastasiac> Bosmon, the code that Justin_o was referring to is here: https://github.com/acheetham/infusion/tree/PFID/src/instructionalDemos/framework/preferences/compositeSchemas

[09:22:36 CST(-0600)] <anastasiac> Bosmon, be warned, it's not yet "master" worthy! It's just my poking and exploring, so that I can understand enough to document it.

[09:23:35 CST(-0600)] <Bosmon> What does "PFID" stand for?

[09:23:53 CST(-0600)] <Justin_o> Bosmon: just looking at your comment on FLUID-5205, what is the problem with the alwaysFlag exactly?

[09:24:15 CST(-0600)] <Bosmon> Justin_o - well, it defines a value that is used once, and only defines it privately

[09:24:20 CST(-0600)] <Bosmon> So it doesn't seem to serve a purpose

[09:24:47 CST(-0600)] <Justin_o> Bosmon: it's used for the check on line 251

[09:25:02 CST(-0600)] <Bosmon> Justin_o - yes - that counts as being used once (smile)

[09:25:29 CST(-0600)] <Justin_o> Bosmon: okay.. i guess it was there to make changing easier, but we can drop it and just use the string in the conditional check

[09:26:42 CST(-0600)] <anastasiac> Bosmon: prefs framework instructional demos

[09:27:11 CST(-0600)] <anastasiac> Bosmon, if we decide to formalize this, we'll create a JIRA and I'll put it in a proper branch (smile)

[09:28:19 CST(-0600)] <Bosmon> anastasiac - why would we have any work without a JIRA? : P

[09:28:27 CST(-0600)] <Bosmon> "consider it formalised" : P

[09:28:53 CST(-0600)] <anastasiac> so no need to discuss whether or not to add instructional demos to master in the meeting this afternoon?

[09:29:14 CST(-0600)] <Bosmon> Well, we can certainly discuss it

[09:29:22 CST(-0600)] <Bosmon> But I think that anything that we spend time on deservers a JIRA

[09:29:27 CST(-0600)] <Bosmon> deserves

[09:29:59 CST(-0600)] <Bosmon> Certainly, anything we spend as significant a time on as it looks like you have

[09:30:56 CST(-0600)] <Justin_o> Bosmon: i just updated the FLUID-5205 branch to address your last comment

[09:31:40 CST(-0600)] <Bosmon> Justin_o - thanks - I consider it "ready to go" subject to the issue of having anastasiac's demos integrated with it

[09:32:10 CST(-0600)] <Justin_o> Bosmon: interesting.. so we will need to merge in anastasiac demo first

[09:32:47 CST(-0600)] <Bosmon> We certainly shouldn't have something that "has the moral force of test cases" which doesn't actually accompany the code

[09:33:37 CST(-0600)] <Bosmon> It appears that from my informal discussions with people, anastasiac's code has a substantial effect in convincing people that your implementation is correct : P

[09:34:13 CST(-0600)] <anastasiac> Well, I'm fine if you want to merge the branch, but it probably wouldn't pass a code review at this point. You might want to give me a bit of time to tidy it up (smile)

[09:34:20 CST(-0600)] <Justin_o> Bosmon: okay.. i guess we can make them manual tests for now and then move them to instructional demos post that discussion.. does that sound okay to you too anastasiac

[09:34:41 CST(-0600)] <Bosmon> anastasiac - cool - let me know when you're happy for me to look it over

[09:34:58 CST(-0600)] <Justin_o> anastasiac: when do you think it might be ready to go?

[09:35:03 CST(-0600)] <anastasiac> Bosmon, Justin_o, should I move them to the manual tests folder before a pull request?

[09:35:11 CST(-0600)] <anastasiac> Justin_o, maybe this afternoon?

[09:35:19 CST(-0600)] <Justin_o> anastasiac: oh great thanks..

[09:35:27 CST(-0600)] <Bosmon> I think that's reasonable

[09:35:36 CST(-0600)] <Bosmon> Let me poll colinclark if he has an ear....

[09:35:45 CST(-0600)] <anastasiac> I'll do this under 5205 for now; make sense, Justin_o?

[09:37:15 CST(-0600)] <Justin_o> anastasiac: seems reasonable to me

[09:38:03 CST(-0600)] <Bosmon> anastasiac - perhaps you could write a JIRA explaining the goals of the "PFID" and how we can measure if they have been achieved

[09:38:20 CST(-0600)] <Justin_o> Bosmon: did you get a chance to look at the jQuery UI upgrade..i think you had wanted to change the tooltip and tabs components in the process

[09:38:40 CST(-0600)] <Bosmon> Justin_o - I didn't look at it yet

[09:38:45 CST(-0600)] <Bosmon> Is there any significant breakage?

[09:38:59 CST(-0600)] <Bosmon> I think only the tooltip needed particular improvement

[09:39:07 CST(-0600)] <Justin_o> Bosmon: only that they don't work and through errors, if i remember correctly (smile)

[09:39:08 CST(-0600)] <Bosmon> To account for the new capability of updating a tooltip contents

[09:40:30 CST(-0600)] <Justin_o> Bosmon: if you are interested you can look at what i've started in this branch https://github.com/jobara/infusion/tree/FLUID-5185

[09:40:56 CST(-0600)] <Justin_o> it has Qunit updated and the new jQuery UI + plugins, but doesn't fix the tooltip and tabs components yet

[09:41:50 CST(-0600)] <Justin_o> Bosmon: i had been thinking of trying to create a generic jQuery UI wrapper component.. but haven't gotten to that yet.

[09:42:19 CST(-0600)] <Justin_o> although i'd guess your changes to tooltip would likely go beyond that

[09:42:36 CST(-0600)] <Bosmon> Justin_o - we already have the "that-ist bridge" : P

[09:42:46 CST(-0600)] <Bosmon> But I think any wrappers we make had best be done by hand

[09:42:56 CST(-0600)] <Bosmon> We could create a declarative scheme for automating this a bit

[09:43:01 CST(-0600)] <Bosmon> But there's no substitute for THOUGHT in this area

[09:43:28 CST(-0600)] <Justin_o> Bosmon: okay.. (smile) that makes sense...

[09:51:46 CST(-0600)] <anastasiac> Bosmon, Justin_o, I've created two JIRAs related to instructional demos: http://issues.fluidproject.org/browse/FLUID-5215 which is the umbrella issue that describes the overall goal, and http://issues.fluidproject.org/browse/FLUID-5216 which is a sub-task specific to the prefs framework. The idea is that we'd create other sub-tasks for each component, etc. Let me know if you think these JIRAs describe things adequately

[09:58:07 CST(-0600)] <Justin_o> anastasiac: they look good to me

[10:16:49 CST(-0600)] <anastasiac> Justin_o and Bosmon, I've filed another JIRA that we might discuss this afternoon as part of the instructional demos discussion: http://issues.fluidproject.org/browse/FLUID-5217

[10:18:14 CST(-0600)] <Justin_o> anastasiac: makes sense.. could be a factor for the build scripts too

[10:18:39 CST(-0600)] <anastasiac> good point

[10:19:17 CST(-0600)] <anastasiac> Justin_o, I've added a comment about that to the JIRA

[10:27:23 CST(-0600)] <Justin_o> anastasiac: thanks

[10:42:28 CST(-0600)] <Justin_o> Bosmon: would you mind taking a look at my FLUID-5214 pull request.. should be really easy to review https://github.com/fluid-project/infusion/pull/436

[11:30:11 CST(-0600)] <jhung> anastasiac, jessm, danaayotte, vjoanna: Ready to chat Metadata authoring?

[11:30:31 CST(-0600)] <vjoanna> jhung: yep

[11:30:53 CST(-0600)] <danaayotte> ready

[11:30:56 CST(-0600)] <anastasiac> getting Skype running

[12:05:20 CST(-0600)] <jhung> jessm, anastasiac I sent you both invites to the meeting. Let me know if you get anything.

[12:05:39 CST(-0600)] <anastasiac> jhung, email?

[12:05:54 CST(-0600)] <jhung> Possibly anastasiac? check ocadu address.

[12:06:25 CST(-0600)] <anastasiac> nothing anywhere yet

[12:33:02 CST(-0600)] <Bosmon> Justin_o - FLUID-5214 is in

[13:23:14 CST(-0600)] <Justin_o> Bosmon: thanks

[13:32:58 CST(-0600)] <Justin_o> fluid-everyone: would anyone like to join the community meeting remotely today?

[13:36:19 CST(-0600)] <Bosmon> Hi Justin_o

[13:37:08 CST(-0600)] <Justin_o> Bosmon: hello

[13:37:21 CST(-0600)] <anastasiac> fluid-everyone: michelled has brought some lovely loukoumades for the Community Meeting this afternoon, for those of you in the office in TO

[13:38:02 CST(-0600)] <Bosmon> wow

[13:38:41 CST(-0600)] <anastasiac> sorry, Bosmon

[13:39:11 CST(-0600)] <Bosmon> I will have to make do with my day-old sushi : P

[13:42:41 CST(-0600)] <anastasiac> michelled, are you going to be able to join us today?

[13:57:24 CST(-0600)] <Justin_o> https://www.piratepad.ca/p/instructional_demos

[14:16:13 CST(-0600)] <Justin_o> http://wiki.fluidproject.org/display/fluid/Docs+Sprint+Planning

[14:29:29 CST(-0600)] <Justin_o> Bosmon: here's the 1.4 version http://wiki.fluidproject.org/display/Infusion14/Demand+Resolution

[15:04:29 CST(-0600)] <Justin_o> Bosmon: here's the start of my changes to how IoC works page... hope it's starting out okay (smile) http://wiki.fluidproject.org/display/docs/How+to+Use+Infusion+IoC

[15:05:06 CST(-0600)] <Bosmon> Thanks, Justin_o