fluid-work IRC Logs-2013-11-28

[09:26:01 CST(-0600)] <cindyli> Bosmon:

[09:27:01 CST(-0600)] <cindyli> just a reminder on reviewing the pull request for FLUID-5213: https://github.com/fluid-project/infusion/pull/438

[09:36:48 CST(-0600)] <anastasiac> yzen, can you give me an ETA on some answers to Ray's questions for PageBuilder, RecordEditor?

[09:48:17 CST(-0600)] <anastasiac> yzen, I'm starting an etherpad for notes on Repeatable: https://etherpad.mozilla.org/fjF4r63Or6

[09:49:08 CST(-0600)] <anastasiac> yzen, if you see anything in there that's wrong, please correct me

[10:09:30 CST(-0600)] <yzen> thanks! and i will

[12:27:15 CST(-0600)] <Bosmon> Hi cindyli - I gave some further comments on the JIRA a couple of days ago:

[12:27:16 CST(-0600)] <Bosmon> http://issues.fluidproject.org/browse/FLUID-5213#comment-24029

[12:27:43 CST(-0600)] <cindyli> sorry, didn't see that, Bosmon. on it

[12:34:04 CST(-0600)] <Bosmon> colinclark: 3 mins until perihelion!

[12:35:35 CST(-0600)] <colinclark> Bosmon: So exciting!

[12:35:40 CST(-0600)] <colinclark> http://www.skyandtelescope.com/observing/home/Comet-ISON-Updates-193909261.html

[12:36:10 CST(-0600)] <colinclark> I will be at the cottage this weekend, so if the comet does survive, I'll be in a good spot for it

[12:36:32 CST(-0600)] <Bosmon> You'll still need to view it via a chimney or lamppost : P

[12:36:51 CST(-0600)] <colinclark>

[12:37:06 CST(-0600)] <anastasiac> Justin_o, have the full-page prefs editor "manual test" pages been kept up-to-date with the latest preferred methods of instantiating prefs editors?

[12:37:08 CST(-0600)] <colinclark> because it will be so close to the sun, still, I guess

[13:20:01 CST(-0600)] <michelled> Bosmon: I'm finding that the primary builder tests are failing for me with your 5212 pull request in

[13:20:10 CST(-0600)] <michelled> did they work for you?

[13:20:46 CST(-0600)] <Bosmon> michelled - sorry, I may have broken it with my last commit last night....

[13:25:46 CST(-0600)] <Bosmon> michelled - unfortunately it is the tests and impl that are going to have to change

[13:25:53 CST(-0600)] <Bosmon> Since I believe the FLUID-5212 algorithm is now correct

[13:26:09 CST(-0600)] <Bosmon> I guess the primary builder has been "coding to an implementation" rather than a principle....

[13:27:22 CST(-0600)] <cindyli> Bosmon: thanks for the jira comment for 5213. The implementation has been simplified and pushed up. Hope now it's not that "white elephant".

[13:28:45 CST(-0600)] <michelled> Bosmon: what sorts of changes need to happen in the primary builder?

[13:29:10 CST(-0600)] <Bosmon> michelled - it needs to put its dynamic grades in the opposite order

[13:29:17 CST(-0600)] <Bosmon> So they override in the correct priority

[14:39:05 CST(-0600)] <michelled> Justin_o: should this template be removed from the repo? src/shared/adjusters/html/magnifierFollowsTemplate.html

[14:39:14 CST(-0600)] <michelled> it has a deprecation comment at the top

[14:48:48 CST(-0600)] <Justin_o> michelled: I think it's needed for the demos that are in there now, but it is something that is being remade by the gpii folks

[15:01:10 CST(-0600)] <Justin_o> yzen: could you please look at this pull request https://github.com/GPII/prefsEditors/pull/11

[15:01:56 CST(-0600)] <yzen> yep