fluid-work IRC Logs-2010-12-10

[08:30:27 CST(-0600)] <colinclark> hey cindyli
[08:30:39 CST(-0600)] <cindyli> colinclark: ya
[08:30:41 CST(-0600)] <colinclark> I'm writing some unit tests to ensure backwards compatibility of Uploader
[08:30:48 CST(-0600)] <cindyli> great
[08:30:59 CST(-0600)] <colinclark> can you pastebin me the code you use to integrate Uploader with ATutor, and I'll include it in the unit tests?
[08:31:10 CST(-0600)] <colinclark> Or send me a link to the file in your SVN, if that's easier
[08:31:12 CST(-0600)] <colinclark> probably is
[08:31:14 CST(-0600)] <cindyli> sure. one sec. digging
[08:31:21 CST(-0600)] <cindyli> ok
[08:34:59 CST(-0600)] <cindyli> colinclark: uploader initializer: http://atutorsvn.atrc.utoronto.ca/repos/atutor/trunk/docs/mods/_core/file_manager/index.php
[08:35:03 CST(-0600)] <cindyli> colinclark: line 60 - 96
[08:36:11 CST(-0600)] <cindyli> colinclark: markup: http://atutorsvn.atrc.utoronto.ca/repos/atutor/trunk/docs/mods/_core/file_manager/filemanager_display.inc.php
[08:36:19 CST(-0600)] <colinclark> cool, thanks
[08:36:28 CST(-0600)] <cindyli> colinclark: line 183 -248
[08:36:47 CST(-0600)] <cindyli> colinclark: anytime
[08:40:01 CST(-0600)] <heidi_> hi folks, i'm going to look over the demos jon mentioned still need a going-over in his last email
[08:41:42 CST(-0600)] <colinclark> Thanks, heidi_
[08:42:16 CST(-0600)] <heidi_> once all the remaining code is commited i can take a look at making sure debug mode is off
[08:43:39 CST(-0600)] <heidi_> justin_o do you know if layout reorderer is really broken, as jon mentioned
[08:45:13 CST(-0600)] <colinclark> It looks pretty broken to me
[08:45:40 CST(-0600)] <Justin_o> heidi_: it looks like it
[08:45:43 CST(-0600)] <Justin_o> not sure what's up with it
[08:45:54 CST(-0600)] <heidi_> maybe ill check that one out first
[08:46:21 CST(-0600)] <Justin_o> heidi_: thanks
[08:48:29 CST(-0600)] <Justin_o> heidi_: is FLUID-3828 ready for review again?
[08:48:51 CST(-0600)] <colinclark> heidi_: I have a feeling that the layout reorderer demo was broken by Antranig
[08:48:53 CST(-0600)] <colinclark> Bosmon2
[08:49:01 CST(-0600)] <heidi_> justin_o oops i gotta close it. michelle reviewed/commited i think
[08:49:11 CST(-0600)] <Justin_o> heidi_: okay.. thanks
[08:49:12 CST(-0600)] <colinclark> I think he had a reason for putting headers into each module, but it's pretty awkwardly done
[08:49:36 CST(-0600)] <heidi_> colinclark okay... will wait to see what he says
[08:49:43 CST(-0600)] <colinclark> There's also a bunch of logging code he failed to remove upon his last commit
[08:49:47 CST(-0600)] <colinclark> yesterday was a rough day for him, I think
[08:49:57 CST(-0600)] <colinclark> fighting with ARIA that wouldn't work all night
[08:50:02 CST(-0600)] <heidi_> yikes
[08:50:09 CST(-0600)] <colinclark> But this is a bit too unpolished to even pass code review
[08:50:22 CST(-0600)] <heidi_> was it reviewed?
[08:50:23 CST(-0600)] <colinclark> You can see if you try the demo that it's actually throwing exceptions
[08:50:28 CST(-0600)] <colinclark> heidi_: It hasn't been yet, no
[08:50:33 CST(-0600)] <colinclark> That's one of the reasons we're slow to freeze
[08:50:34 CST(-0600)] <heidi_> is there a jira for it colin?
[08:50:40 CST(-0600)] <colinclark> I don't know
[08:50:41 CST(-0600)] <heidi_> k
[08:50:44 CST(-0600)] <colinclark> I hope Jonathan would have filed one
[08:50:46 CST(-0600)] <colinclark> but perhaps not
[08:51:02 CST(-0600)] <heidi_> i mean for the issue antranig was fixing?
[08:51:10 CST(-0600)] <Justin_o> colinclark, heidi_: i'm still working my way through yesterdays jira updates.. i'll let you know if i see one
[08:51:41 CST(-0600)] <colinclark> Thanks Justin
[08:52:01 CST(-0600)] <colinclark> This one can be filed under a big "Layout Reorderer throws errors whenever anything is moved" blocker
[08:52:05 CST(-0600)] <colinclark> (tongue)
[08:52:17 CST(-0600)] <colinclark> "with the mouse
[08:52:24 CST(-0600)] <colinclark> looks like keyboard moves are still working
[09:01:48 CST(-0600)] <Justin_o> colinclark: did you need FLUID-3888 open
[09:01:52 CST(-0600)] <Justin_o> or can i close it off?
[09:03:55 CST(-0600)] <colinclark> I'll make sure any new files are updated, Justin_o
[09:03:58 CST(-0600)] <colinclark> so you should be fine to close it
[09:04:04 CST(-0600)] <Justin_o> colinclark: thanks
[09:09:23 CST(-0600)] <heidi_> justin_o i'm going to wait to hear from Bosmon2 before figuring out layout reorderer
[09:09:37 CST(-0600)] <heidi_> ill go over those remaining demos in the meantime
[09:10:16 CST(-0600)] <Justin_o> heidi_: thanks
[09:54:36 CST(-0600)] <heidi_> hey justin_o when i load some demos off the build site with firebug open, i am noticing 404's
[09:54:45 CST(-0600)] <heidi_> like for http://build.fluidproject.org/build-scripts/build.xml
[09:56:16 CST(-0600)] <Justin_o> heidi_: yah... that's just part of the demo portal at the moment
[09:56:35 CST(-0600)] <heidi_> k
[09:56:35 CST(-0600)] <Justin_o> it does ajax calls to fetch the code that is shown on the right
[09:56:55 CST(-0600)] <heidi_> justin_o so things like http://build.fluidproject.org/infusion/demos/uploader/css/uploader.css ?
[09:56:57 CST(-0600)] <Justin_o> and if they don't exist you get errors.. i think that first one is to test for local ajax or something
[09:57:03 CST(-0600)] <Justin_o> heidi_: yep
[09:57:26 CST(-0600)] <heidi_> k!
[10:06:42 CST(-0600)] <anastasiac> Justin_o, I'm here now (working from home) - do you want me to continue investigating the problem I found last night with the build scripts? or is there something else more urgent I can help with?
[10:08:17 CST(-0600)] <Justin_o> anastasiac: you can start looking at that... michelled thinks it may have something to do with code needing to bel linted...
[10:08:26 CST(-0600)] <Justin_o> she had suggested linting the entire codebase
[10:08:47 CST(-0600)] <anastasiac> do you want me to just do that first and commit anything? Is there a jira for that specifically?
[10:09:52 CST(-0600)] <michelled> I'm thinking there's something that's causing a breakage when it gets minified and smashed together
[10:10:40 CST(-0600)] <michelled> I'm hoping linting will find it but it might be wishful thinking
[10:10:47 CST(-0600)] <anastasiac> michelled, I tried looking at the all.js file in aptana, and it didn't find any errors, but we want to lint anyway, so...
[10:11:59 CST(-0600)] <anastasiac> Justin_o, I don't see a JIRA specifically for linting - should I commit under a different one, or create a new one?
[10:14:32 CST(-0600)] <Justin_o> anastasiac: i think it's the code cleanup one
[10:14:50 CST(-0600)] <Justin_o> FLUID-3757
[10:14:51 CST(-0600)] <anastasiac> right - 3757. thanks
[10:15:44 CST(-0600)] <anastasiac> harriswong sent me an email that mentioned some issues with uploader files, so I'll look into that first. It's possible that might have caused other thing to fail
[10:20:33 CST(-0600)] <colinclark> what did the email say, anastasiac?
[10:21:57 CST(-0600)] <anastasiac> colinclark, he checked what the file differences were between 1.2 and trunk, and listed a few files that no longer in trunk - he just wondered if that might have anything to do with it
[10:22:14 CST(-0600)] <anastasiac> the only possibly relevant one is SWFUploadManager.js, I think
[10:22:18 CST(-0600)] <colinclark> Was that on the list?
[10:22:27 CST(-0600)] <anastasiac> yes - I'm just confirming now
[10:27:44 CST(-0600)] <harriswong> i copy & pasted the files onto this channel yesterday as well.
[10:28:44 CST(-0600)] <harriswong> (5:37:28 PM) harriswong:     [82] => src\webapp\components\uploader\js\SWFUploadManager.js
[10:28:44 CST(-0600)] <harriswong> (5:37:28 PM) harriswong:     [502] => src\webapp\lib\jquery\plugins\delegate\jQueryDelegatePluginDependencies.json
[10:28:44 CST(-0600)] <harriswong> (5:37:28 PM) harriswong:     [503] => src\webapp\lib\jquery\plugins\delegate\js\jquery.delegate.js
[10:28:44 CST(-0600)] <harriswong> (5:37:28 PM) harriswong:     [506] => src\webapp\lib\jquery\plugins\tooltip\js\jquery.tooltip.js
[10:28:44 CST(-0600)] <harriswong> (5:37:28 PM) harriswong:     [688] => src\webapp\tests\framework-tests\core\html\keyboard-a11y-tests.html
[10:47:03 CST(-0600)] <colinclark> anastasiac, harriswong: So SWFUploadManager is long gone
[10:47:59 CST(-0600)] <anastasiac> colinclark, yes - and i don
[10:48:25 CST(-0600)] <anastasiac> 't see any dependencies on it. I'm rebuilding the distro so I can reproduce the error and figure out just what was causing it
[12:28:20 CST(-0600)] <heidi_> jhung has CUTE kids !
[12:30:25 CST(-0600)] <anastasiac> fluid-everyone: I've found what might be a problem with our concatenated file. I've sent an email to the list describing what's going on (it's a bit too long to explain here in the channel).
[12:30:51 CST(-0600)] <anastasiac> colinclark and Justin_o, I tried to cc you two on the email, but ocad's webmail wouldn't let me (sad)
[12:34:37 CST(-0600)] <anastasiac> jhung, connor is a bit of a ham, isn't he? very, very cute
[12:43:42 CST(-0600)] <Justin_o> anastasiac: I just replied to you... basically i said that i think that the progressive enhancement wasn't included in the infusionall.js before
[12:44:09 CST(-0600)] <anastasiac> Justin_o, yes, it wasn't
[12:44:19 CST(-0600)] <anastasiac> now it's part of the framework
[12:45:19 CST(-0600)] <Justin_o> anastasiac: really..
[12:45:35 CST(-0600)] <Justin_o> but it's still a separate file right?
[12:45:43 CST(-0600)] <anastasiac> yep and yep
[12:46:26 CST(-0600)] <Justin_o> So we should be able to not include it in the dependency file at all.. meaning removing it from the files array
[12:46:31 CST(-0600)] <Justin_o> would that fix the problem?
[12:47:37 CST(-0600)] <anastasiac> Justin_o, well, it would make the problem go away, but then we'd lose the progressive enhancement capabilities!
[12:47:58 CST(-0600)] <jessm> k
[12:48:47 CST(-0600)] <Justin_o> anastasiac: I think maybe we can just tell people that it is not included in the infusionall.js and to link it in seperately... i'm thinking that we don't want to execute it on pages where it isn't needed...
[12:49:52 CST(-0600)] <anastasiac> Justin_o, that might work. We'd have to make sure our own Uploader files can preserve the use of ProgressiveEnhancements.js when the headers get rewritten - this might take some ant and/or regexp magic
[12:51:08 CST(-0600)] <Justin_o> anastasiac: it should be okay... right now it just removes <script> tags in the head that pertain to files that are included in InfusionAll.js
[12:52:15 CST(-0600)] <jhung> anastasiac: yeah. I have a feeling he's going to be the class clown a lot of the time... not sure how to feel about that. lol
[12:52:23 CST(-0600)] <anastasiac> Justin_o, a different thought: my understanding is that prog enh is in the framework because we want it to be. We could think of it this way: prog enh depends on swfobj, so we could specify swfobj as a dependency of the framework;
[12:52:35 CST(-0600)] <anastasiac> is colinclark around? he should probably get in on this discussion
[12:53:21 CST(-0600)] <anastasiac> I don't like the idea of saying that our framework is dependent on swfobj; maybe ProgEnh could be rewritten to use swfobj only if it's present?
[12:53:26 CST(-0600)] * anastasiac ponders
[13:01:25 CST(-0600)] <anastasiac> Justin_o, colinclark: FYI, removing ProgressiveEnhancement.js from the framework dependencies does fix the issue, and the uploader stuff still has the file included separately. So if we're ok with telling people they have to include it separately, then that fix will work
[13:01:47 CST(-0600)] <Justin_o> heidi_, jhung : just wondering how things are coming along
[13:02:35 CST(-0600)] <Justin_o> anastasiac: i'm fine with that (smile), but i'll defer to colin... so other than this issue all the dependency changes are fine?
[13:02:50 CST(-0600)] <heidi_> justin_o UIO demo is ugly, but I think for now just adding clear instructions will have to be enough. i'll look into debug mode next - cool?
[13:03:28 CST(-0600)] <heidi_> it'd be nice to get rid of inline styles and such but i don't think it's worth fussing with the code at this point
[13:03:29 CST(-0600)] <anastasiac> Justin_o, I haven't finished checking harriswong's fss dependencies patch (since I came across this issue), but so far so good - I'll give it a bit more testing
[13:04:01 CST(-0600)] <Justin_o> heidi_: i can grab the debug mode one now actually.. i just finished up with the copyright stuff.. would you mind doing a quick test of the reorderer...
[13:04:15 CST(-0600)] <Justin_o> there should only be an issue with the layout reorderer at the moment
[13:04:25 CST(-0600)] <Justin_o> and i think you're right about UIOptions
[13:04:35 CST(-0600)] <Justin_o> anastasiac: thanks
[13:04:36 CST(-0600)] <heidi_> justin_o ill test the reorderer . is there a QA plan for it?
[13:04:46 CST(-0600)] <heidi_> jhung is looking at the renderer
[13:05:31 CST(-0600)] <Justin_o> heidi_: yep they should all be linked to here http://wiki.fluidproject.org/display/fluid/Testing+Fluid+Components
[13:05:45 CST(-0600)] <Justin_o> i don't think you have to do the entire test plan.. maybe just the state based tests
[13:05:51 CST(-0600)] <Bosmon2> anastasiac, Justin_o - I wonder if I'm missing something about this issue, but it seems clear that i) ProgressiveEnhancement is something that we need to work, and ii) it depends on a library file in order to function, and that indeed yes iii) if something depends on something, the build process should ensure that it appears in the file earlier...
[13:06:11 CST(-0600)] <Justin_o> heidi_: we'll do a more thorough testing next week
[13:06:42 CST(-0600)] <Justin_o> Bosmon2: i'd agree with the last part for sure
[13:06:48 CST(-0600)] <anastasiac> Bosmon2, that's what I was thinking. I don't know enough about the build/concatenation process to know whether or not it's supposed to be putting them in the right order and failing, or if it's simply not trying
[13:07:25 CST(-0600)] <Justin_o> anastasiac: my guess is that to get it to work you would have to break up the framework module
[13:07:36 CST(-0600)] <Justin_o> i think it only manages order by modules
[13:07:54 CST(-0600)] <Justin_o> but i could be missing something
[13:08:07 CST(-0600)] <colinclark> i'm catching up
[13:08:07 CST(-0600)] <anastasiac> Justin_o, I suspect that if we actually declared the framework to be dependent on swfobject, that might work
[13:08:20 CST(-0600)] <Justin_o> anastasiac: yes.. that would probably work
[13:08:24 CST(-0600)] <Bosmon2> anastasiac - it would be grossly deficient, if it was not trying to produce a build with dependencies in the right order... it would have been breaking things for years
[13:09:30 CST(-0600)] <anastasiac> Bosmon2, yes - I assume it is trying to put them in the right order. The problem is that the framework doesn't declare its dependence on swfobject - this dependence was introduced with the inclusion of ProgressiveEnhancement.js
[13:10:45 CST(-0600)] <colinclark> Okay, so anastasiac and Justin_o
[13:10:56 CST(-0600)] <colinclark> You've found a bug in ProgressiveEnhancement.js
[13:11:23 CST(-0600)] <colinclark> And an interesting question in where it fits with the rest of the framework.
[13:11:57 CST(-0600)] <colinclark> First, I should have checked for the presence of swfobject before trying to invoke a method on it
[13:12:23 CST(-0600)] <colinclark> So that the swfobject dependency doesn't propagate to everything that wants to use Progressive Enhancement
[13:12:51 CST(-0600)] <colinclark> Secondly, I think we can make a decision about how to treat ProgressiveEnhancement.js
[13:13:08 CST(-0600)] <colinclark> Previously, Justin_o is correct that it was part of the framework but intentionally omitted from builds
[13:13:18 CST(-0600)] <colinclark> I'm not sure that really ever made a ton of sense
[13:13:30 CST(-0600)] <colinclark> but I can't even remember our arguments for why, fully
[13:13:49 CST(-0600)] <colinclark> As you'll see in the code, ProgressiveEnhancement.js runs a number of bits of code "immediately"
[13:14:10 CST(-0600)] <colinclark> This code is harmless and worthwhile for those who want to use progressive enhancement on their page or in their component
[13:14:17 CST(-0600)] <colinclark> unnecessary for those who don't
[13:14:26 CST(-0600)] <colinclark> There are two types of such code:
[13:14:49 CST(-0600)] <colinclark> 1. Some code that runs in order to show any markup that should only be visible if JavaScript is enabled
[13:15:27 CST(-0600)] <colinclark> 2. A series of "environment checks," which detect browser features such as support for Flash and other features, and then which drop context names into the static environment accordingly
[13:15:36 CST(-0600)] <colinclark> This means that users can write IoC blocks against certain features
[13:16:21 CST(-0600)] <colinclark> Meaning, it's super easy to deliver subcomponents and invokers specifically to particular capabilities of the browser without having to write a whole whack of if statements and the like
[13:16:39 CST(-0600)] <colinclark> So, we have two choices for what to do with ProgressiveEnhancement.js, I think:
[13:16:59 CST(-0600)] <colinclark> 1. Treat is as a standard part of the framework, and include it in builds whenever a user asks for the framework.
[13:17:22 CST(-0600)] <colinclark> The upside of this approach is that anyone can easily use these various features if necessary. Downside is that they get them even if they don't use them.
[13:17:57 CST(-0600)] <colinclark> 2. Put ProgressiveEnhancement.js in its own module, which users can request if desired. Make this module a dependency for Uploader.
[13:18:14 CST(-0600)] <anastasiac> colinclark, would option 1 include officially declaring the framework to be dependent on swfobject?
[13:18:26 CST(-0600)] <heidi_> the list reorderer has a style prob - who should i bug about it?
[13:18:38 CST(-0600)] <colinclark> The upside of this approach is that people get only the code they need. The downside is that we have to do a bit of work to make it into its own module
[13:18:39 CST(-0600)] <Justin_o> heidi_: how bad is the style issue?
[13:18:57 CST(-0600)] <colinclark> anastasiac: No, as I said previously, you've found a bug in ProgressiveEnhancement.js
[13:19:01 CST(-0600)] <colinclark> It's a blocker and it needs to be fixed.
[13:19:03 CST(-0600)] <heidi_> justin_o needs to be fixed... using keyboard the select style stays after an item is moved
[13:19:38 CST(-0600)] <anastasiac> but if we fix it but don't declare the dependency, then the check for flash is going to be ineffective because even if flash is there, it will act as if not
[13:19:40 CST(-0600)] <anastasiac> wouldn't it?
[13:20:18 CST(-0600)] <colinclark> anastasiac: The check would be ambiguous, yes. But presumably the thing that depended on the check would need to similarly depend on swfobject
[13:21:04 CST(-0600)] <anastasiac> yes, but the whole problem is that swfobject isn't defined at the time fluid.browser.flash() executes, so the uploader will assume flash is not there, even if it is
[13:21:10 CST(-0600)] <Justin_o> harriswong: is that a new issue.. the one that heidi_ mentioned about list reorderer
[13:21:48 CST(-0600)] <heidi_> justin_o i'm having trouble consistently reproducing it, but there's def something goin on
[13:21:59 CST(-0600)] <Justin_o> michelled: could you please look at FLUID-3776 and commit if it is okay
[13:22:07 CST(-0600)] <Justin_o> heidi_:
[13:22:08 CST(-0600)] <Justin_o> hmm
[13:22:13 CST(-0600)] <Justin_o> what browser?
[13:23:01 CST(-0600)] <heidi_> now am not getting select styles. but ill try to figure out what's causing and make a jira
[13:23:01 CST(-0600)] <Justin_o> heidi_: any chance your mouse is over top of the reorderable items when you keyboard nav
[13:23:02 CST(-0600)] <heidi_> ff
[13:23:05 CST(-0600)] <heidi_> nope
[13:23:22 CST(-0600)] <colinclark> anastasiac: That's why I think #2 is probably the most appropriate solution to the problem
[13:24:41 CST(-0600)] <anastasiac> so in option #2, colinclark: the new prog enh module wouldn't be dependent on swfobj, but uploader would be dependent on both - can we ensure that swfobj will be concatted before progenh?
[13:25:55 CST(-0600)] <colinclark> Yes, by having the Uploader express a dependency on swfobject prior to its dependency on the progressive enhancement module
[13:26:47 CST(-0600)] <Justin_o> heidi_: is it when you tab away from the list reorderer.. or while you are moving items?
[13:27:23 CST(-0600)] <anastasiac> colinclark, I tried changing the order of dependencies, and it didn't seem to work... a bug in the scripts? We'll have to test this...
[13:27:40 CST(-0600)] <jhung> fluid-everyone: Heidi and I are going through the remaining demos and cleaning up the markup. We're wondering if this should be done for Renderer or UI Options?
[13:28:09 CST(-0600)] <jhung> There's a lot of work to be done for UI Options, and I don't understand Renderer enough to safely clean-up the markup.
[13:28:26 CST(-0600)] <heidi_> justin_o if i tab out of the frame it seems to get weird when i go back in
[13:28:40 CST(-0600)] <anastasiac> jhung, I've found a problem in the namespacing changes you made to the keyboard-a11y demo: you changed the class names of the stars in the HTML without changing the defaults in five-star.js, so the stars completely don't work now
[13:28:42 CST(-0600)] <Justin_o> heidi_: okay
[13:28:55 CST(-0600)] <Justin_o> Bosmon2: have you heard about the reorderer regressions yet?
[13:29:04 CST(-0600)] <jhung> anastasiac: okay. Let me look at that now.
[13:29:23 CST(-0600)] <colinclark> anastasiac: You'll have to create a new module for the progressive enhancement code
[13:29:35 CST(-0600)] <colinclark> I can't remember exactly what that entails, but it may even require a new directory structure for it
[13:29:42 CST(-0600)] <colinclark> certainly its own json dependencies file
[13:30:14 CST(-0600)] <anastasiac> colinclark, yes, I think the modules are organized by folder, so we'll need a new folder - sibling to 'core' and 'renderer', I think
[13:30:22 CST(-0600)] <colinclark> that's correct
[13:30:36 CST(-0600)] <anastasiac> should I create a JIRA for this, or do it under uploader work?
[13:30:47 CST(-0600)] <colinclark> anastasiac: This is definitely a release blocker
[13:30:52 CST(-0600)] <colinclark> File away
[13:30:57 CST(-0600)] <anastasiac> ok, will do
[13:33:39 CST(-0600)] <Justin_o> michelled, colinclark: can one of you review my patch for FLUID-3776
[13:33:44 CST(-0600)] <Justin_o> it's for the copyrights
[13:36:57 CST(-0600)] <Justin_o> Bosmon2: there've been a regression or two the the reorderer.. the worst being with layout reorderer... which pretty much just doesn't work anymore
[13:37:04 CST(-0600)] <colinclark> anastasiac: I wasn't clear--will you go ahead and take a stab at fixing this issue you are filing?
[13:37:11 CST(-0600)] <Justin_o> the list reorderer also seems to be having focus styling issues now too
[13:37:30 CST(-0600)] <anastasiac> yes, sure - I did get that already (smile)
[13:38:02 CST(-0600)] <anastasiac> Justin_o, FYI http://issues.fluidproject.org/browse/FLUID-3892 filed for this prog. enh. issue
[13:42:04 CST(-0600)] <Justin_o> anastasiac: i've added that to the bug parade
[13:42:45 CST(-0600)] <heidi_> justin_o the select style breaks on shift-tab
[13:42:47 CST(-0600)] <Bosmon2> Justin_o: That's odd... all of the demos and test cases seemed working after my commit
[13:42:51 CST(-0600)] <Bosmon2> Can you be more specific?
[13:43:04 CST(-0600)] <jhung> anastasiac: it should be fixed now. I rolled back the classname change. In retrospect I don't think it really needed the classname change anyway since it's clearly exclusive to the demo.
[13:43:06 CST(-0600)] <heidi_> ^ Bosmon2
[13:43:31 CST(-0600)] <anastasiac> jhung, thanks
[13:44:23 CST(-0600)] <heidi_> Bosmon2 , justin_o ill file a jira
[13:44:54 CST(-0600)] <Justin_o> Bosmon2: for the layout reorderer if you try to reorder using the mouse, the avatars don't drop to the drop target but move back to the original location.. then dragging seems to sometimes be no longer on at all
[13:45:03 CST(-0600)] <Justin_o> heidi_: thanks
[13:46:41 CST(-0600)] <Bosmon2> Justin_o
[13:46:46 CST(-0600)] <Bosmon2> Can you say which demo you are talking about?
[13:47:28 CST(-0600)] <harriswong> heidi_, justin_o: are you talking about the listReorderer demo?
[13:47:41 CST(-0600)] <heidi_> harriswong ya
[13:47:56 CST(-0600)] <harriswong> heidi_: i think i am missing something here...how do you remove an item from that demo?
[13:48:07 CST(-0600)] <heidi_> harriswong shift-tab seems to break it
[13:48:36 CST(-0600)] <heidi_> harriswong remove? do you mean reorder? (smile)
[13:48:36 CST(-0600)] <harriswong> heidi: I tried tabbed onto 3rd bullet, highlighted to green, shift tab, tab back in, i don't hav ea problem though..
[13:49:11 CST(-0600)] <heidi_> harriswong i can screen share? see if you can reproduce it
[13:49:31 CST(-0600)] <harriswong> heidi_: sorry, i read "moved" as "removed" from your message above.
[13:49:46 CST(-0600)] <harriswong> heidi_: sure
[13:50:30 CST(-0600)] <heidi_> harriswong i don't seem to have you on my skype!
[13:50:50 CST(-0600)] <heidi_> what's your skype name
[13:50:54 CST(-0600)] <harriswong> heidi: !!
[13:50:58 CST(-0600)] <heidi_> hehe
[13:51:03 CST(-0600)] <harriswong> heidi_: i think.it's harris225
[13:51:18 CST(-0600)] <harriswong> heidi_: i lied.it's harrisw225
[13:51:35 CST(-0600)] <heidi_> k got it
[13:55:43 CST(-0600)] <Bosmon2> Justin_o: I have my test cases now for FLUID-3487 - is it ok to commit them or should I make a patch first?
[14:00:56 CST(-0600)] <Justin_o> Bosmon2: i think you can go straight ahead and commit... just make sure it gets reviewed
[14:02:34 CST(-0600)] <Bosmon2> ok
[14:08:30 CST(-0600)] <michelled> anastasiac: sorry for joining this conversation so late
[14:09:18 CST(-0600)] <michelled> I think for javascript only dependencies multiple modules can be in the same directory and work fine
[14:09:40 CST(-0600)] <michelled> there is a bug for files that are not javascript where they get included if they are in the same directory structure
[14:10:14 CST(-0600)] <michelled> if it makes more sense to keep progressive enhancement in the framework directory I think you should try it and see if it works
[14:10:33 CST(-0600)] <anastasiac> michelled, thanks for the info - I wonder which approach is actually better: to have a single folder called "framework" that includes two modules, one framework, one other... might be confusing?
[14:10:35 CST(-0600)] <harriswong> Justin_o: pager QA testplan updated. on image reorderer qa test plan
[14:10:49 CST(-0600)] <heidi_> bosmon2 harris and i fiddled around with the list reorderer issue and it happens when you have the ffox accessibility cursor on
[14:11:11 CST(-0600)] <heidi_> so i don't think it's a blocker since it works fine w/o that on, but i'll make a jira
[14:11:25 CST(-0600)] <anastasiac> also, michelled and Justin_o, maybe you know: should the URL rewriting work if I'm building a custom build with uploader only, for example?
[14:11:40 CST(-0600)] <heidi_> justin_o ^
[14:11:48 CST(-0600)] <Justin_o> michelled: i think the code won't get bundled into the infusionall.js but the individual js files will show up in the package
[14:13:08 CST(-0600)] <Justin_o> anastasiac: i'm not sure
[14:13:23 CST(-0600)] <anastasiac> well, it doesn't seem to (wink)
[14:14:15 CST(-0600)] <michelled> anastasiac: I'm not certain if there's a target that will do both particular modules and url rewriting
[14:14:27 CST(-0600)] <anastasiac> ok
[14:15:50 CST(-0600)] <Bosmon2> Justin_o: Ok, I've looked at the layoutReorderer failure and have a fix for that
[14:16:03 CST(-0600)] <Bosmon2> Is there a new JIRA or should I commit under one of the original numbers?
[14:16:51 CST(-0600)] <michelled> anastasiac: if you think there's a bug in dependency resolution for the build, can you open a JIRA?
[14:17:22 CST(-0600)] <anastasiac> Justin_o, michelled: if putting two modules in the same folders doesn't produce a correct InfusionAll.js, then I'd say it doesn't work - agreed?
[14:17:35 CST(-0600)] <michelled> yes
[14:17:38 CST(-0600)] <anastasiac> michelled, which bug are you referring to?
[14:18:02 CST(-0600)] <michelled> you said that changing the order of dependencies listed didn't work.
[14:18:35 CST(-0600)] <Justin_o> jhung, heidi_ : did you file a jira for the reorderer issues
[14:18:37 CST(-0600)] <anastasiac> oh, right - not sure about that one, it actually might have been a browser caching issue. seems to work now
[14:19:06 CST(-0600)] <heidi_> https://issues.opencastproject.org/ down?
[14:19:10 CST(-0600)] <heidi_> oops
[14:19:14 CST(-0600)] <heidi_> TGIF
[14:19:19 CST(-0600)] <Justin_o> (smile)
[14:21:07 CST(-0600)] <Justin_o> Bosmon2: was it a result of one of your commits?
[14:21:53 CST(-0600)] <Bosmon2> yes, there was a fault in my implementation of the ARIA labeller that was exposed by an inconsistency in the arguments of the two routes of firing the "onMove" event
[14:22:26 CST(-0600)] <Justin_o> okay... since it doesn't seem like anything has been filed i guess you can commit it against that one
[14:22:28 CST(-0600)] <Justin_o> then
[14:25:44 CST(-0600)] <heidi_> justin_o http://issues.fluidproject.org/browse/FLUID-3893
[14:26:19 CST(-0600)] <heidi_> oops editing for better title ha
[14:26:28 CST(-0600)] <Justin_o> heidi_: thanks
[14:29:36 CST(-0600)] <anastasiac> so michelled and Justin_o, it seems that having two modules in one folder has the following effect: the All.js file seems to work out fine if you try just one or just the other module, but the distribution includes all the files. So if I build 'framework' only (i.e. not including progressive enhancement), the MyInfusion.js file doesn't have the progressive enhancement stuff, but the disto folder does include the file. Does this m
[14:29:36 CST(-0600)] <anastasiac> we shouldn't do it this way?
[14:30:14 CST(-0600)] <Justin_o> anastasiac: that is the known issue
[14:30:36 CST(-0600)] <Justin_o> does it work properly if you had included both modules?
[14:31:37 CST(-0600)] <anastasiac> the all file does get both, and I believe all the files are present. Didn't test that directly... (prog enh is dependent on framework)
[14:31:49 CST(-0600)] <Justin_o> heidi_: so if you don't use the accessibility cursor, it works?
[14:31:54 CST(-0600)] <anastasiac> checking...
[14:32:07 CST(-0600)] <Justin_o> heidi_: that's for http://issues.fluidproject.org/browse/FLUID-3893
[14:32:20 CST(-0600)] <heidi_> justin_o yeah, works.
[14:32:28 CST(-0600)] <heidi_> and you can unbreak it if you hit tab i think
[14:32:38 CST(-0600)] <heidi_> i always have cursor on
[14:33:02 CST(-0600)] <heidi_> so it's not a biggie, just a little weird
[14:33:32 CST(-0600)] <anastasiac> so Justin_o, is this known issue such that we shouldn't include the two modules together in the framework folder, or is it minor enough in this case that it's ok?
[14:33:33 CST(-0600)] <Justin_o> heidi_: okay.. so i guess not a blocker for the release then, but something we should look at for later. would you agree?
[14:34:35 CST(-0600)] <heidi_> justin_o yep, agreed
[14:34:45 CST(-0600)] <Justin_o> anastasiac: I think it's okay since most people would probably be making use of the single InfusionAll.js anyways..
[14:34:54 CST(-0600)] <Justin_o> fluid-everone: any other thoughts ^
[14:34:59 CST(-0600)] <Justin_o> heidi_: thanks
[14:35:30 CST(-0600)] <Justin_o> fluid-everyone: i'm going to rebuild the daily build site now
[14:35:51 CST(-0600)] <jhung> fluid-everyone: I'm going to review FLUID-3842, FLUID-3841, and FLUID-3448. (Builder styling patches)
[14:36:08 CST(-0600)] <Justin_o> jhung: okay.. thanks
[14:36:18 CST(-0600)] <Bosmon2> Justin_o: I am gardening my JIRAs now...3487 is moved to "REVIEW" - I've added a comment to 3708 saying that the implementation has basically failed, shall I move its fix out to 1.4?
[14:37:23 CST(-0600)] <Justin_o> Bosmon2: yes please
[14:37:36 CST(-0600)] <Justin_o> could you also delete the bug parade tag from the comments
[14:41:27 CST(-0600)] <colinclark> anastasiac, Justin_o: I can't really think of any particular reasons why we wouldn't want to move progressive enhancement into its own directory
[14:41:29 CST(-0600)] <Justin_o> Bosmon2: what else do you have on your list
[14:41:42 CST(-0600)] <colinclark> Given this bug in the build process, that is
[14:42:09 CST(-0600)] <colinclark> Can anyone really think of a compelling argument not to just stick it in its own directory outside of core, now that we've decided to promote it to full module status?
[14:42:32 CST(-0600)] <Bosmon2> Justin_o: 3730 is now also at REVIEW
[14:42:34 CST(-0600)] <anastasiac> colinclark, it works either way; and I wondered if it might be a bit confusing to have a folder called framework contain a module that's not framework - everything else is one-to-one
[14:43:05 CST(-0600)] <anastasiac> so +1 for separate folder
[14:43:11 CST(-0600)] <Justin_o> Bosmon2: thanks
[14:43:45 CST(-0600)] <Justin_o> anastasiac: where will you place the folder?
[14:44:39 CST(-0600)] <anastasiac> Justin_o, I have it as a sibling to 'core' right now
[14:44:49 CST(-0600)] <Justin_o> anastasiac: okay...
[14:45:05 CST(-0600)] <anastasiac> so conceptually, the framework include core, renderer, fss, progressiveEnhancement
[14:45:36 CST(-0600)] <Bosmon2> Justin_o: ok, 3708 and 3711 have been pushed out to 1.4 and detagged
[14:45:56 CST(-0600)] <anastasiac> colinclark, when I'm finished thoroughly testing this, would it be better for you if I commit it, or post a patch? I don't want to cause you more work, but I don't want to mess up your work on uploader...
[14:46:01 CST(-0600)] <Justin_o> Bosmon2: thanks
[14:46:54 CST(-0600)] <colinclark> honestly at this point, I'm not sure I care
[14:47:01 CST(-0600)] <colinclark> Post a patch, because I'd like to see it concretely
[14:47:06 CST(-0600)] <colinclark> but I'm not too worried about getting messed up
[14:47:12 CST(-0600)] <anastasiac> ok, will do
[14:47:14 CST(-0600)] <colinclark> it'll be fine
[14:58:41 CST(-0600)] <Bosmon2> Justin_o: FLUID-3862 now committed, reviewed, and closed
[14:58:52 CST(-0600)] <Justin_o> Bosmon2: thank you
[14:58:58 CST(-0600)] <Bosmon2> colinclark, Justin_o: Shall I now deal with FLUID-3883?
[14:59:12 CST(-0600)] <Bosmon2> I think our vote in the channel on it seemed to conclude yesterday in favour of fluid.get()?
[14:59:40 CST(-0600)] <Justin_o> Bosmon2: sure
[14:59:44 CST(-0600)] <Bosmon2> ok
[14:59:51 CST(-0600)] <colinclark> Bosmon2: yes, that's correct
[15:00:15 CST(-0600)] <Bosmon2> Hopefully noone now has any patches outstanding against the core framework that are targetted for this release
[15:00:20 CST(-0600)] <Bosmon2> Since after this point they will fail to apply cleanly
[15:00:32 CST(-0600)] <Justin_o> heidi_: have you finished the rough tests on the reorderer components
[15:00:47 CST(-0600)] <Bosmon2> Well... hopefully noone has any patches outstanding against JS code of any kind? (tongue)
[15:01:22 CST(-0600)] <heidi_> justin_o still looking through but good so far
[15:01:41 CST(-0600)] <Justin_o> i updated.. so layout reorderer should be fixed now
[15:02:02 CST(-0600)] <Bosmon2> I need to reply to jhung onlist about the changes to the markup for the demo....
[15:03:10 CST(-0600)] <heidi_> jhung i think for reorderers the keyboard commands should prob be at the top
[15:03:15 CST(-0600)] <heidi_> for screen readers
[15:03:25 CST(-0600)] <heidi_> for the demos i mean
[15:04:28 CST(-0600)] <heidi_> justin_o ill check layout now
[15:05:19 CST(-0600)] <jhung> thanks bosmon2!
[15:06:30 CST(-0600)] <jhung> heidi_: jameswy and I talked about positioning the instruction text before.
[15:06:58 CST(-0600)] <jhung> my fear was that if the keyboard instructions were at the top, users may get the wrong impression that keyboard is the only way to interact with it.
[15:08:42 CST(-0600)] <Justin_o> Bosmon2: there may be some patches oustanding...
[15:08:49 CST(-0600)] <Justin_o> michelled: do you know
[15:08:50 CST(-0600)] <heidi_> jhung i think they should be at the top for screen reader or AT users
[15:09:02 CST(-0600)] <heidi_> jhung and we could make it more clear that there are two ways in the intro text
[15:09:33 CST(-0600)] <Bosmon2> Well, I'm pleased to say that this global rename has only hit a total of 10 files
[15:09:40 CST(-0600)] <Bosmon2> Although ideally it would only have been about 3
[15:09:48 CST(-0600)] <heidi_> jhung for layout reorderer the banana img changes sizes depending on column - is that intentional?
[15:10:27 CST(-0600)] <jhung> heidi_: yeah. because we were getting weird scaling overflow issues when shrunk.
[15:10:36 CST(-0600)] <heidi_> k
[15:10:44 CST(-0600)] <Bosmon2> I guess "ProgressTests.js" is the only potentially suspicious use of fluid.getBeanValue... I'll have a look at this quickly
[15:12:36 CST(-0600)] <michelled> Bosmon2: can you do me a favour? I was looking at harriswong's patch for http://issues.fluidproject.org/browse/FLUID-3848 and I think the tests needs some work
[15:12:47 CST(-0600)] <michelled> can you take a peek and see what you think?
[15:15:21 CST(-0600)] <Bosmon2> Justin_o: FLUID-3883 is now committed and closed
[15:15:50 CST(-0600)] <jhung> heidi_: regarding the instruction text, if you have time, make a patch and send it to Jameswy and I for review?
[15:16:16 CST(-0600)] <heidi_> jhung sure!
[15:16:34 CST(-0600)] <jhung> heidi_: thanks!
[15:18:14 CST(-0600)] <heidi_> jhung is it just reorderer or all demos?
[15:18:38 CST(-0600)] <jhung> heidi_: not all demos have it at the bottom.
[15:18:58 CST(-0600)] <jhung> I think List, Grid, and Layout have instructions at the bottom.
[15:19:27 CST(-0600)] <heidi_> k
[15:22:00 CST(-0600)] <Justin_o> Bosmon2: thank you..
[15:22:08 CST(-0600)] <Justin_o> what you else are you looking into at the moment?
[15:29:31 CST(-0600)] <Bosmon2> Justin_o - I just pinged jhung on the list about my changes to the layoutReorderer demo
[15:29:50 CST(-0600)] <Bosmon2> So that actually marks the the of the official release tasks I see on my plate
[15:30:07 CST(-0600)] <Bosmon2> I will pop off and have a shower briefly but I will be back in a bit to see if there is anything else I can help out with
[15:30:35 CST(-0600)] <Justin_o> Bosmon2: thanks.. we'll probably be dropping off soon.. but i'll send out a progress update to the list
[15:30:51 CST(-0600)] <Bosmon2> Does it look like we will properly freeze today?
[15:31:29 CST(-0600)] <Justin_o> Bosmon2: i don't think so unfortunately (sad) there's still work to be done for uploader
[15:31:39 CST(-0600)] <Justin_o> also those unspported functions all need to be commented
[15:31:42 CST(-0600)] <Justin_o> not sure if that's done yet
[15:31:59 CST(-0600)] <Justin_o> Bosmon2: michelled also wants to get through all the code reviews
[15:32:11 CST(-0600)] <Justin_o> you might be able to help with those.. at least for the ones you didn't commit
[15:33:36 CST(-0600)] <jhung> bosmon2 thanks! I'll take a look at that now.
[15:33:41 CST(-0600)] <heidi_> image reorderer doesn't have screen reader feedback
[15:34:49 CST(-0600)] <harriswong> Justin_o, colinclark, mlam: is there something I have to do to make the uploader demo work on my FF?
[15:35:16 CST(-0600)] <mlam> harriswong: have you adjusted your flash settings?
[15:36:01 CST(-0600)] <mlam> http://build.fluidproject.org/infusion/demos/uploader/demo.html
[15:36:12 CST(-0600)] <mlam> on the build site, there's a link to adjust your flash settings
[15:36:16 CST(-0600)] <harriswong> mlam: thanks!
[15:36:18 CST(-0600)] <mlam> and it should work.
[15:36:19 CST(-0600)] <mlam> np
[15:36:24 CST(-0600)] <colinclark> harriswong: What version of FF are you running?
[15:36:24 CST(-0600)] <jhung> bosmon2 - just did a quick run through using mouse and keyboard, looks good! Thanks!
[15:36:48 CST(-0600)] <harriswong> colinclark: 3.6.12
[15:37:13 CST(-0600)] <colinclark> At least in its default configuration, you shouldn't even need Flash with a modern version of Firefox like that
[15:37:41 CST(-0600)] <Bosmon2> Ok, I guess there is a good "unsupported function sweep" to be done
[15:38:14 CST(-0600)] <heidi_> jhung do you have a chance to try image reorderer with a screen reader? i'm not having much luck
[15:38:41 CST(-0600)] <mlam> colinclark: added more tests for HTML5. tested that the multi-part content was properly generated. attached patch on FLUID-3777
[15:38:47 CST(-0600)] <jhung> heidi_: checking that now
[15:38:48 CST(-0600)] <colinclark> excellent!
[15:39:01 CST(-0600)] <michelled> Bosmon2: feel free to start killing off the needs review JIRAs
[15:39:17 CST(-0600)] <harriswong> colinclark, mlam: the link mike sent me works. Mine is the localhost version off the trunk, which i can' tclick on "browse", could be just me though. Using the build site one for test plan updates
[15:39:29 CST(-0600)] <colinclark> ?!?
[15:39:35 CST(-0600)] <colinclark> You're saying that the latest trunk is broken
[15:39:37 CST(-0600)] <colinclark> ?
[15:39:47 CST(-0600)] <mlam> colinclark: small code refactoring was made to pull the multi-part content generation into it's own function so that it could be easily tested
[15:40:00 CST(-0600)] <heidi_> jhung there's some serious funkiness going on in IE8 too. i can screen share to show ya
[15:40:11 CST(-0600)] <colinclark> mlam: excellent!
[15:41:26 CST(-0600)] <jhung> heidi_: you need to turn on application mode for NVDA. Ins + Space is the default ket stroke to switch modes.
[15:41:59 CST(-0600)] <jhung> heidi_: sure let's share
[15:42:03 CST(-0600)] <heidi_> jhung i think i was. are you getting good feedback?
[15:42:37 CST(-0600)] <harriswong> colinclark, mlam: apparently it's jsut the demo that's not quite working. I am now using webapp/components/uploade/html to update the QA test plan.
[15:42:44 CST(-0600)] <colinclark> eek
[15:42:46 CST(-0600)] <jhung> heidi: Not particularly. Lots of repetition, but I think it's because of the alt text on images and then reading the captions.
[15:42:56 CST(-0600)] <colinclark> mlam: Any guesses on what's wrong with the demo?
[15:43:02 CST(-0600)] <mlam> colinclark: i'm checking into it now
[15:43:06 CST(-0600)] <jhung> but when I turn on application move to allow keyboard navigation, the feedback isn't useful.
[15:43:12 CST(-0600)] <jhung> Just reads out the item #s.
[15:43:14 CST(-0600)] <colinclark> It should show an error in FF with local ajax not set to be allowed (which is the default)
[15:43:31 CST(-0600)] <heidi_> jhung hm, yeah doesn't do anything with voice over. list reorderer reads beautifully
[15:43:58 CST(-0600)] <Justin_o> heidi_: if you still have time later can you test FLUID-3849 and FLUID-3850 and see if they can be closed.. the fix was just committed through FLUID-3848
[15:44:06 CST(-0600)] <Justin_o> the build site will have to be rebuilt to test from there
[15:44:11 CST(-0600)] <Justin_o> if you don't have time.. we can confirm monday
[15:44:31 CST(-0600)] <heidi_> justin_o i can do that for sure, i have a local server w php
[15:44:50 CST(-0600)] <Justin_o> heidi_: thanks
[15:44:58 CST(-0600)] <mlam> colinclark: harriswong: uploader demo in the demos directory is fine for me.
[15:45:33 CST(-0600)] <Justin_o> heidi_: if it is working feel free to close the jira off
[15:45:37 CST(-0600)] <heidi_> justin_o oopsi thought this was the builder issues. i don't have a sound NVDA set up here justin
[15:45:50 CST(-0600)] <jhung> heidi_: I don't know if we'll be able to address these issues right now. Since we're going to do a round of testing, we'll find out of any of those a11y issues are blockers.
[15:46:13 CST(-0600)] <Justin_o> heidi_: okay
[15:46:53 CST(-0600)] <harriswong> mlam: mmm can i borrow you for a second.
[15:47:00 CST(-0600)] <mlam> yup, coming over
[15:48:13 CST(-0600)] <jhung> gotta run and pick up the kiddies. Will check back here later.
[15:52:30 CST(-0600)] <harriswong> mlam: can i stop uploading midway?
[15:53:39 CST(-0600)] <mlam> yes, you should be able to
[15:53:41 CST(-0600)] <mlam> is it not?
[15:57:57 CST(-0600)] <heidi_> harriswong you can't stop a file halfway
[15:58:08 CST(-0600)] <heidi_> just stop it from finishing the list
[15:58:25 CST(-0600)] <Justin_o> heidi_: did you finish looking at the reorderer demos... just about to update the e-mail
[15:58:49 CST(-0600)] <heidi_> justin_o image reorderer has some screen reader issues, but i think we can leave that for now?
[15:59:18 CST(-0600)] <Justin_o> heidi_: okay.. please file a jira though and we'll look at it later
[15:59:21 CST(-0600)] <heidi_> it's similar to the pager sort heading issue where one mode gives you some info, the other gives you more
[15:59:27 CST(-0600)] <heidi_> okay
[15:59:30 CST(-0600)] <harriswong> heidi_: ok
[15:59:52 CST(-0600)] <Justin_o> heidi_: i see
[16:01:17 CST(-0600)] <heidi_> justin_o already a jira for it: http://issues.fluidproject.org/browse/FLUID-3668
[16:04:45 CST(-0600)] <anastasiac> colinclark, patch attached to http://issues.fluidproject.org/browse/FLUID-3892 for the progressive enhancement move, and the jira assigned to you as "needs commit"
[16:06:52 CST(-0600)] <colinclark> thanks, anastasiac
[16:07:46 CST(-0600)] <anastasiac> gotta go catch a bus - have a good weekend, everyone!
[16:11:55 CST(-0600)] <heidi_> have fun skating folks!
[16:25:09 CST(-0600)] <harriswong> added http://issues.fluidproject.org/browse/FLUID-3894