fluid-work IRC Logs-2013-09-19
- Fluid IRC Log Bot
[08:16:24 CDT(-0500)] <amilchev> hi cindyli
[08:16:36 CDT(-0500)] <amilchev> got time for a quick question?
[08:16:36 CDT(-0500)] <cindyli> hi amilchev
[08:16:39 CDT(-0500)] <cindyli> yes
[08:17:39 CDT(-0500)] <amilchev> cindyli: I sent a mail to Justin and the UX mailing list cc-ed, but don't know if you participate in it so perhaps you haven't seen it
[08:18:03 CDT(-0500)] <cindyli> umm.. don't think i got it
[08:18:10 CDT(-0500)] <amilchev> cindyli: it's related to the GET / POST http requests we chatted about yesterday
[08:18:59 CDT(-0500)] <cindyli> can you forward me the email, amilchev
[08:19:09 CDT(-0500)] <cindyli> cli@ocadu.ca
[08:19:16 CDT(-0500)] <amilchev> ok thanks
[08:19:19 CDT(-0500)] <cindyli> np
[08:20:08 CDT(-0500)] <amilchev> can u see it now
[08:25:36 CDT(-0500)] <cindyli> yes, amilchev. unfortunately, i'm perhaps not the right person to answer those questions. in terms of the POST request, it seems the gpii server my code is using was set up from a different gpii branch, which leads the different POST request.
[08:27:10 CDT(-0500)] <cindyli> with regards to the returned format, I certainly can share the return from my gpii server but it may not be same as what your server is going to return, since yours might be a different setup
[08:27:37 CDT(-0500)] <cindyli> the better person to check with is the one who set up the gpii server that you code is going to use, amilchev
[08:29:18 CDT(-0500)] <amilchev> ok, sorry for disturbing you then, cindyli
[08:30:24 CDT(-0500)] <cindyli> not a problem, amilchev. in case it would help, i'm sharing the GET return from my gpii server here: https://github.com/GPII/universal/blob/master/testData/preferences/andrei.json
[08:31:31 CDT(-0500)] <cindyli> in my case for the discovery too, there would be a new entry key for it such as:
[08:32:02 CDT(-0500)] <cindyli> "http://registry.gpii.org/applications/fluid.gpii.discoveryTool": [{value: {…}}]
[08:33:28 CDT(-0500)] <cindyli> that entry key is what's defined in GpiiStore.js, the defaults block of "gpii.discoveryTool.gpiiStore", the code POSTs and GETs based on this entry key
[08:34:33 CDT(-0500)] <cindyli> "are based .."
[08:36:10 CDT(-0500)] <amilchev> cindyli: that makes sense
[08:36:16 CDT(-0500)] <amilchev> thanks
[08:36:21 CDT(-0500)] <cindyli> anytime
[09:22:27 CDT(-0500)] <amilchev> hi yzen
[09:23:36 CDT(-0500)] <amilchev> tell me if you could answer some quick questions on the http GET and POST requests we chatted about yesterday
[09:51:55 CDT(-0500)] <yzen> Hi amilchev I'm intermittent in the channel but sure
[09:55:33 CDT(-0500)] <amilchev> yzen: is it ok if I forward you an email I yesterday wrote? because I must leave now
[09:56:30 CDT(-0500)] <yzen> Sure sounds good
[09:57:09 CDT(-0500)] <amilchev> thanks
[10:16:09 CDT(-0500)] <anastasiac> cindyli, could you tell me something about the "%" notation here https://github.com/fluid-project/infusion/blob/master/src/components/uiOptions/js/AuxBuilder.js#L263
[10:19:05 CDT(-0500)] <cindyli> anastasiac: %prefKey is meant to be replaced by an internally generated preference key - https://github.com/fluid-project/infusion/blob/master/src/components/uiOptions/js/AuxBuilder.js#L129-131
[10:21:20 CDT(-0500)] <anastasiac> so, cindyli, the prefKey is added to the component options? Am I reading that right?
[10:22:33 CDT(-0500)] <anastasiac> cindyli, I'm trying to figure out where the framework goes to look up the prefKey
[10:23:51 CDT(-0500)] <cindyli> anastasiac: the prefKey is not a component option. it's an unique key extracted from aux schema to identify each preference.
[10:24:22 CDT(-0500)] <cindyli> it's only used internally by auxBuilder
[10:24:26 CDT(-0500)] <anastasiac> ok, so this is very specific to the aux schema builder? It's not a notation that will be used in general
[10:24:40 CDT(-0500)] <cindyli> exactly
[10:24:44 CDT(-0500)] <anastasiac> so it doesn't need to be documented as an IoC reference syntax
[10:24:53 CDT(-0500)] <anastasiac> ok, thanks, cindyli
[10:25:00 CDT(-0500)] <cindyli> np
[12:12:50 CDT(-0500)] <Justin_o> michelled: when you get a chance can you look at my vp pull request https://github.com/fluid-project/videoPlayer/pull/132
[14:41:14 CDT(-0500)] <Justin_o> anastasiac: could you please add jiras for all the documentation tasks we need to get done before a 1.5 release.. and mark them as fix for 1.5
[14:41:30 CDT(-0500)] <Justin_o> anastasiac: can you also take a look at what's already there and clean those up as needed?
[14:41:41 CDT(-0500)] <anastasiac> will do, Justin_o
[14:49:27 CDT(-0500)] <Bosmon> Hi Justin_o and cindyli - how are things going with the composite panel work?
[14:50:47 CDT(-0500)] <cindyli> Justin_o is in process of creating the "panel combining panel" grade, btw, he's been waiting for u to be online 
[14:51:25 CDT(-0500)] <Justin_o> cindyli: thanks..
[14:52:30 CDT(-0500)] <Justin_o> Bosmon: yes.. i'm just about to leave though.. but can you take a look at this jira ( http://issues.fluidproject.org/browse/FLUID-5131 ) and make sure that the details are a little bit better.. i've started implementation off of it so far which you can see in my https://github.com/jobara/infusion/tree/FLUID-5131 branch
[14:55:40 CDT(-0500)] <Bosmon> Thanks, Justin_o
[14:56:59 CDT(-0500)] <Justin_o> Bosmon: do you have any feedback now.. or if you could comment on the jira that and my commits, that would be helpful
[14:57:28 CDT(-0500)] <Bosmon> Justin_o - yes - I'm wondering why you do the conversion from . to _ when combining the preference map
[14:57:32 CDT(-0500)] <Bosmon> Can you explain the motivation here?
[14:59:28 CDT(-0500)] <Justin_o> Bosmon: that's because it's just the value used in the parents internal model.. i think the UIO builder already does something similar to that… but basically here we need to distinguish between paths segments and actual end points
[14:59:42 CDT(-0500)] <Justin_o> seemed reasonable to name the model key after the preference it was for
[15:00:57 CDT(-0500)] <Bosmon> Justin_o - ok
[15:03:19 CDT(-0500)] <Justin_o> Bosmon: sorry i have to run.. but please leave me some comments as you see necessary. Thanks
[16:13:27 CDT(-0500)] <michelled> colinclark: FLUID-5132 is now in. just to let you know. you've already pushed the pull request that the GPII folks were waiting for, so no rush on getting to the other ones
[16:13:35 CDT(-0500)] <colinclark> ok
[16:13:38 CDT(-0500)] <colinclark> thank you
[16:13:43 CDT(-0500)] <michelled> np
[16:14:41 CDT(-0500)] <michelled> Bosmon: I looked at why that invoker needed to be dynamic, but I couldn't determine the reason https://github.com/fluid-project/infusion/pull/406/files
[16:15:01 CDT(-0500)] <michelled> when I step through the code, it looks identical whether the dynamic flag is on or not
[16:15:08 CDT(-0500)] <michelled> but the result is different
[16:15:34 CDT(-0500)] <michelled> when I have the dynamic flag, the correct classes get put on the labels and the styling bug in the contrast panel is fixed.
[16:16:04 CDT(-0500)] <Bosmon> michelled - this may represent some kind of bug in the application, so it would be good to get to the bottom of it
[16:16:05 CDT(-0500)] <michelled> unless firebug was messing with me. I suppose that's possible
[16:16:37 CDT(-0500)] <Bosmon> For a start, it would only seem possible for there to be a problem if the invoker is executing twice or more
[16:16:40 CDT(-0500)] <Bosmon> Do you seem to see that?
[16:17:05 CDT(-0500)] <michelled> it happens on page load and then when I open the fat panel.
[16:17:27 CDT(-0500)] <michelled> I think that might be an issue we should deal with - we probably shouldn't happen twice
[16:17:37 CDT(-0500)] <Bosmon> So the issue would have to be that the dom node is different the 2nd time
[16:17:58 CDT(-0500)] <Bosmon> If you look at the node which it grabs the first time, you may see that it has become "detached" the 2nd time
[16:18:20 CDT(-0500)] <Bosmon> That is, if you keep the Firebug inspector focused on it through the process, you might see that it is no longer in the document
[16:18:32 CDT(-0500)] <Bosmon> But has gone to the "strange purgatory" for detached DOM nodes