fluid-work IRC Logs-2011-03-09

Owned by Fluid IRC Log Bot
Last updated: Mar 09, 2011Version comment
4 min read

[08:41:03 CST(-0600)] <heidi_> hey Justin_o i thought fss had an accessibility class, for "hiding" skip to links for example... can't find it. have you run into it anywhere?
[08:41:45 CST(-0600)] <Justin_o> heidi_: you mean the fl-offscreen-hidden class?
[08:41:55 CST(-0600)] <heidi_> aha
[08:42:00 CST(-0600)] <heidi_> thanks Justin_o i think that's it
[08:42:40 CST(-0600)] <Justin_o> it's at the bottom of the fss-layout.css file
[08:45:12 CST(-0600)] <cindyli> Justin_o: jslint reports 2 errors on regex line: togo = togo.replace(/\<(\S+)[^\>\s]*\>/g, function (match) { ...
[08:46:01 CST(-0600)] <cindyli> Unexpected '\', and, Insecure '^'. the regex seems correct, do u have an idea how to get rid of it?
[08:46:13 CST(-0600)] <cindyli> them
[08:47:54 CST(-0600)] <Justin_o> cindyli: as far as the "\" goes, maybe it's unnecessary.. so you might want to double check that.. as for the ^ I think our settings specify that you shouldn't use it
[08:48:10 CST(-0600)] <Justin_o> which file is this for by the way?
[08:48:33 CST(-0600)] <cindyli> InlineEditIntegrations.js
[08:48:43 CST(-0600)] <Justin_o> ah
[08:49:24 CST(-0600)] <Justin_o> is there a way to replace the ^, if not we are looking at a way to make exceptions
[08:51:02 CST(-0600)] <cindyli> finding out the way to replace
[09:15:11 CST(-0600)] <cindyli> Justin_o: why do we not allow ^ in regex
[09:15:46 CST(-0600)] <Justin_o> i'm not entirely sure.. let me see if i can dig up the justification
[09:16:35 CST(-0600)] <Justin_o> cindyli: http://www.JSLint.com/lint.html
[09:16:49 CST(-0600)] <Justin_o> here's crockford's explanation
[09:16:50 CST(-0600)] <Justin_o> Regular expressions are written in a terse and cryptic notation. JSLint looks for problems that may cause portability problems. It also attempts to resolve visual ambiguities by recommending explicit escapement.
[09:16:50 CST(-0600)] <Justin_o> JavaScript's syntax for regular expression literals overloads the / character. To avoid ambiguity, JSLint expects that the character preceding a regular expression literal is a ( or = or : or , character.
[09:16:58 CST(-0600)] <Justin_o> not quit detailed about he "^" though
[09:17:17 CST(-0600)] <Justin_o> michelled: do you know more about what "^" might not be good in a regex
[09:24:59 CST(-0600)] <michelled> cindyli, Justin_o: I'm not sure but I think he talks about it in the regular expressions chapter in the Good Parts book
[09:25:23 CST(-0600)] <michelled> heidi_ do you have the book at home?
[09:25:37 CST(-0600)] <heidi_> michelled i do! sorry.
[09:25:50 CST(-0600)] <colinclark> http://books.google.ca/books?id=PXa2bby0oQ0C&amp;pg=PA65&amp;lpg=PA65&amp;dq=crockford+regex+^&source=bl&ots=HHuqr9s1eF&sig=y37mcWguze9_0DZ-u0kJ-iJLT28&hl=en&ei=2Zt3TeLwB8n6rAGT2Ki0BQ&sa=X&oi=book_result&ct=result&resnum=2&ved=0CB0Q6AEwAQ#v=onepage&q&f=false
[09:26:47 CST(-0600)] <colinclark> I
[09:26:54 CST(-0600)] <colinclark> I'm not sure if he explains it here
[09:27:02 CST(-0600)] <colinclark> probably in the few chapters Google Books skips (tongue)
[09:27:12 CST(-0600)] <michelled> there are pages skipped too
[09:27:20 CST(-0600)] <michelled> which I think may explain exactly what we want
[09:28:34 CST(-0600)] <cindyli> find this from my search: The issue is with unicode characters, you're allowing pretty much anything in there and there's potential for security issues, or validation bypassing issues. Instead of disallowing something (which can be bypassed), allow only what characters are valid.
[10:03:05 CST(-0600)] <mlam> colinclark: Just read your comments regarding FLUID-4134. I will make the change from passing the XHR object itself to the onFileError event to the error code.
[10:04:45 CST(-0600)] <colinclark> ah mlam
[10:04:46 CST(-0600)] <colinclark> you're here!
[10:05:01 CST(-0600)] <mlam> With regards to passing the xhr object as an argument into the onFileError and onFileSuccess events, I thought we discussed adding the xhr object as a parameter to be shipped by default as a natural transition from Flash to HTML5 ? Or did I misinterpret something?
[10:05:32 CST(-0600)] <colinclark> mlam: So you definitely should pass along the XHR as an argument to both events
[10:05:41 CST(-0600)] <colinclark> the problem is the fact that you're missing other arguments
[10:05:59 CST(-0600)] <colinclark> mlam: sorry, one sec
[10:07:08 CST(-0600)] <colinclark> mlam: You're really close, we're just missing an argument or two here
[10:07:13 CST(-0600)] <colinclark> would it be easier to skype?
[10:07:24 CST(-0600)] <mlam> colinclark: barely here. I can't eat or drink anything until my doctor's appointment ---> headaches!
[10:07:30 CST(-0600)] <colinclark> eek
[10:07:48 CST(-0600)] <mlam> colinclark: sure. i'll get my mic set up
[10:09:14 CST(-0600)] <mlam> colinclark: are you signed onto skype?
[10:11:43 CST(-0600)] <cindyli> Justin_o: i've replaced the regex that has ^ in. i think might be good to talk with the original writer making sure i understand his regex correctly, provided he/she still remembers (smile)
[10:12:01 CST(-0600)] <cindyli> as said, the script is InlineEditIntegrations.js
[10:12:10 CST(-0600)] <Justin_o> cindyli: I can't quite remember.. it was either yura_ or Bosmon2
[10:12:20 CST(-0600)] <Justin_o> yura_: do you remember?
[10:13:00 CST(-0600)] <cindyli> in particular, line 66, function fluid.inlineEdit.normalizeHTML
[10:13:22 CST(-0600)] <yura_> Justin_o: i m afraid not..
[10:14:15 CST(-0600)] <cindyli> alrite, guys, thx
[10:14:16 CST(-0600)] <Justin_o> yura_: okay, thanks..
[10:20:00 CST(-0600)] <jhung> anastasiac: I'm curious to find out how the different documentation platforms deal with searching content. I suspect the customizability, performance, and quality of results will be crucial.
[10:20:41 CST(-0600)] <anastasiac> yes, jhung, that's definitely on my list! might be hard to truly test without lots of content, but we'll see what we can do
[10:24:24 CST(-0600)] <jhung> anastasiac: very true. If the platform supports different search implementations via plugins, then that may be a good alternative if we decide to change.
[10:40:50 CST(-0600)] <mlam> fluid-everyone: I'm having some audio issues with breeze, so I'll give my stand-up update here. I spent the early parts of this morning working on the Flash Uploader error handler, I had a good meeting with colinclark and got some great feedback with my branches. I'll be making the discussed changes this afternoon. I may be in the office around 4 today.
[13:34:05 CST(-0600)] <michelled> fluid-everyone: dev meeting will start soon
[13:34:11 CST(-0600)] <michelled> does anyone want to be skyped in?