fluid-work IRC Logs-2010-12-02

[10:45:36 CST(-0600)] <mlam> colinclark: shall we start the To Do List for uploader?
[10:45:44 CST(-0600)] <colinclark> yeah, let's do it
[10:45:51 CST(-0600)] <colinclark> So let's just start with a random list
[10:45:57 CST(-0600)] <mlam> ok
[10:46:15 CST(-0600)] <mlam> 1. Broaden tests for HTML5 uploader
[10:46:25 CST(-0600)] <colinclark> * Automatically switch HTML 5 upload POSTing strategies based on whether or not the browser supports FormData
[10:46:53 CST(-0600)] <colinclark> * Get XHR progress events working, adapt them to the Uploader, and fire the various file progress events correctly
[10:47:02 CST(-0600)] <mlam> 2. Randomize boundary for multi-part upload
[10:47:22 CST(-0600)] <colinclark> * HTML 5 local implementation--support for removing files, for enabling/disabling the browse button
[10:48:04 CST(-0600)] <mlam> 3. HTML 5 - listen and fire error events
[10:48:11 CST(-0600)] <colinclark> ah yes, errors
[10:49:41 CST(-0600)] <mlam> I've already implemented the error event handling
[10:49:59 CST(-0600)] <colinclark> * Full progressive enhancement HTML 5 > Flash > single file
[10:50:00 CST(-0600)] <mlam> just need to test it
[10:50:45 CST(-0600)] <colinclark> * Options backwards compatibility
[10:50:58 CST(-0600)] <mlam> 4. I think we'll need to implement the progressive enhancement work into the image gallery
[10:51:00 CST(-0600)] <colinclark> I can't remember if there were any prominent bugs from the AEGIS demo testing that we need to include on our list
[10:51:20 CST(-0600)] <mlam> Ok, I can bug Jan for those
[10:52:55 CST(-0600)] <colinclark> They should be in JIRA
[10:54:34 CST(-0600)] <mlam> ok
[10:54:47 CST(-0600)] <mlam> Is this our list?
[10:55:09 CST(-0600)] <mlam> that is, our complete list for next wednesday
[10:55:45 CST(-0600)] <colinclark> I think this is pretty close to it
[10:55:58 CST(-0600)] <colinclark> We need to go through our JIRAs and see what else we're missing
[10:56:01 CST(-0600)] <colinclark> So let's prioritize it
[10:56:07 CST(-0600)] <colinclark> 1. Broaden unit tests
[10:56:19 CST(-0600)] <colinclark> 2. Automatically switch HTML 5 upload POSTing strategies based on whether or not the browser supports FormData
[10:56:31 CST(-0600)] <colinclark> 3. HTML 5 local implementation--support for removing files, for enabling/disabling the browse button
[10:56:37 CST(-0600)] <colinclark> 4. Get XHR progress events working, adapt them to the Uploader, and fire the various file progress events correctly
[10:56:46 CST(-0600)] <colinclark> 5. Randomize boundary for multi-part upload
[10:56:50 CST(-0600)] <colinclark> 6. Progressive Enhancement
[10:56:56 CST(-0600)] <colinclark> But really, lots of these are on equal footing
[10:57:12 CST(-0600)] <colinclark> 2, 3, 4, are related to basic working functionality in the Uploader
[10:57:18 CST(-0600)] <colinclark> so let's split 'em up and squash them
[10:57:31 CST(-0600)] <colinclark> #1 really just needs to be done asap so we have confidence we're not breaking stuff
[10:57:49 CST(-0600)] <colinclark> 5 isn't visible to the user but is really sort of crazy and should just be fixed
[10:57:55 CST(-0600)] <colinclark> 6 is big
[10:58:02 CST(-0600)] <colinclark> so I've got a working fix for #2 now
[10:58:04 CST(-0600)] <mlam> I can do 1, 3, 5 and maybe 4?
[10:58:07 CST(-0600)] <colinclark> you're working on #1, right mlam
[10:58:10 CST(-0600)] <mlam> right
[10:58:30 CST(-0600)] <colinclark> Yep, that makes sense... do 3 next. I can play around with 4 and see what I can figure out
[10:58:38 CST(-0600)] <mlam> ok, sounds good
[10:58:48 CST(-0600)] <colinclark> and then maybe pass it to you so that i can start on 6
[10:58:54 CST(-0600)] <colinclark> and 7 is options chewing of some kind
[10:59:01 CST(-0600)] <mlam> ok
[10:59:05 CST(-0600)] <colinclark> Okay, so your order is, as you say, 1, 3, 5
[10:59:09 CST(-0600)] <colinclark> I'll do 2, 4, 6
[10:59:16 CST(-0600)] <colinclark> and we might meet in the middle on 4
[10:59:20 CST(-0600)] <mlam> ok
[10:59:24 CST(-0600)] <colinclark> wicked
[11:00:26 CST(-0600)] <mlam> i'm excited. the uploader is going to be awesome
[11:02:23 CST(-0600)] <colinclark> it really is
[11:02:37 CST(-0600)] <colinclark> anastasiac and i were just talking off-channel about documentation
[11:02:44 CST(-0600)] <colinclark> we'll pretty much have to start from scratch there
[11:02:49 CST(-0600)] <colinclark> but it'll be worth it
[11:04:28 CST(-0600)] <mlam> ok, sounds good
[11:04:43 CST(-0600)] <colinclark> mlam: I can imagine the King will love us more if we try to commit against real bug parade JIRAs
[11:05:00 CST(-0600)] <colinclark> I don't know whether you'd prefer us to rework our bug parade list, Justin_o?
[11:05:14 CST(-0600)] <colinclark> there's been some drift from what we had early on and what's actually on our own list
[11:05:18 CST(-0600)] <Justin_o> colinclark: sorry... haven't been following
[11:05:23 CST(-0600)] <colinclark> 'sokay
[11:05:43 CST(-0600)] <Justin_o> colinclark: did you guys have new jiras?
[11:05:45 CST(-0600)] <colinclark> Justin_o: The bug parade list for Uploader is fairly out of sync with our actual tasks
[11:05:52 CST(-0600)] <Justin_o> colinclark: ah
[11:05:59 CST(-0600)] <colinclark> Do you want us to file new JIRAs and be more specific, or just keep filing things against the umbrella, FLUID-3722?
[11:06:33 CST(-0600)] <Justin_o> (smile) I suppose it would be better to have them more specific... but it may be too late at this point... any thoughts
[11:07:31 CST(-0600)] <colinclark> More specific might actually help us with our to do list
[11:07:43 CST(-0600)] <colinclark> mlam: Why don't you carry on and I'll pause to whip up some new JIRAs
[11:07:57 CST(-0600)] <colinclark> Justin_o: I think many of the things on your list have been addressed, so we don't need to take them off
[11:07:59 CST(-0600)] <mlam> ok, sounds good
[11:08:07 CST(-0600)] <colinclark> I just need to update them like you asked me to like a month and a half ago
[11:08:11 CST(-0600)] <colinclark> and then I can resolve them
[11:08:31 CST(-0600)] <colinclark> We'll bundle up all the Uploader JIRAs for a mega review by Bosmon2 or michelled
[11:08:58 CST(-0600)] <colinclark> mlam: I committed the doUpload feature detection stuff
[11:09:10 CST(-0600)] <colinclark> I tested quickly in FF 3.6, FF 4, Safari 5, and Chrome
[11:09:18 CST(-0600)] <mlam> ok, cool...i'll take a look
[11:09:25 CST(-0600)] <Justin_o> colinclark, mlam: thanks.. just let me know how to update the bug parade
[11:09:30 CST(-0600)] <colinclark> ok, sure
[11:09:40 CST(-0600)] <colinclark> you can approve all of my proposed JIRAs first, Justin_o
[11:10:10 CST(-0600)] <Justin_o> colinclark: okay.. i'lll take a look when they're up
[11:11:35 CST(-0600)] <colinclark> Justin_o: I have marked this bug parade issue as resolved. It will need review in the mega Uploader review: http://issues.fluidproject.org/browse/FLUID-3727
[11:15:08 CST(-0600)] <Justin_o> colinclark: thanks.
[11:15:45 CST(-0600)] <colinclark> Justin_o: I have added a long description and then marked this bug parade issue as resolved: http://issues.fluidproject.org/browse/FLUID-3726
[11:15:54 CST(-0600)] <colinclark> similarly it will need mega-review once Uploader is looking fully hot
[11:16:45 CST(-0600)] <Justin_o> okay.. got it
[11:20:45 CST(-0600)] <colinclark> Justin_o: I've updated the description of this JIRA, but I think it needs to stay open and more work needs to be done: http://issues.fluidproject.org/browse/FLUID-3725
[11:20:56 CST(-0600)] <colinclark> However, in all likelihood it will have to punted until Infusion 1.4
[11:21:02 CST(-0600)] <colinclark> It really, really needs to be done
[11:21:08 CST(-0600)] <colinclark> "but it works" (tongue)
[11:26:48 CST(-0600)] <colinclark> Justin_o: I've added a longer description and resolved this issue: http://issues.fluidproject.org/browse/FLUID-3724
[11:27:12 CST(-0600)] <Justin_o> okay
[12:03:03 CST(-0600)] <colinclark> anastasiac: What's the best way to mark APIs as deprecated in code?
[12:04:03 CST(-0600)] <anastasiac> colinclark, we've adopted the convention of using the "strikeout" style on the actual option (or whatever it is) and adding a note such as "Deprecated as of v1.3", but leaving the rest of the description in place
[12:04:16 CST(-0600)] <colinclark> anastasiac: ok
[12:04:20 CST(-0600)] <colinclark> but how should do it in code?
[12:04:24 CST(-0600)] <colinclark> like, in the source file
[12:04:32 CST(-0600)] <anastasiac> oh!
[12:04:41 CST(-0600)] <anastasiac> hm
[12:05:00 CST(-0600)] <anastasiac> I'd say the simplest way would be to add a comment to that effect
[12:05:13 CST(-0600)] <anastasiac> I don't know that we have a convention for that yet, so we can make one up (smile)
[12:06:25 CST(-0600)] <colinclark> I have a whole file I want to mark as deprecated
[12:06:35 CST(-0600)] <colinclark> I moved everything related to Flash 9 into a separate, optional file
[12:06:45 CST(-0600)] <colinclark> So, can you suggest a comment? Or should I just write something
[12:23:36 CST(-0600)] <colinclark> Justin_o: For http://issues.fluidproject.org/browse/FLUID-3718, do we need to update any QA test plans before closing the issue? Or is it enough to have split all the Flash 9-specific code out into a separate file and clearly marking it as deprecated?
[12:25:35 CST(-0600)] <Justin_o> colinclark: we should update the test plans... not sure this jira can't be closed before that though
[12:25:42 CST(-0600)] <colinclark> ok
[12:25:46 CST(-0600)] <colinclark> i'll add a comment then
[12:25:49 CST(-0600)] <Justin_o> okay.. thanks
[13:03:36 CST(-0600)] <jessm> athena: link to puppy pics?
[13:03:55 CST(-0600)] <athena> we don't have a ton up yet but there are a few on facebook
[13:04:25 CST(-0600)] <athena> a few on my twitter stream as well: http://yfrog.com/75a90lj and http://yfrog.com/3ucbq0j
[13:04:36 CST(-0600)] <athena> i took some last night that i'll get up on flickr or something soon though (smile)
[13:04:38 CST(-0600)] <jessm> there we go
[13:04:38 CST(-0600)] <athena> he's super cute
[13:04:59 CST(-0600)] <athena> trying to keep him from chewing on the laptop power cord
[13:05:15 CST(-0600)] <jessm> i know that problem all too well – twice over
[13:07:28 CST(-0600)] <athena> lol i bet
[13:07:49 CST(-0600)] <jhung> athena: Awwww. Puppy is adorable! is that a husky?
[13:08:05 CST(-0600)] <athena> yep! 9 weeks old
[13:08:12 CST(-0600)] <athena> he came home 2 days ago
[13:09:33 CST(-0600)] <jhung> wow! that's super cool! Hope you have a lot of room! (big grin)
[13:12:19 CST(-0600)] <athena> yeah we're going to have to take him out a lot (tongue)
[13:12:39 CST(-0600)] <athena> for now he's hesitant to go too far from our front door though, poor thing
[13:12:44 CST(-0600)] <athena> shadows are scary!
[13:34:33 CST(-0600)] <colinclark> athena: woah, jess is rigth
[13:34:39 CST(-0600)] <colinclark> OMG is the best description for your puppy
[13:34:42 CST(-0600)] <colinclark> super cute!
[13:34:44 CST(-0600)] <athena> thanks (smile)
[13:35:04 CST(-0600)] <colinclark> lookit him sleeping!
[13:35:08 CST(-0600)] <colinclark> her?
[13:35:24 CST(-0600)] <athena> him
[13:35:31 CST(-0600)] <athena> Maelström (smile)
[13:37:16 CST(-0600)] <athena> hang on, i'll upload the ones i took last night
[13:44:55 CST(-0600)] <colinclark> cool
[13:53:25 CST(-0600)] <athena> here you go: http://www.flickr.com/photos/swimathena/sets/72157625515401882/
[14:12:48 CST(-0600)] <colinclark> athena: I think this one is my favourite http://www.flickr.com/photos/swimathena/5227220898/in/set-72157625515401882/
[14:12:50 CST(-0600)] <colinclark> or the one after
[14:13:05 CST(-0600)] <athena> yeah, he's so cute curled up
[14:13:12 CST(-0600)] <athena> and i accidentally caught him in mid-lick (smile)
[14:17:14 CST(-0600)] <Justin_o> jamon: it looks like the commits e-mails are not coming through
[14:28:05 CST(-0600)] <colinclark> Justin_o: I updated http://issues.fluidproject.org/browse/FLUID-3723 with a comment about how the code-specific work is done, and that we just need to update the QA test plans
[14:29:19 CST(-0600)] <Justin_o> colinclark: thanks... is that all of the ones that need to be closed
[14:29:34 CST(-0600)] <colinclark> I'm still going through in them in between coding, meetings and other distractions
[14:29:41 CST(-0600)] <colinclark> but i'm close to the point where they've all been looked at
[14:29:53 CST(-0600)] <colinclark> and then I'll file some new ones for us
[14:30:26 CST(-0600)] <Justin_o> okay
[14:30:27 CST(-0600)] <Justin_o> thanks
[14:30:36 CST(-0600)] <Justin_o> i'll send out an update to bug parade soon then
[14:31:46 CST(-0600)] <colinclark> Justin_o: I noticed that you've got this issue in the Critical category in bug parade: http://issues.fluidproject.org/browse/FLUID-2849
[14:31:50 CST(-0600)] <colinclark> but it's actually filed as major
[14:32:00 CST(-0600)] <colinclark> and one that is probably unlikely for us to get to in time for this release
[14:33:55 CST(-0600)] <colinclark> jhung: Did we decide what will happen to the Uploader demo for Infusion 1.3?
[14:34:01 CST(-0600)] <colinclark> Are we doing any work on?
[14:34:29 CST(-0600)] <colinclark> mlam: I'm thinking we definitely squashed this one for the AEGIS demos, right? http://issues.fluidproject.org/browse/FLUID-3838
[14:36:00 CST(-0600)] <mlam> yes, we got this one
[14:37:05 CST(-0600)] <colinclark> ok, i'll resolve it
[14:38:45 CST(-0600)] <colinclark> Justin_o: to add to the deluge of issues I've been resolving, this one is now done: http://issues.fluidproject.org/browse/FLUID-3838
[14:57:07 CST(-0600)] <heidi_> justin_o there is a new jira for inline edit, affecting safari. http://issues.fluidproject.org/browse/FLUID-3871
[15:07:21 CST(-0600)] <mlam> colinclark: we tried uploading an image size of 1.6GB and FF crashed
[15:07:39 CST(-0600)] <colinclark> not surprised at all
[15:07:42 CST(-0600)] <colinclark> so, i'm curious
[15:07:54 CST(-0600)] <colinclark> did it "beachball" first
[15:07:59 CST(-0600)] <colinclark> or whatever happens in Gnome
[15:08:21 CST(-0600)] * colinclark is resolving to actually bother to use questions marks again
[15:08:25 CST(-0600)] <colinclark> Let me try that again
[15:08:29 CST(-0600)] <colinclark> mlam: Did it beach ball?
[15:08:35 CST(-0600)] <mlam> not really
[15:08:38 CST(-0600)] <colinclark> Or whatever it is that happens in GNOME when things are blocking?
[15:08:40 CST(-0600)] <colinclark> interesting
[15:08:51 CST(-0600)] <colinclark> So, I'm curious if there is any difference if you use the FileReader API
[15:08:51 CST(-0600)] <mlam> there was a long lag with the file dialog
[15:08:57 CST(-0600)] <colinclark> I expect it will not be any different
[15:09:02 CST(-0600)] <mlam> yeah, i'm really not sure
[15:09:23 CST(-0600)] <mlam> I wonder if it's the file conversion before sending
[15:09:28 CST(-0600)] <colinclark> and that this is a fatal limitation of using the HTML 5 version of Uploader with FF versions < 4
[15:09:38 CST(-0600)] <colinclark> you should watch in your activity monitor
[15:09:40 CST(-0600)] <colinclark> top or whatever
[15:09:50 CST(-0600)] <mlam> yah, we're trying again
[15:09:52 CST(-0600)] <colinclark> i expect you'll see Firefox's memory footprint bloat to the point where it explodes
[15:10:03 CST(-0600)] <jamon> Justin_o: i need more information about the mailing list, the logs look fine
[15:10:08 CST(-0600)] <colinclark> As I am wont to say, there's no magic here
[15:10:16 CST(-0600)] <colinclark> We know we're reading files straight into memory
[15:10:34 CST(-0600)] <colinclark> so it crashing is a nice confirmation of what was already apparent to us as problematic
[15:10:43 CST(-0600)] <colinclark> if nice is the right word for a crashing bug (wink)
[15:22:04 CST(-0600)] <colinclark> hey King Justin_o
[15:22:19 CST(-0600)] <colinclark> I'd like to petition you to add this JIRA to the bug parade for Uploader http://issues.fluidproject.org/browse/FLUID-3872
[15:22:43 CST(-0600)] <colinclark> It covers the fact that our progressive enhancement scheme was never very good for Uploader, and that we temporarily disabled it once we introduced the HTML 5 version
[15:22:54 CST(-0600)] <colinclark> we should get it working nicely from HTML 5 > Flash > single file upload
[15:28:54 CST(-0600)] <justin_o_> colinclark: mlam just showed me the jira.. i think i can add it..
[15:29:04 CST(-0600)] <colinclark> King justin_o_, here's another one I'd like to suggest for bug parade: http://issues.fluidproject.org/browse/FLUID-3873
[15:29:05 CST(-0600)] <justin_o_> it seems necessary
[15:29:15 CST(-0600)] <colinclark> I'm biased because I filed it, but I think you're right
[15:29:24 CST(-0600)] <colinclark> Uploader without prog enhancement isn't very useful
[15:29:57 CST(-0600)] <colinclark> The one other issue I should raise, justin_o_ and mlam, is that we are using a slightly weird JIRA ticket as a catch-all
[15:30:06 CST(-0600)] <colinclark> FLUID-3722 is the name of our branch and the issue we most often file under
[15:30:24 CST(-0600)] <colinclark> and yet it's actually quite specific, mentioning repurposing Gears code that we had previously
[15:30:28 CST(-0600)] <colinclark> Which we have certainly done
[15:30:51 CST(-0600)] <colinclark> but this one is actually the most accurate umbrella issue: http://issues.fluidproject.org/browse/FLUID-3718
[15:31:05 CST(-0600)] <colinclark> Now, justin_o_, we typically don't include umbrella issues on bug parade, right?
[15:31:22 CST(-0600)] <colinclark> And if so, should I file a series of more specific issues which I think will cover the work still left to be done
[15:31:49 CST(-0600)] <colinclark> in particular, 1) implementing support in the HTML 5 strategies for all of the events and APIs we currently support for Flash
[15:31:51 CST(-0600)] <justin_o_> colinclark: that sounds reasonable
[15:32:13 CST(-0600)] <colinclark> 2) implementing the rest of the local interface
[15:32:16 CST(-0600)] <colinclark> okay, i'll do that
[15:32:24 CST(-0600)] <colinclark> and maybe it's time now for us to move from the branch into trunk?
[15:32:30 CST(-0600)] <colinclark> Do you have any opinion about that, justin_o_?
[15:32:44 CST(-0600)] <colinclark> So my own personal metric for that was when we had proper support for the demo...
[15:32:57 CST(-0600)] <colinclark> meaning that we could default to the SWF version and nothing that worked previously would be broken
[15:33:07 CST(-0600)] <colinclark> even while HTML 5 is still baking a bit longer
[15:33:13 CST(-0600)] <justin_o_> colinclark: that makes sense to me
[15:33:28 CST(-0600)] <colinclark> I'd be curious if michelled or Bosmon2 had any opinions
[15:33:37 CST(-0600)] <colinclark> I've seen Bosmon2 around, but not michelled
[15:33:40 CST(-0600)] <colinclark> is she here somewhere?
[15:33:55 CST(-0600)] <colinclark> mlam: Do you think we're ready for trunk, if we leave HTML 5 turned off by default?
[15:34:23 CST(-0600)] <justin_o_> michelled is physically here, but not virtually
[15:34:42 CST(-0600)] <mlam> Yes, I think we're ready with the SWF refactoring for sure
[15:35:00 CST(-0600)] <colinclark> I guess the only thing we've really regressed on is covered by FLUID-3873 anyway
[15:35:42 CST(-0600)] <colinclark> Taking the "don't break trunk" rule seriously, I think we're probably okay
[15:36:54 CST(-0600)] <colinclark> ah, there she is
[15:37:14 CST(-0600)] <colinclark> michelled: I like to consult with you and justin_o_ as voices of reason when it comes to quality
[15:37:23 CST(-0600)] <colinclark> So, mlam and I are thinking we're ready for Broadway
[15:37:50 CST(-0600)] <colinclark> Wondering if Uploader can go into trunk now
[15:38:04 CST(-0600)] <colinclark> the HTML 5 strategy is workable if not fully working yet
[15:38:15 CST(-0600)] <colinclark> and we can leave it turned off by default until it's 100% solid
[15:38:16 CST(-0600)] <michelled> what does that mean? does it uploade?
[15:38:21 CST(-0600)] <colinclark> It does, yes
[15:38:35 CST(-0600)] <colinclark> It doesn't quite fire all the appropriate events, you can't remove files from the queue yet
[15:38:40 CST(-0600)] <colinclark> a few other things
[15:38:52 CST(-0600)] <michelled> ok, so we could turn it off and ship with the html 5 upload in sneak peek maybe?
[15:38:59 CST(-0600)] <colinclark> Well, this isn't so much about shipping
[15:39:05 CST(-0600)] <colinclark> I think we'll be ready to ship HTML 5
[15:39:21 CST(-0600)] <colinclark> with progressive enhancement so you get what's best
[15:41:17 CST(-0600)] <colinclark> So the real question is just about when it's safe to bring something that is still baking into trunk, michelled
[15:41:25 CST(-0600)] <colinclark> assuming it's a new feature and the old features still work fully
[15:43:08 CST(-0600)] <michelled> colinclark: at this point in the cycle I think it's important to talk about what we'd do if we couldn't polish what was left in time for release. I think in the case of the uploader, as long as swf upload is still working fully and there is a way to turn off html 5 upload that we should be ok
[15:44:55 CST(-0600)] <colinclark> The HTML 5 strategy is entirely configurable and is currently off by default
[15:45:05 CST(-0600)] <colinclark> But if we couldn't polish it in time, we'd back it out
[15:45:10 CST(-0600)] <colinclark> no reason to ship extra bytes
[15:45:44 CST(-0600)] <michelled> well, if it's almost there people may actually prefer that we ship it. but let's just say we'll polish it in time (smile)
[15:46:17 CST(-0600)] <colinclark> indeed
[15:46:34 CST(-0600)] <michelled> I'm guessing you checked, but your units all pass, right?
[15:46:36 CST(-0600)] <colinclark> okay, so justin_o_ and michelled, you're cool if I merge the branch and mlam and I start working out of trunk
[15:46:51 CST(-0600)] <justin_o_> colinclark: yep
[15:47:34 CST(-0600)] <michelled> yes - off to Broadway with you! OMG!
[15:47:58 CST(-0600)] <mlam> hahaha yayy!
[15:48:20 CST(-0600)] <colinclark> OMG!
[15:48:49 CST(-0600)] <justin_o_> colinclark: also about the new jiras, can you make a list and we'll look at all of them tomorrow...including the ones you mentioned just recently
[15:49:00 CST(-0600)] <colinclark> yep
[15:49:03 CST(-0600)] <colinclark> i'll send my list to the list
[15:49:15 CST(-0600)] <justin_o_> colinclark: thanks
[16:04:14 CST(-0600)] <mlam> michelled: i've taken a look at heidi's patch for FLUID-3861 and it looks good
[16:04:57 CST(-0600)] <michelled> good to know mlam - can you comment on the JIRA?
[16:05:24 CST(-0600)] <mlam> yup
[16:05:27 CST(-0600)] <michelled> thx
[16:11:42 CST(-0600)] <colinclark> mlam: Good test for the browse handler in Uploader
[16:11:45 CST(-0600)] <colinclark> one minor suggestion
[16:11:57 CST(-0600)] <mlam> sure
[16:12:01 CST(-0600)] <colinclark> Instead of having to redundantly supply some options, you can just use the defaults
[16:12:12 CST(-0600)] <colinclark> unless you want the markup somehow configured differently
[16:12:20 CST(-0600)] <mlam> oh ok
[16:12:36 CST(-0600)] <colinclark> so you see on line 155, you make up that options block?
[16:12:42 CST(-0600)] <mlam> yup, i see it
[16:12:53 CST(-0600)] <colinclark> it looks identical to the defaults, no?
[16:13:11 CST(-0600)] <mlam> yah (smile)
[16:13:35 CST(-0600)] <colinclark> So, component options are cool
[16:13:52 CST(-0600)] <colinclark> they have defaults, so if a client doesn't want to change the configuration, they can just leave the options argument blank
[16:13:54 CST(-0600)] <colinclark> and the defaults will be used
[16:14:05 CST(-0600)] <colinclark> or, indeed, they can choose to override individual options and leave the others the same
[16:14:05 CST(-0600)] <colinclark> so
[16:14:14 CST(-0600)] <colinclark> you can just toss that line of code and not pass along options to the component
[16:14:24 CST(-0600)] <colinclark> The tests themselves are exactly what we need
[16:14:32 CST(-0600)] <mlam> ok, cool. want me to recommit now?
[16:14:36 CST(-0600)] <colinclark> sure
[16:14:38 CST(-0600)] <colinclark> two other things
[16:14:44 CST(-0600)] <colinclark> I think I'd move this test into a new test file
[16:14:55 CST(-0600)] <mlam> set up a new HTML5 test file?
[16:14:59 CST(-0600)] <colinclark> We're going to accumulate a whole set of new tests for the HTML 5 strategy, so we might as well create a file
[16:15:19 CST(-0600)] <colinclark> yeah, just call it HTML5UploaderSupportTests.js
[16:15:35 CST(-0600)] <colinclark> Second, thing...
[16:15:39 CST(-0600)] <colinclark> I can't remember
[16:15:51 CST(-0600)] <colinclark> oh, yes
[16:16:00 CST(-0600)] <colinclark> I wonder if there's any way we can test the event handling behaviour
[16:16:16 CST(-0600)] <colinclark> i guess it's impossible to click the button and test whether the file dialog is open
[16:16:34 CST(-0600)] <mlam> yah
[16:17:07 CST(-0600)] <colinclark> But you could test the focus and blur behaviour
[16:17:36 CST(-0600)] <colinclark> minor test, but might be nice to have
[16:18:43 CST(-0600)] <mlam> ok
[16:28:46 CST(-0600)] <mlam> colinclark: are you merging the branch to trunk tonight?
[16:29:32 CST(-0600)] <colinclark> I was thinking I might
[16:29:35 CST(-0600)] <colinclark> what do you think?
[16:31:05 CST(-0600)] <mlam> Oh ok, no thoughts. Was just curious.
[16:31:49 CST(-0600)] <mlam> I'll commit the change where I pulled my HTML 5 tests out of the existing uploader test first
[16:32:13 CST(-0600)] <mlam> and then I'll just keep all the HTML5 stuff separate to commit tomorrow
[16:43:58 CST(-0600)] <colinclark> ok, great
[16:44:03 CST(-0600)] <colinclark> I'll merge shortly, then
[16:46:24 CST(-0600)] <mlam> I just committed the new test files