/
fluid-work IRC Logs-2008-10-29

fluid-work IRC Logs-2008-10-29

Oct 29, 2008

[07:43:46 EDT(-0400)] * phiggins (n=dante@c-68-34-199-67.hsd1.tn.comcast.net) has joined #fluid-work
[08:17:44 EDT(-0400)] * Justin_o (n=Justin@142.150.154.101) has joined #fluid-work
[08:17:49 EDT(-0400)] * Justin_o (n=Justin@142.150.154.101) has left #fluid-work
[08:33:34 EDT(-0400)] * ptmahent (n=ptmahent@net2.senecac.on.ca) has joined #fluid-work
[08:40:58 EDT(-0400)] * jessm (n=Jess@c-76-19-199-61.hsd1.ma.comcast.net) has joined #fluid-work
[09:03:52 EDT(-0400)] * anastasiac (n=team@142.150.154.160) has joined #fluid-work
[09:45:22 EDT(-0400)] * theclown (n=theclown@guiseppi.atrc.utoronto.ca) has joined #fluid-work
[09:51:09 EDT(-0400)] * ptmahent__ (n=ptmahent@net2.senecac.on.ca) has joined #fluid-work
[10:07:09 EDT(-0400)] * jessm (n=Jess@c-76-19-199-61.hsd1.ma.comcast.net) has joined #fluid-work
[10:14:07 EDT(-0400)] * michelled (n=team@142.150.154.197) has joined #fluid-work
[10:15:10 EDT(-0400)] * Topic is '0.6 beta code freeze today - Justin will soon be crowned' set by michelled on 2008-10-29 10:15:10 EDT(-0400)
[10:17:00 EDT(-0400)] * jessm_ (n=Jess@c-76-19-199-61.hsd1.ma.comcast.net) has joined #fluid-work
[10:17:29 EDT(-0400)] * ptmahent (n=ptmahent@net2.senecac.on.ca) has joined #fluid-work
[10:32:12 EDT(-0400)] <Antrani1> ping
[10:47:49 EDT(-0400)] * EricDalquist (n=dalquist@bohemia.doit.wisc.edu) has joined #fluid-work
[10:57:38 EDT(-0400)] <theclown> pong
[11:05:04 EDT(-0400)] * Justin_o (n=Justin@142.150.154.101) has joined #fluid-work
[11:51:42 EDT(-0400)] * ecochran (n=ecochran@dhcp-169-229-212-33.LIPS.Berkeley.EDU) has joined #fluid-work
[12:40:49 EDT(-0400)] * EricDalquist (n=dalquist@bohemia.doit.wisc.edu) has joined #fluid-work
[12:40:49 EDT(-0400)] * sgithens342f (n=sgithens@in-143-211.dhcp-149-166.iupui.edu) has joined #fluid-work
[12:40:49 EDT(-0400)] * Antrani1 (n=Antranig@ginger.caret.cam.ac.uk) has joined #fluid-work
[13:03:46 EDT(-0400)] <Antrani1> ping
[13:13:18 EDT(-0400)] <michelled> pong
[13:25:49 EDT(-0400)] <theclown> gnop
[13:46:44 EDT(-0400)] <Antrani1> PNOOoooooo!
[13:47:26 EDT(-0400)] <Antrani1> OK.... we have I18N support.... just in time for code freeze
[13:47:40 EDT(-0400)] <Antrani1> sgithens342f: rsf:id="msg=" is now supported in trunk
[13:47:48 EDT(-0400)] <Antrani1> Together with UIMessage and message resolution in general
[13:48:31 EDT(-0400)] * colinclark (n=colin@142.150.154.101) has joined #fluid-work
[13:48:37 EDT(-0400)] <Antrani1> CLARK KENT
[13:48:55 EDT(-0400)] <colinclark> That is me.
[13:50:57 EDT(-0400)] <sgithens342f> Antrani1: Is there a sample-demo for it?
[13:53:09 EDT(-0400)] <Antrani1> There is a TEST CASE
[13:53:36 EDT(-0400)] <sgithens342f> oh
[13:54:17 EDT(-0400)] <sgithens342f> how does the test case get the properties?
[14:07:18 EDT(-0400)] <Justin_o> colinclark, ecochran: the following jiras against Uploader have been added
[14:07:18 EDT(-0400)] <Justin_o> http://issues.fluidproject.org/browse/FLUID-1729
[14:07:22 EDT(-0400)] <Justin_o> http://issues.fluidproject.org/browse/FLUID-1730
[14:07:48 EDT(-0400)] <Justin_o> ecochran: could you please mark uploader issues I filed today as resolved
[14:08:45 EDT(-0400)] <Justin_o> http://issues.fluidproject.org/browse/FLUID-1725
[14:08:49 EDT(-0400)] <Justin_o> http://issues.fluidproject.org/browse/FLUID-1726
[14:08:54 EDT(-0400)] <Justin_o> http://issues.fluidproject.org/browse/FLUID-1727
[14:09:22 EDT(-0400)] <Justin_o> ecochran: those are the ones that I need you to resolve
[14:09:48 EDT(-0400)] <ecochran> I haven't looked at 1730 yet
[14:09:54 EDT(-0400)] <ecochran> are you sure that it's fixed?
[14:10:03 EDT(-0400)] <ecochran> Justin_o: ^
[14:10:22 EDT(-0400)] <colinclark> ecochran: FLUID-1730 looks like it's related to your progress bars.
[14:10:32 EDT(-0400)] <Justin_o> sorry.. just the last 3
[14:10:37 EDT(-0400)] <Justin_o> the first two are issues
[14:10:44 EDT(-0400)] <colinclark> When I delete a file, I end up geting an error of "that.progressBar.position() has no properties."
[14:10:54 EDT(-0400)] <ecochran> interesting
[14:12:32 EDT(-0400)] <Justin_o> ecochran: didn't know that you committed a change for FLUID-1729
[14:12:38 EDT(-0400)] <Justin_o> i'm going to rebuild and test again
[14:12:46 EDT(-0400)] <ecochran> Justin_o: colinclark: as written 1730 does appear to be fixed
[14:13:42 EDT(-0400)] <ecochran> the counts are all messed up though
[14:13:56 EDT(-0400)] <ecochran> so the queue is not getting populated correctly
[14:14:05 EDT(-0400)] <ecochran> colinclark: ^
[14:16:06 EDT(-0400)] <colinclark> Let me check the latest build.
[14:17:30 EDT(-0400)] <colinclark> I'm still seeing this that.progressBar.position() error.
[14:17:49 EDT(-0400)] <colinclark> ecochran: When you say the counts are messed up, can you elaborate?
[14:18:19 EDT(-0400)] <Justin_o> ecochran, colinclark: I am still seeing that error too
[14:18:40 EDT(-0400)] <ecochran> when I browse for 5 files, then delete 1, when I go to upload I get Uploading: 5 of 4 files (2.5 MB of 2.5 MB)
[14:19:09 EDT(-0400)] <ecochran> this may not be the queue
[14:19:34 EDT(-0400)] <ecochran> so when dod you see the that.progressBar.position() error, I'm not seeing it
[14:21:15 EDT(-0400)] <ecochran> there is a general problem of the UI still active (even though it appears disabled) during upload
[14:21:20 EDT(-0400)] <ecochran> I'll get to it
[14:21:39 EDT(-0400)] <Justin_o> http://issues.fluidproject.org/browse/FLUID-1731
[14:21:43 EDT(-0400)] <Justin_o> added above issue
[14:21:52 EDT(-0400)] * davidb (n=davidb@bas4-toronto06-1279310177.dsl.bell.ca) has joined #fluid-work
[14:22:57 EDT(-0400)] * davidb (n=davidb@bas4-toronto06-1279310177.dsl.bell.ca) has left #fluid-work
[14:23:46 EDT(-0400)] <colinclark> ecochran: That one is probably my bug.
[14:23:52 EDT(-0400)] <colinclark> FLUID-1730 is definitely still an issue, and I expect it's yours.
[14:24:00 EDT(-0400)] <ecochran> Justin_o: FLUID-1725, is this still active, I can not reproduce, is it browser or OS specific?
[14:24:33 EDT(-0400)] <colinclark> So FLUID-1727 looks like it probably is still an issue... SWFUploadManager doesn't inform swf upload when it removes something from the queue.
[14:24:34 EDT(-0400)] <colinclark> Oops
[14:24:38 EDT(-0400)] <colinclark> I have a fix.
[14:24:39 EDT(-0400)] <Justin_o> ecochran: Fluid-1725 has been fixed now, with some of your recent committs
[14:25:18 EDT(-0400)] <ecochran> Justin_o: and 1726
[14:25:19 EDT(-0400)] <ecochran> ?
[14:25:43 EDT(-0400)] <Justin_o> yep that one too
[14:25:47 EDT(-0400)] <colinclark>
[14:26:01 EDT(-0400)] <ecochran> OK
[14:26:04 EDT(-0400)] <ecochran> thanks
[14:26:16 EDT(-0400)] <colinclark> So, FLUID-1727 is mine, and 1730 is yours, Eli. I can't be certain of my fix for 1727 until 1730 gets fixed, but perhaps they're interrelated.
[14:26:20 EDT(-0400)] <colinclark> So I'll commit my one line fix now.
[14:27:01 EDT(-0400)] <ecochran> I'm not seeing 1730 at all
[14:27:42 EDT(-0400)] <colinclark> Are you working off the build?
[14:28:25 EDT(-0400)] <colinclark> Or against the demo?
[14:28:28 EDT(-0400)] <colinclark> ecochran: ^
[14:28:41 EDT(-0400)] <ecochran> demo
[14:28:50 EDT(-0400)] <ecochran> colinclark: demo
[14:28:59 EDT(-0400)] <colinclark> ecochran: That's probably it
[14:29:04 EDT(-0400)] <colinclark> use build.fluidproject.org
[14:29:13 EDT(-0400)] <colinclark> Justin is rebuilding it every time we commit.
[14:29:28 EDT(-0400)] <colinclark> To quote michelled, "we love our king."
[14:31:29 EDT(-0400)] <ecochran> colinclark: I think that the queue or the way that I'm using the queue is messed up and that is causing 1730
[14:31:41 EDT(-0400)] <ecochran> I can see it now
[14:31:43 EDT(-0400)] <colinclark> ecochran: Ok, tell me more.
[14:32:24 EDT(-0400)] <ecochran> I think that I'm going to upload a file that is no longer in the queue and SWFUpload stops because the file is no longer in it's queue
[14:33:16 EDT(-0400)] <colinclark> ok
[14:33:20 EDT(-0400)] <colinclark> Is it something I need to fix?
[14:34:13 EDT(-0400)] * jessm (n=Jess@c-76-19-199-61.hsd1.ma.comcast.net) has joined #fluid-work
[14:36:58 EDT(-0400)] <ecochran> so when I go to get the queue, I'm not getting the right list
[14:36:58 EDT(-0400)] <ecochran> I can check that pretty quickly
[14:36:58 EDT(-0400)] <ecochran> I suspect that what is happening, is that when a file is being removed from the queue, it isn't being removed from the queue (well, that was confusing)
[14:36:59 EDT(-0400)] <ecochran> removeFile isn't removing something from somewhere
[14:37:01 EDT(-0400)] <ecochran>
[14:37:05 EDT(-0400)] <ecochran> we just lost connectivity
[14:37:07 EDT(-0400)] <ecochran> we're having connectivity problems... I may have missed the last 4 minutes of chatter
[14:37:12 EDT(-0400)] <ecochran> can you hear me now?
[14:37:35 EDT(-0400)] <Justin_o> i'm going to rebuild the site now
[14:38:52 EDT(-0400)] <colinclark> ecochran: I hear you.
[14:38:56 EDT(-0400)] <colinclark> I think perhaps our issues are related.
[14:38:58 EDT(-0400)] <ecochran> colinclark: I think so, give me another 2 minutes to debug so I can see where the data is getting munched, or which data is getting munched
[14:39:37 EDT(-0400)] <colinclark> ecochran: In SWFUploadManager, I wasn't telling the underlying swfUploader that a file was being removed.
[14:39:46 EDT(-0400)] <colinclark> When Justin rebuilds, that fix should be in.
[14:39:53 EDT(-0400)] <ecochran> great!!
[14:39:58 EDT(-0400)] <ecochran> colinclark: thanks
[14:40:04 EDT(-0400)] <ecochran> I knew it was something like that
[14:41:03 EDT(-0400)] <ecochran> colinclark: counts are still messed up
[14:41:17 EDT(-0400)] <colinclark> ecochran: Which counts in particular?
[14:41:34 EDT(-0400)] <ecochran> Uploading: 6 of 4 files (342.7 KB of 342.7 KB)
[14:41:47 EDT(-0400)] <ecochran> that was after I removed 2 before hitting Upload
[14:41:51 EDT(-0400)] <colinclark> where are you getting those stats from?
[14:42:20 EDT(-0400)] <ecochran> file.index I think, which is probably wrong
[14:42:26 EDT(-0400)] <Justin_o> that is a problem that affects uploader 1 as well
[14:43:37 EDT(-0400)] <ecochran> colinclark: yep, I just checked, even though the file is gone from the queue, the index is not updated
[14:43:49 EDT(-0400)] <ecochran> the index is static to when the file was inserted
[14:43:52 EDT(-0400)] <ecochran> grump
[14:43:55 EDT(-0400)] <ecochran> grumph
[14:43:59 EDT(-0400)] <colinclark> ecochran: Sounds like SWFUpload sucks once again.
[14:44:03 EDT(-0400)] <Justin_o> this also happens if the file is too big to be added to the file queue
[14:44:41 EDT(-0400)] <colinclark> I suppose I could do their work for them, and when files get removed, set their index to -1 or something.
[14:44:43 EDT(-0400)] <colinclark> Feels hacky.
[14:44:50 EDT(-0400)] <colinclark> Why are you hanging on to a file reference that has been removed?
[14:45:43 EDT(-0400)] <ecochran> I'm not, it's the file reference of a file that doesn't get removed
[14:46:12 EDT(-0400)] <ecochran> let's see if I can make a simple example:
[14:46:48 EDT(-0400)] <ecochran> browse for 2 files, file 1 = file.index: 0, file 2 = file.index: 1
[14:46:55 EDT(-0400)] <ecochran> delete file 1
[14:47:07 EDT(-0400)] <ecochran> file 2 still = file.index: 1
[14:47:11 EDT(-0400)] <colinclark> Arg!
[14:47:33 EDT(-0400)] <colinclark> ecochran: Does this sound like a bug in SWFUpload to you, too?
[14:47:41 EDT(-0400)] <ecochran> the index isn't going to work anyway because different batches need different indexes
[14:47:59 EDT(-0400)] <ecochran> I don't know... I know think that they ever expected anyone to use the index in this way
[14:48:10 EDT(-0400)] <ecochran> although I don't know why not
[14:48:16 EDT(-0400)] <colinclark> ecochran: Ok. Can you use the data in currentBatch instead?
[14:48:29 EDT(-0400)] <colinclark> Last night, I added a reference to the file that is currently being uploaded.
[14:48:29 EDT(-0400)] <ecochran> colinclark: that's what I'm wondering
[14:48:47 EDT(-0400)] <colinclark> ecochran: So you should be able to use that, along with currentBatch.files(), right?
[14:48:55 EDT(-0400)] <ecochran> I could also just keep a count somewhere
[14:48:56 EDT(-0400)] <colinclark> a little $.indexOf magic, and you're all set.
[14:49:03 EDT(-0400)] <colinclark> Keep a count of what?
[14:49:18 EDT(-0400)] <ecochran> the files that I'm uploading during this cycle
[14:49:26 EDT(-0400)] <colinclark> That's in currentBatch.files
[14:49:26 EDT(-0400)] <ecochran> add one to the count for each fileStart
[14:49:40 EDT(-0400)] <ecochran> the total
[14:49:48 EDT(-0400)] <ecochran> and the one that I'm on?
[14:49:54 EDT(-0400)] <colinclark> let's hop on ichat
[14:49:56 EDT(-0400)] <colinclark> i'm confused
[14:50:21 EDT(-0400)] <colinclark> We'll summarize to the channel once we figure it out.
[14:56:41 EDT(-0400)] <Justin_o> added http://issues.fluidproject.org/browse/FLUID-1733 it is only minor though
[14:57:57 EDT(-0400)] <colinclark> Thanks Justin_o.
[15:04:37 EDT(-0400)] <colinclark> Okay, so Eli chatted.
[15:04:50 EDT(-0400)] <colinclark> FileQueue.currentBatch has pretty much all the state that is needed.
[15:05:13 EDT(-0400)] <colinclark> So I'm going to add the index of the file that is currently being uploaded, relative to the current batch.
[15:05:56 EDT(-0400)] <colinclark> Comme ��a: that.queue.currentBatch.fileIdx = $.inArray(file, that.queue.currentBatch.files);
[15:07:20 EDT(-0400)] <Justin_o> added http://issues.fluidproject.org/browse/FLUID-1734