fluid-work IRC Logs-2010-02-12

[05:21:43 EST(-0500)] * sveto (~sveto@62.44.108.2) has joined #fluid-work
[06:07:55 EST(-0500)] * boyan (~boyan@62.44.108.2) has joined #fluid-work
[06:55:38 EST(-0500)] * athena (~athena@adsl-76-250-193-123.dsl.wlfrct.sbcglobal.net) has joined #fluid-work
[07:39:52 EST(-0500)] * athena (~athena@adsl-76-250-193-123.dsl.wlfrct.sbcglobal.net) has joined #fluid-work
[08:08:39 EST(-0500)] <sveto> hi jameswy, will it be a bad thing if I merge the background image and the del image into one (actually two taking account of the language) image?
[08:09:47 EST(-0500)] <sveto> i have it working as it is now, but at the cost of some ugly code, for example make both the overlayed del image and the background image act as a delete button
[08:14:25 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[08:32:32 EST(-0500)] <sveto> hi, justin_o, I've managed to get the code entry tests running at the cost of modifying the code a bit, it practically doesn't contain explicit test code, but rather constructs that allow a unit test to be plugged in, hope this is ok
[08:33:26 EST(-0500)] <justin_o> sveto: hello.... i'm not quite sure what you mean by "doesn't contain explicit test code, but rather constructs that allow a unit test to be plugged in"
[08:34:56 EST(-0500)] <sveto> well the function that retrieves the artifact URL is put into the options and in the test I replace it with another one that simulates a check
[08:37:21 EST(-0500)] <justin_o> sveto: that sounds reasonable
[08:40:15 EST(-0500)] <justin_o> sveto: do you have a patch for that?
[08:41:24 EST(-0500)] <sveto> justin_o: not yet, I can create it now, or later when I have made some more changes, but I guess it will be better if you can have a look at it, I'll create it now
[08:42:11 EST(-0500)] <justin_o> sveto: thanks... probably good... it is a bit easier to look at when they are smaller...
[08:47:41 EST(-0500)] <sveto> justin_o: I have also changed the button images with the latest from James, should I include them in the patch?
[08:48:40 EST(-0500)] <justin_o> sveto: i don't think those will come through on the patch unfortunately... they don't usually work to well with binary files... i suppose if you can though, it would be fine
[08:49:00 EST(-0500)] <sveto> ok, I'll try
[08:49:03 EST(-0500)] <justin_o> or make a seperate patch just for those
[08:52:51 EST(-0500)] <jameswy> sveto: Both the overlayed del image and its background should act as the delete button (i.e., the total area of 106x52 pixels, or whatever it was), so that doesn't sound bad to me (unless I'm misunderstanding you)
[08:53:52 EST(-0500)] <jameswy> sveto: as for merging the background image with the del image (i.e., making them into one image), I'm okay with that as well, though the better practice would be to keep them separate.
[08:55:21 EST(-0500)] <sveto> jameswy: ok, it's just that I'm not sure if if I took the right path to make them separate
[09:03:55 EST(-0500)] <sveto> justin_o: I have attached the patch to http://issues.fluidproject.org/browse/ENGAGE-293
[09:04:38 EST(-0500)] <sveto> the images were indeed not included
[09:13:55 EST(-0500)] * jhung (~Lynnette@H63.C204.cci.switchworks.net) has joined #fluid-work
[09:16:52 EST(-0500)] <justin_o> sveto: thanks
[09:33:33 EST(-0500)] * jessm (~Jess@c-71-232-3-151.hsd1.ma.comcast.net) has joined #fluid-work
[09:34:04 EST(-0500)] * colinclark (~colin@bas2-toronto09-1176130909.dsl.bell.ca) has joined #fluid-work
[09:35:51 EST(-0500)] <colinclark> Today seems like a pretty good day for a commit.
[09:35:51 EST(-0500)] <colinclark> I think I'll try it.
[09:39:17 EST(-0500)] <colinclark> jessm: hey
[09:39:24 EST(-0500)] <colinclark> Wanna talk CSS?
[09:39:29 EST(-0500)] <jessm> colinclark: sher
[09:39:34 EST(-0500)] <jessm> shure
[09:39:41 EST(-0500)] <colinclark> If you want to send along your files to talk through, you can use a paste bin.
[09:39:50 EST(-0500)] <colinclark> My favourite is pastie.org
[09:39:56 EST(-0500)] <jessm> k, i'm working on this: http://issues.fluidproject.org/browse/ENGAGE-329
[09:40:04 EST(-0500)] <colinclark> ok
[09:40:47 EST(-0500)] <colinclark> jessm: Are you working on all of these issues, or a subset of them?
[09:41:07 EST(-0500)] * yura (~yura@142.150.154.101) has joined #fluid-work
[09:41:17 EST(-0500)] <jessm> all of 'em – i put a note in there denoting what i was able to fix and what stumped me
[09:41:24 EST(-0500)] <jessm> i think the ellipsis is just something i can't see in FF
[09:41:28 EST(-0500)] <jessm> it's a Safari fix
[09:41:47 EST(-0500)] <jessm> and since safari doesn't have a nice web dev toolkit, i can't see if the fix worked
[09:41:55 EST(-0500)] <jessm> but i'm having issues with the Catalog and # bit
[09:42:04 EST(-0500)] <jessm> lemme use a pastie
[09:42:11 EST(-0500)] <jessm> that sounds naught
[09:42:12 EST(-0500)] <jessm> y
[09:42:39 EST(-0500)] <colinclark> jessm: There are definitely CSS3 styles that just don't work in FF
[09:42:45 EST(-0500)] <colinclark> I hear FF 3.6 improves things a bit
[09:43:27 EST(-0500)] <colinclark> lol
[09:43:58 EST(-0500)] <yura> hi jessm i created a jira that's a blocker (broken links on exhibit and catalogue pages) and i was wondering if it could be added to the bug parade
[09:44:04 EST(-0500)] <yura> it's ENGAGE-376
[09:44:45 EST(-0500)] <jessm> colinclark: http://pastie.org/821821
[09:45:19 EST(-0500)] <jessm> colinclark: this is the task that says the catalogue should be one size and the #, if there is one should be another size
[09:45:34 EST(-0500)] <jessm> i can make them two different <div>s but i can't get them to be beside each other
[09:45:46 EST(-0500)] <jessm> and when i try to make them an <ul> all hell breaks loose
[09:46:00 EST(-0500)] <colinclark> jessm: k, lemme take a look
[09:46:49 EST(-0500)] <colinclark> jessm: Do you not have Safari?
[09:46:51 EST(-0500)] <jessm> yura: yikes, yes, let's add it
[09:46:54 EST(-0500)] <jessm> colinclark: i do
[09:47:11 EST(-0500)] <yura> jessm: cool thanks
[09:47:12 EST(-0500)] <jessm> it just doesn't have firebug
[09:47:44 EST(-0500)] <colinclark> Ah, right. And a lot of these pages can't be previewed from the file system
[09:47:53 EST(-0500)] <jessm> colinclark: exactly
[09:47:55 EST(-0500)] <colinclark> I think if you asked him, yura might be able to tweak that for you
[09:47:56 EST(-0500)] <jessm> so, i'm stuck in FF
[09:48:04 EST(-0500)] <jessm> tweak what?
[09:48:06 EST(-0500)] <colinclark> He did Artifact View yesterday afternoon
[09:48:08 EST(-0500)] <jessm> the viewability?
[09:48:11 EST(-0500)] <colinclark> jessm: yep
[09:48:25 EST(-0500)] <jessm> well, it's nothing urgent, so i hate to ask
[09:48:31 EST(-0500)] <jessm> we can get to it in a bit
[09:48:49 EST(-0500)] <colinclark> ok
[09:49:01 EST(-0500)] <colinclark> So I see your markup here
[09:49:19 EST(-0500)] <colinclark> When you say "them," you mean the "Catalogue" part of the text and the number?
[09:49:56 EST(-0500)] <jessm> yes, the two separate bits of data
[09:50:04 EST(-0500)] <colinclark> Yeah, this is an interesting issue
[09:50:16 EST(-0500)] <colinclark> From a CSS perspective, we should be able to get it working pretty nicely
[09:50:25 EST(-0500)] <colinclark> But wrapping text will involve a code change too
[09:50:40 EST(-0500)] <colinclark> yura or justin_o, can you weigh in on what this would mean?
[09:51:06 EST(-0500)] <colinclark> jessm is working on a bug where the number of items in a section has a different font size than the label
[09:51:24 EST(-0500)] <colinclark> She's inevitably going to have to wrap the number in a separate element...
[09:51:45 EST(-0500)] <colinclark> but if I remember correctly, this string is built up in code
[09:52:09 EST(-0500)] <colinclark> jessm: So I would probably wrap the number in a span, rather than a div.
[09:52:18 EST(-0500)] <colinclark> Spans aren't block level, so they won't force a line break by default.
[09:52:34 EST(-0500)] <justin_o> colinclark: so we would have to break our string template
[09:52:35 EST(-0500)] <jessm> colinclark: ah, good idea, not sure if i tried that
[09:52:55 EST(-0500)] <colinclark> jessm: Try it and see. I would imagine that it should be really simple--wrap in a span, put a custom class on it, and size the text accordingly
[09:53:10 EST(-0500)] <colinclark> justin_o: That's what I'm thinking. Do you think that is the case?
[09:53:23 EST(-0500)] <colinclark> So if you look at jessm's paste: http://pastie.org/821821
[09:53:28 EST(-0500)] <justin_o> colinclark: and that would mean that the user would have less flexibility in the format of the string... or more difficulty anyways
[09:53:45 EST(-0500)] <colinclark> justin_o: Good question.
[09:53:53 EST(-0500)] <colinclark> So text like this: Catalogue (507)
[09:53:58 EST(-0500)] <colinclark> would have to look like this:
[09:54:11 EST(-0500)] <colinclark> Catalogue <span class="fl-text-smaller">(507)</span>
[09:54:14 EST(-0500)] <jessm> yeah, my worry is also the conditional, "if" there's a number – how will this apply to other pages?
[09:54:27 EST(-0500)] <colinclark> jessm: That's exactly the problem at the code level, too
[09:54:41 EST(-0500)] <colinclark> We have some logic that handles these kinds of cases and builds a string accordingly
[09:54:49 EST(-0500)] <colinclark> My vote, on the face of it, is to punt this one for awhile
[09:54:52 EST(-0500)] <jessm> colinclark: i'm actually afraid most of my fixes to this page are going to fall into that issue – making it apply to all pages
[09:55:13 EST(-0500)] <jessm> colinclark: anyway, i an table it, no biggie
[09:55:27 EST(-0500)] <colinclark> jessm: In many cases, you should be able to get it to apply to all pages
[09:55:36 EST(-0500)] <colinclark> but there's an interaction between markup and styles that occurs
[09:56:02 EST(-0500)] <colinclark> Ultimately, I think that means we need to render these kinds of situations in a common way, which we aren't really successfully doing right now.
[09:56:10 EST(-0500)] <colinclark> So it boils down to a non-trivial code change
[09:56:23 EST(-0500)] <colinclark> Which sort of pains me, but so it goes right now
[09:56:30 EST(-0500)] <colinclark> justin_o: Do you agree?
[09:56:48 EST(-0500)] <jessm> eek
[09:57:08 EST(-0500)] <justin_o> colinclark: that seems to be the case
[09:57:16 EST(-0500)] <colinclark> jessm: The conditional part is really easy, were we rendering these strings in two pieces. The Renderer makes it really easy to not emit markup if there's no data there
[09:57:33 EST(-0500)] <colinclark> So, if there was no number, we wouldn't bother to render the <span class="fl-text-smaller"> tags
[09:57:53 EST(-0500)] <colinclark> The problem is that we treat that whole thing, "Catalogue (507)" as a single, atomic string
[09:58:07 EST(-0500)] <colinclark> So let's punt it
[09:58:11 EST(-0500)] <colinclark> What about your other fixes?
[09:58:33 EST(-0500)] * anastasiac (~team@142.150.154.193) has joined #fluid-work
[09:58:33 EST(-0500)] <jessm> so, in the comment i put a '-' in front of things that plague me
[09:58:42 EST(-0500)] <jessm> not sure how to make a button exactly 25px high
[09:58:46 EST(-0500)] <colinclark> ok
[09:58:49 EST(-0500)] <jessm> and the ellipsis bit
[09:58:52 EST(-0500)] <jessm> that's it i think
[09:58:57 EST(-0500)] <colinclark> jessm: Yeah, buttons are not easy...
[09:59:00 EST(-0500)] <colinclark> What kind of button is it?
[09:59:07 EST(-0500)] <colinclark> ah, isee
[09:59:25 EST(-0500)] <colinclark> Those should actually be pretty easy
[10:00:02 EST(-0500)] <colinclark> So jessm, just so I'm clear...
[10:00:03 EST(-0500)] <colinclark> http://build.fluidproject.org:8095/engage/exhibitions/view.html?db=mccord_exhibitions&amp;title=Simply+Montréal%3A+Glimpses+of+a+Unique+City&lang=en
[10:00:12 EST(-0500)] <colinclark> We're talking about these buttons, right?
[10:00:26 EST(-0500)] <jessm> the Read more, View the full catalogue, etc.
[10:00:54 EST(-0500)] <colinclark> yeah
[10:01:02 EST(-0500)] <colinclark> So those buttons seem largely driven by padding
[10:01:10 EST(-0500)] <jessm> 'xactly
[10:01:28 EST(-0500)] <colinclark> So if you set your text size as listed...
[10:01:49 EST(-0500)] <colinclark> 12pt
[10:02:22 EST(-0500)] <colinclark> Then I guess we just have to deal with the mismatch between units... pt and px
[10:02:26 EST(-0500)] <jessm> i'll be at 16px
[10:02:32 EST(-0500)] <colinclark> Ah, there you go
[10:02:54 EST(-0500)] <jessm> then i can just add the appropriate px to the padding to total 25
[10:02:56 EST(-0500)] <jessm> ok, got that
[10:03:00 EST(-0500)] <jessm> last question
[10:03:04 EST(-0500)] <colinclark> cool
[10:03:08 EST(-0500)] <jessm> assuming the ellipsis will work on safari...
[10:03:18 EST(-0500)] <colinclark> ok
[10:03:22 EST(-0500)] <jessm> how do i specify that the text should be truncated after the second line
[10:03:38 EST(-0500)] <colinclark> justin_o: I'm gonna need to lean on you here
[10:03:45 EST(-0500)] <colinclark> I haven't looked at the ellipsis stuff at all yet
[10:04:05 EST(-0500)] <colinclark> ah, nifty
[10:04:13 EST(-0500)] <justin_o> colinclark, jessm: you can only use css to truncate and add ellipsis on single lines
[10:04:27 EST(-0500)] <justin_o> because you have to set the nowrap optoin
[10:04:35 EST(-0500)] <colinclark> aha!
[10:04:38 EST(-0500)] <colinclark> That's it, eh?
[10:04:43 EST(-0500)] <colinclark> I'm just inspecting your NavBar styles
[10:05:21 EST(-0500)] <justin_o> colinclark: yep... that's why we didn't have the ellipses in the component formerly known as description
[10:05:47 EST(-0500)] <colinclark> jessm: And in your case, you're truncating single lines... titles of artifacts, right?
[10:06:22 EST(-0500)] <colinclark> Do you want to paste me your code for it, and I can try it out?
[10:07:06 EST(-0500)] <colinclark> btw, yura, I'm at home for an hour or two to try to get My Collection squared away, but then I'll come into the office and we can pair on your recent patches? I'm keen to see them.
[10:07:41 EST(-0500)] <justin_o> colinclark: yura is just getting coffee... i'll point him to the channel when he gets back
[10:07:42 EST(-0500)] <jessm> colinclark: no, want to truncate after the second line – is that what you're asking?
[10:07:54 EST(-0500)] <colinclark> Thanks, King
[10:08:04 EST(-0500)] <colinclark> jessm: yeah, that's what I was asking... or assuming the opposite, anyway
[10:08:10 EST(-0500)] <colinclark> lemme re-read your bug
[10:08:30 EST(-0500)] <colinclark> "- Artifact names below the artifact thumbnail under catalog should truncate at the second line with ellipses replacing text "
[10:08:43 EST(-0500)] <colinclark> I get it... meaning the text can flow up to two lines before being cut off
[10:09:00 EST(-0500)] <colinclark> justin_o: And there's really no way to do more than one line with nowrap and the ellipsis?
[10:09:15 EST(-0500)] <jessm> colinclark: justin_o: that's consistent with what i found
[10:09:17 EST(-0500)] <jessm> one line
[10:09:40 EST(-0500)] <justin_o> colinclark: yes...
[10:09:52 EST(-0500)] <colinclark> I'm just reading about it now...
[10:09:59 EST(-0500)] <jessm> colinclark: justin_o: so the good news with my patches is they can always be reverted, right?!
[10:10:09 EST(-0500)] <colinclark> ha!
[10:10:36 EST(-0500)] <jessm> http://pastie.org/821855
[10:10:50 EST(-0500)] <colinclark> I sort of feel like if we could fix the size of the text's container, it might actually work
[10:10:53 EST(-0500)] <jessm> colinclark: ^ that's what i was working with, but again, I can't test it in safari to see if it works and it doesn't in FF
[10:11:40 EST(-0500)] <colinclark> jessm: ok
[10:12:18 EST(-0500)] <colinclark> lemme see what it does, just out of curiosity
[10:14:39 EST(-0500)] <colinclark> You've got to love the CSS3 spec. In the description of text-overflow, it basically just says "To be continued..."
[10:16:51 EST(-0500)] <colinclark> jessm: Looks to me like it's not quite working.
[10:18:05 EST(-0500)] <jessm> boo
[10:18:21 EST(-0500)] <jessm> ah well, let's not worry about this – i'll keep fussing, i'll produce a patch and i'll leave it
[10:18:29 EST(-0500)] <colinclark> ok
[10:18:34 EST(-0500)] <colinclark> What about your fix from the other day?
[10:19:01 EST(-0500)] <colinclark> jessm: btw, if you're really curious about the ellipsis, you might want to play around with a very simple HTML example
[10:19:22 EST(-0500)] <jessm> that's a great idea, of course
[10:19:30 EST(-0500)] <colinclark> You might have some luck with setting the size of the text container (both height and width) and see if you can get it to truncate over two lines
[10:19:37 EST(-0500)] <colinclark> I get the feeling it might
[10:19:45 EST(-0500)] <colinclark> Though I know fj had some trouble with this
[10:19:50 EST(-0500)] <jessm> k, i'll try that
[10:19:57 EST(-0500)] * boyan (~boyan@62.44.108.2) has left #fluid-work
[10:20:21 EST(-0500)] <colinclark> I like what you've done here, jessm. Seems like you're getting to know our styling world.
[10:20:35 EST(-0500)] <jessm> colinclark: you're being very generous
[10:20:50 EST(-0500)] <colinclark> Things are fairly weird at first as you adjust to the sort of "additive" nature of the FSS... as well as dancing around the distinction between fl- and flc- selectors
[10:21:22 EST(-0500)] <jessm> colinclark: i'm pretty sure i don't have it yet
[10:21:31 EST(-0500)] <colinclark> Seems like you're well on the way
[10:22:59 EST(-0500)] <justin_o> sveto: sorry am still looking at your code
[10:23:46 EST(-0500)] <justin_o> so i notice that you are trying to internationalize the delete button's image; which is good... however the path to the image changes when run in standalone (from a war file) mode so you get broken images
[10:25:00 EST(-0500)] <sveto> justin_o: I haven't thought about that, is there a solution to this problem?
[10:25:42 EST(-0500)] <justin_o> sveto: not that i know of unfortunately... i suppose you could have both in the markup and then selective show one or the other, but that would only be a short term solution and not something that would scale...
[10:26:07 EST(-0500)] <justin_o> colinclark: did you and yura come accross that issue with the images for the media section on the artifact view page
[10:26:18 EST(-0500)] <sveto> justin_o: hm, then manipulate the last portion of the src attribute?
[10:26:31 EST(-0500)] <justin_o> I think at one point yura needed different default images
[10:26:47 EST(-0500)] <justin_o> sveto... no you could use css to show or hide the image
[10:26:53 EST(-0500)] <colinclark> justin_o, sveto: I'm just catching up. Can some explain the problem?
[10:27:21 EST(-0500)] <justin_o> basically the image for the delete button says "del" on it...
[10:27:33 EST(-0500)] <colinclark> And it should be different in French?
[10:27:49 EST(-0500)] <justin_o> right... there is a second version of the image that just has an x on it.. I think
[10:27:58 EST(-0500)] <sveto> yes, that's right
[10:29:16 EST(-0500)] <colinclark> Is there a story card that explains this behaviour? Or did Hugues ask for a different button in French than English?
[10:29:59 EST(-0500)] <justin_o> colinclark: probably neither really
[10:30:16 EST(-0500)] <justin_o> i believe it is just an effort to make things consistent
[10:30:29 EST(-0500)] <justin_o> and localized
[10:31:14 EST(-0500)] <justin_o> jameswy: may have an opinion if we should just side step the issue for now
[10:31:58 EST(-0500)] <colinclark> At the moment, we still don't have a programmatic API for rewriting URLs in code.
[10:32:20 EST(-0500)] <colinclark> The only solution to the issue is to embed URLs in the markup, where they will be rewritten automatically for you.
[10:32:35 EST(-0500)] <colinclark> I haven't looked at the code. How do we even know which image URL to use?
[10:33:37 EST(-0500)] <sveto> I'm sending the URL from the service
[10:33:53 EST(-0500)] <colinclark> sveto: How does the service know what URL to use?
[10:34:09 EST(-0500)] <jameswy> sveto, colinclark, justin_o: Using the word "Del" for the delete button is not a huge issue in my mind (many localized keyboards still use "Ctrl", "Alt", "Esc", etc. even though they're English abbreviations), but it would be ideal to have the French equivalent for "Del". If we can't, let's just go with the alternate "x" button I provided in the package. User testing can show if that's clear enough.
[10:34:43 EST(-0500)] <justin_o> jameswy: you always use the "x"
[10:34:45 EST(-0500)] <justin_o> ?
[10:34:50 EST(-0500)] <sveto> colinclark: well, it has the language as parameter and based on that returns the URL
[10:35:07 EST(-0500)] <colinclark> sveto: Right, but how does it know which language matches which URL?
[10:35:19 EST(-0500)] <colinclark> What would it do if the locale was, say, Spanish?
[10:35:20 EST(-0500)] <justin_o> colinclark: here is a snippet from the service
[10:35:21 EST(-0500)] <justin_o> http://fluid.pastebin.com/m33a83e88
[10:35:38 EST(-0500)] <sveto> colinclark: it is hardcoded, it will return french I think
[10:35:40 EST(-0500)] <jameswy> justin_o: We used to use "x" (to keep consistent with Apple's numpad), but one early user test suggested it was unclear, so we changed it to "del".
[10:36:24 EST(-0500)] <colinclark> Ok, so we don't really have a reasonable i18n strategy here for non-strings
[10:36:30 EST(-0500)] <colinclark> fascinating problem, actually
[10:36:47 EST(-0500)] <colinclark> indeed, I imagine it will go away entirely when we stop using images for the number pad buttons
[10:36:58 EST(-0500)] <colinclark> And then it's really just back to the issue of localizing strings again
[10:37:14 EST(-0500)] <colinclark> So, jamesw, here's my suggestion... tell me if you hate it.
[10:37:22 EST(-0500)] <colinclark> We go with the generic X button in all cases.
[10:37:32 EST(-0500)] <justin_o> colinclark: true although i suppose there are cases where icons will have different meanings or salenience in different locals
[10:37:41 EST(-0500)] <colinclark> justin_o:
[10:37:44 EST(-0500)] <colinclark> indeed
[10:38:16 EST(-0500)] <colinclark> I haven't thought at all about how we'd solve the problem sensibly... once you get into this territory, something more interesting pops up
[10:38:25 EST(-0500)] <colinclark> The notion that templates are often locale-specific
[10:38:42 EST(-0500)] <colinclark> I mean, if we only had one of these images, we'd just refer to the URL in the template and all would be good
[10:38:57 EST(-0500)] <justin_o> colinclark: yep exactly
[10:39:00 EST(-0500)] <colinclark> Once we get into the realm of changing icons based on locale, we also open even more exciting cans of worms..
[10:39:07 EST(-0500)] <justin_o> i suppose for the most part that would be the case
[10:39:08 EST(-0500)] <colinclark> Left vs. right-read languages, etc.
[10:39:15 EST(-0500)] <colinclark> Here's an example...
[10:39:36 EST(-0500)] <colinclark> In Mac OS X applications, you typically create a whole new Interface Builder layout for each language
[10:39:55 EST(-0500)] <colinclark> Basic string substitution is possible in a way analogous to the way we do it
[10:40:08 EST(-0500)] <colinclark> But beyond that, you actually lay out the interface based on the locale
[10:40:48 EST(-0500)] <colinclark> So jameswy, what do you think of the idea of going with the generic X button in all cases?
[10:41:15 EST(-0500)] <justin_o> for the web it may not be that difficult, if we just provide a different style sheet
[10:41:20 EST(-0500)] <colinclark> I really like how we've tried to localize images, but I imagine it's worth putting some more thought into how to do this generically
[10:41:28 EST(-0500)] <justin_o> although getting that into the page may be another issue
[10:41:29 EST(-0500)] <colinclark> justin_o: yep, you're right.
[10:41:32 EST(-0500)] <jameswy> colinclark: I'm fine with it for 0.3--it doesn't break localization, and it'll give us the chance to test "x"'s clarity with a larger user base.
[10:41:44 EST(-0500)] <colinclark> justin_o: Pretty easy to swap style sheets on the server with the Renderer
[10:41:57 EST(-0500)] <colinclark> sveto, justin_o: Does that also seem reasonable to you?
[10:42:21 EST(-0500)] <justin_o> colinclark: sure... we can go with the generic "x" one for 0.3
[10:42:25 EST(-0500)] <justin_o> 0.3b that is
[10:43:05 EST(-0500)] <colinclark> sveto: What do you think?
[10:43:33 EST(-0500)] * clown (~clown@142.150.154.101) has joined #fluid-work
[10:45:09 EST(-0500)] <sveto> colinclark: sorry, they called me to go outside for a minute, just let me read the conversation
[10:45:16 EST(-0500)] <colinclark> sveto: No worries
[10:45:27 EST(-0500)] <colinclark> How is the weather in Sofia these days, sveto?
[10:45:32 EST(-0500)] <colinclark> It's pretty cold here in Toronto.
[10:45:49 EST(-0500)] <sveto> it is what was the word again - slushy?
[10:46:29 EST(-0500)] <sveto> yes, I think that going with the X is fine
[10:47:10 EST(-0500)] <colinclark> sveto, justin_o: Cool, go for it.
[10:47:13 EST(-0500)] <justin_o> sveto: cool... do you think you could provide a new patch for me
[10:47:24 EST(-0500)] <sveto> sure
[10:47:30 EST(-0500)] <colinclark> sveto: If it's slushy there, it must be warmer than here. Everything's frozen pretty solid.
[10:48:47 EST(-0500)] <sveto> colinclark: I've attached a patch for the navigation bar for my collection to http://issues.fluidproject.org/browse/ENGAGE-154, it also fixes a bug with english strings for the artifact view that was causing exceptions
[10:49:03 EST(-0500)] <colinclark> sveto: Awesome
[10:49:07 EST(-0500)] <colinclark> I'll take a look at it shortly
[10:49:15 EST(-0500)] <sveto> colinclark: thanks
[10:53:29 EST(-0500)] <colinclark> hey jameswy, a totally off-topic question for you
[10:53:47 EST(-0500)] <colinclark> In the latest kiosk thinking, how big are you guys imagining the screen will be?
[10:57:28 EST(-0500)] <justin_o> jessm, colinclark: yura and I were just talking to jameswy and we can use the one line instead of two for the artifact name truncation on the exhibition view page
[10:57:42 EST(-0500)] <colinclark> ah, interesting
[10:57:43 EST(-0500)] <jessm> justin_o: ah, good to know
[10:57:58 EST(-0500)] <jessm> I'll do some testing with a simple example and then try to implement
[11:02:47 EST(-0500)] <sveto> justin_o: I've attached the patch for code entry to http://issues.fluidproject.org/browse/ENGAGE-293
[11:04:35 EST(-0500)] <justin_o> sveto thanks
[11:04:41 EST(-0500)] <jameswy> colinclark: in the latest thoughts, big--40"+
[11:05:16 EST(-0500)] <colinclark> wow
[11:05:25 EST(-0500)] <colinclark> my TV isn't even that big
[11:05:52 EST(-0500)] <colinclark> jameswy: An actual use for the iPad occurred to me the other day...
[11:06:03 EST(-0500)] <colinclark> They'd make great personal "mini kiosks"
[11:06:06 EST(-0500)] <colinclark> For cheap
[11:06:12 EST(-0500)] <jameswy> colinclark: They really would!
[11:06:28 EST(-0500)] <colinclark> And they'd have a built-in screen reader and high contrast mode, the whole works
[11:06:45 EST(-0500)] <jameswy> colinclark: wait, are you thinking of it as a mobile mini-kiosk, or a bunch of static mini-kiosks?
[11:07:18 EST(-0500)] <jameswy> (by static I really mean fixed, of course)
[11:07:26 EST(-0500)] <colinclark> Hard to hook one up to a printer I imagine, and not ideal for sharing the experience with family
[11:07:37 EST(-0500)] <colinclark> I was thinking static mini-kiosks... you could afford to have lots of them
[11:07:49 EST(-0500)] <colinclark> Or, indeed, have "artifact-specific" mini kiosks
[11:08:26 EST(-0500)] <jameswy> Indeed. We could spend a bit of time thinking about a 10" kiosk UI.
[11:08:30 EST(-0500)] <colinclark> It'd be really great because they could just have an app on them that was a "kiosk mode UIWebView" app... administrators would point them to a slick HTML app, and you'd be off and running
[11:08:36 EST(-0500)] <colinclark> It would smoke Flash for a lot of use cases
[11:08:44 EST(-0500)] <colinclark> And we could really take a11y to another level with it
[11:10:32 EST(-0500)] <jameswy> The cheap cost also opens up the option of having these things everywhere--opens up a lot of good use cases.
[11:11:09 EST(-0500)] <jameswy> We had been limiting ourselves to thinking about one or two moderately priced kiosks in a non-distributed, centralized location.
[11:12:26 EST(-0500)] * sveto (~sveto@62.44.108.2) has left #fluid-work
[11:15:18 EST(-0500)] <colinclark> jameswy: Again, there's the printing problem. But for the price of a good 40" touch screen, I imagine you could buy like 10 iPads
[11:16:21 EST(-0500)] <yura> hi jessm, i have this ENGAGE-377 with the patch attached that fixes the empty catalogue problem on exhibition view page, could that be added to the bug parade?
[11:17:18 EST(-0500)] <jameswy> colinclark: Indeed. The logical extension of this line of thought is to just go all the way with the iPad, of course--leave the paper printout behind and carry a lightweight iPad around.
[11:17:28 EST(-0500)] <jessm> yura: sure
[11:17:43 EST(-0500)] <yura> jessm: thanks
[11:17:48 EST(-0500)] <colinclark> jameswy: Remind me of the price different between an iPad and an iPod touch?
[11:18:00 EST(-0500)] * jessm (~Jess@c-71-232-3-151.hsd1.ma.comcast.net) has left #fluid-work
[11:18:16 EST(-0500)] <jameswy> iPod touch: ~$150, I think, and iPad $500 USD for the base model.
[11:18:25 EST(-0500)] * jessm (~Jess@c-71-232-3-151.hsd1.ma.comcast.net) has joined #fluid-work
[11:18:41 EST(-0500)] <jameswy> My bad--iPod touch: $200 USD.
[11:18:54 EST(-0500)] <colinclark> So they're still not cheap, relative to the iPod
[11:19:17 EST(-0500)] <jessm> yura: i'm not going to add it to the to be reviewed email since it isn't a blocker
[11:19:32 EST(-0500)] <jessm> yura: that ok?
[11:19:47 EST(-0500)] <jameswy> Nope, though still quite reasonable (the high-memory iPod touch is $400--just $100 off of the low-memory iPad)
[11:19:55 EST(-0500)] <yura> sure, justin_o will commit it and we can resolve it very soon{color}
[11:23:13 EST(-0500)] <justin_o> yura, jessm: okay the commit is in
[11:23:16 EST(-0500)] <justin_o> i'll close the jira now
[11:23:58 EST(-0500)] <jessm> k
[11:24:50 EST(-0500)] <jessm> justin_o: where does ENGAGE-293 stand?
[11:25:38 EST(-0500)] <justin_o> jessm... coming soon.. I have another patch from sveto, but i think there needs to be one more change to the delete button and then i'll commit it
[11:25:41 EST(-0500)] <justin_o> and it will be done
[11:25:54 EST(-0500)] <justin_o> i think there is a subtask there that is actually already done or will done with this patch as well
[11:26:30 EST(-0500)] <jessm> justin_o: great
[11:27:36 EST(-0500)] <jessm> yura: you're working on 376 now?
[11:28:07 EST(-0500)] <jessm> Bosmon: you here?
[11:35:21 EST(-0500)] * Bosmon2 (~amb26free@174-29-31-88.hlrn.qwest.net) has joined #fluid-work
[11:39:09 EST(-0500)] <colinclark> justin_o: I found an interesting bug emerging from the fact that you store the language setting in a cookie.
[11:45:48 EST(-0500)] <justin_o> colinclark: really
[11:45:51 EST(-0500)] <justin_o> what is that
[11:45:54 EST(-0500)] <colinclark> Well, it's sort of a funny one
[11:46:12 EST(-0500)] <colinclark> The bug is that, by setting the language selection in the cookie, people are tempted to actually use it
[11:46:28 EST(-0500)] <colinclark> So, why do you store the language in the cookie, again?
[11:47:57 EST(-0500)] <justin_o> colinclark: oh basically only for handling the case of someone getting to the home page without the lang param set, and having already picked a language
[11:48:41 EST(-0500)] <colinclark> justin_o: Here's the interesting use case. I stumbled across it when I saw that Sveto has started using your cookie to read out the language. I guess perhaps it was easier than parsing the URL
[11:48:53 EST(-0500)] <colinclark> So, imagine that I've never been to Engage before, but you have
[11:49:04 EST(-0500)] <colinclark> You get excited about the coffee can, so you send me a link to it.
[11:49:26 EST(-0500)] <colinclark> The URL correctly specifies the language, but I don't have the cookie since I've never been to the site before
[11:49:41 EST(-0500)] <colinclark> If other pages rely on the presence of your cookie, I get errors when I got to look at your artifact
[11:50:47 EST(-0500)] <justin_o>
[11:51:01 EST(-0500)] <colinclark> justin_o: It's not the end of the world
[11:51:03 EST(-0500)] <justin_o> funny... i guess that cookie should really just work on the home page
[11:51:21 EST(-0500)] <colinclark> justin_o: If we hadn't unscoped it to home, Sveto couldn't have ever used it
[11:51:27 EST(-0500)] <colinclark> Oh well, we both learned a valuable lesson
[11:52:05 EST(-0500)] <justin_o> yep
[11:54:13 EST(-0500)] <yura> jessm: yes, this one has a patch already
[12:02:31 EST(-0500)] <Bosmon> I guess people are aware that none of the images used in the previews exist on "wozniak"...
[12:02:53 EST(-0500)] <colinclark> Bosmon: I'm pretty sure yura mentioned that to Hugues. yura, what was his response?
[12:04:14 EST(-0500)] <yura> he didn't really respond to that
[12:04:24 EST(-0500)] <yura> colinclark: ^
[12:04:37 EST(-0500)] <colinclark> yura: Can you ping him again about it, and cc the list?
[12:04:42 EST(-0500)] <yura> yes
[12:06:08 EST(-0500)] <colinclark> thanks, dude
[12:28:44 EST(-0500)] * EricDalquist (~dalquist@2607:f388:e:0:221:9bff:fe37:e768) has joined #fluid-work
[12:41:16 EST(-0500)] <yura> colinclark: justin_o and I were thinking if we should get read of the loadData related code which would require 1 resource less to load on any page?
[12:41:39 EST(-0500)] <colinclark> yura: Can you get rid of it while retaining all the desired functionality? I imagine you probably can, right?
[12:41:57 EST(-0500)] <colinclark> VICTORY!
[12:42:01 EST(-0500)] <colinclark> My Collection COLLECTS!
[12:42:24 EST(-0500)] <justin_o> colinclark: congratulations
[12:42:47 EST(-0500)] <colinclark> I've still got a handful of bugs to fix, but I think this means I can commit and come into the office!
[12:45:11 EST(-0500)] <yura> !! yey
[12:47:16 EST(-0500)] <colinclark> hey yura: does skype screensharing work for you?
[12:47:33 EST(-0500)] <yura> ya i can do it on Jacob's machine
[12:47:36 EST(-0500)] <colinclark> cool
[12:47:43 EST(-0500)] <colinclark> Do you see any reason why we couldn't do our review that way?
[12:47:50 EST(-0500)] <yura> no
[12:47:52 EST(-0500)] <colinclark> There is a cat sleeping in a laundry basket here...
[12:48:03 EST(-0500)] <colinclark> so I have some incentive to not come into the office
[12:48:04 EST(-0500)] <yura>
[12:48:19 EST(-0500)] <colinclark> justin_o: Are you cool with that?
[12:49:05 EST(-0500)] <yura> colinclark: would you be able to digitally sign my timesheet ?
[12:49:11 EST(-0500)] <justin_o> colinclark: sure...
[12:49:14 EST(-0500)] <colinclark> yura: Ah, you have a timesheet to sign
[12:49:21 EST(-0500)] <colinclark> I'm not sure I can sign them digitally anymore
[12:49:23 EST(-0500)] <colinclark> I'll come in
[12:49:25 EST(-0500)] <yura> well Pat is going on vacation
[12:49:29 EST(-0500)] <yura> next weel
[12:49:29 EST(-0500)] <colinclark> yura: Sure, no problem
[12:49:31 EST(-0500)] <yura> week
[12:49:35 EST(-0500)] <colinclark> Lemme commit and and I'll be in within an hour
[12:49:39 EST(-0500)] <yura> no it's ok
[12:49:44 EST(-0500)] <yura> i m sure monday will be fine
[12:49:51 EST(-0500)] <yura> i think she leaves on 16th
[12:50:08 EST(-0500)] <yura> colinclark: dont come just for that
[12:50:13 EST(-0500)] <justin_o> colinclark: also Everett just spotted that the emoticons in the wiki don't have any alt text supplied with them... (he noticed this in the browser support chart ). I sent him a reply on list with some possible work arounds.. but do you think we should just disable emoticons from the wiki
[12:50:18 EST(-0500)] <colinclark> yura: Are you sure?
[12:50:28 EST(-0500)] <colinclark> justin_o: I dunno... it is a real drag
[12:50:28 EST(-0500)] <yura> yes
[12:50:40 EST(-0500)] <colinclark> justin_o: Ask him what he thinks we should do
[12:50:59 EST(-0500)] <yura> shoot, monday is a holiday
[12:51:05 EST(-0500)] <justin_o> okay... i'll wait for his response and carry on the conversation with him
[12:51:23 EST(-0500)] <colinclark> justin_o: Yeah, you already did exactly what I was thinking
[12:51:28 EST(-0500)] <colinclark> Dude, you rule!
[12:51:34 EST(-0500)] <colinclark> We have a great king!
[12:51:46 EST(-0500)] <justin_o>
[12:55:30 EST(-0500)] <yura> colinclark: yes, tuesday should be fine, she leaves on 18th
[12:55:39 EST(-0500)] <colinclark> yura: Thanks
[12:55:44 EST(-0500)] <yura> thank you
[13:01:20 EST(-0500)] <justin_o> jessm: I have closed off ENGAGE-305, ENGAGE-294, and have resolved ENGAGE-293 (colin will review)
[13:03:15 EST(-0500)] <jessm> justin_o: colinclark: yura: now that we're into non-blockers, is this email list still helpful or should we just tightly communicate about it in the channel?
[13:03:31 EST(-0500)] <jessm> or are we moving into bug parade phase 2?
[13:03:39 EST(-0500)] <colinclark> jessm: I think the email helps, but it's kind of interesting...
[13:03:51 EST(-0500)] <colinclark> our JIRA filter is so comprehensive, I have been looking at it more than your emails
[13:03:54 EST(-0500)] <colinclark> justin_o: What do you think?
[13:04:39 EST(-0500)] <jessm> yura: since 376 is patched shouldn't you resolve it?
[13:04:52 EST(-0500)] <jessm> yura: and then it can get reviewed?
[13:05:18 EST(-0500)] <yura> jessm: you're right
[13:05:18 EST(-0500)] <justin_o> colinclark: that is true... i think i've been doing much the same lately... maybe have the e-mail just to keep us updated on what needs to be reviewed and other appropriate notes
[13:05:32 EST(-0500)] <yura> speaking of, colinclark did you want to review it?
[13:05:37 EST(-0500)] <colinclark> jessm: Given that, I say we try to use the JIRA filter and chatting in the channel
[13:05:38 EST(-0500)] <yura> via skype
[13:05:53 EST(-0500)] <colinclark> yura: Yes. I'm just in the midst of committing my My Collection changes
[13:05:57 EST(-0500)] <yura> alright
[13:05:58 EST(-0500)] <colinclark> After that, let's do a whack of reviews
[13:05:59 EST(-0500)] <jessm> k, let's see if i can get a list of thing that need review
[13:06:00 EST(-0500)] <yura> let me know then
[13:06:05 EST(-0500)] <colinclark> yura: I will
[13:06:12 EST(-0500)] <yura> colinclark: thanks
[13:06:32 EST(-0500)] <jessm> 280, 292, 346, 358, 366, 370 and 376 are up for review
[13:06:53 EST(-0500)] <colinclark> jessm: I know how my afternoon will go
[13:07:01 EST(-0500)] <jessm> colinclark:
[13:08:05 EST(-0500)] <colinclark> oh, hey Bosmon
[13:08:07 EST(-0500)] <colinclark> you around?
[13:08:43 EST(-0500)] <jessm> add 353 to that list above
[13:09:01 EST(-0500)] <colinclark> ah! jessm, yura !
[13:09:05 EST(-0500)] <colinclark> I forgot about a new blocker
[13:09:15 EST(-0500)] <jessm> colinclark: for review 280, 292, 346, 353, 358, 366, 370, and 376
[13:09:29 EST(-0500)] <colinclark> Remember the whole thing about related artifacts, some of which aren't actually part of any of the exhibitions?
[13:09:50 EST(-0500)] <jessm> i thought we tabled related artifacts
[13:09:52 EST(-0500)] <colinclark> Well, the Word From Hugues was to include them in Engage 0.3, even if it set us behind schedule by a day or two
[13:10:02 EST(-0500)] <jessm> ah
[13:10:14 EST(-0500)] <colinclark> jessm: We did table related artifacts, then Hugues put them back on. So we implemented, then Hugues added to it
[13:10:27 EST(-0500)] <colinclark> Anyway, this will involve extending our importer to crawl through related artifacts
[13:10:36 EST(-0500)] <colinclark> yura: Is this something you and justin_o could work on together?
[13:10:48 EST(-0500)] <yura> yes
[13:10:50 EST(-0500)] <yura> definetely
[13:12:34 EST(-0500)] <colinclark> justin_o: are you in?
[13:12:37 EST(-0500)] <justin_o> sure
[13:12:43 EST(-0500)] <justin_o> sorry... was getting caught up in the channe
[13:12:45 EST(-0500)] <justin_o> l
[13:12:47 EST(-0500)] <colinclark> no problemo
[13:13:06 EST(-0500)] <colinclark> Can we add a JIRA for this task? The description should include a link to the thread on nabble where we discuss the issue
[13:13:23 EST(-0500)] <colinclark> And then you can appeal to the Proxy King jessm for permission to add it to the list and actually work on it
[13:13:33 EST(-0500)] <colinclark> Seem reasonable?
[13:13:48 EST(-0500)] <colinclark> jessm: I'm actually thinking you're beyond the Proxy King at this point. You rock at this also
[13:13:53 EST(-0500)] <justin_o> colinclark: sure i can create a jira for it.
[13:14:05 EST(-0500)] <jessm> colinclark: not sure about that
[13:14:09 EST(-0500)] <colinclark> We're becoming more of a democratic Kingdom, I guess.
[13:14:10 EST(-0500)] <colinclark>
[13:14:24 EST(-0500)] <jessm> justin_o: yura: I'm gonna say, add blockers! then squash them!!
[13:14:28 EST(-0500)] <jessm> do that first!
[13:14:30 EST(-0500)] <colinclark>
[13:15:25 EST(-0500)] <jessm> colinclark: is Bosmon just not closing out his bugs?
[13:15:37 EST(-0500)] <colinclark> Bosmon: ^
[13:15:50 EST(-0500)] <colinclark> he's certainly making progress on his bugs
[13:16:06 EST(-0500)] <colinclark> but you'd have to ask him the details... i just pinged him to respond
[13:16:09 EST(-0500)] <jessm> yeah, i know he is, just wondering if any of them have changed status to resolved
[13:16:13 EST(-0500)] <jessm> k
[13:16:31 EST(-0500)] <jessm> oh god! "if any of them HAS changed status
[13:16:39 EST(-0500)] <jessm> he's probably not answering because of my bad grammar
[13:17:46 EST(-0500)] <colinclark> jessm: I find my grammar is getting worse
[13:17:51 EST(-0500)] <colinclark> Because my typing is getting worse
[13:18:16 EST(-0500)] <justin_o> jessm: could you please add http://issues.fluidproject.org/browse/ENGAGE-378 to the bug parade for Yura and I to squash
[13:18:52 EST(-0500)] <jessm> justin_o: yura: squash away boys!
[13:19:00 EST(-0500)] <colinclark> Bosmon: jessm was doing some bug parade tidy up
[13:19:07 EST(-0500)] <Bosmon> Hello
[13:19:11 EST(-0500)] <colinclark> Just wondering if you'd updated the status of your JIRAs, or if they're all still as-is pretty much?
[13:19:13 EST(-0500)] <jessm> hey there
[13:19:16 EST(-0500)] <Bosmon> Yes, I don't think these bugs can be "closed" as such
[13:19:22 EST(-0500)] <jessm> ok
[13:19:24 EST(-0500)] <Bosmon> I guess I could claim some of them are "resolved"
[13:19:32 EST(-0500)] <Bosmon> But the Goosebook itself doesn't actually do anything as yet
[13:19:40 EST(-0500)] <justin_o> colinclark, jessm: any objections to my removing Tags from the repository under the clean up jira
[13:19:40 EST(-0500)] <jessm> Bosmon: are they patched and waiting for review?
[13:20:03 EST(-0500)] <jessm> justin_o: ?
[13:20:18 EST(-0500)] <colinclark> justin_o: YAY!
[13:20:19 EST(-0500)] <colinclark> +1
[13:20:24 EST(-0500)] <justin_o> jessm: we no longer use tags but it is still in the repository
[13:20:35 EST(-0500)] <colinclark> I wish fj was here to sing the Tidy Up song
[13:20:39 EST(-0500)] <jessm> justin_o: ah, go for it
[13:21:01 EST(-0500)] <colinclark> yura: Are you ready for review time now?
[13:21:16 EST(-0500)] <yura> colinclark: sure
[13:21:41 EST(-0500)] <Bosmon> Well, 310 and 309 I guess could be considered done
[13:21:59 EST(-0500)] <Bosmon> I guess we could argue 283 is done
[13:22:32 EST(-0500)] <Bosmon> I guess I should do a bit of cleaning up....
[13:25:13 EST(-0500)] <Bosmon> Ah, I see 283 has sprouted all those children
[13:25:39 EST(-0500)] <Bosmon> I guess I should assign the whole thing to you, although only Sveto's portions remain undone
[13:25:55 EST(-0500)] <colinclark> Bosmon: Ok, go for it
[13:26:03 EST(-0500)] * yakimax (~yakimax@66-224-237-30.atgi.net) has joined #fluid-work
[13:29:21 EST(-0500)] <yura> justin_o: so should I attach my patch for load data to ENGAGE-342 ?
[13:30:34 EST(-0500)] <justin_o> yura: probably shouldn't gone on the parent if we can avoid it... it should probably be a new jira
[13:30:41 EST(-0500)] <justin_o> with that as the parent
[13:31:48 EST(-0500)] <Bosmon> What is the patch to load data?
[13:32:03 EST(-0500)] <Bosmon> ah
[13:32:10 EST(-0500)] <Bosmon> "loading" screen?
[13:33:45 EST(-0500)] <colinclark> Bosmon: Sorry, just doing a code review with yura.
[13:33:53 EST(-0500)] <colinclark> Yep, there are now, what, three spouts in the system?
[13:33:58 EST(-0500)] <Bosmon> I think 4
[13:34:07 EST(-0500)] <colinclark> It was amazing how much code justin_o and I were able to get rid of by switching to a spout
[13:34:10 EST(-0500)] <Bosmon>
[13:34:24 EST(-0500)] <Bosmon> The framework is practically a Colander
[13:35:34 EST(-0500)] <justin_o> Bosmon: load data was that bit of code that would either load data from a local file system or fetched from a server... the renderer is basically taking care of this for us now by rewriting the init block.
[13:36:48 EST(-0500)] <Bosmon> Isn't it gone already?
[13:38:59 EST(-0500)] * yakimax (~yakimax@66-224-237-30.atgi.net) has joined #fluid-work
[13:45:19 EST(-0500)] * yakimax (~yakimax@66-224-237-30.atgi.net) has joined #fluid-work
[13:46:17 EST(-0500)] <yura> justin_o: ok ill create one
[13:47:11 EST(-0500)] <justin_o> yura thanks
[13:50:45 EST(-0500)] <colinclark> jessm: I've reviewed yura's patch for ENGAGE-376. He's going to make a few tweaks to it and then I'll commit it.
[13:51:15 EST(-0500)] <jessm> colinclark: cool!
[13:52:47 EST(-0500)] <justin_o> colinclark: not sure if you've seen sam's e-mail about object code entry
[13:52:55 EST(-0500)] <colinclark> justin_o: I haven't yet
[13:53:02 EST(-0500)] <colinclark> Ignoring email while I do a massive code review sprint
[13:53:05 EST(-0500)] <colinclark> Should I be worried?
[13:53:07 EST(-0500)] <justin_o> basically the buttons are just being read as button
[13:53:33 EST(-0500)] <justin_o> i think we should do <input type="image" src="image url" alt="alt text">
[13:53:43 EST(-0500)] <justin_o> does that seem correct to you
[13:54:06 EST(-0500)] <justin_o> colinclark: ^
[13:54:19 EST(-0500)] <colinclark> justin_o: That will probably work just fine
[13:54:28 EST(-0500)] <colinclark> What does the iPhone simulator do in that case?
[13:54:49 EST(-0500)] <justin_o> i'm just about to try that out... i haven't implemented anything just yet.. but i'll let you know in a minute
[13:55:30 EST(-0500)] <colinclark> justin_o: Thanks
[13:57:22 EST(-0500)] <colinclark> jessm: ENGAGE-280 is reviewed, +1'ed, and closed.
[13:58:05 EST(-0500)] <jessm> k
[13:58:10 EST(-0500)] <colinclark> jessm, justin_o: I'm not sure I'm the one to be reviewing ENGAGE-292, since I implemented the NavBar.
[13:58:15 EST(-0500)] <colinclark> justin_o: What do you think?
[13:59:08 EST(-0500)] <justin_o> colinclark: did you want me to review that one?
[13:59:28 EST(-0500)] <colinclark> justin_o: If you could, yes.
[13:59:45 EST(-0500)] <colinclark> justin_o: Can you do a quick other one for me?
[13:59:51 EST(-0500)] <justin_o> colinclark: also the simulator seems to say the same thing... so i'm not sure if it is the same or if it is just not presenting all of the infor
[14:00:00 EST(-0500)] * yakimax (~yakimax@66-224-237-30.atgi.net) has joined #fluid-work
[14:00:00 EST(-0500)] <colinclark> Sveto has already double checked these for me but a third pair of eyes should help: ENGAGE-346
[14:00:05 EST(-0500)] <justin_o> colinclark: sure i can review
[14:00:15 EST(-0500)] <colinclark> justin_o: interesting
[14:00:23 EST(-0500)] <colinclark> I guess you can always try the phone
[14:01:23 EST(-0500)] <justin_o> colinclark: is the phone accessible today
[14:01:25 EST(-0500)] <justin_o> ?
[14:01:37 EST(-0500)] <colinclark> justin_o: eek
[14:01:41 EST(-0500)] <colinclark> my keys are here at home
[14:01:42 EST(-0500)] <colinclark>
[14:01:53 EST(-0500)] <colinclark> if you need me to, i can come in and unlock it for you
[14:02:09 EST(-0500)] <justin_o> colinclark: it should be okay... i'll think of something
[14:04:33 EST(-0500)] <colinclark> justin_o: Sam's second email looks pretty interesting, too
[14:05:12 EST(-0500)] <justin_o> colinclark: yep... two issues there i guess... lack of live regions and the app is slow
[14:05:22 EST(-0500)] <colinclark> yeah
[14:05:30 EST(-0500)] <colinclark> we'll get that latter one soon enough
[14:06:15 EST(-0500)] <colinclark> all these synchronous AJAX calls Sveto is fond of don't help with the perception of speed, i fear
[14:09:23 EST(-0500)] <colinclark> jessm: ENGAGE-353 is +1'ed and closed
[14:11:24 EST(-0500)] <colinclark> ditto ENGAGE-358
[14:13:48 EST(-0500)] <colinclark> ditto ENGAGE-366
[14:13:56 EST(-0500)] * colinclark is a code reviewing machine
[14:15:48 EST(-0500)] <colinclark> justin_o: As far as testing your fix to ENGAGE-370... I'm guessing it will be blatantly obvious... as in, nothing works in French?
[14:15:51 EST(-0500)] <jessm> colinclark: woot woot
[14:16:05 EST(-0500)] <jessm> colinclark: bah, my css ellipsis works!
[14:16:13 EST(-0500)] <colinclark> YES!
[14:16:24 EST(-0500)] <jessm> but you said it didn't work for you
[14:16:36 EST(-0500)] <colinclark> jessm: It didn't, but I'm kind of an idiot
[14:16:47 EST(-0500)] <jessm> oh hush
[14:17:09 EST(-0500)] <colinclark> For me, it just seemed to cause everything to flow strangely
[14:17:16 EST(-0500)] <colinclark> perhaps I was just missing something?
[14:18:32 EST(-0500)] * yakimax (~yakimax@66-224-237-30.atgi.net) has joined #fluid-work
[14:18:55 EST(-0500)] <colinclark> Hey everyone, any reason I can't rebuild the daily build?
[14:20:27 EST(-0500)] <justin_o> colinclark: sure you can rebuild
[14:20:27 EST(-0500)] <colinclark> justin_o: Another question... your ENGAGE-293 commit says you added the icons for Object code entry. I'm not seeing the warning icon show up. Should that be included, or is it out of scope for this issue?
[14:21:10 EST(-0500)] <justin_o> colinclark: in regards to 370 yes, you'll just see the default strings if it doesn't work. Note that there is a problem with the spouts still i think not finding the bundles when in standalone... that is a different issue
[14:21:32 EST(-0500)] <justin_o> colinclark: the images i added were from ENGAGE-305
[14:21:37 EST(-0500)] <justin_o> they were for that issue...
[14:21:48 EST(-0500)] <justin_o> I'm not sure about the warning one...
[14:22:11 EST(-0500)] <colinclark> justin_o: Ok
[14:22:39 EST(-0500)] <colinclark> You asked me to take a look at your ENGAGE-293 commit for Sveto, and I noticed that warning icon attache dot the ticke.t
[14:22:50 EST(-0500)] <colinclark> I guess I'll close 293 and move the image to a new JIRA
[14:23:04 EST(-0500)] <justin_o> colinclark: yah... sorry about that
[14:23:11 EST(-0500)] <colinclark> justin_o: Not your fault at all!
[14:23:12 EST(-0500)] <colinclark> No worries
[14:23:50 EST(-0500)] <colinclark> jessm: Closed ENGAGE-145 and ENGAGE-149. I had reviewed and committed these two for yura yesterday.
[14:24:13 EST(-0500)] <colinclark> ditto ENGAGE-143
[14:25:01 EST(-0500)] <jessm> colinclark: by my count our to be reviewed are 292, 346, 370, and 376
[14:25:16 EST(-0500)] <colinclark> 376 is in progress--yura is giving me a new patch
[14:25:37 EST(-0500)] <jessm> looks like 292 is closed too
[14:25:47 EST(-0500)] <jessm> 346, and 370 then
[14:26:01 EST(-0500)] <colinclark> jessm: ENGAGE-370 is now closed
[14:26:09 EST(-0500)] <jessm> woah, now it's just 346
[14:26:12 EST(-0500)] <jessm> a machine
[14:26:27 EST(-0500)] <jessm> i better hurry up on my little bug...
[14:26:27 EST(-0500)] <colinclark> justin_o: you're gonna take a quick peek at 346 for me and close it, right?
[14:27:27 EST(-0500)] <jessm> Bosmon: you're on 356, right?
[14:27:29 EST(-0500)] <jessm> it feels big
[14:27:49 EST(-0500)] <jessm> Bosmon: ^
[14:28:06 EST(-0500)] <justin_o> colinclark: yep
[14:28:20 EST(-0500)] <colinclark> thanks dude, i appreciate it
[14:30:23 EST(-0500)] <colinclark> jessm: I've created a new Phase 3 issue and added it to bug parade so I can close an otherwise fixed blocker
[14:30:27 EST(-0500)] <colinclark> The new issue is http://issues.fluidproject.org/browse/ENGAGE-379
[14:30:54 EST(-0500)] <colinclark> The now-complete blocker is http://issues.fluidproject.org/browse/ENGAGE-379
[14:30:56 EST(-0500)] <colinclark> ack
[14:30:58 EST(-0500)] <colinclark> http://issues.fluidproject.org/browse/ENGAGE-293
[14:31:02 EST(-0500)] <justin_o> jessm: closed 346
[14:31:06 EST(-0500)] <colinclark> jessm: You cool with that?
[14:31:20 EST(-0500)] <jessm> colinclark: roger that
[14:31:23 EST(-0500)] <jessm> justin_o: roger that
[14:31:33 EST(-0500)] <jessm> we've got Bos's stuff up for review according to JIRA then
[14:31:45 EST(-0500)] <jessm> and mysteriously it's assigned to me!
[14:31:51 EST(-0500)] <colinclark> jessm: Awesome!
[14:32:01 EST(-0500)] <jessm> um, no
[14:32:22 EST(-0500)] <jessm> we've got artifact view stuff too colinclark i'm assuming you're already reviewing that?
[14:32:49 EST(-0500)] <colinclark> jessm: I'm closing those as we speak
[14:32:57 EST(-0500)] <jessm> colinclark: nice
[14:32:58 EST(-0500)] <colinclark> where they've been reviewed and fixed, that is
[14:33:06 EST(-0500)] * jessm holding breath
[14:33:29 EST(-0500)] <colinclark> such as, jessm, ENGAGE-252
[14:33:43 EST(-0500)] <Bosmon> colinclark: yura tells me that he is removing all the "data" folders for the components
[14:33:43 EST(-0500)] <jessm> yes
[14:33:45 EST(-0500)] <Bosmon> Can you explain why?
[14:33:52 EST(-0500)] * EricDalquist (~dalquist@2607:f388:e:0:221:9bff:fe37:e768) has joined #fluid-work
[14:34:01 EST(-0500)] <colinclark> Bosmon: I don't know anything about it, actually. yura?
[14:34:15 EST(-0500)] <Bosmon> "because we are removing loadData from all templates"
[14:34:16 EST(-0500)] <justin_o> jessm, colinclark, and others: so Sam has found a couple of a11y issues with the code entry page. I've mentioned them early but to recap 1) buttons are just read as "Button" so there is no indication about what button it is 2) There are no live regions to inform what the entered code is nor the messages that get displayed (i.e. page redirect and invalid code)
[14:34:17 EST(-0500)] <Bosmon> Why are we doing this?
[14:34:30 EST(-0500)] <colinclark> Bosmon: If I were to take a random guess, perhaps he's moving sample data into init blocks in the page by default
[14:34:43 EST(-0500)] <Bosmon> Is that really helpful?
[14:34:50 EST(-0500)] <jessm> justin_o: i think they're already on bug parade and you can add details.. lemme find the issue
[14:35:01 EST(-0500)] <colinclark> I dunno. Let's hear what yura is up to
[14:35:21 EST(-0500)] <justin_o> jessm: okay
[14:35:22 EST(-0500)] <jessm> justin_o: it's related but not 'xactly the same as http://issues.fluidproject.org/browse/ENGAGE-347
[14:36:28 EST(-0500)] <jessm> justin_o: my sense is they're critical but not blockers, is that right?
[14:37:07 EST(-0500)] <yura> colinclark: Bosmon yes. the options are in the template
[14:37:09 EST(-0500)] <colinclark> jessm: ENGAGE-354 is closed
[14:37:15 EST(-0500)] <colinclark> yura: So, there's an interesting issue here
[14:37:32 EST(-0500)] <colinclark> We are attempting to shed load data so that we can have a somewhat lighter profile for downloading a template...
[14:37:38 EST(-0500)] <yura> also we can't really load data because of the security issue there
[14:37:55 EST(-0500)] <colinclark> But if you're moving a lot of extra sample data into the template, you're going to bulk it up in a different way
[14:38:03 EST(-0500)] <colinclark> yura: Which security issue are you thinking of?
[14:38:26 EST(-0500)] <yura> local ajax doesnt work in firefox
[14:38:36 EST(-0500)] <Bosmon> You just need to alter a config setting in Firefox
[14:38:37 EST(-0500)] <yura> I saw that in other browsers too
[14:39:07 EST(-0500)] <yura> well yes, but people who might want to use the local version might not know about it
[14:39:18 EST(-0500)] <Bosmon> The people who want to use the local version are DEVELOPERS
[14:39:19 EST(-0500)] <Bosmon> They are us
[14:39:22 EST(-0500)] <colinclark> So, let's break this down a little bit...
[14:39:39 EST(-0500)] <colinclark> First, the issue with local AJAX in Firefox
[14:40:07 EST(-0500)] <yura> actually safari doesnt let it load either
[14:40:56 EST(-0500)] <colinclark> Firefox prevents AJAX calls to the local file system when they access any parent directory, relative to the HTML file
[14:41:06 EST(-0500)] <colinclark> So local AJAX calls to "../foo/bar" will fail.
[14:41:16 EST(-0500)] <colinclark> Whereas, local calls to "foo/bar" will work
[14:41:40 EST(-0500)] <colinclark> Safari, last I checked, had no restrictions on local AJAX calls
[14:41:48 EST(-0500)] <colinclark> Of course, on all browsers, the same origin policy applies
[14:42:10 EST(-0500)] <colinclark> Meaning you can't do a local AJAX call if you're loading a page from the server
[14:42:19 EST(-0500)] <colinclark> Nor can you load something via AJAX from a different domain.
[14:42:27 EST(-0500)] <colinclark> Does this all sound about right, Bosmon and yura?
[14:42:54 EST(-0500)] <Bosmon> Yes, this is all true
[14:42:56 EST(-0500)] <yura> yes
[14:43:30 EST(-0500)] <colinclark> So, our goal is to lighten up all our pages as much as possible...
[14:44:08 EST(-0500)] <colinclark> Removing loadData would certainly cut down on an unnecessary round-trip to the server in production
[14:44:13 EST(-0500)] <justin_o> jessm: it is a bit different than 347. If we were to fix that issue... we may not have this one.
[14:44:20 EST(-0500)] <colinclark> A few ways we could do this, Bosmon and yura:
[14:44:47 EST(-0500)] <colinclark> 1. We could just stuff our sample data in the pages init block. This might work for very small bits of sample data, but might be a bit ugly in other cases.
[14:45:01 EST(-0500)] <jessm> justin_o: file the issue and relate it to 347?
[14:45:05 EST(-0500)] <colinclark> 2. We could use the renderer to remove loadData from the head of templates
[14:45:25 EST(-0500)] <colinclark> 3. We could find some simple replacement for load data in order to get sample data off the file system
[14:45:34 EST(-0500)] <justin_o> jessm: sure i'll file the issues for sure... should i be working on them now though... just wondering about that...
[14:45:55 EST(-0500)] <jessm> lemme check
[14:46:02 EST(-0500)] <colinclark> Pros and cons to each of these options, Bosmon and yura?
[14:46:21 EST(-0500)] <Bosmon> So - let's look at option 3 - what might possibly be simpler than loadData?
[14:46:29 EST(-0500)] <Bosmon> Given it is currently a file with 1.7K of data in it?
[14:46:37 EST(-0500)] <Bosmon> The file is already virtually empty
[14:46:45 EST(-0500)] <colinclark> Bosmon: That's a good sign
[14:46:52 EST(-0500)] <Bosmon> Option 1 - the data as well as becoming ugly, stops being reusable
[14:47:05 EST(-0500)] <jessm> justin_o: what about 378?
[14:47:14 EST(-0500)] <colinclark> Bosmon: Because it's locked into the HTML, rather than sitting somewhere shared on the file system
[14:47:15 EST(-0500)] <Bosmon> The breakage came to light as a result of the fact that I was using one of the data blocks on the serverside as a "stub service"
[14:47:19 EST(-0500)] <Bosmon> Yes
[14:47:28 EST(-0500)] <Bosmon> And there may well be other uses we can think of for these files
[14:47:45 EST(-0500)] <colinclark> jessm: ENGAGE-355 is gonzo
[14:47:45 EST(-0500)] <Bosmon> Having the "test data" written manually inside an init block makes it hard to reuse as well as hard to maintain
[14:48:11 EST(-0500)] <Bosmon> And as for Option 2, if we are really worried about the 1.7K of data, it is as easy as adding rsf:id="scr=ignore" into the include file
[14:48:22 EST(-0500)] <Bosmon> Into the header that is
[14:48:25 EST(-0500)] <colinclark> yura: That sounds like a fairly compelling argument for not putting our sample data into markup
[14:48:47 EST(-0500)] <Bosmon> But I understood we would be rolling some kind of minified distro anyway?
[14:48:58 EST(-0500)] <colinclark> Bosmon: I think that we should be very concerned about all roundtrips to the server at this point... Undoubtedly we'll concat + minify, but we may as well do our best to reduce things from the beginning
[14:49:07 EST(-0500)] <colinclark> So I think your #2 solution makes an awful lot of sense
[14:49:29 EST(-0500)] <justin_o> jessm: 378 still needs to be done
[14:49:45 EST(-0500)] <colinclark> I also think, if we're facing the Ajax local filesystem issue with loadData that we should consider moving data inside a html/data
[14:49:47 EST(-0500)] <Bosmon> Well, we can't do the 2 solutions at once.... weren't we going to make a kind of "EngageAll.js" as I understand it?
[14:49:50 EST(-0500)] <jessm> justin_o: yes, can you work on it?
[14:50:04 EST(-0500)] <colinclark> Bosmon: Doing #2 will get us through until we can concat + minify
[14:50:16 EST(-0500)] <justin_o> jessm: sure
[14:50:18 EST(-0500)] <Bosmon> "through" meaning we might not concat + minify for the pilot?
[14:50:21 EST(-0500)] <colinclark> We're still quite a ways away from having the cycles to implement it, I'm afraid
[14:50:28 EST(-0500)] <jessm> justin_o: it's a higher priority than the object code entry
[14:50:30 EST(-0500)] <colinclark> Bosmon: I suspect we're gonna have to, but I'm taking it one step at a time
[14:50:33 EST(-0500)] <Bosmon> ok
[14:50:51 EST(-0500)] <colinclark> So, yura, is this all making some sense?
[14:50:52 EST(-0500)] <justin_o> jessm: makes sense... so i'll file those other jiras... and move on... thanks
[14:51:05 EST(-0500)] <jessm> justin_o: thank you! i hope that's ok?
[14:51:23 EST(-0500)] <yura> so for the ajax problem, do i put it in html/data?
[14:51:29 EST(-0500)] <colinclark> jessm: can you recap real quick what you guys just decided?
[14:51:39 EST(-0500)] <colinclark> yura: If we feel it's a big enough problem to worry about it right now
[14:51:43 EST(-0500)] <colinclark> I'm not fully convinced it is
[14:51:49 EST(-0500)] <colinclark> but I'm open to the idea
[14:52:12 EST(-0500)] <jessm> colinclark: sure, justin_o is going to work on 378 after he files the a11y bugs for object code entry that are critical, but not blocker and related to 347
[14:52:44 EST(-0500)] <Bosmon> loadData seems to work for me in Safari as it is
[14:52:47 EST(-0500)] <Bosmon> At least on Windows
[14:53:22 EST(-0500)] <colinclark> yura: Is it working for you?
[14:53:25 EST(-0500)] <yura> yes
[14:53:34 EST(-0500)] <yura> colinclark: i can focus on the other patch for now then
[14:53:34 EST(-0500)] <yura> ?
[14:53:57 EST(-0500)] <colinclark> jessm: +1 on starting with ENGAGE-378. We are going to have to get to those a11y pretty soon, though
[14:54:20 EST(-0500)] <colinclark> yura: I'd go ahead and add the scr=ignore to all references to load data
[14:54:26 EST(-0500)] <colinclark> then you can carry on, yes
[14:54:38 EST(-0500)] <jessm> colinclark: roger that – soon = critical; immediate=blocker
[14:54:42 EST(-0500)] <yura> ok
[14:54:47 EST(-0500)] <colinclark> jessm: lol
[14:54:48 EST(-0500)] <justin_o> jessm: just filed ENGAGE-380 and ENGAGE-381
[14:55:08 EST(-0500)] <colinclark> yura: You rock, thanks. These issues are always a little more subtle once you peel back a layer or two
[14:55:22 EST(-0500)] <jessm> justin_o: great, thanks
[14:55:24 EST(-0500)] <colinclark> justin_o: how're your java chops these days?
[14:55:58 EST(-0500)] * yakimax (~yakimax@66-224-237-30.atgi.net) has joined #fluid-work
[14:56:06 EST(-0500)] <colinclark> yura: Quick question for you
[14:56:09 EST(-0500)] <colinclark> http://issues.fluidproject.org/browse/ENGAGE-341
[14:56:14 EST(-0500)] <justin_o> colinclark: dusty and rusty... with a few cob webs
[14:56:22 EST(-0500)] <colinclark> Did you actually get those icons into the repo, even if they aren't loading correctly?
[14:56:43 EST(-0500)] <colinclark> justin_o: I can give you a hand on Monday... probably not today since I'm still sitting on a few My Collection blockers
[14:56:58 EST(-0500)] <colinclark> And I have a band practice at 8 tonight so I want to get 'em all squashed by then
[14:57:04 EST(-0500)] <justin_o> colinclark: np
[14:57:35 EST(-0500)] <colinclark> yura's got a few other patches on his plate, but he could help with import. Might be worth pairing up at this stage
[14:57:41 EST(-0500)] <colinclark> justin_o: ^
[14:58:18 EST(-0500)] <yura> colinclark: not really, i dont think the imgages got included into a patch
[14:58:22 EST(-0500)] <justin_o> colinclark: will do
[14:58:50 EST(-0500)] <colinclark> yura: Ok. Are there references to those images in the code? If so, I'll go ahead and commit them
[14:59:04 EST(-0500)] <yura> yes there were
[14:59:19 EST(-0500)] <colinclark> yura: wicked. i'll commit them right now
[14:59:37 EST(-0500)] <yura> thanks
[14:59:46 EST(-0500)] <colinclark> Bosmon: Got time for a super-quick question?
[15:01:20 EST(-0500)] <Bosmon> yes
[15:02:20 EST(-0500)] <colinclark> Bosmon: URL rewriting again
[15:02:45 EST(-0500)] <colinclark> I want to think that perhaps there is now a way to get a stable URL to things in code
[15:02:53 EST(-0500)] <Bosmon> Yes
[15:02:55 EST(-0500)] <Bosmon> There is
[15:03:08 EST(-0500)] <colinclark> Here's my use case. I've got a couple of image URLs that, for whatever reason aren't in the markup
[15:03:13 EST(-0500)] <colinclark> How can I ensure that they rock?
[15:03:17 EST(-0500)] <Bosmon>
[15:04:07 EST(-0500)] <Bosmon> I think I gave some pointers in my mail from the night before, but I may have forgotten...
[15:04:38 EST(-0500)] <colinclark> jessm: ENGAGE-375 is now closed, too
[15:04:49 EST(-0500)] <colinclark> Bosmon: Ah, which email? I'm frightfully scatted about emails these days
[15:04:51 EST(-0500)] <Bosmon> There is now a utility in kettle.js called "expandMountRelative"
[15:04:59 EST(-0500)] <colinclark> ok
[15:05:26 EST(-0500)] <Bosmon> For example, it is what is being used in the Goosebook in order to find the reference to its own template file
[15:05:29 EST(-0500)] <colinclark> jessm: ditto ENGAGE-159
[15:05:39 EST(-0500)] <colinclark> Bosmon: Cool. I'll look there, then.
[15:05:48 EST(-0500)] <colinclark> You also rule, since this was a major pain point for us
[15:05:51 EST(-0500)] <jessm> colinclark: Goosebook reviews are all you too – even though they're assigned to me!
[15:05:51 EST(-0500)] <colinclark> And you fixed it!@
[15:06:04 EST(-0500)] <colinclark> jessm: Can you reassign when you get a chance
[15:06:21 EST(-0500)] <colinclark> Bosmon: I'm tempted to wait and do a big Goose book review when all your geese are honking simultaneously?
[15:06:23 EST(-0500)] <Bosmon> I guess it could theoretically use the renderHandlerConfig + resolveLocalUrl method, but this seems if anything even more straightforward
[15:06:27 EST(-0500)] <jessm> colinclark: doing...
[15:07:04 EST(-0500)] <Bosmon> colinclark - I guess. Although if anyone has some CSS cycles at some point it could be helpful
[15:07:09 EST(-0500)] <colinclark> yura: Good news. I've closed all your Artifact View blockers!
[15:07:10 EST(-0500)] <Bosmon> The Goosebook currently looks terrible
[15:07:17 EST(-0500)] <colinclark> except one, for the media images, which I reopened and will fix myself
[15:07:24 EST(-0500)] <Bosmon> I also wanted to mention this issue of background images
[15:07:33 EST(-0500)] <colinclark> Bosmon: I can probably give you some CSS cycles on Monday
[15:07:38 EST(-0500)] <Bosmon> I think it was in my mail, but it is probably worth bringing up again
[15:07:43 EST(-0500)] <colinclark> unless jessm is feeling up for it
[15:07:48 EST(-0500)] <jessm> Bosmon: i suck at CSS, but i've been doing it anyway
[15:07:52 EST(-0500)] <colinclark> I think she could tackle it with no problem
[15:08:01 EST(-0500)] <Bosmon> Since we do no url-rewriting currently on "nested templates", it means that any images the Goosebook uses need to be applied in CSS
[15:08:02 EST(-0500)] <jessm> Bosmon: y'all are gonna have to re-do all of it anyway
[15:08:08 EST(-0500)] <Bosmon> For example the little pencil icon etc.
[15:08:09 EST(-0500)] <colinclark> jessm: I'm guessing Bosmon's pages are even previewable from the filesystem
[15:08:22 EST(-0500)] <colinclark> Bosmon: There's one risk to that...
[15:08:23 EST(-0500)] <Bosmon> They are indeed previewable from the filesystem...
[15:08:24 EST(-0500)] <colinclark> alt text
[15:08:27 EST(-0500)] <jessm> Bosmon: whatryourpages?
[15:08:36 EST(-0500)] <Bosmon> Well, there is goosebook.html?
[15:08:37 EST(-0500)] <colinclark> CSS background images tend not to have the ability to set alt text
[15:08:47 EST(-0500)] <Bosmon> colinclark - that is awkward
[15:08:58 EST(-0500)] <colinclark> i assume the icons are actually focusable?
[15:09:03 EST(-0500)] <colinclark> or are they just decorative?
[15:09:10 EST(-0500)] <Bosmon> I think the little pencil is actually a link
[15:09:12 EST(-0500)] <jessm> Bosmon: we're off to a good start
[15:09:25 EST(-0500)] <Bosmon> You click on it to write a new comment
[15:09:58 EST(-0500)] <jessm> colinclark: when you get a moment, i'm going to reveal my svn-ignorance. i've got to create a patch, but i want to create it from two of the 3 files i've edited – how do i | only those 2 files to a patch file/
[15:10:14 EST(-0500)] <colinclark> jessm: ah, good question
[15:10:17 EST(-0500)] <Bosmon> So, even things like setting width and height are a bit problematic
[15:10:23 EST(-0500)] <colinclark> Bosmon: Does the link have any text in it
[15:10:35 EST(-0500)] <colinclark> jessm: Your third file--do you actually want to keep the changes in it?
[15:10:41 EST(-0500)] <Bosmon> I struggled until I could get a "thing" to display so that it had the same size as the background image
[15:10:43 EST(-0500)] <colinclark> Easiest thing to do is just revert that third file
[15:10:51 EST(-0500)] <jessm> colinclark: yes, it's my un-reviewed previous patch for another issue
[15:10:51 EST(-0500)] <Bosmon> colinclark: What I did was actually to use a "label"
[15:10:52 EST(-0500)] <colinclark> Otherwise, any sane GUI should let you generate a patch from just the two files you want
[15:11:01 EST(-0500)] <colinclark> Bosmon: A label tag?
[15:11:01 EST(-0500)] <jessm> colinclark: oh, but i already uploaded it
[15:11:02 EST(-0500)] <Bosmon> So the text says "Add note"
[15:11:03 EST(-0500)] <Bosmon> Yes
[15:11:05 EST(-0500)] <Bosmon> A label tag
[15:11:19 EST(-0500)] <jessm> colinclark: roger that
[15:11:20 EST(-0500)] <Bosmon> And I made this the label for the "thing" which was a link which had the background image
[15:11:30 EST(-0500)] <colinclark> Bosmon: I dunno if it will work, but that is a good start
[15:11:53 EST(-0500)] <colinclark> jessm: So are you going to try to address Bosmon's styling woes?
[15:12:03 EST(-0500)] <jessm> colinclark: i'm going to poke around quietly
[15:12:12 EST(-0500)] <colinclark> Bosmon: Next week, I can do some a11y testing of your goose book images
[15:12:22 EST(-0500)] <colinclark> It occurs to me that I keep saying "Monday" when really Monday is a holiday here.
[15:12:27 EST(-0500)] <colinclark> I'm snowboarding that day. Tuesday.
[15:12:32 EST(-0500)] <Bosmon> Other issues are that the CSS for the goosebook is completely screwed up when it becomes embedded, say, in the artifact view
[15:12:42 EST(-0500)] <Bosmon> The text styling mixes up with the artifact view styling
[15:12:48 EST(-0500)] <Bosmon> There is a CATT here
[15:13:00 EST(-0500)] <colinclark> There's one here, too!
[15:13:05 EST(-0500)] <Bosmon> It is.... CATTING
[15:13:08 EST(-0500)] <colinclark> With bad breath, no less
[15:13:12 EST(-0500)] <Bosmon> Ah
[15:13:19 EST(-0500)] <Bosmon> This CATTT has always smelled sweet
[15:13:28 EST(-0500)] <Bosmon> A mysteriously constant smell of freshly washed linen...
[15:13:31 EST(-0500)] <jessm> Bosmon: thank you :-D
[15:13:34 EST(-0500)] <colinclark> lol
[15:17:25 EST(-0500)] <yura> ok colinclark i attached 2 new patches for 376
[15:17:30 EST(-0500)] <yura> ENAGE-376 that os
[15:17:31 EST(-0500)] <yura> is
[15:17:32 EST(-0500)] <yura>
[15:17:36 EST(-0500)] <colinclark> yura: great, thanks dude
[15:17:48 EST(-0500)] <yura> they no title thing worked perfectly
[15:17:51 EST(-0500)] <colinclark> do you want to review it now?
[15:17:57 EST(-0500)] <yura> in 10mis?
[15:18:02 EST(-0500)] <yura> mins
[15:18:03 EST(-0500)] <colinclark> sure
[15:18:06 EST(-0500)] <colinclark> ping me when you're ready
[15:18:12 EST(-0500)] <colinclark> i'll work on your artifact view media images
[15:26:32 EST(-0500)] <colinclark> Bosmon: I must be thinking about this the wrong way, but I the issue is that I need to resolve image URLs for the client, not the server. Whereas, I'm assuming expandMountRelative() will give me a file:// URL
[15:27:06 EST(-0500)] <jessm> colinclark: should i really have a go with Guestbook CSS? it's raw enough that I'm going to be more creating than tweaking like I just did for exhibition
[15:27:25 EST(-0500)] <colinclark> jessm: Yeah, that sounds okay to me if you're up for it
[15:27:35 EST(-0500)] <colinclark> Your chance to use the FSS from scratch
[15:27:37 EST(-0500)] <jessm> colinclark: worst case we can revert
[15:27:52 EST(-0500)] <colinclark> jessm: Well, you are creating patches, so worst case we just won't commit
[15:27:55 EST(-0500)] <colinclark>
[15:28:04 EST(-0500)] <jessm> colinclark: even better!
[15:28:31 EST(-0500)] <colinclark> There's a certain freedom about not having commit access--ultimately someone else is responsible if your code breaks everything
[15:29:41 EST(-0500)] <jessm> excellent!
[15:31:50 EST(-0500)] <jessm> jameswy: is the navigationbar text for goosebook different from the exhibition name?
[15:33:52 EST(-0500)] <yura> colinclark: do you want to review that patch now?
[15:34:12 EST(-0500)] <jameswy> jessm: Yep. It should read Guestbook, I believe.
[15:34:26 EST(-0500)] <colinclark> jameswy: Make that "Guest book"
[15:34:36 EST(-0500)] <colinclark> Otherwise it really will be the Goosebook
[15:34:38 EST(-0500)] <colinclark> Honk honk
[15:34:41 EST(-0500)] <jameswy> jessm: My bad, it should be: "Simply Montreal: Guest Book"
[15:36:02 EST(-0500)] <jessm> jameswy: so, "exhibition name": Guest Book
[15:36:07 EST(-0500)] <jessm> presumably we have more than one
[15:37:32 EST(-0500)] <colinclark> jessm: Yep, we have lots of exhibitions, so that title will have to be dynamically rendered
[15:37:43 EST(-0500)] <jessm> colinclark: rt
[15:37:50 EST(-0500)] <colinclark> boz may already be doing that, I'm not sure
[15:38:04 EST(-0500)] <colinclark> yura: call me when you're ready
[15:38:18 EST(-0500)] <jameswy> jessm: correct.
[15:41:59 EST(-0500)] <jessm> jameswy: hrm
[15:42:32 EST(-0500)] <jessm> jameswy: so, the wireframes... for exhibition show the nav bar with Simply Montr... and then the first heading is Simply Montreal
[15:43:15 EST(-0500)] <jessm> jameswy: but goosebook has SImply Montr... and then no heading
[15:43:23 EST(-0500)] <jessm> jameswy: i might be talking outloud here... ignore me
[15:44:14 EST(-0500)] <jameswy> jessm: Correct. The design repeats the name because the navigation bar will typically cut part of it off. In Guestbook, the rationale is that we're still within the "Simply Montreal" exhibition page, and we're just looking at a subpage. Repetition at this point is an extra affordance, not a necessity.
[15:44:39 EST(-0500)] <jameswy> Visually, it will be obvious by the the time they get to Guestbook that they're in a Guestbook, and accessibility-wise we have the heading.
[15:58:08 EST(-0500)] * Bosmon5 (~AndChat@16.sub-97-37-44.myvzw.com) has joined #fluid-work
[15:58:18 EST(-0500)] <colinclark> Hey Bosmon5
[16:00:10 EST(-0500)] <colinclark> jessm: I committed Yura's second patch for ENGAGE-376 and have closed it.
[16:01:23 EST(-0500)] <jessm> colinclark: sweet
[16:01:40 EST(-0500)] <jessm> if you want to kill all the resolved ones, then 310 and 309 are all that are left
[16:02:31 EST(-0500)] <colinclark> jessm: ok, i'll see what I can do
[16:02:36 EST(-0500)] <colinclark> Should probably get back to My Collection
[16:02:39 EST(-0500)] <colinclark> It's gotta get into trunk asap
[16:02:46 EST(-0500)] <jessm> colinclark: go to My Collection
[16:02:52 EST(-0500)] <jessm> i agree re: trunk
[16:15:34 EST(-0500)] * yakimax (~yakimax@66-224-237-30.atgi.net) has joined #fluid-work
[16:26:13 EST(-0500)] <colinclark> yura: Do you know of any artifacts that have audio attached to them?
[16:26:34 EST(-0500)] * yakimax (~yakimax@66-224-237-30.atgi.net) has joined #fluid-work
[16:35:44 EST(-0500)] <yura> not that i m aware of
[16:41:44 EST(-0500)] * Bosmo1 (~Bosmon@eccr224-158-dhcp.colorado.edu) has joined #fluid-work
[16:42:02 EST(-0500)] <Bosmo1> Congrats to all on fixing the two views that I broke
[16:42:15 EST(-0500)] <Bosmo1> We are just now discussing this issue of "ordering in CouchDB view keys"
[16:42:33 EST(-0500)] <Bosmo1> But also, in looking at the catalogue, I am seeing some crazy formatting in Firefox... I guess we don't really care about this, but all the same it seems odd
[16:42:42 EST(-0500)] <Bosmo1> I see a little scrollbar on every row
[16:42:48 EST(-0500)] <Bosmo1> But when I try to drag it, the entire row seems to drag
[16:42:52 EST(-0500)] <Bosmo1> But fails
[16:45:11 EST(-0500)] * yakimax (~yakimax@66-224-237-30.atgi.net) has joined #fluid-work
[16:48:02 EST(-0500)] <colinclark> Bosmo1: Jess has a patch for this issue, I believe
[16:48:24 EST(-0500)] <colinclark> jessm: ^
[16:48:38 EST(-0500)] <jessm> um, yeah, i have something
[16:48:41 EST(-0500)] <colinclark> yura: Do you know of any artifacts in the database that have audio, as opposed to video?
[16:49:40 EST(-0500)] <jessm> Bosmon: this is what i have for catalogue: http://issues.fluidproject.org/browse/ENGAGE-363
[16:51:17 EST(-0500)] <Bosmo1> OK. this is pretty insane
[16:51:30 EST(-0500)] <colinclark> Bosmo1: Any reason why I would encounter images whose src wasn't getting rewritten?
[16:51:30 EST(-0500)] <Bosmo1> So, we will have to write our own "JSON" "encoder" for material which appears in Couch URLs
[16:51:53 EST(-0500)] <Bosmo1> Since it is just it seems "sheer luck" that the views we have are working
[16:52:14 EST(-0500)] <colinclark> Bosmo1 This is the issue I filed: //issues.fluidproject.org/browse/ENGAGE-383
[16:52:14 EST(-0500)] <Bosmo1> I can easily imagine that on a different VM they might just fail
[16:52:22 EST(-0500)] <colinclark> By sheer luck, indeed
[16:52:31 EST(-0500)] <Bosmo1> Unless there is some oddity that causes NativeJson to always output keys in alphabetical order or something
[16:52:32 EST(-0500)] <colinclark> We should see if Couch will fix the issue
[16:52:35 EST(-0500)] <Bosmo1> I'll just have a look at the source
[16:52:43 EST(-0500)] <Bosmo1> I can't imagine they would fix it if they have not fixed it so far
[16:52:54 EST(-0500)] * jhung (~Lynnette@H63.C204.cci.switchworks.net) has left #fluid-work
[16:53:01 EST(-0500)] <Bosmo1> colinclark: As for image src... what do they look like?
[16:53:02 EST(-0500)] <colinclark> Bosmo1: No reason to assume.
[16:53:18 EST(-0500)] <Bosmo1> Well... it is such an obvious "behaviour" that they must mean something by it
[16:53:20 EST(-0500)] <Bosmo1> I will research it a bit
[16:53:27 EST(-0500)] <colinclark> thanks Bosmo1
[16:53:49 EST(-0500)] <colinclark> <img class="flc-artifactView-video-icon" src="../../../../fluid-engage-core/components/artifactView/images/video_icon.png"/>
[16:54:05 EST(-0500)] <Bosmo1> No reason that should not be rewritten, no
[16:54:09 EST(-0500)] <colinclark> odd
[16:54:09 EST(-0500)] <Bosmo1> Assuming it is correct in the first place
[16:54:12 EST(-0500)] <Bosmo1> Does it work in the template?
[16:54:15 EST(-0500)] <colinclark> it does indeed
[16:54:21 EST(-0500)] <colinclark> quite niftily
[16:54:26 EST(-0500)] <Bosmo1> ok
[16:54:27 EST(-0500)] <colinclark> ah, well, perhaps i'm going something stupid
[16:54:33 EST(-0500)] <colinclark> yura: do you know of any artifacts which have audio
[16:54:35 EST(-0500)] <colinclark> ?
[16:54:36 EST(-0500)] <Bosmo1> It doesn't match a cutpoint by any chance?
[16:54:44 EST(-0500)] <Bosmo1> That is, a cutpoint on the server
[16:55:33 EST(-0500)] <colinclark> Bosmo1: Ack, I'm being an idiot
[16:56:14 EST(-0500)] <colinclark> One must restart Kettle if one wants to see one's changes to server-side code in action
[16:56:19 EST(-0500)] <colinclark> Not me, of course, but "one"
[16:56:45 EST(-0500)] <Bosmo1>
[16:57:41 EST(-0500)] <colinclark> ok, this all works
[16:57:50 EST(-0500)] * yakimax (~yakimax@66-224-237-30.atgi.net) has joined #fluid-work
[16:57:53 EST(-0500)] <colinclark> I'd love to see an artifact with related audio before I commit. Any luck finding one, yura?
[16:58:35 EST(-0500)] <Bosmo1> colinclark, yura: It seems that "collation" is a fairly substantial issue
[16:58:37 EST(-0500)] <Bosmo1> http://wiki.apache.org/couchdb/View_collation
[16:59:08 EST(-0500)] <Bosmo1> I don't think we have really been doing what we think we have been doing when making queries
[16:59:19 EST(-0500)] <colinclark> "CouchDB allows arbitrary JSON structures to be used as keys. You can use complex keys for fine-grained control over sorting and grouping. "
[16:59:34 EST(-0500)] <Bosmo1> Keep reading
[16:59:51 EST(-0500)] <colinclark> i am, i am
[17:01:10 EST(-0500)] <Bosmo1> So... this isn't anything like what I imagined
[17:01:29 EST(-0500)] <Bosmo1> I imagined we had the ability to design our own Couch URLs to some extent... but clearly we don't
[17:03:04 EST(-0500)] <yura> colinclark: there's no audio
[17:03:08 EST(-0500)] <yura> at the moment
[17:03:13 EST(-0500)] <yura> i checked all artifacts
[17:03:45 EST(-0500)] <colinclark> Bosmo1: So, I now agree with you that we'll have to write our own serialization for Couch keys
[17:03:52 EST(-0500)] <colinclark> yura: Thanks!
[17:03:55 EST(-0500)] <Bosmo1> Which is quite surprising
[17:03:58 EST(-0500)] <yura> colinclark: np
[17:04:01 EST(-0500)] <Bosmo1> In a language which is itself Javascript
[17:04:34 EST(-0500)] <colinclark> yes
[17:04:40 EST(-0500)] <colinclark> very
[17:05:04 EST(-0500)] <Bosmo1> So, what Couch operates is actually a kind of "lexicographic Javascript"
[17:05:05 EST(-0500)] <colinclark> I will link to this collation document and close the JIRA, since I can't imagine we want to try to get them to fix it
[17:05:15 EST(-0500)] <Bosmo1> They would probably laugh at us
[17:05:22 EST(-0500)] <colinclark> yeah
[17:05:25 EST(-0500)] <colinclark> sorry dude
[17:05:38 EST(-0500)] <Bosmo1> Must as Chargaff laughed at Crick and Watson when he discovered they didn't even know the difference between purines and pyrimidines
[17:05:46 EST(-0500)] <Bosmo1> er Much as
[17:06:29 EST(-0500)] <colinclark> this was the jira... I think I may have pasted it wrong earlier http://issues.fluidproject.org/browse/ENGAGE-383
[17:06:29 EST(-0500)] <Bosmo1> I think that doing things this way actually gives queries more power - as well as reducing the time Couch would have to spend canonicalising things
[17:06:34 EST(-0500)] <colinclark> yes
[17:07:08 EST(-0500)] <Bosmo1> But at least I understand now what went wrong at the weekend... since I could really see "no way" that it seemed I could have been responsible for breaking those views
[17:07:35 EST(-0500)] <Bosmo1> But what actually happened was that the change I made caused conversion into JSON to occur at a different time in the request workflow
[17:07:46 EST(-0500)] <Bosmo1> Which, just randomly, caused the keys to get encoded in a different order
[17:07:53 EST(-0500)] <Bosmo1> It's interesting that it is so consistent though
[17:08:09 EST(-0500)] <Bosmo1> let me look at the NativeJson code for a bit to see if it is trying to do anything....
[17:08:24 EST(-0500)] <colinclark> cool
[17:08:28 EST(-0500)] <Bosmo1> But I think we have to declare this a blocker
[17:08:38 EST(-0500)] <Bosmo1> As it stands, any view could fail at absolutely any time
[17:10:28 EST(-0500)] * yakimax (~yakimax@66-224-237-30.atgi.net) has joined #fluid-work
[17:10:37 EST(-0500)] <Bosmo1> Actually - did Yura check into our SVN somewhere the exact code tree used to build Rhino1.3Pre?
[17:10:45 EST(-0500)] <Bosmo1> I think it is important that we keep a firm record of that
[17:10:46 EST(-0500)] <Bosmo1> Damn
[17:10:47 EST(-0500)] <Bosmo1> he is gone
[17:11:20 EST(-0500)] <colinclark> hey Bosmo1, can you do me a favour?
[17:11:22 EST(-0500)] <Bosmo1> yes
[17:11:26 EST(-0500)] <colinclark> I'm wondering if you'll review my two commits for http://issues.fluidproject.org/browse/ENGAGE-341
[17:11:30 EST(-0500)] <Bosmo1> ok
[17:11:34 EST(-0500)] <colinclark> Related to adding support for the media icons.
[17:11:46 EST(-0500)] <colinclark> In short, you'll want to look at both the ArtifactView template, view.html
[17:11:55 EST(-0500)] <colinclark> and the component itself
[17:12:18 EST(-0500)] <Bosmo1> ok
[17:12:22 EST(-0500)] <colinclark> Unfortunately there are no audio files related to any of our artifacts, so we can't test that it fully works
[17:13:09 EST(-0500)] <Bosmo1> "since we don't yet have the ability to programmatically rebase URLs on the client"
[17:13:13 EST(-0500)] <Bosmo1> I guess you meant on the server?
[17:13:23 EST(-0500)] <Bosmo1> Well, I guess you meant, "client-operated urls on the server"
[17:14:07 EST(-0500)] <Bosmo1> Hmm
[17:14:22 EST(-0500)] <Bosmo1> Do you like a space before the ternary operator query?
[17:16:27 EST(-0500)] <colinclark> Bosmo1: So says JSLint
[17:16:40 EST(-0500)] <Bosmo1> .....
[17:16:48 EST(-0500)] <Bosmo1> JSLint is written by a wonk
[17:16:54 EST(-0500)] <colinclark> Bosmo1: yes, to your comment about my commit log
[17:17:09 EST(-0500)] <colinclark> Bosmo1: Yes, indeed. You can feel free to hate Crockford for our style guidelines
[17:17:13 EST(-0500)] <colinclark> But they remain our style guidelines
[17:17:16 EST(-0500)] <Bosmo1> "to my eyes" I think it is clearer with the polarity of the ? operator next to the value which it tests
[17:17:24 EST(-0500)] <colinclark> and they keep us from hating each other over our style guidelines
[17:17:27 EST(-0500)] <Bosmo1> I mean, it clearly has no relation to the value after it
[17:18:13 EST(-0500)] <Bosmo1> Hmm... Eclipse diff has improved in recent versions
[17:18:19 EST(-0500)] <Bosmo1> It actually shows you what has changed
[17:18:29 EST(-0500)] <colinclark>
[17:18:58 EST(-0500)] <Bosmo1> The patch looks good, although I would write the argument to getMediaIconURLsFromDOM as simply the DOM binder itself to be clear that this is all the utility requires
[17:19:11 EST(-0500)] <Bosmo1> "naturally" this sort of thing goes away once we have a proper IoC system
[17:19:14 EST(-0500)] <colinclark> Bosmo1: Yes, you're totally right
[17:19:22 EST(-0500)] <colinclark> Honestly, this was something i was just talking to Yura about the other day
[17:19:32 EST(-0500)] <colinclark> Being specific in your function arguments
[17:19:42 EST(-0500)] <colinclark> I suck, and will fix it
[17:20:06 EST(-0500)] <Bosmo1> No, you do not suck
[17:20:23 EST(-0500)] <Bosmo1> And as a microscopic point of style I would avoid calling the function and sending in the same statement
[17:20:33 EST(-0500)] <jessm> Bosmo1: any idea why styling isn't happening on Goosebook? e.g. NavigationBar styling it's inheriting?
[17:20:49 EST(-0500)] <Bosmo1> It is something I see a lot and I don't think that our download footprint would kill us with it
[17:21:04 EST(-0500)] <Bosmo1> jessm: In Junior Jacob stakes I guess I would rate Junior Jacob VI
[17:21:20 EST(-0500)] <jessm>
[17:21:33 EST(-0500)] <Bosmo1> colinclark: I am meaning on line 151
[17:21:58 EST(-0500)] <colinclark> Bosmo1: Interesting.
[17:22:05 EST(-0500)] <colinclark> This is something I have been doing a lot of these days...
[17:22:15 EST(-0500)] <colinclark> I find it strangely annoying to see variables declared for only one usage
[17:22:21 EST(-0500)] <Bosmo1>
[17:22:25 EST(-0500)] <colinclark> It certainly makes debugging less pleasant
[17:22:29 EST(-0500)] <Bosmo1> You must find a lot of my code strangely annoying then
[17:22:34 EST(-0500)] <colinclark>
[17:22:34 EST(-0500)] <Bosmo1> You mean, more pleasant?
[17:22:59 EST(-0500)] <justin_o> Bosmo1, colinclark: yura and i are going to update the databases
[17:23:00 EST(-0500)] <justin_o> is that okay
[17:23:11 EST(-0500)] <Bosmo1> justin_o: OK - what is the update going to be?
[17:23:11 EST(-0500)] <colinclark> justin_o: umm
[17:23:15 EST(-0500)] <colinclark> can you hang on one sec?
[17:23:20 EST(-0500)] <justin_o> sure...
[17:23:21 EST(-0500)] <Bosmo1> Did you discover the thing behind the incorrect thumbnail urls?
[17:23:23 EST(-0500)] <colinclark> justin_o: I just want to test my fix here
[17:23:37 EST(-0500)] <justin_o> Bosmo1: we have reimported the data
[17:23:47 EST(-0500)] <colinclark> So Bosmo1, you'd prefer this above line 151:
[17:23:51 EST(-0500)] <colinclark> var mediaIconURLs = getMediaIconURLsFromDOM(that.dom);
[17:23:53 EST(-0500)] <justin_o> it all seems to be working (related artifacts and their thumbnails)
[17:23:54 EST(-0500)] <colinclark> that.sections = makeCabinetSections(that.model, that.options, mediaIconURLs);
[17:24:09 EST(-0500)] <Bosmo1> Yes, something like that
[17:24:12 EST(-0500)] <colinclark> hmm
[17:24:20 EST(-0500)] <Bosmo1> Also, I believe you have placed the image icons outside the templated area?
[17:24:29 EST(-0500)] <Bosmo1> So this suggests you wouldn't need to add them to "selectorsToIgnore"
[17:24:32 EST(-0500)] <colinclark> We could bike shed about that all day
[17:24:32 EST(-0500)] <Bosmo1> I guess it is best to be safe
[17:24:40 EST(-0500)] <colinclark> I thought it was prudent, just in case
[17:24:45 EST(-0500)] <Bosmo1> ok
[17:24:48 EST(-0500)] <colinclark> but yes, i did place it as far away from the rest of the world as possible
[17:24:49 EST(-0500)] <colinclark> i
[17:24:59 EST(-0500)] <Bosmo1> I guess each missing selector does actually speed up parsing somewhat
[17:25:08 EST(-0500)] <colinclark> it did occur to me that stripping these things out of the document might make some sense
[17:25:14 EST(-0500)] <colinclark> but this should be ok
[17:25:29 EST(-0500)] <Bosmo1> ok
[17:25:42 EST(-0500)] <colinclark> justin_o: two minutes
[17:25:43 EST(-0500)] <colinclark> sorry
[17:26:12 EST(-0500)] <Bosmo1> ok
[17:27:17 EST(-0500)] <Bosmo1> Well, I think that is all I can find to "review"
[17:27:25 EST(-0500)] <colinclark> Bosmo1: thanks
[17:27:32 EST(-0500)] <colinclark> I'll get you to close it in a sec when I commit again
[17:29:46 EST(-0500)] <colinclark> Bosmo1: Ok, it's in
[17:29:52 EST(-0500)] <colinclark> Close it if you like what I've done
[17:29:57 EST(-0500)] <Bosmo1>
[17:29:58 EST(-0500)] <colinclark> justin_o: go fo rit
[17:30:19 EST(-0500)] <justin_o> colinclark: thanks
[17:30:20 EST(-0500)] <colinclark> back to my collection for me
[17:30:21 EST(-0500)] <justin_o> will do
[17:30:27 EST(-0500)] <justin_o>
[17:30:55 EST(-0500)] <Bosmo1> Who is the "final assignee" of closed issues?
[17:30:57 EST(-0500)] <Bosmo1> KING I?
[17:31:10 EST(-0500)] <colinclark> Bosmo1: Once it's closed, no one need be the final assignee
[17:31:17 EST(-0500)] <Bosmo1> Ah
[17:31:19 EST(-0500)] <colinclark> I should really resolve it and bounce it to you
[17:31:20 EST(-0500)] <Bosmo1> It can be "Unassigned"
[17:31:23 EST(-0500)] <Bosmo1> Didn't see that
[17:31:24 EST(-0500)] <colinclark> and then you can jsut close it and tell jessm
[17:32:23 EST(-0500)] <colinclark> jessm: One more blocker down ENGAGE-341
[17:32:31 EST(-0500)] <jessm> colinclark: yay
[17:33:24 EST(-0500)] <jessm> open bugs are down to one page!
[17:33:30 EST(-0500)] <jessm> on a large monitor...
[17:35:25 EST(-0500)] <colinclark>
[17:35:35 EST(-0500)] <colinclark> justin_o: You'll ping us when the DB is back again? I miss it already
[17:35:46 EST(-0500)] * clown (~clown@142.150.154.101) has left #fluid-work
[17:35:47 EST(-0500)] <justin_o> colinclark: yes, will do
[17:36:10 EST(-0500)] <justin_o> i still haven't had a chance to commit my removal of tags, but i'll do that once the db is up and i can make sure i didn't break artifact view
[17:37:01 EST(-0500)] * yakimax (~yakimax@66-224-237-30.atgi.net) has joined #fluid-work
[17:37:43 EST(-0500)] <Bosmo1> Trying to browse through "ScriptableObject.java"
[17:37:51 EST(-0500)] <Bosmo1> It's really amazing how expensive these things are
[17:37:58 EST(-0500)] <Bosmo1> No wonder RhinoJS runs so slowly...
[17:38:10 EST(-0500)] <Bosmo1> But my best understanding is, the order of enumerated properties will be unstable
[17:38:21 EST(-0500)] <Bosmo1> There is a linked list of "slots"
[17:38:32 EST(-0500)] <justin_o> colinclark: it should be back up
[17:38:45 EST(-0500)] <colinclark> thanks
[17:41:34 EST(-0500)] <justin_o> colinclark: so we just came across a minor issue... basically we need to crawl the highlights in exhibition view as well... also it seems that the highlights for the french vs english are different
[17:41:42 EST(-0500)] <jessm> colinclark: ok, let's make sure this is getting logged... i've no idea what i'm doing on Goosebook
[17:41:50 EST(-0500)] <colinclark> jessm:
[17:41:56 EST(-0500)] <colinclark> jessm: How can we help?
[17:42:01 EST(-0500)] <colinclark> justin_o: Ok, does that seem hard?
[17:42:27 EST(-0500)] <jessm> i have what seem like all the necessary css files referenced (incidentally all the same as exhibition page) and a matching set of scripts incidentally of course
[17:42:34 EST(-0500)] <colinclark> ok
[17:42:36 EST(-0500)] <jessm> but the styling doesn't seem to be applying at all
[17:42:50 EST(-0500)] <justin_o> i don't think it will be too hard.. yura had to leave though... i can be here for about another 15 min... i can see if i can get it working in that time...
[17:42:59 EST(-0500)] <colinclark> ok, otherwise...
[17:43:02 EST(-0500)] <colinclark> go home, have a good long weekend
[17:43:04 EST(-0500)] <colinclark> all that stuff
[17:43:08 EST(-0500)] <justin_o>
[17:43:10 EST(-0500)] <justin_o> thanks
[17:43:22 EST(-0500)] <colinclark> jessm: Ok, start at the basics...
[17:43:31 EST(-0500)] <jessm> NavBar
[17:43:38 EST(-0500)] <colinclark> Are you seeing your CSS correctly in Firebug or the Safari debugger?
[17:43:55 EST(-0500)] <jessm> yes
[17:44:03 EST(-0500)] <colinclark> ok, so the files are getting loaded
[17:44:13 EST(-0500)] <jessm> woah, i found something funny
[17:44:22 EST(-0500)] <jessm> guestbook.html is loading as CSS
[17:44:27 EST(-0500)] <colinclark> ?!?
[17:44:30 EST(-0500)] <colinclark> wowza
[17:44:40 EST(-0500)] <jessm> that is shocking
[17:44:57 EST(-0500)] <colinclark> ok, Bosmo1, i'm hopelessly doomed
[17:45:02 EST(-0500)] <colinclark> Can I talk something out with you here?
[17:45:12 EST(-0500)] <colinclark> jessm: Are you just loading a certain page off the file system?
[17:45:21 EST(-0500)] <colinclark> or is this a test file you made or something?
[17:45:28 EST(-0500)] <jessm> yes, file from file system
[17:45:32 EST(-0500)] <colinclark> interesting
[17:45:42 EST(-0500)] <colinclark> zip up your working copy and email it to me
[17:46:14 EST(-0500)] <colinclark> crusty branches are the worst things ever invented
[17:47:31 EST(-0500)] <colinclark> jessm: Are you zipping up your stuff for me?
[17:47:37 EST(-0500)] <jessm> colinclark: no!
[17:47:43 EST(-0500)] <colinclark> jessm: How come?
[17:47:45 EST(-0500)] <jessm> colinclark: i'm looking harder at it until it flinches
[17:47:52 EST(-0500)] <colinclark> jessm: Your call, boss
[17:48:00 EST(-0500)] <jessm> don't wanna bug you with this...
[17:48:05 EST(-0500)] <colinclark> But remember, I can help
[17:48:10 EST(-0500)] <colinclark> Plus, I'm already doomed
[17:48:23 EST(-0500)] <jessm>
[17:48:30 EST(-0500)] <jessm> k, i'll send you the css
[17:48:41 EST(-0500)] <colinclark> jessm: Send me the whole shebang, so i can see what is going crazy
[17:49:07 EST(-0500)] <jessm> colinclark: incoming
[17:49:32 EST(-0500)] <colinclark> jessm: I am doomed by a crusty branch
[17:49:38 EST(-0500)] <jessm> i'm sure it's because i've copy/pasted
[17:49:44 EST(-0500)] <colinclark> I have just come face-to-face with the merge from hell that I was trying to postpone
[17:49:45 EST(-0500)] <jessm> at least you're stuck for a good/noble reason
[17:49:53 EST(-0500)] <colinclark> As are you, boss
[17:50:54 EST(-0500)] <colinclark> hey jessm
[17:51:00 EST(-0500)] <jessm> yessir
[17:51:02 EST(-0500)] <colinclark> This copy of guestbook you sent me...
[17:51:09 EST(-0500)] <colinclark> is it in context of anything, or have you just checked it out as-is
[17:51:09 EST(-0500)] <colinclark> ?
[17:51:18 EST(-0500)] <jessm> as is
[17:51:28 EST(-0500)] <colinclark> Ok, I forgot to tell you a horrible, essential detail
[17:51:33 EST(-0500)] <colinclark> Which means I am a bad code mentor
[17:51:40 EST(-0500)] <jessm> !
[17:51:41 EST(-0500)] <colinclark> Our repository is split into three modules:
[17:51:41 EST(-0500)] <jessm> what?
[17:51:44 EST(-0500)] <colinclark> 1. Kettle
[17:51:53 EST(-0500)] <colinclark> 2. "core" (the client side part of Engage)
[17:51:55 EST(-0500)] <colinclark> 3. Infusion
[17:52:11 EST(-0500)] <colinclark> Your file is freaking out because it misses Infusion
[17:52:17 EST(-0500)] <colinclark> Sad, lonely guestbook.html
[17:52:18 EST(-0500)] <colinclark> So
[17:52:24 EST(-0500)] <jessm> lol
[17:52:24 EST(-0500)] <colinclark> Check out fluid-all
[17:52:26 EST(-0500)] <colinclark> I'll get you the URL
[17:52:35 EST(-0500)] <colinclark> Then make sure your work is always within context of fluid-all
[17:52:35 EST(-0500)] <colinclark> a
[17:52:37 EST(-0500)] <Bosmo1> ?
[17:52:40 EST(-0500)] <colinclark> and all will be cool
[17:53:09 EST(-0500)] <colinclark> jessm: Check this one out: http://source.fluidproject.org/svn/fluid/fluid-all/
[17:53:18 EST(-0500)] <colinclark> It's a monster, but it will give you everything
[17:53:36 EST(-0500)] <colinclark> Bosmo1: So, I wanted to ask you if I was doomed
[17:53:40 EST(-0500)] <jessm> it's ok if it sits locally in the same dir as trunk?
[17:53:41 EST(-0500)] <colinclark> But I think I've convinced myself that I am
[17:53:51 EST(-0500)] <colinclark> jessm: Check it out to its own spot, separate from everything else
[17:53:57 EST(-0500)] <colinclark> otherwise you'll go insane
[17:54:20 EST(-0500)] <colinclark> Bosmo1: I have been postponing a merge between Yura's new Artifact View and Sveto's hacks to the old Artifact View
[17:54:23 EST(-0500)] <jessm> er, i guess my question is do i have to try to recreate the svn structure on my desktop?
[17:54:36 EST(-0500)] <colinclark> And now that Yura has changed the views in Couch, I'm gonna have to face the music, Bosmo1
[17:54:42 EST(-0500)] <colinclark> jessm: hmm
[17:54:43 EST(-0500)] <jessm> when i check something out versions creates a folder in my docs/fluid/svn folder
[17:54:53 EST(-0500)] <jessm> so, right now fluid-all and trunk are both in there
[17:54:56 EST(-0500)] <colinclark> jessm: Ah, I see
[17:54:58 EST(-0500)] <colinclark> so that's just fine
[17:55:11 EST(-0500)] <colinclark> Just don't put fluid-all inside trunk
[17:55:22 EST(-0500)] <Bosmo1>
[17:55:26 EST(-0500)] <Bosmo1> What did these hacks do?
[17:55:29 EST(-0500)] <colinclark> so, once you've checked out fluid-all, what do you see inside it?
[17:55:39 EST(-0500)] <colinclark> Bosmo1: Well, hacks isn't a fair way to put it
[17:55:58 EST(-0500)] <colinclark> They make My Collection work. They're not quite as self-contained as I would like, so I'll just have to do a bit more tidying up
[17:55:59 EST(-0500)] <jessm> f-engage-core, f-engage-kettle, fluid-infusion
[17:56:07 EST(-0500)] <colinclark> Then suffer a horrible merge, then I'll be back in business
[17:56:12 EST(-0500)] <colinclark> jessm: Ok, you're good to go
[17:56:24 EST(-0500)] <colinclark> open guestbook.html within fluid-engage-core and tell me if it works ok
[17:56:26 EST(-0500)] <jessm> colinclark: perhaps i'm expecting too much – that didn't help styling
[17:56:39 EST(-0500)] <jessm> wow, i have no idea what that means
[17:56:44 EST(-0500)] <Bosmo1> ...
[17:56:45 EST(-0500)] <colinclark> jessm: You need to abandon your old guestbook.html, wherever it may live
[17:56:53 EST(-0500)] <jessm> in trunk
[17:56:53 EST(-0500)] <colinclark> Can I screenshare with you for a sec, jessm ?
[17:56:57 EST(-0500)] <jessm> yes
[17:57:12 EST(-0500)] <jessm> i'm a hopeless (l)user
[17:57:26 EST(-0500)] <colinclark> jessm: no, it's just that i forgot to tell you that key detail when you started
[17:57:29 EST(-0500)] <colinclark> Blame me!
[17:57:43 EST(-0500)] <jessm> right! that's ridiculous
[17:59:21 EST(-0500)] * anastasiac (~team@142.150.154.193) has left #fluid-work
[18:01:43 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[18:19:34 EST(-0500)] * yakimax (~yakimax@66-224-237-30.atgi.net) has joined #fluid-work
[18:20:29 EST(-0500)] <jessm> thanks for you help everyone
[18:20:31 EST(-0500)] <jessm> i'm heading out
[18:20:35 EST(-0500)] <jessm> have a good weekend
[18:20:38 EST(-0500)] <jessm> i'll be here on Monday
[18:34:33 EST(-0500)] <justin_o> colinclark: hello
[18:34:42 EST(-0500)] <colinclark> justin_o: What are you still doing working?!?
[18:34:44 EST(-0500)] <colinclark>
[18:34:47 EST(-0500)] <colinclark> hello
[18:34:56 EST(-0500)] <justin_o> colinclark: going to be leaving soon i think
[18:35:01 EST(-0500)] <colinclark> cool
[18:35:22 EST(-0500)] <justin_o> so i adjusted the code, did a test import.. and got back about 200 extra documents..
[18:35:31 EST(-0500)] <justin_o> so i guess that's about 100 artifacts more
[18:35:31 EST(-0500)] <colinclark> ah, interesting
[18:35:35 EST(-0500)] <colinclark> cool
[18:35:56 EST(-0500)] <justin_o> so it wasn't working and i just realized why it isn't now.. forgot to replicate the views...
[18:36:06 EST(-0500)] <justin_o> so i'm going to try again and if that works... i'll replace our databases
[18:37:39 EST(-0500)] <colinclark> justin_o: sounds good
[18:37:50 EST(-0500)] <colinclark> justin_o: I'm in the midst of some branch merging hell, so take your time
[18:38:04 EST(-0500)] <colinclark> justin_o: Hope you're not missing any friday night plans because of this
[18:38:14 EST(-0500)] <colinclark> and I hope you actually are enjoying yourself
[18:38:16 EST(-0500)] <colinclark> the office must be dead
[18:38:45 EST(-0500)] <justin_o> yep... i think i'm the last one here...
[18:39:07 EST(-0500)] <justin_o> and yep it's fun... just getting confused by some newish java syntax here and there
[18:43:24 EST(-0500)] <colinclark> justin_o: I still can't quite remember the Java 1.5 syntax
[18:43:36 EST(-0500)] <colinclark> Bosmo1: I'm guess you often have the same problem
[18:43:46 EST(-0500)] <Bosmo1> JAVER?
[18:43:52 EST(-0500)] <Bosmo1> Oh
[18:43:54 EST(-0500)] <Bosmo1> In the importer
[18:44:02 EST(-0500)] <Bosmo1> I wish I had got the other one working
[18:44:42 EST(-0500)] <justin_o> with the ui and all, that would have been nice
[18:49:55 EST(-0500)] <justin_o> this is so wierd... i re-imported and got 200 less documents... with the same import code ????
[19:01:24 EST(-0500)] * yakimax (~yakimax@66-224-237-30.atgi.net) has joined #fluid-work
[19:10:44 EST(-0500)] <colinclark> justin_o: Sounds like it's a good time to head home and have a nice long weekend
[19:11:09 EST(-0500)] <justin_o> colin i think so... just trying one more thing then i'll just post a patch on the jira and call it a night
[19:12:01 EST(-0500)] <justin_o> i wonder if there is something going on with hugues servers or something
[19:17:43 EST(-0500)] <colinclark> justin_o: Interesting
[19:18:09 EST(-0500)] <colinclark> justin_o: Seems like the data has changed a lot
[19:19:40 EST(-0500)] <justin_o> colinclark: yes... i think so
[19:20:09 EST(-0500)] <justin_o> colinclark: i've posted a patch with yura and my changes to the CouchdbUtility.java file onto ENGAGE-378
[19:21:12 EST(-0500)] <justin_o> So the problem that exists with the current data in couchdb is that if you go to the simply montreal exhibition view page and put it in French .. one of the hightlight artifacts doesn't exist
[19:21:30 EST(-0500)] <justin_o> i'm trying to address that in the patch... (you'll see a bunch of commented sections)...
[19:23:42 EST(-0500)] <justin_o> and what is weird is that it seemed to pull in about 200 more artifacts the first time i ran it (but i had forgotten to replicate in the views that time)...then on subsequent tries i just got back the same as what is in there now
[19:42:25 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[19:48:37 EST(-0500)] <colinclark> justin_o: you're still here
[19:48:48 EST(-0500)] <colinclark> it's so late!
[19:49:02 EST(-0500)] <justin_o> yah... i'm going to go soon... just trying to help Bosmo1 debug something quickly
[19:49:24 EST(-0500)] <colinclark> ok, but make sure you get a good friday night
[19:49:27 EST(-0500)] <colinclark> and have a long weekend
[19:49:33 EST(-0500)] <colinclark> i have to run to my band practice now
[19:49:39 EST(-0500)] <colinclark> don't stay past 8!
[19:51:09 EST(-0500)] * justin_o (~jmo@142.150.154.101) has joined #fluid-work
[20:16:50 EST(-0500)] * yura (~yura@bas3-toronto06-2925097429.dsl.bell.ca) has joined #fluid-work