fluid-work IRC Logs-2012-04-10

[09:06:22 CDT(-0500)] <logiclord> yura : ping

[09:08:38 CDT(-0500)] <yura> logiclord: hi

[09:09:51 CDT(-0500)] <logiclord> yura : Hi, I drop an email for my gsoc proposal Highly customizable and accessible web based ePub reader .. any feedback ?

[09:10:02 CDT(-0500)] <logiclord> I have submitted proposal http://www.google-melange.com/gsoc/proposal/review/google/gsoc2012/gauravaggarwal/43003

[09:19:13 CDT(-0500)] <yura> yes, logiclord, i did take a look. it was pretty good, i liked the level of detail in the research section

[09:19:44 CDT(-0500)] <logiclord> yura : Thanks .. I will wait for reply (smile)

[09:23:16 CDT(-0500)] <yura> logiclord: np (smile)

[10:15:24 CDT(-0500)] <anastasiac> michelled, I've pushed a couple of changes to my FLOE-6-afa-md branch: make the icons tab accessible; make the tooltip text enlarge with UIO adjustments; add missing high-contrast styles for one of the icons

[10:24:02 CDT(-0500)] <jhung> @justin_o: Check out this kickstarter project for a scanning robot. http://projectgado.org/

[10:24:37 CDT(-0500)] <jhung> Not sure if I want that noise in a library though. (tongue)

[11:17:55 CDT(-0500)] <Bosmon2> Justin_o - KINGGG!

[11:18:06 CDT(-0500)] <Bosmon2> Could you add me as an owner for fluid-project on github?

[11:18:11 CDT(-0500)] <Justin_o> Bosmon2: hello

[11:18:15 CDT(-0500)] <Bosmon2> I managed to create a broken repository last night that I can't get rid of.....

[11:18:24 CDT(-0500)] <Justin_o> Bosmon2: okay

[11:18:33 CDT(-0500)] <Bosmon2> Cheers

[11:18:48 CDT(-0500)] <Bosmon2> Also - are you the right person to talk to about updating our versions of TinyMCE etc. in our CDN?

[11:19:44 CDT(-0500)] <Justin_o> Bosmon2: done for the github.

[11:19:53 CDT(-0500)] <Bosmon2> Cheers, Justin_o (smile)

[11:20:14 CDT(-0500)] <Justin_o> Bosmon2: I think yura originally setup the cdn's i can send you the login info though if you want to look at it

[11:22:57 CDT(-0500)] <Bosmon2> ok

[11:23:08 CDT(-0500)] <Bosmon2> Perhaps yura can give me some pointers after his meeting

[11:25:04 CDT(-0500)] <Justin_o> Bosmon2: will you be around for a while.. i'm trying to track down an issue where an event is firing twice.. I haven't spent enough time looking into it just yet, but may need a hand later.

[11:25:13 CDT(-0500)] <Bosmon2> Justin_o - I'll be here

[11:25:18 CDT(-0500)] <Justin_o> Bosmon2: thanks

[12:04:52 CDT(-0500)] <michelled> cindyli, anastasiac, alexn, yura: please start using the authoring-vp branch for your OER commons integration work

[12:05:09 CDT(-0500)] <anastasiac> ok, michelled

[12:05:13 CDT(-0500)] <michelled> our demo will be built from that branch and I will be pushing all our work there

[12:05:27 CDT(-0500)] <cindyli> ok

[12:19:56 CDT(-0500)] <anastasiac> michelled and jameswy, I've posted the demo script to the wiki, at http://wiki.fluidproject.org/display/fluid/Script+for+OER+Commons+Authoring+Tool+Demo

[12:20:02 CDT(-0500)] <anastasiac> Please have a look and suggest any improvements

[12:20:15 CDT(-0500)] <michelled> thx anastasiac

[13:02:38 CDT(-0500)] <Bosmon2> colinclark - I forgot to mention one thing about my node-jqUnit port

[13:02:54 CDT(-0500)] <Bosmon2> I renamed the thing which used to be called "jqUnit.TestCase" as "jqUnit.module"

[13:02:57 CDT(-0500)] <Bosmon2> And mostly removed its body

[13:03:11 CDT(-0500)] <Bosmon2> So the thing we have in node is not actually 100% compatible with the Infusion incarnation

[13:08:33 CDT(-0500)] <colinclark> ok

[13:08:43 CDT(-0500)] <colinclark> that sounds just fine to me

[13:09:04 CDT(-0500)] <colinclark> I find it funny, in the end, that you say in several places that "xUnit style is a benefit"

[13:09:10 CDT(-0500)] <colinclark> since I wish we didn't use it

[13:09:11 CDT(-0500)] <anastasiac> cindyli, alexn, is there anything I can do to help with the video player integration?

[13:09:21 CDT(-0500)] <Bosmon2> It seemed silly to pretend we had an "instance" of something when really we didn't.... it seems pretty impossible to "paper over" the stateful nature of qunit

[13:09:22 CDT(-0500)] <colinclark> but legacy code speaks

[13:09:24 CDT(-0500)] <colinclark> as does the King

[13:09:32 CDT(-0500)] <colinclark> This stuff was incredibly old

[13:09:37 CDT(-0500)] <colinclark> It used to be a new-ist thing

[13:09:37 CDT(-0500)] <Bosmon2> As well as the fact that "TestCase" didn't really describe what the thing did

[13:09:42 CDT(-0500)] <colinclark> long prior even to thatism

[13:09:52 CDT(-0500)] <Bosmon2> So people looking at the qunit fundamentals would be puzzled as to what a "module" was

[13:09:54 CDT(-0500)] <Bosmon2> Certainly I was : P

[13:10:10 CDT(-0500)] <colinclark> and was an attempt to map, awkwardly, to xUnit semantics

[13:10:15 CDT(-0500)] <colinclark> which it never properly did

[13:10:18 CDT(-0500)] <colinclark> nor, in my mind, should

[13:10:51 CDT(-0500)] <Bosmon2> Well... I would be for mapping to them if it seemed practicable : P

[13:10:54 CDT(-0500)] <Bosmon2> But I don't think it is

[13:11:24 CDT(-0500)] <colinclark> no

[13:11:40 CDT(-0500)] <colinclark> i agree that it isn't

[13:11:42 CDT(-0500)] <colinclark> though i still probably wouldn't agree if it was

[13:11:44 CDT(-0500)] <Bosmon2> That aspect of qunit is just too architecturally fundamental

[13:12:28 CDT(-0500)] <Bosmon2> I guess we should figure out what avtar and Jenkins need to know about test cases

[13:12:35 CDT(-0500)] <Bosmon2> In order to integrate them into our continuous builds

[13:12:55 CDT(-0500)] <Bosmon2> i) how to find out where they are, ii) how to interpret their output

[13:12:57 CDT(-0500)] <colinclark> It'll probably be a few weeks before we get to that

[13:13:01 CDT(-0500)] <Bosmon2> ok

[13:13:04 CDT(-0500)] <colinclark> especially since I'm keen to see Windows build automation first

[13:13:19 CDT(-0500)] <colinclark> and that Avtar needs to provision our four-server mini cloud before he can really get Jenkins running for us

[13:13:31 CDT(-0500)] <colinclark> but definitely we will get there

[13:13:36 CDT(-0500)] <colinclark> i don't mean to say that it's not important

[13:13:48 CDT(-0500)] <Bosmon2> How can we achieve Windows build automation?

[13:14:34 CDT(-0500)] <avtar> Bosmon2: i'll try to get my hands on a windows machine so that i can try a few solutions

[13:14:51 CDT(-0500)] <Bosmon2> If we make a "standard build image" into a VM, would there be an issue with bundling Microsoft tools onto it?

[13:16:31 CDT(-0500)] <colinclark> Hopefully we can source an MSI for VS Express

[13:17:09 CDT(-0500)] <Bosmon2> colinclark - would that help?

[13:17:18 CDT(-0500)] <colinclark> I think so, yes

[13:17:40 CDT(-0500)] <Bosmon2> I was wondering about licencing issues, more than anything

[13:17:43 CDT(-0500)] <colinclark> Right

[13:17:57 CDT(-0500)] <Bosmon2> Would we create a "ready to go" VM, or distribute a list of instructions?

[13:17:59 CDT(-0500)] <colinclark> The process, as I understand it, is to have individuals create "base box" themselves, using automated scripts

[13:18:08 CDT(-0500)] <colinclark> but they'll have to provide a base Windows ISO and license

[13:18:24 CDT(-0500)] <colinclark> some people seem to use Windows 7 trial ISOs as well

[13:18:35 CDT(-0500)] <colinclark> so then they build their base box with their license

[13:18:40 CDT(-0500)] <colinclark> we don't redistribute Windows

[13:18:43 CDT(-0500)] <Bosmon2> Very odd

[13:19:03 CDT(-0500)] <colinclark> avtar will correct me if I'm more confused than usual

[13:19:59 CDT(-0500)] <colinclark> I'm pretty excited about how this will end up

[13:20:09 CDT(-0500)] <colinclark> since I like the dev tools on my host machine

[13:20:23 CDT(-0500)] <colinclark> but of course we all need to be able to quickly and easily build and test on both Windows and Linux

[13:20:58 CDT(-0500)] <colinclark> Back the days of Web4all, for example, this stuff just wasn't possible

[13:21:12 CDT(-0500)] <colinclark> the only option was to equip every developer on the project with a physical Windows box

[13:21:40 CDT(-0500)] <colinclark> This sure beats having Bert ship Lenovos to Bulgaria (smile)

[13:22:11 CDT(-0500)] <Bosmon2> I'm not convinced Bulgaria would agree, but sure : P

[13:24:19 CDT(-0500)] <avtar> colinclark: that's correct

[13:25:04 CDT(-0500)] <avtar> distributing an iso would make this easier but i'm guessing legal issues will prevent that from happening

[13:25:16 CDT(-0500)] <colinclark> yup

[13:25:27 CDT(-0500)] <colinclark> certainly everyone here at the IDRC has access to a site license of Windows

[13:25:40 CDT(-0500)] <colinclark> and I'm assuming Cloud4all developers have reasonable access to licenses as needed

[13:25:45 CDT(-0500)] <colinclark> if not, we can arrange something

[13:36:43 CDT(-0500)] <sgithens> colinclark: Do we support anything other than win7?

[13:36:55 CDT(-0500)] <colinclark> sgithens: oh, good question

[13:37:07 CDT(-0500)] <colinclark> I don't think we've really formally set system requirements yet

[13:37:14 CDT(-0500)] <colinclark> I think for now, we'll probably develop on Windows 7

[13:37:21 CDT(-0500)] <colinclark> But I'd like to see us support back to XP

[13:37:32 CDT(-0500)] <colinclark> Which is why we ended up not writing our native Windows code in C#

[13:43:47 CDT(-0500)] <Bosmon2> SWGITHEN!

[13:44:12 CDT(-0500)] <Bosmon2> From what I read, we can't support the USB listener on Win2k

[13:52:35 CDT(-0500)] <colinclark> Bosmon2: That must be hard for you (wink)

[13:56:23 CDT(-0500)] <sgithens> Bosman2: AMB26PONDER!

[13:58:26 CDT(-0500)] <michelled> anastasiac, cindyli, alexn, yura: I've pushed to the authoring-vp branch

[13:58:40 CDT(-0500)] <cindyli> ok

[13:58:43 CDT(-0500)] <michelled> it now has the AfA and the uniSubs widget

[14:00:05 CDT(-0500)] <NickMayne> But C# is awesome!

[14:16:31 CDT(-0500)] <colinclark> NickMayne: if only it worked on Windows XP without the client having to install .NET, and then it would be super awesome!

[14:19:46 CDT(-0500)] <Bosmon2> Wow.... we have ANDREI ALEXANDRESCU on the GSoC list : P

[14:20:21 CDT(-0500)] <Bosmon2> Wanting to mentour 2 students.... I imagine he could take on a dozen if he'd had his breakfast

[14:35:47 CDT(-0500)] <NickMayne> So Bosmon2 - Are you Bosmon but Version 2?

[14:36:07 CDT(-0500)] <Bosmon2> NickMayne - I can't explain why I have become incremented : P

[14:36:13 CDT(-0500)] <Bosmon2> How are you getting on with that exception

[14:36:19 CDT(-0500)] <Bosmon2> Did you manage to reproduce it?

[14:36:22 CDT(-0500)] <NickMayne> Yeah

[14:36:25 CDT(-0500)] <NickMayne> I sent it to you

[14:36:28 CDT(-0500)] <NickMayne> Yesterday (smile)

[14:37:07 CDT(-0500)] <Bosmon2> Really....

[14:37:09 CDT(-0500)] <Bosmon2> I don't seem to see it

[14:37:11 CDT(-0500)] <Bosmon2> How did you send it?

[14:37:20 CDT(-0500)] <NickMayne> Email

[14:37:54 CDT(-0500)] <Bosmon2> The last I have from you is the github comment.....

[14:37:58 CDT(-0500)] <NickMayne> I have sent it to you again

[14:38:02 CDT(-0500)] <Bosmon2> From about 9pm I guess

[14:38:14 CDT(-0500)] <NickMayne> (smile)

[14:40:54 CDT(-0500)] <NickMayne> Did you get it this time?

[14:41:11 CDT(-0500)] <Bosmon2> no

[14:41:26 CDT(-0500)] <Bosmon2> Our campus has switched to Microsoft Exchange

[14:41:37 CDT(-0500)] <Bosmon2> Do try my personal address, which uses a sensible provider : P

[14:41:44 CDT(-0500)] <NickMayne> lol!!

[14:41:49 CDT(-0500)] <NickMayne> No problem... what s your email?

[14:42:05 CDT(-0500)] <Bosmon2> See private message

[14:48:45 CDT(-0500)] <Bosmon2> NickMayne - worryingly I can't reproduce your problem....

[14:48:54 CDT(-0500)] <Bosmon2> Although you do seem to have broken avatar generation somehow

[14:49:00 CDT(-0500)] <Bosmon2> Didn't you want one?

[14:49:22 CDT(-0500)] <NickMayne> yeah I guess I did!

[14:49:28 CDT(-0500)] <NickMayne> :S Ive broken it?

[14:49:35 CDT(-0500)] <Bosmon2> Well, the default is to give you one : P

[14:49:49 CDT(-0500)] <NickMayne> how did I hide it then?

[14:49:54 CDT(-0500)] <Bosmon2> Ah!

[14:49:57 CDT(-0500)] <Bosmon2> I can see the failure in Chrome

[14:50:09 CDT(-0500)] <Bosmon2> In FF it works fine

[14:50:46 CDT(-0500)] <NickMayne> I was jsut going to ask if you wanted to skype and i would show ya!

[14:50:53 CDT(-0500)] <NickMayne> hold on...

[14:50:59 CDT(-0500)] <Bosmon2> Does it fail for you in FF too?

[14:51:00 CDT(-0500)] <NickMayne> FF widgets dont work well at all

[14:51:01 CDT(-0500)] <Bosmon2> Or just in Chrome

[14:51:30 CDT(-0500)] <NickMayne> ive only tested in chrome

[14:51:36 CDT(-0500)] <Bosmon2> ah ok

[14:51:45 CDT(-0500)] <NickMayne> as widgets in FF dont work. They dont beome unstuck

[14:52:13 CDT(-0500)] <NickMayne> they drop and then become reattached to the mouse. And then firefox goes nuts!

[14:52:28 CDT(-0500)] <NickMayne> Firefox 12 that is.

[14:53:27 CDT(-0500)] <NickMayne> Also how do I fix Avatar generation?

[14:53:42 CDT(-0500)] <Bosmon2> It might just be a CSS issue

[14:53:52 CDT(-0500)] <Bosmon2> Let me look into this first issue first : P

[14:53:57 CDT(-0500)] <NickMayne> Okay

[14:54:10 CDT(-0500)] <NickMayne> (smile)

[14:56:41 CDT(-0500)] <Bosmon2> Looks like some "order of focus events" shiznitz

[14:56:50 CDT(-0500)] <Bosmon2> I really wish browsers wouldn't stop messing about with this

[14:57:21 CDT(-0500)] <Bosmon2> Looks like Chrome is managing to service a move event for a widget and then generating a focusout event for it AFTERWARDS

[14:58:57 CDT(-0500)] <NickMayne> argh

[14:59:24 CDT(-0500)] <NickMayne> I had a better example of it, where you didnt even need to drap, just moving the mouse over it would cause the bug

[14:59:32 CDT(-0500)] <NickMayne> But I forgot how to generate it (sad)

[15:00:02 CDT(-0500)] <Bosmon2> Yup... I can even generate this issue with one of our standard demos

[15:00:10 CDT(-0500)] <NickMayne> yay!

[15:00:11 CDT(-0500)] <Bosmon2> So this looks like some recent and rather major Chrome regression

[15:00:23 CDT(-0500)] <NickMayne> Phew... I thought it was me

[15:00:30 CDT(-0500)] <NickMayne> (just me)

[15:02:02 CDT(-0500)] <cindyli> Bosmon2: do you have some time to chat about the problem i have at integrating video player into authoring tool?

[15:04:16 CDT(-0500)] <Bosmon2> Oh good grief.... they've broken practically everything

[15:04:25 CDT(-0500)] <Bosmon2> Keyboard-a11y is totally broken on Chrome too (sad)

[15:04:28 CDT(-0500)] <Bosmon2> cindyli - sure

[15:04:44 CDT(-0500)] <cindyli> Bosmon2: what i'm doing is, when authors upload a local video, use javascript to dynamically inject the video player into the editor to play it. The issue is the video player never gets rendered.

[15:05:13 CDT(-0500)] <cindyli> i looked into VideoPlayer_uiOptions.js, from this line - https://github.com/amb26/videoPlayer/blob/demo-integration-sketch/js/VideoPlayer_uiOptions.js#L182

[15:05:54 CDT(-0500)]

<cindyli> it seems the initialization of the first batch of the video players is dependent on the

Unknown macro: {fatPanel}

.onReady

[15:06:48 CDT(-0500)] <cindyli> in my case, at the time that the the video player is needed to be rendered, the fat panel has been ready long ago

[15:07:07 CDT(-0500)] <Bosmon2> cindyli - I think the branch I pushed showed an example of initialisation of a video player very late

[15:07:07 CDT(-0500)] <anastasiac> michelled, I've pushed the uniSubWidget/AfA integration into the FLOE-4-afa-in-unisub branch of my github. All working now

[15:07:13 CDT(-0500)] <Bosmon2> Did you have a look at it?

[15:07:19 CDT(-0500)] <cindyli> yes, Bosmon2

[15:07:32 CDT(-0500)] <michelled> thx anastasiac

[15:07:39 CDT(-0500)] <Bosmon2> The binding trigger is not necessary for initialisation

[15:08:04 CDT(-0500)] <Bosmon2> After the fatPanel has constructed, any further videoPlayers will count as an "immediate binding instance"

[15:08:37 CDT(-0500)] <cindyli> your example instatiate both the early and late, Bosmon2. at the time the late binding happens, the early binding has been called once which sets relay.options.bindingTriggered = true

[15:09:13 CDT(-0500)] <Bosmon2> cindyli - that's right

[15:09:22 CDT(-0500)] <Bosmon2> After the flag is set, the event is no longer necessary

[15:09:41 CDT(-0500)] <Bosmon2> But if the video player is not rendering, this sounds like a separate issue to the UIOptions integration

[15:09:45 CDT(-0500)] <Bosmon2> NickMayne - welcome to http://issues.fluidproject.org/browse/FLUID-4693

[15:10:13 CDT(-0500)] <NickMayne> sorry back!

[15:10:46 CDT(-0500)] <NickMayne> Ah very cool!!!

[15:10:52 CDT(-0500)] <Bosmon2> Ah, looks like the a11y problem is just a result of having the debugger open

[15:11:00 CDT(-0500)] <Bosmon2> It seems to act as a "ready-build focus trap"

[15:11:05 CDT(-0500)] <Bosmon2> So just one issue to look at (smile)

[15:11:08 CDT(-0500)] <Bosmon2> Oh yes, the avatar...

[15:11:35 CDT(-0500)] <NickMayne> so Keyboard Ally is broken only when the debuggeer is open (sad) boo!!

[15:12:08 CDT(-0500)] <Bosmon2> Well, it's completely full of junk... no doubt if I hit TAB several hundred times, focus may one day again return to the reorderer.

[15:14:39 CDT(-0500)] <NickMayne_> hmm

[15:14:49 CDT(-0500)] <NickMayne_> My IRC stopped working, wierd

[15:14:54 CDT(-0500)] <Bosmon2> NickMayne - avatar issue actually looks like a layout issue

[15:14:59 CDT(-0500)] <Bosmon2> It exists but the contents are not sizing to fit

[15:15:27 CDT(-0500)] <Bosmon2> Might be something to do with the fact that you have all header set to display: block

[15:15:29 CDT(-0500)] <NickMayne_> Hmmm

[15:15:31 CDT(-0500)] <Bosmon2> But I'm not an CSS expert

[15:15:51 CDT(-0500)] <NickMayne_> Thats a default setting

[15:15:53 CDT(-0500)] <Bosmon2> The avatar's overall size is set by setting the display to block of the overall dragging node - which in your case is an "article"

[15:16:08 CDT(-0500)] <Bosmon2> So the "article" is properly sized, but the contents all end up with 0 height for some reason

[15:16:14 CDT(-0500)] <NickMayne_> everything is set to block for IE

[15:17:01 CDT(-0500)] <NickMayne_> I thought that fluid uses inline styles when dragging

[15:17:21 CDT(-0500)] <Bosmon2> It doesn't

[15:17:33 CDT(-0500)] <Bosmon2> We need to be able to set the size of the avatar element in absolute terms

[15:17:38 CDT(-0500)] <Bosmon2> Given it is floating above everything else...

[15:18:00 CDT(-0500)]

<cindyli> Bosmon2: I understand that all the late binding uses "immediate". in my case, there's no video on the page initially, so the "late binding instance" never have a chance to be called at the time that

Unknown macro: {fatPanel}

is ready

[15:18:02 CDT(-0500)] <Bosmon2> Still looks like there SHOULD be room for the grab handle text to render though.... trying to figure out why it is transparent

[15:18:51 CDT(-0500)] <Bosmon2> cindyli - ah, a bug!

[15:19:49 CDT(-0500)] <Bosmon2> cindyli - could you verify that the integration works if you set the "bindingTriggered" flag to true manually, and I'll issue a patch this evening

[15:19:52 CDT(-0500)] <NickMayne_> So if it hsouldnt be Display: block, what should it be?

[15:21:01 CDT(-0500)] <Bosmon2> NickMayne_ - not sure yet... still not sure why it is invisible

[15:21:05 CDT(-0500)] <cindyli> ah, smart, Bosmon2. will try

[15:22:07 CDT(-0500)] <Bosmon2> Ah.... it's because of YOU!!!

[15:22:08 CDT(-0500)] <Bosmon2> NickMayne_

[15:22:15 CDT(-0500)] <Bosmon2> You have a rule in your orchard css file

[15:22:33 CDT(-0500)] <Bosmon2> It says .fl-reorderer-avatar { visibility: hidden

[15:22:35 CDT(-0500)] <Bosmon2> You beast

[15:22:50 CDT(-0500)] <Bosmon2> I vote that you should be destroyed!

[15:23:03 CDT(-0500)] <NickMayne_> lol!!

[15:23:09 CDT(-0500)] <NickMayne_> I copied that file!!

[15:23:14 CDT(-0500)] <NickMayne_> From you demos....

[15:23:19 CDT(-0500)] <NickMayne_> I must have screwed it up some how

[15:23:35 CDT(-0500)] <NickMayne_> Good catch!

[15:23:45 CDT(-0500)] <Bosmon2> Ok, I'll patch your Chrome exception issue later on today

[15:23:48 CDT(-0500)] <Bosmon2> The rest is man's work

[15:24:22 CDT(-0500)]

<NickMayne_> .demo-layoutReorderer-avatar .demo-layoutReorderer-module-dragbar, .demo-layoutReorderer-avatar .demo-layoutReorderer-module-content

Unknown macro: { /* hide contents of the module's avatar, while dragging. */ visibility}

[15:24:36 CDT(-0500)] <NickMayne_> Oh I see what its dooing lol!!

[15:24:56 CDT(-0500)] <Bosmon2> Right

[15:25:02 CDT(-0500)] <Bosmon2> The aim was to only hide PART of the content : P

[15:25:04 CDT(-0500)] <cindyli> yes, Bosmon2, works

[15:25:16 CDT(-0500)] <Bosmon2> Although to be honest a better method would have been to override the avatar creator function

[15:25:23 CDT(-0500)] <Bosmon2> cindyli - cool, I will patch your thing later too

[15:25:33 CDT(-0500)] <cindyli> thanks, Bosmon2

[15:25:45 CDT(-0500)] <NickMayne_> Fantastic stuff.

[15:25:51 CDT(-0500)] <Bosmon2> I forgot about the case where there are zero original players on the page

[15:26:23 CDT(-0500)] <Bosmon2> Now, what else was I doing.....

[15:27:44 CDT(-0500)] <NickMayne_> I have 1 more thing (not a bug I promise)

[15:28:23 CDT(-0500)] <cindyli> Bosmon2: another minor issue with FLUID-4531 that the MyInfusion.js for video player integration is built on. Missing "tab4" from the fat panel template - https://github.com/amb26/infusion/blob/FLUID-4531/src/webapp/components/uiOptions/html/FatPanelUIOptions.html

[15:28:47 CDT(-0500)] <Bosmon2> cindyli - that file will need to be modified manually

[15:29:01 CDT(-0500)] <Bosmon2> Since that tab is not part of the core configuration any more

[15:29:18 CDT(-0500)] <Bosmon2> It is expected that the UIOptions integrator will supply markup themselves for whatever extra panels they require

[15:29:19 CDT(-0500)] <cindyli> ah, i see ur point. ok, manually updated. (smile)

[15:32:18 CDT(-0500)] <Bosmon2> NickMayne_ - what've you got

[15:32:21 CDT(-0500)] <NickMayne_> Bosmon2: I have been attempting to override displayModeRenderer so that I can get the Edit, Undo and Redo buttons to correctly line up

[15:32:27 CDT(-0500)] <Bosmon2> Ah cool

[15:32:41 CDT(-0500)] <NickMayne_> But have failed badely

[15:33:02 CDT(-0500)] <Bosmon2> Like.... Hermione Baddeley? : P

[15:33:25 CDT(-0500)] <NickMayne_> lol

[15:33:37 CDT(-0500)] <NickMayne_> okay, not that bedely

[15:33:39 CDT(-0500)] <NickMayne_> (smile)

[15:35:06 CDT(-0500)] <Bosmon2> NickMayne_ - you may have noticed that in one of my patches I cleaned up the default renderer a bit for you

[15:35:11 CDT(-0500)] <Bosmon2> To make it easier to register the event handles

[15:35:18 CDT(-0500)] <NickMayne_> Oh?

[15:35:25 CDT(-0500)] <NickMayne_> I didnt notice that.

[15:36:14 CDT(-0500)] <Bosmon2> So, what are you observing?

[15:36:27 CDT(-0500)] <Bosmon2> I guess the first thing to achieve is to get them to all render inside the same DOM node

[15:37:07 CDT(-0500)] <NickMayne_> I have got that

[15:37:10 CDT(-0500)] <NickMayne_> But

[15:37:50 CDT(-0500)] <NickMayne_> hmm

[15:38:20 CDT(-0500)] <NickMayne_> It seems like if you specify the selectors, they it puts them on the page out side

[15:38:24 CDT(-0500)] <NickMayne_> going to try something

[15:38:57 CDT(-0500)] <Bosmon2> You might even find it easier to change the undo renderer, rather than the inline edit renderer

[15:39:01 CDT(-0500)] <Bosmon2> Since that configuration is much simpler

[15:39:48 CDT(-0500)] <NickMayne_> Okay let me try

[15:49:43 CDT(-0500)] <NickMayne_> Hmmm

[16:18:40 CDT(-0500)] <NickMayne_> Hey Bosmon2 - Is there a reason why the edit button sits under fl-inlineEdit-textContainer?

[16:22:19 CDT(-0500)] <Bosmon2> NickMayne_ - I'm not sure, what kind of reason might you be looking for? : P

[16:22:38 CDT(-0500)] <NickMayne_> A reason to keep it there (smile)

[16:23:05 CDT(-0500)] <NickMayne_> I wondered if there was an accessibility reason

[16:23:53 CDT(-0500)] <Bosmon2> I'm sure you can put it wherever you prefer

[16:25:20 CDT(-0500)] <NickMayne_> Cool (smile)

[16:25:24 CDT(-0500)] <NickMayne_> Thanks dude.