fluid-work IRC Logs-2012-03-26
[08:52:13 CDT(-0500)] <Abhinav> Hi anybody online?
[08:54:05 CDT(-0500)] <greggy> who did you need to reach?
[08:55:05 CDT(-0500)] <Abhinav> Justin Hung
[08:55:26 CDT(-0500)] <Abhinav> Sorry I mean Jon Hung or Justin Obara
[08:55:38 CDT(-0500)] <Abhinav> None of them replying
[08:55:46 CDT(-0500)] <greggy> Justin_o: ^ use a user name as a prefix to get someones attention
[08:57:36 CDT(-0500)] <greggy> jhung: ^
[08:57:57 CDT(-0500)] <Justin_o> thanks greggy
[08:58:00 CDT(-0500)] <Justin_o> hi Abhinav
[08:58:03 CDT(-0500)] <Abhinav> jhung: ^I have some ideas to discuss about HTML5 editor
[08:58:13 CDT(-0500)] <jhung> Abhinav, sure. What do you have in mind?
[08:58:49 CDT(-0500)] <Abhinav> I researched on the web and I found a Javascript library which can help us in the impolementation
[08:59:07 CDT(-0500)] <Abhinav> It is under the open source licence so we can also edit and customise it to our own needs
[09:00:12 CDT(-0500)] <jhung> Abhinav, that's great!
[09:00:23 CDT(-0500)] <Abhinav> jhung It covers some of the features that we desire and plus we can utiliuze greater number of features
[09:00:57 CDT(-0500)] <Abhinav> jhung, I can also code new features in it and it is perfectly allowable as its under open source licence
[09:01:30 CDT(-0500)] <Abhinav> We can integrate it with the HTML5 Canvas
[09:01:36 CDT(-0500)] <jhung> Abhinav, out of curiousity, what license does it use?
[09:02:44 CDT(-0500)] <Abhinav> jhung, Mozilla Public Licence Cersion 1.1
[09:03:27 CDT(-0500)] <jhung> justin_o: I'm not familiar with that license. Do you have any thoughts?
[09:03:29 CDT(-0500)] <Abhinav> Sorry I meant Mozilla Public Licence Version 1.1
[09:03:46 CDT(-0500)] <Abhinav> jhung, http://en.wikipedia.org/wiki/Mozilla_Public_License
[09:03:54 CDT(-0500)] <Abhinav> I read about the licence from here
[09:04:42 CDT(-0500)] <Abhinav> jhung, As quoted from Wikipedia : "The MPL has been approved as both a free software license (albeit one with a weak copyleft) by the Free Software Foundation[3] and an open-source software license by the Open Source Initiative."
[09:05:25 CDT(-0500)] <jhung> Thanks Abhinav. I see now that it is compatible with Apache License, which is what we're using elsewhere.
[09:05:50 CDT(-0500)] <Justin_o> jhung: i'd have to look at it in more detail, but i think it should be okay
[09:06:29 CDT(-0500)] <Abhinav> jhung, I believe I can make a good proposal using this. Do you have any recommendations
[09:07:30 CDT(-0500)] <Abhinav> jhung, It has around 28 basic effects on images. In addition we can integrate the desired image effects into the library
[09:08:25 CDT(-0500)] <jaugusto111> Hello
[09:08:37 CDT(-0500)] <Justin_o> jaugusto111: hello
[09:08:46 CDT(-0500)] <jhung> Abhinav: as long as it satisfies the project goals, you are free to use what you think is needed. It's good that the library you are looking at is MPL - we like open source!
[09:09:12 CDT(-0500)] <Abhinav> jhung, Alternatively I can also create a subset of this library and integrate our own effects to form a customised JS library suitable for the project
[09:10:06 CDT(-0500)] <Abhinav> jhung, Any advice you would like to give me as I read on the GSOC FAQ that we should interact with the mentors as much as possible.
[09:10:59 CDT(-0500)] <Abhinav> jhung, O also have a strong motivation for this particular project as my future work will involve dealing with images and other forms of multimedia
[09:12:36 CDT(-0500)] <jhung> Abhinav, that's great! I think at this point it's good to get your proposal in. Be sure to mention the different features you have in mind and how you would implement it. Also a demo would be helpful to demonstrate your ability and ideas.
[09:13:06 CDT(-0500)] <jaugusto111> where are the metores?
[09:13:20 CDT(-0500)] <Abhinav> jhung, How would you like me to provide a demo?
[09:13:32 CDT(-0500)] <Justin_o> jaugusto111: which mentors are you looking for?
[09:13:37 CDT(-0500)] <Abhinav> jhung, Should I provide a sample code for 1-2 effects ?
[09:15:15 CDT(-0500)] <jhung> Abhinav, you can host the demo and provide a link to it, or you can send us the source code. The demo doesn't have to be big - just enough to demonstrate your ability and ideas. If you can do that in 1 or 2 features than that is great!
[09:15:41 CDT(-0500)] <jaugusto111> jhung, I have an idea and wanted to submit to GoSC2012. It works on the detection of digital activism on Twitter.
[09:16:42 CDT(-0500)] <Abhinav> jhung, I can show you the demo of the library right away
[09:17:00 CDT(-0500)] <jaugusto111> Justin_o I have an idea and wanted to submit to GoSC2012. It works on the detection of digital activism on Twitter. You is Mentor?
[09:18:07 CDT(-0500)] <jhung> Abhinav: great. Can you email the code / link to jobara@ocadu.ca and jhung@ocadu.ca please?
[09:18:22 CDT(-0500)] <Abhinav> I sure will
[09:18:39 CDT(-0500)] <jhung> Thanks!
[09:19:19 CDT(-0500)] <colinclark> Abhinav: What's the library you're referring to, out of curiosity?
[09:19:52 CDT(-0500)] <Justin_o> jaugusto111: I am a mentor, but you might want to float your idea by colinclark and greggy since I take it you are talking about proposing your own project
[09:20:42 CDT(-0500)] <Abhinav> colinclark, Pixastic, http://www.pixastic.com/
[09:20:46 CDT(-0500)] <colinclark> Oh yes
[09:20:50 CDT(-0500)] <colinclark> I know Pixastic quite well
[09:21:00 CDT(-0500)] <colinclark> Good choice
[09:21:13 CDT(-0500)] <Abhinav> jhung, Is it fine if I have no knowledge about Fluid Infusion?
[09:21:29 CDT(-0500)] <Abhinav> colinclark, Thank you sir
[09:25:48 CDT(-0500)] <Justin_o> Abhinav: you should try to start familiarizing yourself with it. We understand that you won't likely know it ahead of time, but we'd expect you to make use of it for the project.
[09:26:47 CDT(-0500)] <Abhinav> Justin_o, I will get to that right away. Is the Image Editor supposed to be integrated into the project?
[09:28:03 CDT(-0500)] <Justin_o> Abhinav: not right away, although depending on how it is, we may use it in Decapod and/or other projects
[09:29:21 CDT(-0500)] <Abhinav> Justin_o, So should I start to familiarize myself with any particular Fluid Project?
[09:30:31 CDT(-0500)] <Justin_o> Abhinav: Start looking at Fluid Infusion… It's an application framework and widget set built on top of jQuery… we use it in many of our projects
[09:31:05 CDT(-0500)] <Abhinav> Justin_o: Sure
[10:26:27 CDT(-0500)] <am33sh> jhung : i want to submit a patch for the fluid bug FLUID-4066... can you tell me how to submit it... or any documentation regarding it
[10:27:22 CDT(-0500)] <am33sh> jhung : or should i just attach the file in comment
[10:27:31 CDT(-0500)] <jhung> ^justin_o or anastasiac can help you with that question am33sh.
[10:27:44 CDT(-0500)] <am33sh> jhung : okay
[10:28:42 CDT(-0500)] <am33sh> anastasiac, justin_o : can i get any help regarding submitting the patch
[10:28:46 CDT(-0500)] <anastasiac> am33sh, have you looked at this page? http://wiki.fluidproject.org/display/fluid/Contributing+Code
[10:30:00 CDT(-0500)] <am33sh> anastasiac : thankyou
[10:31:10 CDT(-0500)] <jaugusto111> greggy you is Mentor?
[10:31:41 CDT(-0500)] <greggy> jaugusto111: I am.
[10:41:15 CDT(-0500)] <jaugusto111> greggy How do I submit my idea?
[10:41:29 CDT(-0500)] <jaugusto111> I work with Online Social Networks
[10:41:56 CDT(-0500)] <greggy> your was the twitter idea?
[10:42:01 CDT(-0500)] <greggy> yours
[10:42:14 CDT(-0500)] <jaugusto111> yes
[10:43:35 CDT(-0500)] <greggy> you would need to find a mentor who is interested in the project first. Discuss the possibilities with regard to the projects participating ATutor or Fluid, then with input from the mentor create a proposal….
[10:45:13 CDT(-0500)] <jaugusto111> Where can I find other mentors?
[10:46:19 CDT(-0500)] <greggy> my first look at your proposal, I'm not sure where it fits. If you can make it usable in ATutor, or perhaps using Fluid technologies to implement it, its more likely a mentor will find it interesting...
[10:46:52 CDT(-0500)] <greggy> All mentor can be found here or in the #atutor channels, though they are online at different times during a day
[10:47:43 CDT(-0500)] <jaugusto111> what deadline for submition of proposals?
[10:47:51 CDT(-0500)] <codercube> hi fluid-work team, on GSoC page of IDI there's some info about contributing to jQuery UI, what exactly did you help with? just curious
[10:48:28 CDT(-0500)] <jhung> colinclark, avtar: Just spotted this press release from Logitech this morning. A business conferencing Webcam with remotecontrollable camera, speaker and mic. No idea how good the mic is - since we're pretty picky about those. http://www.logitech.com/en-ca/172/9812
[10:48:31 CDT(-0500)] <codercube> jaugusto111: you have 2 weeks
[10:48:43 CDT(-0500)] <greggy> jaugusto111: april 6 is the deadline, but you will want to have something together before that is you want feedback
[10:50:07 CDT(-0500)] <greggy> codercube: which project are you referring to?
[10:50:09 CDT(-0500)] <colinclark> codercube: We've contributed accessibility features and testing to jQuery UI, including ARIA and keyboard navigation features
[10:50:26 CDT(-0500)] <colinclark> Justin_o, these days, contributes a lot to the jQuery testing tools effort
[10:51:47 CDT(-0500)] <codercube> greggy: I don't mean exact project, I've got this info from http://wiki.atutor.ca/display/atutorwiki/Google+Summer+of+Code+2012
[10:52:10 CDT(-0500)] <logiclord> yura I have some doubts regarding "Highly customizable and accessible web based ePub reader"
[10:52:19 CDT(-0500)] <codercube> colinclark : that's really interesting
[10:52:27 CDT(-0500)] <greggy> codercube: colinclark is a good person to talk to then
[10:53:51 CDT(-0500)] <yura> logiclord: please share
[10:54:04 CDT(-0500)] <logiclord> yura What exactly is intended from editing features ??
[10:54:11 CDT(-0500)] <logiclord> Adding comments ??
[10:54:11 CDT(-0500)] <logiclord> Higlighting text ??
[10:54:11 CDT(-0500)] <logiclord> Touch support ??
[10:54:11 CDT(-0500)] <logiclord> BooKmarks ??
[10:54:53 CDT(-0500)] <logiclord> or complete text edit + indentation ?
[10:57:12 CDT(-0500)] <avtar> jhung: that looks pretty neat
[10:58:04 CDT(-0500)] <jhung> avtar: yeah. Too bad someone remote can't control the camera.
[10:58:20 CDT(-0500)] <jhung> Then we can have a virtual jessm at the idrc offices.
[10:59:35 CDT(-0500)] <avtar> that could be an arduino/lego project
[11:00:21 CDT(-0500)] <avtar> mount the cam on a robot and let allow jessm to navigate through the office
[11:01:14 CDT(-0500)] <jhung> You're thinking too terrestrial Avtar. Put it up on an AR Drone Parrot.
[11:01:20 CDT(-0500)] <Justin_o> avtar: that sounds like fun
[11:03:09 CDT(-0500)] <NickMayne> Hi All
[11:03:57 CDT(-0500)] <NickMayne> Has anyone looked in to ugprading the Fluid project to use jQuery 1.7.1 yet?
[11:04:12 CDT(-0500)] <NickMayne> I am running in to issues with the inline editor.
[11:04:13 CDT(-0500)] <yura> logiclord: this sort of stuff is very flexible, main goal is to have the ebum reader keyboard and screen reader accessible, as well as customizable to user preferences. adding comments was one of the examples of adding additional features. I brought up comments just because they are actually mentioned in epub spec
[11:04:57 CDT(-0500)] <colinclark> Hi NickMayne: Not that I know of, but you're definitely welcome to give it a try and we can help you with any issues you encounter
[11:05:19 CDT(-0500)] <NickMayne> The problem is the .ally stuff
[11:05:36 CDT(-0500)] <NickMayne> sorry I meant the ToolTip stuff
[11:05:38 CDT(-0500)] <logiclord> yura : And how do we expect to get epub files ... we expect user to upload them or choose from a library ?
[11:05:59 CDT(-0500)] <NickMayne> mouseover removes the lines
[11:06:02 CDT(-0500)] <NickMayne> not sure why yet.
[11:17:45 CDT(-0500)] <colinclark> NickMayne: Let me know if you dig up anymore details and we'll take a look
[11:19:46 CDT(-0500)] <NickMayne> I have a base working, it might be best if I push it up to a mecurial instance
[11:19:59 CDT(-0500)] <NickMayne> I have make it the inline editing option for Orchard CMS
[11:20:02 CDT(-0500)] <NickMayne> as a module.
[11:20:18 CDT(-0500)] <NickMayne> So will let you know what other issues I run in to.
[11:21:07 CDT(-0500)] <Abhinav> jhung: you there?
[11:21:15 CDT(-0500)] <Abhinav> Justin_o :
[11:21:17 CDT(-0500)] <colinclark> NickMayne: That's great, thanks!
[11:21:33 CDT(-0500)] <NickMayne>
[11:22:11 CDT(-0500)] <jhung> Abhinav: yup
[11:22:49 CDT(-0500)] <Abhinav> jhung, I have made a raw sample code as an illustriation. It helps in changing the brightness of the image using canvas.
[11:23:05 CDT(-0500)] <Abhinav> jhung, Its a very raw code just to show the basics
[11:24:14 CDT(-0500)] <NickMayne> How offen if the Fluid Project stuff being updated btw?
[11:24:25 CDT(-0500)] <NickMayne> Is the focus currently around the HTML5 player?
[11:24:34 CDT(-0500)] <jhung> Abhinav: okay. Did you send justin_o and I a copy?
[11:25:28 CDT(-0500)] <logiclord> yura : do we expect to get epub files ... we expect user to upload them or choose from a library ?
[11:26:27 CDT(-0500)] <yura> logiclord: epub reader would be just a widget that the implementor would use on their website. I would thing it would need to support loading epub from an url(file) on the server as well as jsonp
[11:26:51 CDT(-0500)] <colinclark> NickMayne: We try to put out Infusion releases on a regular basis. Infusion 1.4 came out about six months ago and we're pretty happy with it so far.
[11:27:46 CDT(-0500)] <colinclark> At the moment, a lot of our focus is on the UI Options component and the new HTML5 video player.
[11:27:54 CDT(-0500)] <NickMayne> @colinclark: dont get me wrong, its very good... I was looking at the commit history on GIT and there didnt appear to be much activity
[11:28:10 CDT(-0500)] <colinclark>
[11:28:43 CDT(-0500)] <colinclark> Most of the development work is currently happening in various forks and branches, which slowly migrate into master as they are fully baked
[11:28:48 CDT(-0500)] <Abhinav> jhung, just mailed to both of you.
[11:29:03 CDT(-0500)] <NickMayne> Oh, private repos?
[11:29:20 CDT(-0500)] <EricDalquist> quick question for all you JS buffs
[11:29:33 CDT(-0500)] <Abhinav> jhung, I have provided an image that loads, you have to give a numerical value to the brightness and the brightness will change accordingly.
[11:29:48 CDT(-0500)] <colinclark> We've had a fair number of framework changes; as you say, there's been less activity on some of the components in the past while
[11:29:51 CDT(-0500)] <colinclark> EricDalquist: Shoot
[11:29:58 CDT(-0500)] <EricDalquist> if http://a.com/index.html loads JS from http://b.com/foo.js can foo.js make ajax calls back to b.com?
[11:30:25 CDT(-0500)] <colinclark> No
[11:30:41 CDT(-0500)] <logiclord> yura : Is there any mailing list or wiki for this where I could post more detailed description ?
[11:31:06 CDT(-0500)] <colinclark> EricDalquist: Aside from using JSONP, all requests are limited to the origin of the web page.
[11:31:17 CDT(-0500)] <EricDalquist> ok
[11:31:25 CDT(-0500)] <EricDalquist> so for something like google analytics
[11:31:36 CDT(-0500)] <EricDalquist> they must be doing jsonp for everything?
[11:31:53 CDT(-0500)] <jhung> Thanks Abhinav. We'll take a look.
[11:32:02 CDT(-0500)] <colinclark> EricDalquist: I'd assume so, yes
[11:32:13 CDT(-0500)] <Abhinav> jhung, sure when do I get back to you?
[11:32:14 CDT(-0500)] <EricDalquist> thanks
[11:32:23 CDT(-0500)] <colinclark> Any time
[11:32:56 CDT(-0500)] <yura> logiclord: let me see
[11:32:58 CDT(-0500)] <NickMayne> Gotta shoot!... Let you know if I get stuck. Nick
[11:33:04 CDT(-0500)] <Abhinav> colinclark, could you explain EricDalquist's doubt a little more, if you are not busy.
[11:33:38 CDT(-0500)] <colinclark> Abhinav: Is there something in particular I can explain?
[11:34:10 CDT(-0500)] <jhung> Abhinav: You should work on a project proposal in the mean time. Either justin_o or I will get back to you with comments / ideas once we've had a look at the code.
[11:34:53 CDT(-0500)] <Abhinav> colinclark, You said all requests are limited to the origin page. Can tou explain a little bit more on that part.
[11:35:27 CDT(-0500)] <Abhinav> jhung, sure I will start that. You guys will get back to me through mail or through the IRC Channel?
[11:35:32 CDT(-0500)] <EricDalquist> its the javascript same origin policy
[11:35:44 CDT(-0500)] <colinclark> Abhinav: This is probably the best place to learn: http://en.wikipedia.org/wiki/Same_origin_policy
[11:35:47 CDT(-0500)] <EricDalquist> I just couldn't remember if it was the page's origin or the script's origin
[11:36:32 CDT(-0500)] <Abhinav> colinclark, Thanks a lot. I will go through this
[11:36:41 CDT(-0500)] <colinclark> No problem
[11:37:18 CDT(-0500)] <Abhinav> colinclark, I was working on a HTML5 Android App and got the same problem, so got a bit curious
[11:38:12 CDT(-0500)] <jhung> Abhinav: We'll respond via email
[11:39:16 CDT(-0500)] <Abhinav> jhung, Thank you
[11:39:31 CDT(-0500)] <jhung> no problem.
[11:42:14 CDT(-0500)] <yura> logiclord: so i think you can register on the wiki. if you do , you can add a new page links to the epub project description where you can put more details etc
[12:48:47 CDT(-0500)] <NickMayne> Hey Chaps,
[12:49:35 CDT(-0500)] <NickMayne> Is there any reason why with the inline editor in v1.2 you woere able to click to edit the content, but in the latest build you have to click the edit link?
[12:49:46 CDT(-0500)] <NickMayne> or an 'edit' link?
[12:51:27 CDT(-0500)] <colinclark> Hey again, NickMayne. That doesn't sound like the right behaviour to me
[12:51:47 CDT(-0500)] <NickMayne> Thats what I thought
[12:51:49 CDT(-0500)] <colinclark> If you try this demo, you'll see that the content itself in indeed clickable http://fluidproject.org/releases/1.4/demos/inlineEdit/simple/html/inlineEdit.html
[12:51:50 CDT(-0500)] <NickMayne> Thats in your demo
[12:52:03 CDT(-0500)] <NickMayne> Ah
[12:52:07 CDT(-0500)] <colinclark> There is a link in the default markup for Inline Edit, which helps for accessibility
[12:52:12 CDT(-0500)] <NickMayne> yes thats the behaviour I would expect
[12:53:28 CDT(-0500)] <NickMayne> here is the demo I have been working from http://build.fluidproject.org/infusion/demos/inlineEdit/rich/demo.html
[12:54:22 CDT(-0500)] <colinclark> Ah, yes, the rich text version
[12:55:07 CDT(-0500)] <colinclark> jameswy may remember the motivation for why, by default, the whole content isn't clickable
[12:55:26 CDT(-0500)] <colinclark> I believe we had design reasons why it was typically awkward to have a whole region of text be clickable
[12:55:30 CDT(-0500)] <colinclark> But ultimately, this is all configurable
[12:55:45 CDT(-0500)] <colinclark> so if it's the behaviour you want, I imagine it should be fairly straightforward for you to configure it that way
[12:56:20 CDT(-0500)] <NickMayne> Okay
[12:56:34 CDT(-0500)] <NickMayne> Any ideas on how to do that?
[12:56:48 CDT(-0500)] <NickMayne> I could try taking parts of the example you showed me
[12:58:19 CDT(-0500)] <Janani> hi all, i am interested in applying fo GSOC with "HTML5 Image Editor" project.
[12:58:51 CDT(-0500)] <Janani> can i know whom i should contact?
[12:59:28 CDT(-0500)] <Janani> is there a mailing list?
[13:00:44 CDT(-0500)] <jhung> Hi Janani. Justin_o is the mentor on that project and I am advising on it. Anything we can help with?
[13:02:36 CDT(-0500)] <Janani> thank you for your response, I am interested in that project, can you guide me how should I make the proposal?
[13:03:22 CDT(-0500)] <Justin_o> Janani: in regards to the mailing list, you can contact us not the fluid-work mailing list http://lists.idrc.ocad.ca/mailman/listinfo/fluid-work
[13:04:51 CDT(-0500)] <Janani> thank you justin, I think it will be verymuch useful.
[13:08:47 CDT(-0500)] <jhung> Janani anything else you need help with? Feel open to ask.
[13:12:17 CDT(-0500)] <Janani> what are the abilities you expect from this online image editor?
[13:12:42 CDT(-0500)] <Janani> i meant the functionalities of the editor?
[13:13:40 CDT(-0500)] <jhung> Janani, the context in which this will be used will be in correcting scanned images of books so they can be OCR'ed. So any image editing functionality that will help improve image quality will be useful. For example:...
[13:14:41 CDT(-0500)] <jhung> erase, clone / stamp, undo / redo, orientation, skew, brightness/contrast, threshold (converting to B&W), etc.
[13:30:01 CDT(-0500)] <NickMayne> Hey Colin, do you know what the config values are to switch the control back?
[14:05:26 CDT(-0500)] <NickMayne> With the support events in the inline editor (http://wiki.fluidproject.org/display/fluid/Inline+Edit+API) - say I wanted to pass a unique ID (an ID for that item) back to the modelChanged event, so that I could change the value on the server, how could I go about doing that?
[14:05:45 CDT(-0500)] <NickMayne> I see the Source field... but I cant see where to populate it
[14:05:54 CDT(-0500)] <NickMayne> or even if thats the field I should be using.
[14:09:28 CDT(-0500)] <colinclark> NickMayne: The source argument probably isn't what you want. But can you tell me more about what you're trying to accomplish? Where is the ID coming from, and why do you need it each time the model changes?
[14:10:32 CDT(-0500)] <NickMayne> ColinClark: so this work im doing is for Orchard CMS
[14:10:48 CDT(-0500)] <NickMayne> Orchard CMS defines lots of 'widgets' which have there own versioning on a page
[14:11:09 CDT(-0500)] <NickMayne> When a user makes a change to a particular widget, that widget needs to be updated in the database
[14:11:23 CDT(-0500)] <NickMayne> Each widget has an id
[14:11:46 CDT(-0500)] <NickMayne> That Id is what I need to pass back to the server, along with the markup that has changed.
[14:11:52 CDT(-0500)] <colinclark> How is the widget ID communicated to the widget in the first place?
[14:12:12 CDT(-0500)] <NickMayne> It is part of a object that is pushed to the view
[14:12:23 CDT(-0500)] <NickMayne> I have the ID being rendered in the markup
[14:12:32 CDT(-0500)] <colinclark> Okay, so you've got the ID in the markup
[14:12:37 CDT(-0500)] <NickMayne> yes
[14:13:12 CDT(-0500)] <NickMayne> <div id="richInlineEdit-container-8"> <span class="fl-inlineEdit-textContainer fl-inlineEdit-focus"> <div class="flc-inlineEdit-text" tabindex="-1" style="padding-right: 0px;">
[14:13:32 CDT(-0500)] <NickMayne> where 8 in the id="richInlineEdit-container-8" is the ID of the widget
[14:13:42 CDT(-0500)] <colinclark> So presumably you've also got a listener for afterFinishEdit?
[14:13:50 CDT(-0500)] <NickMayne> I can change that to anything, I have complete control of that.
[14:13:55 CDT(-0500)] <NickMayne> no?
[14:14:01 CDT(-0500)] <NickMayne> modelChanged
[14:14:06 CDT(-0500)] <colinclark> okay
[14:14:27 CDT(-0500)] <NickMayne> should it be afterfinishedit?
[14:14:31 CDT(-0500)] <colinclark> do you have some code you can pastie for me to take a look at? http://pastie.org
[14:14:37 CDT(-0500)] <NickMayne> sure
[14:16:01 CDT(-0500)] <NickMayne> http://pastie.org/3673550
[14:16:06 CDT(-0500)] <NickMayne> I posted some JS and HTML
[14:16:43 CDT(-0500)] <colinclark> So you need to post back this ID? #richInlineEdit-container-" + shapeId
[14:17:03 CDT(-0500)] <NickMayne> Yeah
[14:17:17 CDT(-0500)] <NickMayne> along with the html that has changed
[14:17:58 CDT(-0500)] <colinclark> Easiest option would be for you to store that ID in a variable, and send it along as needed
[14:18:51 CDT(-0500)] <NickMayne> a variable?
[14:19:05 CDT(-0500)] <NickMayne> How would ModelChanged know about that?
[14:19:16 CDT(-0500)] <colinclark> It would be in scope
[14:19:33 CDT(-0500)] <NickMayne> Do you mean in the HTML markup for the editor?
[14:19:57 CDT(-0500)] <colinclark> No, in the JavaScrtip
[14:20:05 CDT(-0500)] <colinclark> let me whip an example, one sec
[14:20:17 CDT(-0500)] <NickMayne> How will that work with multiple #richInlineEdit-container-" + shapeId on the page?
[14:20:32 CDT(-0500)] <NickMayne> (Sorry im a C# dev not a JS - but im trying!)
[14:21:29 CDT(-0500)] <NickMayne> oh wait
[14:21:29 CDT(-0500)] <NickMayne> lol
[14:21:32 CDT(-0500)] <Bosmon> NickMayne - your sort will be first against the wall when the revolution comes
[14:21:33 CDT(-0500)] <NickMayne> I already have it!!
[14:21:37 CDT(-0500)] <Bosmon> Actually 2nd against the wall
[14:21:40 CDT(-0500)] <Bosmon> Java devs first
[14:21:46 CDT(-0500)] <NickMayne> lol
[14:21:57 CDT(-0500)] <NickMayne> orchardInlineEditing.initRichInlineEdit = function (shapeId) {
[14:22:11 CDT(-0500)] <Bosmon> Looks like you do indeed have it, yes
[14:22:13 CDT(-0500)] <NickMayne> I was passing it in, but didnt release JS scopes worked quite that way
[14:22:37 CDT(-0500)] <NickMayne> wierd!! Majic I say!
[14:22:44 CDT(-0500)] <NickMayne> Magic*
[14:22:45 CDT(-0500)] <Bosmon> We tend to call it.... "closures" : P
[14:23:17 CDT(-0500)] <colinclark> NickMayne: http://pastie.org/3673589
[14:23:49 CDT(-0500)] <colinclark> NickMayne: They're really wonderful, closures.
[14:24:08 CDT(-0500)] <NickMayne> yeah they look useful.
[14:24:10 CDT(-0500)] <Bosmon> It's almost hard for me to remember by now how the other kind of functions worked...
[14:24:16 CDT(-0500)] <NickMayne> in C# it would fall out of scope
[14:24:28 CDT(-0500)] <Bosmon> The ones that, if they let you refer to anything, allowed you to helpfully refer to some kind of "deallocated memory" : P
[14:24:31 CDT(-0500)] <NickMayne> hence why I didnt think the value was being stored.
[14:24:36 CDT(-0500)] <NickMayne> thanks for the Pastie
[14:24:44 CDT(-0500)] <Bosmon> I thought C# had at least some form of closures....
[14:24:44 CDT(-0500)] <colinclark> Glad we could help
[14:24:58 CDT(-0500)] <NickMayne> They do... but you have to specify them
[14:25:05 CDT(-0500)] <colinclark> I guess they do
[14:25:11 CDT(-0500)] <NickMayne> they are explicit rather than implicit
[14:25:51 CDT(-0500)] <colinclark> Looks like they were added in C# 3.0
[14:26:14 CDT(-0500)] <colinclark> http://www.codethinked.com/c-closures-explained
[14:26:40 CDT(-0500)] <NickMayne> oh yes
[14:26:49 CDT(-0500)] <NickMayne> but they dont work the same way as JS ones
[14:26:53 CDT(-0500)] <Bosmon> Looks like you have to use a "delegate" or anonymous method....
[14:27:05 CDT(-0500)] <NickMayne> yup
[14:27:09 CDT(-0500)] <Bosmon> For some reason, a normal method doesn't quite cut it : P
[14:27:14 CDT(-0500)] <NickMayne> lol
[14:27:26 CDT(-0500)] <NickMayne> I like them... some people use them in overkill
[14:27:37 CDT(-0500)] <NickMayne> but they are useful for certain things.
[14:27:38 CDT(-0500)] <NickMayne> hey colin, earlier you said that the inline controls were configurable, do you know what the config values are to switch the control back to what it was like in 1.2?
[14:27:56 CDT(-0500)] <Bosmon> In a language which is mostly organised around "objects", they can be confusing in their impact
[14:28:09 CDT(-0500)] <colinclark> Maybe Bosmon remembers...
[14:28:18 CDT(-0500)] <Bosmon> Let me see if I can remember
[14:28:25 CDT(-0500)] <colinclark> NickMayne wants a rich text inline editor where the body is clickable, not just the "Edit" link
[14:28:27 CDT(-0500)] <Bosmon> After having mostly contributed heckling to this discussion so far....
[14:28:36 CDT(-0500)] <colinclark> I remember that we actually changed this behaviour due to usability concerns
[14:28:49 CDT(-0500)] <colinclark> I'm sure it's configurable, but I couldn't obviously see how it was done
[14:28:58 CDT(-0500)] <colinclark> Regular inline edit works this way, obviously
[14:29:32 CDT(-0500)] <NickMayne> I really do like this inline editor so far..
[14:30:33 CDT(-0500)] <colinclark> That's great
[14:31:03 CDT(-0500)] <colinclark> It looks like that behaviour is actually controlled in code, unfortunately
[14:31:20 CDT(-0500)] <colinclark> In the implementation of fluid.inlineEdit.richTextDisplayModeRenderer(), if I'm reading this correctly
[14:31:32 CDT(-0500)] <colinclark> You could add the behaviour back yourself with a single line of code
[14:31:43 CDT(-0500)] <colinclark> NickMayne: Does Orchard use jQuery or a toolkit?
[14:31:55 CDT(-0500)] <colinclark> I guess you've got jQuery there for sure if you're using Infusion
[14:32:09 CDT(-0500)] <NickMayne> jQuery
[14:32:54 CDT(-0500)] <Bosmon> colinclark found it before me...
[14:33:06 CDT(-0500)] <Bosmon> I got lost in this rat's maze wondering why this code is so old-fashioned : P
[14:33:12 CDT(-0500)] <colinclark> Try something like this, on the line after instantiating your inline editor:
[14:33:38 CDT(-0500)]
<colinclark> tinyEditor.locate("edit").click(function ()
);
[14:33:50 CDT(-0500)] <colinclark> oops
[14:33:51 CDT(-0500)] <colinclark> not quite
[14:34:03 CDT(-0500)]
<colinclark> tinyEditor.locate("text").click(function ()
);
[14:34:05 CDT(-0500)] <Bosmon> At least we made these things public
[14:34:19 CDT(-0500)] <colinclark> That will locate the text of the inline editor, and when it is clicked, call the edit() method, which will open it up and make it editable
[14:34:32 CDT(-0500)] <Bosmon> It may be safer to use the dedicated function fluid.inlineEdit.bindMouseHandlers
[14:34:47 CDT(-0500)] <colinclark> ah, interesting
[14:34:58 CDT(-0500)] <Bosmon> Since it does some extra processing to avoid triggering on native HTML controls
[14:35:06 CDT(-0500)] <colinclark> That's right
[14:35:07 CDT(-0500)] <colinclark> s
[14:35:12 CDT(-0500)] <colinclark> so it would look like this, instead:
[14:35:22 CDT(-0500)] <Bosmon> So, for example, to write fluid.inlineEdit.bindMouseHandlers(tinyEditor.container, tinyEditor.edit);
[14:35:28 CDT(-0500)] <colinclark> Bosmon beat me to it
[14:35:49 CDT(-0500)] <NickMayne> okay where do I pop that?
[14:35:52 CDT(-0500)] <Bosmon> Or more accurately, fluid.inlineEdit.bindMouseHandlers(tinyEditor.viewEl, tinyEditor.edit);
[14:36:01 CDT(-0500)] <Bosmon> NickMayne - at any point after you have initialised the editor
[14:36:15 CDT(-0500)] <Bosmon> And assigned it to a variable named "tinyEditor" in this case : P
[14:36:32 CDT(-0500)] <Bosmon> This is actually the magic missing line of code in the initialisation sequence for a rich text editor, to a standard one
[14:36:40 CDT(-0500)] <colinclark> NickMayne: Like this, from your original paste: http://pastie.org/3673660
[14:36:49 CDT(-0500)] <Bosmon> Although unfortunately this code is so old that we have to compare these line by line to find the difference : P
[14:37:19 CDT(-0500)] <NickMayne>
[14:37:26 CDT(-0500)] <NickMayne> Wow worked like a dream