fluid-work IRC Logs-2013-04-19

[08:02:17 CDT(-0500)] <arashs> ]

[09:57:02 CDT(-0500)] <michelled> hey cindyli, how's it going?

[09:57:19 CDT(-0500)] <cindyli> michelled: how's what going?

[09:57:51 CDT(-0500)] <cindyli> i sent a pull request this morning to rename "enactors" in the base grade, wonder if you can review it when you have a chance?

[09:58:03 CDT(-0500)] <michelled> cindyli: sure

[09:58:10 CDT(-0500)] <michelled> I was curious about the other pull request

[09:58:18 CDT(-0500)] <cindyli> currently working on the feedbacks from Bosmon's review on 4927

[09:58:22 CDT(-0500)] <michelled> I know Bosmon has been making a lot of review recommendations

[09:58:30 CDT(-0500)] <cindyli> ya, working on it

[09:58:35 CDT(-0500)] <michelled> how's it going?

[09:58:45 CDT(-0500)] <cindyli> pretty good

[09:58:55 CDT(-0500)] <cindyli> no stoppers so far

[09:59:00 CDT(-0500)] <cindyli> (smile)

[09:59:28 CDT(-0500)] <michelled> cool (smile)

[11:06:01 CDT(-0500)] <michelled> cindyli: now that we've got rid of 'enactors' I wonder if we should actually rename the javascript file itself

[11:06:05 CDT(-0500)] <michelled> what do you think?

[11:06:59 CDT(-0500)] <cindyli> michelled: i thought about that but since that js file is a collection of several enactors. might make sense to use enactors as the file name?

[11:07:36 CDT(-0500)] <michelled> it doesn't seem to fit that pattern we have in the repo. for example, we have Store.js that has both the cookie store and the temp store in it

[11:07:55 CDT(-0500)] <cindyli> ok, i see your point. i will rename the file

[11:23:32 CDT(-0500)] <lastlegion> hello all, I want to work on a music dev environment as a gsoc project, can someone point me to the appropriate mentor, Cheers!

[11:26:20 CDT(-0500)] <Justin_o> lastlegion: colinclark is the mentor for that one, but he isn't in the channel at the momemnt

[11:26:44 CDT(-0500)] <lastlegion> thanks man (smile)

[11:27:04 CDT(-0500)] <Justin_o> arashs: if you want you can follow look at my svg test page as I go https://dl.dropboxusercontent.com/u/548929/fontIconTests/svtTest.html not much there at the moment though, but it will update with each of my saves

[11:27:11 CDT(-0500)] <Justin_o> lastlegion: np

[11:27:46 CDT(-0500)] <arashs> thanks Justin_o

[12:02:42 CDT(-0500)] <arashs> Justin_o: are you gonna try the coloured SVGs?

[12:26:29 CDT(-0500)] <Justin_o> arashs: yep.. i still have to put those on and see how hard it is to manipulate the styles

[12:27:00 CDT(-0500)] <arashs> cool,

[12:45:08 CDT(-0500)] <Justin_o> arashs: realized there was a typo in the file name, here's the new link to the svg test page https://dl.dropboxusercontent.com/u/548929/fontIconTests/svgTest.html

[12:45:56 CDT(-0500)] <arashs> nice,

[12:46:10 CDT(-0500)] <arashs> the stacking looks good Justin_o

[12:46:34 CDT(-0500)] <Justin_o> arashs: (smile) thanks

[12:46:58 CDT(-0500)] <arashs> I wonder if we could change opacity of the top layer...

[12:55:37 CDT(-0500)] <Justin_o> arashs: if you wanted to do that after the svg was created, we could probably do it with the markup version through css

[12:57:35 CDT(-0500)] <arashs> I think it would be great if we could, as long as it is not a lot of work for you

[13:09:35 CDT(-0500)] <Justin_o> arashs: done

[13:11:24 CDT(-0500)] <arashs> great (smile) Justin_o let me know if you would want to try it with other icons

[13:11:40 CDT(-0500)] <Justin_o> arashs: will do.. going to try some other things first

[13:11:49 CDT(-0500)] <arashs> cool

[14:04:31 CDT(-0500)] <Bosmon> Justin_o - are you there?

[14:05:19 CDT(-0500)] <Justin_o> Bosmon: hello

[14:07:17 CDT(-0500)] <Bosmon> I was thinking of starting to implement our dedicated framework functionality for FLUID-4878

[14:07:22 CDT(-0500)] <Bosmon> What do you think of the following syntax: http://pastie.org/7665641

[14:07:25 CDT(-0500)] <Bosmon> Also cindyli

[14:09:13 CDT(-0500)] <Justin_o> Bosmon: looking at it now

[14:09:51 CDT(-0500)] <cindyli> Bosmon: what is "this"? always a dom object, could it be other stuff?

[14:10:38 CDT(-0500)] <Bosmon> It can be any "this"

[14:11:12 CDT(-0500)] <Justin_o> Bosmon: would it be possible and would it make sense, to have "method" be "funcName" so that it looked more like regular invokers?

[14:12:03 CDT(-0500)] <Bosmon> Justin_o - I think it would undesirable

[14:12:08 CDT(-0500)] <Bosmon> Since the expected values are completely different

[14:12:21 CDT(-0500)] <Bosmon> "method" must always be a single string representing a direct method on the object

[14:12:36 CDT(-0500)] <Justin_o> Bosmon: ah i see now

[14:12:38 CDT(-0500)] <Bosmon> Whereas "funcName" can be a general EL path representing a method's global name

[14:13:07 CDT(-0500)] <Bosmon> So for example I have this in my current Uploader branch, which doesn't work:

[14:13:10 CDT(-0500)] <Bosmon> enableBrowseButton: {

[14:13:10 CDT(-0500)]

<Bosmon> func: "

Unknown macro: {that}


[14:13:10 CDT(-0500)] <Bosmon> args: false

[14:13:10 CDT(-0500)] <Bosmon> },

[14:13:20 CDT(-0500)] <Bosmon> As it turns out, swfUpload also expects to be a "this"

[14:13:26 CDT(-0500)] <Bosmon> And we would rewrite this as follows:

[14:13:35 CDT(-0500)] <Bosmon> enableBrowseButton: {

[14:13:36 CDT(-0500)]

<Bosmon> "this": "

Unknown macro: {that}


[14:13:36 CDT(-0500)] <Bosmon> args: false

[14:13:36 CDT(-0500)] <Bosmon> },

[14:13:38 CDT(-0500)] <Bosmon> damn

[14:13:50 CDT(-0500)] <Bosmon> If only I could delete that from the record (smile)

[14:14:24 CDT(-0500)] <Bosmon> With Skype you can actually call back your last message now....

[14:14:27 CDT(-0500)] <Bosmon> Anyway, I meant to write this:

[14:14:30 CDT(-0500)] <Bosmon> enableBrowseButton: {

[14:14:30 CDT(-0500)]

<Bosmon> "this": "

Unknown macro: {that}


[14:14:30 CDT(-0500)] <Bosmon> method: "setButtonDisabled",

[14:14:30 CDT(-0500)] <Bosmon> args: false

[14:14:30 CDT(-0500)] <Bosmon> },

[14:15:19 CDT(-0500)] <cindyli> michelled: the pull request for renaming enactors - https://github.com/fluid-project/infusion/pull/316 - is ready for more reviews

[14:15:32 CDT(-0500)] <michelled> thx cindyli

[14:15:35 CDT(-0500)] <cindyli> np

[14:15:41 CDT(-0500)] <Justin_o> Bosmon: just to double check, does "this" always refer to the parent of the method?

[14:15:58 CDT(-0500)] <Bosmon> Justin_o - yes

[14:16:17 CDT(-0500)] <Bosmon> It's no different to the arguments for your "fluid.bind", only differently packaged

[14:19:19 CDT(-0500)] <Justin_o> Bosmon: cool (smile)

[14:19:24 CDT(-0500)] <Justin_o> Bosmon: could we do something like this http://pastie.org/7665848

[14:20:01 CDT(-0500)] <Justin_o> oops.. lost some of my comment in there.. how do i edit that?

[14:20:29 CDT(-0500)] <Justin_o> oh it just scrolled off screen

[14:20:48 CDT(-0500)] <Bosmon> Justin_o - isn't that just the first example in my pastie?

[14:22:16 CDT(-0500)] <Justin_o> Bosmon: hmm maybe i'm missing something .. i was suggesting to remove the "this" property and source it instead from the elpath to the method that you'd want to call

[14:22:31 CDT(-0500)] <Bosmon> Oh, right

[14:22:58 CDT(-0500)] <Bosmon> yes, that would be more difficult to implement

[14:23:03 CDT(-0500)] <Bosmon> Don't you think it might also be more unclear?

[14:23:35 CDT(-0500)] <Justin_o> Bosmon: maybe (smile) just exploring ideas… i guess it is nice that the "this" is explicity

[14:23:40 CDT(-0500)] <Justin_o> "explicit"

[14:26:59 CDT(-0500)] <cindyli> Bosmon: hope I'm not distracting you from "this" conversation. I have a question on demands block.

[14:27:07 CDT(-0500)] <Bosmon> Hi cindyli, go ahead!

[14:27:31 CDT(-0500)] <Justin_o> Bosmon: i think that's probably all i'd have to really comment… your first suggestion is pretty clear and explicit and i think the syntax would be usable. And of course, I'd love to have this type of declarative way of calling things in the framework (smile)

[14:27:36 CDT(-0500)] <cindyli> working the last piece of your suggestions to extract the common options share by all default settings panels to a demands block

[14:27:42 CDT(-0500)] <cindyli> http://pastie.org/7663807

[14:28:27 CDT(-0500)] <Bosmon> cindyli - ah, that's funny, isn't it

[14:28:30 CDT(-0500)] <cindyli> as you would see in the code, if the demands is issued against a particular panel like "textSizer", it would just work fine

[14:28:32 CDT(-0500)] <Bosmon> Yes, currently we have no such function

[14:28:49 CDT(-0500)] <Bosmon> Please add a JIRA requesting it and I will think about it (smile)

[14:28:56 CDT(-0500)] <Bosmon> In the meantime you will have to put it in the GRADE...

[14:29:15 CDT(-0500)] <cindyli> it doesn't make sense to put in the grade

[14:29:23 CDT(-0500)] <Bosmon> You can put it in a DIFFERENT grade

[14:29:26 CDT(-0500)] <cindyli> if you meant the base grade settingsPanel

[14:29:38 CDT(-0500)] <cindyli> ah i see

[14:29:40 CDT(-0500)] <cindyli> trying

[14:29:48 CDT(-0500)] <Bosmon> You can make a new grade, perhaps "defaultSettingsPanel"

[14:30:10 CDT(-0500)] <Bosmon> Although people will have to look hard to distinguish it from "defaultSettingsPanels"

[14:30:16 CDT(-0500)] <cindyli> haha, right

[14:30:33 CDT(-0500)] <cindyli> so similar

[14:30:40 CDT(-0500)] <system64> Hello colinclark!

[14:30:46 CDT(-0500)] <Bosmon> I am sorry your CATTs ran away!

[14:31:02 CDT(-0500)] <cindyli> i feel sorry for myself too

[14:33:21 CDT(-0500)] <Justin_o> Bosmon, colinclark, arashs: are you guys happy with the svg testing http://wiki.fluidproject.org/display/fluid/Research+the+viability+of+using+icon+fonts+in+UI+Options

[14:33:42 CDT(-0500)] <Justin_o> fluid-everyoen: ^

[14:35:41 CDT(-0500)] <arashs> nice Justin_o , I'm guessing we can do the opacity effect with the coloured logos too

[14:35:46 CDT(-0500)] <arashs> right?

[14:36:06 CDT(-0500)] <Bosmon> Justin_o - that looks like a really valuable set of testing, and a great resources to have it on the page there

[14:36:06 CDT(-0500)] <arashs> in markup

[14:38:52 CDT(-0500)] <Bosmon> Justin_o - do .ttf files work fine on Android?

[14:42:05 CDT(-0500)] <arashs> Justin_o: the complex SVG margup doesn't fully appear on my iPhone

[14:43:40 CDT(-0500)] <cindyli> Bosmon:

[14:43:47 CDT(-0500)] <cindyli> https://github.com/fluid-project/infusion/pull/308 is ready for more reviews

[14:46:46 CDT(-0500)] <Justin_o> Bosmon: don't have an android to test on personally, and the test page for that has fall backs.. so not exactly sure

[14:47:01 CDT(-0500)] <Justin_o> arashs: i think it's a safari issues as it it doesn't even show up properly on my desktop

[14:47:57 CDT(-0500)] <arashs> good point Justin_o

[14:49:02 CDT(-0500)] <arashs> the chrome app has the same issue

[14:50:22 CDT(-0500)] <Justin_o> arashs: right, must be a webkit thing then