fluid-work IRC Logs-2013-04-25
[08:17:32 CDT(-0500)] <Justin_o> heidiv: good morning⦠is FLUID-4971 ready for me to continue code review on?
[08:17:43 CDT(-0500)] <heidiv> Justin_o yep!
[08:17:49 CDT(-0500)] <heidiv> and morning
[08:18:03 CDT(-0500)] <Justin_o> cindyli: how's everything going with FLUID-4927, i was looking through the pull request comments
[08:18:35 CDT(-0500)] <cindyli> thanks, Justin_o, trying to figure out how to implement bosman's last comment
[08:18:43 CDT(-0500)] <cindyli> "To simply the work for now, you could just supply the extra grade to pageEnhancer as an option, and leave it as being manual init"
[08:19:41 CDT(-0500)]
<cindyli> wonder how would this help to replace the reference to
to
[08:46:26 CDT(-0500)] <Justin_o> cindyli: did you want to talk through it on skype?
[08:47:33 CDT(-0500)] <cindyli> Justin_o: i'm about to finish up the implementation but it certainly needs feedbacks from your guys
[08:47:43 CDT(-0500)] <Justin_o> cindyli: cool
[08:47:55 CDT(-0500)] <cindyli> about to push up, will let u know
[08:56:54 CDT(-0500)] <cindyli> the implementation has been pushed up - https://github.com/cindyli/infusion/commit/61324401709e4b81e764ecaeda0508c9076828f0 Bosmon, yzen, Justin_o, your feedback please
[10:01:20 CDT(-0500)] <cindyli> Justin_o: michelle, I have a branch that implements the draggable floating menu aimed for the text-to-speech design. wonder if you can take a look and give some feedback: https://github.com/cindyli/infusion/tree/FLUID-floating-selfVoicing-menu
[10:01:54 CDT(-0500)] <cindyli> run fat panel demo will show u the experimental menu. please forgive the not-so-pretty styling
[10:03:34 CDT(-0500)] <Justin_o> cindyli: okay.. will try to take a look in a bit
[10:03:37 CDT(-0500)] <Justin_o> thanks for putting it up
[10:03:42 CDT(-0500)] <cindyli> thanks, Justin_o
[10:06:55 CDT(-0500)] <cindyli> Justin_o: next, i'm going to look for a slidable slider for both touch and non-touch screens. is there anyone looking into that?
[10:07:29 CDT(-0500)] <Justin_o> cindyli: for the carousel.. jhung and heidiv are looking into finding an accessible carousel
[10:08:55 CDT(-0500)] <cindyli> Justin_o: but not sliders. jhung and heidiv, are you looking into a slidable slider for touch screens?
[10:09:18 CDT(-0500)] <Justin_o> cindyli: oh you mean for the font size and etc.. no they aren't
[10:09:35 CDT(-0500)] <cindyli> ok, will work on that. thanks, Justin_o
[10:10:10 CDT(-0500)] <Justin_o> heidiv: I left a couple more minor comments to your pull request.. once you have those taken care of I'll try to run it
[10:10:30 CDT(-0500)] <heidiv> Justin_o gee i fixed these already⦠making sure it pushed correctly
[10:10:44 CDT(-0500)] <Justin_o> heidiv: okay.. thanks
[10:15:15 CDT(-0500)] <heidiv> cindyli there was a jquery plugin i came across w the carousels called mousewheel - not sure if it's related to touch sliding but maybe?
[10:15:39 CDT(-0500)] <heidiv> seemed to try to make mouse/track pad activity work cross-browser
[10:16:35 CDT(-0500)] <cindyli> heidiv: would that plugin be a part of your carousel or different one?
[10:16:57 CDT(-0500)] <heidiv> cindyli it was a seperate jquery plugin that one carousel required
[10:17:13 CDT(-0500)] <cindyli> ok, i see. could try that. thanks, heidiv
[13:03:48 CDT(-0500)] <arashs> jvass: I like both of your options for simplifying content presentation on UI Options, and I was thinking that they could both be used in different scenarios
[13:04:28 CDT(-0500)] <arashs> But I came across a concept, and wanted to know what you think. The 7th image on this article (http://coding.smashingmagazine.com/2013/03/11/responsible-web-design/) has a "text size" scroll bar that has stages. I was imagining that we could have a scroll bar like this with each stage dedicated to specific content on the pageβ¦
[13:05:19 CDT(-0500)] <arashs> what do you think?
[13:18:05 CDT(-0500)] <Justin_o> cindyli: just looking over your code changes for FLUID-4927
[13:18:09 CDT(-0500)] <Justin_o> what was this needed for https://github.com/cindyli/infusion/commit/61324401709e4b81e764ecaeda0508c9076828f0#L2R257
[13:19:40 CDT(-0500)] <cindyli> Justin_o: you mean 'fluid.originalEnhancerOptions'?
[13:21:16 CDT(-0500)]
<cindyli> in the same commit, at the top, there are changes made into FatPanelUIOptions.js and FullPreviewUIOptions.js, to replace
with
[13:21:40 CDT(-0500)] <Justin_o> i mean that.uiEnhancerOptions = fluid.copy(uiEnhancerOptions);
[13:22:36 CDT(-0500)] <cindyli> right, good point, no longer necessary to make a copy. making change
[13:22:50 CDT(-0500)] <Justin_o> cindyli: thansk
[13:23:06 CDT(-0500)] <cindyli> np
[13:25:23 CDT(-0500)] <cindyli> done and pushed, Justin_o
[13:27:35 CDT(-0500)] <Justin_o> cindyli: great. thanks
[13:29:04 CDT(-0500)] <Justin_o> cindyli: i think that's all i can see.. i guess you couldn't make it autoInit because you needed to copy the options before the framework started to act on them?
[13:29:20 CDT(-0500)] <cindyli> yes, Justin_o
[13:29:35 CDT(-0500)] <Justin_o> cindyli: okay
[14:04:55 CDT(-0500)] <Bosmon> Hi cindyli
[14:04:59 CDT(-0500)] <Bosmon> Did you work out the GRADES?
[14:05:19 CDT(-0500)] <cindyli> yes, Bosmon
[14:05:25 CDT(-0500)] <Bosmon> That's great!
[14:05:36 CDT(-0500)] <cindyli> here: https://github.com/cindyli/infusion/commit/61324401709e4b81e764ecaeda0508c9076828f0
[14:05:40 CDT(-0500)] <Bosmon> Looks like htere will be some BIG MERGING ACTTION soon : P
[14:05:46 CDT(-0500)] <Bosmon> How are things standing with the design work?
[14:06:38 CDT(-0500)] <cindyli> pretty good i think, Justin_o and michelle are reviewing that branch
[14:07:23 CDT(-0500)] <Justin_o> Bosmon, cindyli: it's pretty close.. I'm testing it out and have a few more comments/issues to mention.
[14:07:54 CDT(-0500)] <Bosmon> cindyli - I'm wondering whether you ran into this problem: http://issues.fluidproject.org/browse/FLUID-4987
[14:08:02 CDT(-0500)] <Bosmon> I have a memory you might have mentioned something similar to this recently
[14:08:51 CDT(-0500)] <cindyli> no, don't recal
[14:08:53 CDT(-0500)] <cindyli> l
[14:08:59 CDT(-0500)] <Bosmon> Perhaps it was Justin_o....
[14:09:13 CDT(-0500)] <Bosmon> Did you at some point seem to see events firing twice, or having listeners registered twice?
[14:09:57 CDT(-0500)] <Justin_o> Bosmon: sounds like something i may have run into.. i'll read over the description and hopefully it will job my memory
[14:10:37 CDT(-0500)] <cindyli> The issue i ran into often is options specified in a demands block don't get registered
[14:11:40 CDT(-0500)] <Justin_o> Bosmon: can't really remember.. the summary sounds familiar, but the description doesn't bring anything specific to mind. Sorry
[14:16:46 CDT(-0500)] <cindyli> yzen: regarding ur comment on the pull request - Only model/applier specific stuff can stay in the final init function. We should move this material into an onCreate listener.
[14:17:10 CDT(-0500)] <cindyli> how do we distinguish what goes into finalInit or onCreate listener?
[14:17:25 CDT(-0500)] <Bosmon> cindyli - at the moment the movement seems to be to move everything into the onCreate listener