fluid-work IRC Logs-2013-07-19

[08:09:33 CDT(-0500)] <cindyli> Justin_o, yzen, i pushed more into my 4907 branch that has:

[08:09:47 CDT(-0500)] <cindyli> 1. the renaming of resourceLoader and resourcePath

[08:10:09 CDT(-0500)] <cindyli> 2. merged in antranig's pull request that fixed the issues we had yesterday

[08:10:25 CDT(-0500)] <cindyli> 3. removed the work-arounds for yesterday's issues

[08:11:06 CDT(-0500)] <cindyli> i wonder if one of you can review antranig's pull request https://github.com/fluid-project/infusion/pull/366, and push it if it looks fine

[08:13:12 CDT(-0500)] <Justin_o> cindyli: you merged this one into the FLUID-4907 branch already?

[08:13:19 CDT(-0500)] <cindyli> yes, Justin_o

[08:13:34 CDT(-0500)] <Justin_o> cindyli: and it sounds like it works right

[08:13:46 CDT(-0500)] <cindyli> ya

[08:15:49 CDT(-0500)] <yzen> cindyli: Justin_o I'm still trying to get the tts working, it looks like there are some issues with passing changes to the model to the enactor, somewhere in the custom model relay stuff

[08:20:13 CDT(-0500)] <cindyli> yzen: my pull request #360 that fixes our model relay is not in our 4907 branch yet, we should merge that in and try again

[08:20:30 CDT(-0500)] <yzen> cindyli: ok ill review it right now

[08:20:36 CDT(-0500)] <cindyli> thanks, yzen

[08:21:49 CDT(-0500)] <Justin_o> yzen: are you going to be reviewing both of those pull request?

[08:22:18 CDT(-0500)] <yzen> Justin_o: sure

[08:25:25 CDT(-0500)] <Justin_o> yzen: thanks

[08:34:44 CDT(-0500)] <yzen> anastasiac: hi

[08:44:30 CDT(-0500)] <yzen> anastasiac: ^

[08:49:56 CDT(-0500)] <anastasiac> yzen, I seem to have dropped out of the channel at a critical moment. What's your question?

[08:50:07 CDT(-0500)] <yzen>

[08:50:08 CDT(-0500)] <yzen> yzen: anastasiac: so what's the problem you are experiencing with the pref editors? i can't seem to pass the changes from the tts panel to the enactor, is that related ?

[08:50:36 CDT(-0500)] <anastasiac> yzen, the problem I was having will be fixed by cindy's fix yesterday

[08:50:44 CDT(-0500)] <anastasiac> so it's not a problem with the prefs editor

[08:50:51 CDT(-0500)] <anastasiac> it's a bug in UIO

[08:51:03 CDT(-0500)] <yzen> anastasiac: would you know if mine is related ?

[08:51:29 CDT(-0500)] <anastasiac> passing changed from the panel to the enactor… no, that doesn't sound anything like the problem I was experiencing.

[08:51:39 CDT(-0500)] <anastasiac> yzen, the tts panel used to talk to the enactor

[08:51:44 CDT(-0500)] <yzen> is saw a number of // this is being ignored - ?? in the custom panel defaults

[08:52:17 CDT(-0500)] <anastasiac> yes, that referred to some selectors

[08:52:33 CDT(-0500)] <anastasiac> yzen, your panel is not turning tts on?

[08:53:03 CDT(-0500)] <yzen> no , when i click on the tts icon, the model change event in the enactor is not triggered

[08:54:17 CDT(-0500)] <anastasiac> yzen, yeah, I'm seeing it not working. The panel itself changes, but no tts, and the store doesn't get the new value.

[08:54:18 CDT(-0500)] <anastasiac> hm

[08:54:43 CDT(-0500)] <yzen> anastasiac: ya that

[08:55:11 CDT(-0500)] <anastasiac> yzen, I know we had this working… I'm going to check if my 118 branch still works, and if so compare them to see what's changed

[08:55:29 CDT(-0500)] <yzen> anastasiac: btw i have a pull with updated url

[08:55:34 CDT(-0500)] <yzen> the original does not work anymor

[08:55:39 CDT(-0500)] <yzen> perhaps you can review it

[08:55:46 CDT(-0500)] <yzen> you won't hear anything otherwise

[08:55:50 CDT(-0500)] <yzen> it 1 line

[08:55:51 CDT(-0500)] <anastasiac> could you give me the url and tell me what to do with it?

[08:55:55 CDT(-0500)] <yzen> ok

[08:56:10 CDT(-0500)] <anastasiac> or point me at the pull

[08:56:43 CDT(-0500)] <yzen> anastasiac: https://github.com/fluid-project/prefsEditors/pull/5/files

[08:58:08 CDT(-0500)] <cindyli> yzen: anastasiac, in terms of the enactors not responding to the panel change, Justin_o and i had the similar problem when we tried to remove "selections" layer from uio model. we traced down into fluid.fireSourcedChange() and suspected it might be a framework issue in there but haven't been able to succeeded in creating a test case

[08:58:09 CDT(-0500)] <anastasiac> ok, yzen, it definitely works in my older branch, using the same version of infusion. i'm going to compare the versions to see what's changed

[08:59:07 CDT(-0500)] <yzen> anastasiac: thanks

[08:59:11 CDT(-0500)] <yzen> cindyli: good to know

[09:01:23 CDT(-0500)] <Justin_o> cindyli: do you think you could pair with me for a bit.. i can't seem to find out what's going on with those two preferences.. the model relay isn't being triggered but i can't understand why

[09:01:52 CDT(-0500)] <cindyli> sure. the problem sounds familiar with what yzen is having

[09:02:01 CDT(-0500)] <cindyli> skype, Justin_o

[09:02:23 CDT(-0500)] <Justin_o> cindyli: sure

[09:02:37 CDT(-0500)] <yzen> cindyli: just a white space issue in your pull otherwise I will merge it

[09:03:07 CDT(-0500)] <cindyli> ok, yzen let me fix those. how do you see what white spaces are extra?

[09:03:31 CDT(-0500)] <yzen> cindyli: well it's in my diff for once, but i also have a plugin for eclipse that strips them on on save

[09:03:34 CDT(-0500)] <yzen> on file save

[09:03:37 CDT(-0500)] <yzen> sorry sublime

[09:03:42 CDT(-0500)] <yzen> not eclipse

[09:03:53 CDT(-0500)] <cindyli> cool plug in, which one it is

[09:03:57 CDT(-0500)] <yzen> one sec

[09:04:21 CDT(-0500)] <yzen> called trailing spaces

[09:04:32 CDT(-0500)] <yzen> make sure you set this in user prefs though

[09:04:33 CDT(-0500)] <yzen> "trailing_spaces_include_current_line": false

[09:04:37 CDT(-0500)] <anastasiac> yzen: found it!!

[09:04:39 CDT(-0500)] <yzen> {

[09:04:40 CDT(-0500)] <yzen> "trailing_spaces_include_current_line": false

[09:04:41 CDT(-0500)] <yzen> }