fluid-work IRC Logs-2013-09-27

[08:02:53 CDT(-0500)] <justin_o> cindyli: saw your comment on the pull request for GPII-185. Sorry I had missed that.. I think i can merge it in, but I don't have the setup to test it here. Could you get someone in the office to test it out and comment on the pull request and then I'll merge it in.

[08:04:14 CDT(-0500)] <cindyli> sure, justin_o,

[08:05:33 CDT(-0500)] <justin_o> cindyli: thanks

[08:05:45 CDT(-0500)] <cindyli> np

[08:13:47 CDT(-0500)] <justin_o> anastasiac, cindyli: thanks for the changes to http://wiki.fluidproject.org/display/docs/Localization+in+the+Preferences+Framework

[08:13:50 CDT(-0500)] <justin_o> it looks so much better

[08:13:59 CDT(-0500)] <cindyli> yay!

[08:14:30 CDT(-0500)] <anastasiac> np, justin_o. Feel free to double-check that I didn't change the meaning of anything to the point of being wrong, and please further edit in any way you see fit

[08:15:09 CDT(-0500)] <justin_o> anastasiac: thanks.. i read it through this morning and it looked good

[08:37:45 CDT(-0500)] <anastasiac> cindyli, if I'm using the gpiiStore, should the contents of the cookie be ignored and unaffected?

[08:37:58 CDT(-0500)] <cindyli> yes, anastasiac

[08:38:23 CDT(-0500)] <cindyli> oh, the user "testDT" might have some preset prefs that was from me

[08:39:16 CDT(-0500)] <anastasiac> ok, I'll change the user to something unique

[08:45:40 CDT(-0500)] <justin_o> michelled: what do you think we should do about this page http://wiki.fluidproject.org/display/fluid/Infusion+Roadmap+1.5

[09:22:13 CDT(-0500)] <michelled> justin_o: looks like it should be deleted

[09:22:23 CDT(-0500)] <justin_o> michelled: okay

[09:26:40 CDT(-0500)] <justin_o> michelled: okay.. it's been removed

[09:29:26 CDT(-0500)] <michelled> thx justin_o

[09:30:50 CDT(-0500)] <michelled> justin_o: are you available for a quick Skype call?

[09:31:11 CDT(-0500)] <justin_o> michelled: sure

[09:52:42 CDT(-0500)] <anastasiac> cindyli, the gpii store looks pretty good. I've tried creating a bunch of IDs and setting all different preferences. Seems to work just fine

[09:55:14 CDT(-0500)] <cindyli> super! thanks, anastasiac, can you comment the test result on the pull request: https://github.com/fluid-project/prefsEditors/pull/49, so justin_o can carry on.

[09:55:24 CDT(-0500)] <anastasiac> k

[10:06:29 CDT(-0500)] <justin_o> cindyli, anastasiac: thanks for the testing.. i've merged the pull request for GPII-185 in

[10:06:48 CDT(-0500)] <cindyli> thanks, justin_o and anastasiac

[10:08:50 CDT(-0500)] <justin_o> cindyli: we should probably update infusion in the prefsEditors repo again, and then send another pull request to the gpii/prefsEditors

[10:09:09 CDT(-0500)] <cindyli> good idea, justin_o

[10:09:36 CDT(-0500)] <cindyli> justin_o: we should also talk about the multi language switching issue that Chris has

[10:16:13 CDT(-0500)] <justin_o> cindyli: you mean the sort of on the fly language changes? currently it seems that it only happens on init.. i don't think we have a way to change the message bundles used on the fly.

[10:19:34 CDT(-0500)] <cindyli> justin_o: i'm thinking if we can have a way to re-run UIObuilder, which means re-instantiate UIO, at the language change, the dynamic change could be achieved.

[10:20:28 CDT(-0500)] <justin_o> cindyli: they would need to pass in a different auxiliary schema though

[10:22:48 CDT(-0500)] <cindyli> justin_o: Chris tries to pass a language variable into the aux schema, which sheds some lights on a possibility to alter path on the fly.

[10:23:51 CDT(-0500)] <justin_o> cindyli: interesting

[10:27:34 CDT(-0500)] <justin_o> cindyli: did he modify the auxschema? or used the standard format?

[10:28:29 CDT(-0500)] <cindyli> justin_o: he modified the aux schema a bit with string manipulation on the path to message files

[10:29:20 CDT(-0500)] <justin_o> cindyli: ah i see

[10:29:38 CDT(-0500)] <justin_o> cindyli: so he changes some global variable to try to get it to switch languages

[10:29:43 CDT(-0500)] <cindyli> exactly

[10:30:18 CDT(-0500)] <justin_o> cindyli: so perhaps what should be changing is the prefix

[10:30:44 CDT(-0500)] <justin_o> or maybe we need to some other flag to consume different language paths

[10:31:24 CDT(-0500)] <justin_o> cindyli: although this still doesn't feel quite right because we should be supporting this outside of the schema too

[10:46:11 CDT(-0500)] <cindyli> justin_o: agree. passing a global var around certainly is not a clean way. but it gives some ideas of how much flexibility it needs for supporting multi language. Another thought is, create a wrapper component (or perhaps some other ways) to connect the constructed UIO with the language dropdown. so the language switch triggers an event telling the template loader to re-fetch from certain path.

[10:51:03 CDT(-0500)] <justin_o> that's interesting.. but how do we get the languages in there.. do they have to be passed in to start? and somehow not pre-fetched?

[11:05:15 CDT(-0500)] <cindyli> anastasiac: i finished updating http://wiki.fluidproject.org/display/docs/fluid.messageResolver, can you have a look when you have a chance?

[11:05:24 CDT(-0500)] <anastasiac> thanks, cindyli, will do

[11:05:32 CDT(-0500)] <cindyli> thanks, anastasiac

[11:24:39 CDT(-0500)] <jhung1> justin_o: I sent a pull request for GPII-193 (finally!). I also left a comment on that pull req.

[11:25:46 CDT(-0500)] <justin_o> jhung1: cool thanks.. i'll take a look at it the next time in the office with vjoanna

[11:35:20 CDT(-0500)] <anastasiac> cindyli, the messageResolver docs say "A message resolver is included automatically in any renderer-bearing components created using fluid.initRendererComponent." Do you know if it's also automatic if you use the fluid.rendererComponent grade?

[11:36:06 CDT(-0500)] <cindyli> anastasiac: yes as i understood

[11:36:14 CDT(-0500)] <anastasiac> ok, thanks cindyli

[11:36:17 CDT(-0500)] <cindyli> np

[11:40:43 CDT(-0500)]

[11:42:31 CDT(-0500)] <anastasiac> I just want to make sure I'm not missing something, or misunderstanding something

[11:44:26 CDT(-0500)] <cindyli> anastasiac: my understanding is that once you attach a message resolver to "parentBundle" option of a renderer component, the message mapping will happen. this seems to me the message resolver functions are embedded in rendererComponent

[11:45:13 CDT(-0500)] <cindyli> or the automation is triggered by "parentBundle" option

[11:45:24 CDT(-0500)] <anastasiac> and if there's no parentBundle in the options?

[11:45:59 CDT(-0500)] <cindyli> nothing to map to and "messageKey" on the protoTree would not be resolved

[11:46:50 CDT(-0500)] <anastasiac> suppose the protoTree doesn't use messageKey anywhere? i.e. suppose the integrator makes no attempt at using string bundles?

[11:47:07 CDT(-0500)] <cindyli> then they don't need to worry about attaching "parentBundle"

[11:47:19 CDT(-0500)] <anastasiac> and no messageResolver would be created

[11:48:28 CDT(-0500)] <cindyli> i'm also looking at that chunk of code, trying to figure out what "rendererOptions.messageSource" is

[11:51:25 CDT(-0500)] <cindyli> i think "if (!rendererOptions.messageSource && that.options.strings)" means if "strings" option is defined and message resolver hasn't been attached, create the message resolver

[11:51:45 CDT(-0500)] <cindyli> so, the option that triggers the creation of the message resolver is the "strings" option

[11:51:53 CDT(-0500)] <cindyli> this simplifies the logic

[11:52:15 CDT(-0500)] <anastasiac> but it's checking rendererOptions.messageSource, not that.messageResolver

[11:52:41 CDT(-0500)] <cindyli> the created resolver is attached onto rendererOptions.messageSource

[11:52:45 CDT(-0500)] <cindyli> see line 188

[11:52:46 CDT(-0500)] <anastasiac> if you look at lines 223-225, it's possible for there to be no messageResolver attached to that

[11:53:05 CDT(-0500)] <anastasiac> line 188 is inside the if

[13:19:33 CDT(-0500)] <michelled> justin_o: are you there?

[13:20:05 CDT(-0500)] <justin_o> michelled: hello

[13:20:21 CDT(-0500)] <michelled> can you hop on Skype for a few moments?

[13:20:32 CDT(-0500)] <michelled> avtar needs to check something about the prefs server with you

[13:21:53 CDT(-0500)] <justin_o> michelled: sure

[13:33:09 CDT(-0500)] <justin_o> cindyli: what do you think of this https://github.com/jobara/prefsEditors/tree/chris-i18n

[13:35:26 CDT(-0500)] <justin_o> cindyli: i sent you an e-mail about it instead.. i'm heading out now.. talk to you next week.

[13:45:42 CDT(-0500)] <cindyli> anastasiac: thanks for improving the message resolver doc. it looks a lot better.

[13:45:57 CDT(-0500)] <anastasiac> np cindyli

[14:07:57 CDT(-0500)] <cindyli> hi Bosmon or Bosmon8

[15:17:27 CDT(-0500)] <anastasiac> cindyli, did you have any thoughts for ChrisP regarding his i18n issues? I see that no one has responded to him yet

[15:20:14 CDT(-0500)] <cindyli> yes, we do, anastasiac, even though we still don't have a plan for the dynamic language switching yet

[15:20:47 CDT(-0500)] <anastasiac> ok, good, because I'm not sure what to say

[15:20:51 CDT(-0500)] <cindyli> i've fixed the issue one, justin refactored his code. i will send out the email soon

[15:20:59 CDT(-0500)] <anastasiac> k

[15:21:25 CDT(-0500)] <cindyli> thanks for reminding, almost slip out my mind